[vJass] (System) CustomInventory

[CloudMax]

If you cant change the hero, how do you think you will be able to use this system at all? Seriously.
The system itself is far more advanced then just changing the hero you know.

 

[karland90]

But really, how many people take profit from these updates? I guess 4-5?

i will!

What about changing the hero why cant i change it (im a noob pls teach me how)

if you have read the description then you should know that you HAVE TO know jass to be able to use this normally.

@offtopic:
i disagree with vercas cause it is not proper to mention illegal stuff at this site, it is improper and it is in violation of the site rules. i think you should also remove that link, be it in h4x0r language or not.
though i do agree with vercas, cause sweden is a damn welfare country , life in sweden is one of the best. and dude ive been to sweden too so i know whats it like. yes, games for you are 1.5 times more expensive than in the US and probably 10 times more expensive than in romania or here (estonia). i basically live in northern europe, but im still poor and with my funds i shouldnt even have the crappy computer i have. prices in sweden are higher than in other countries, but wages are way more higher yet and thats what matters. why do you think all those immigrants from around the world run to sweden when you have such high prices? if our family was to move to sweden id be swimming in money compared to the situation before. and that only thanks to the social benefits.
i would like to continue this discussion, but this here is not the right place for it.

 

[Vercas]

The link is WRONG.
I won't talk about prices because my head hurts. I don't even want to think about them...

 

[Catch_ya]

if our family was to move to sweden id be swimming in money compared to the situation before. and that only thanks to the social benefits.
i would like to continue this discussion, but this here is not the right place for it.

I'm really sorry to do this last off topic but, thats a big problem with people in greece or if you go to a more poor land than where I come from (Denmark). They always think we are rich and we got everything because we are from a 'rich' country. That is not necessarily true.

 

[Hashjie]

something on-topic:
I have a map where players have to select a hero through a hero tavern.
Is it possible to create a fake inventory unit when the hero is created and use the hero+fake inventory unit for the system?
I tryed doing this:

set fakeInv = CreateInventoryUnit(Player(GetConvertedPlayerId(GetOwningPlayer(GetSoldUnit()))), 'h000')
call CreateInventoryUI(GetSoldUnit(), fakeInv)

But it seems like it's not working. When I test it in-game I can't press escape to see the inventory for the hero thats being created from the tavern. Does the system need a hero created on init? Or am I doing something wrong?

this is the trigger I used instead of the test trigger:

• Hero Selected
  • Events
    • Unit - A unit Sells a unit
  • Conditions
    • (Unit-type of (Selling unit)) Equal to SomeUnit
  • Actions
    • Custom script: local unit fakeInv = null
    • Set TempLoc = (Position of (Selling unit))
    • Unit - Remove (Selling unit) from the game
    • Unit - Move (Sold unit) instantly to TempLoc
    • Set HeroSpawnLoc[(Player number of (Owner of (Sold unit)))] = TempLoc
    • Set PlayerHero[(Player number of (Owner of (Sold unit)))] = (Sold unit)
    • Selection - Select (Sold unit) for (Owner of (Sold unit))
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Unit-type of (Sold unit)) Equal to Myhero1
      • Then - Actions
        • Custom script: set fakeInv = CreateInventoryUnit(Player(GetConvertedPlayerId(GetOwningPlayer(GetSoldUnit()))), 'h000')
        • Custom script: call CreateInventoryUI(GetSoldUnit(), fakeInv)
      • Else - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Unit-type of (Sold unit)) Equal to Myhero2
          • Then - Actions
            • Custom script: set fakeInv = CreateInventoryUnit(Player(GetConvertedPlayerId(GetOwningPlayer(GetSoldUnit()))), 'h001')
            • Custom script: call CreateInventoryUI(GetSoldUnit(), fakeInv)
          • Else - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • (Unit-type of (Sold unit)) Equal to Myhero3
              • Then - Actions
                • Custom script: set fakeInv = CreateInventoryUnit(Player(GetConvertedPlayerId(GetOwningPlayer(GetSoldUnit()))), 'h002')
                • Custom script: call CreateInventoryUI(GetSoldUnit(), fakeInv)
              • Else - Actions
                • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                  • If - Conditions
                    • (Unit-type of (Sold unit)) Equal to Myhero4
                  • Then - Actions
                    • Custom script: set fakeInv = CreateInventoryUnit(Player(GetConvertedPlayerId(GetOwningPlayer(GetSoldUnit()))), 'h003')
                    • Custom script: call CreateInventoryUI(GetSoldUnit(), fakeInv)
                  • Else - Actions
                    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                      • If - Conditions
                        • (Unit-type of (Sold unit)) Equal to myhero5
                      • Then - Actions
                        • Custom script: set fakeInv = CreateInventoryUnit(Player(GetConvertedPlayerId(GetOwningPlayer(GetSoldUnit()))), 'h004')
                        • Custom script: call CreateInventoryUI(GetSoldUnit(), fakeInv)
                      • Else - Actions
    • Camera - Reset camera for (Owner of (Sold unit)) to standard game-view over 0.00 seconds
    • Custom script: call RemoveLocation (udg_TempLoc)

 

[Anachron]

But it seems like it's not working. When I test it in-game I can't press escape to see the inventory for the hero thats being created from the tavern. Does the system need a hero created on init? Or am I doing something wrong?

Check the example. You have to set up fake hero types for the fake units for the inventory. Just check the loop.

 

[Hashjie]

Check the example. You have to set up fake hero types for the fake units for the inventory. Just check the loop.

I did that. Please check the edit in my post for the trigger I used to create fake hero types and create the UI with the sold unit + the fake hero.

EDIT: DOH >< forgot that in jass the index starts at 0 for players xD sry (I'm such a noob xD) changed it and works

 

[Anachron]

I don't know. Maybe GUI is the mistake.

 

[Hashjie]

I don't know. Maybe GUI is the mistake.

no man it works ;D!
I was just a bit stupid xD I forgot that in jass the indexes start at 0 so I changed them to:

set fakeInv = CreateInventoryUnit(Player(GetConvertedPlayerId(GetOwningPlayer(GetSoldUnit())) - 1), 'h000')

sry for the mistakes, just learning from them

EDIT: b.t.w. have you found a way to create black fog over the inventory to cover it completely? Because I have no idea how to create something like that inside your system :S
I'm also trying to show a multiboard after a user pressed escape to close the inventory. I tryed doing this:

private method onDestroy takes nothing returns nothing
        call DestroyMultiboard(bBoard)
        set bBoard = null
        if GetLocalPlayer() == Player(0) then
            call MultiboardDisplay(udg_Headquarters_multiboard, true)
        endif
    endmethod

but it didn't work ;( Now the multiboard of the inventory doesnt show because the multiboard I want to show just stays there xD. Did I put it at the wrong place in the code? Or am I failing ones again? When does this private method gets executed? :S
this is in the Board trigger btw xD

 

[Anachron]

the onDestroy is only called when you destroy the inventory.

Use the show/hide method inside CWInventoryWindow (At least I remember that name) to run code on show/hide actions.

 

[Hashjie]

the onDestroy is only called when you destroy the inventory.

Use the show/hide method inside CWInventoryWindow (At least I remember that name) to run code on show/hide actions.

there is no CWInventoryWindow.
CWDestructable, CWTrackable, CustomWindow and CWBorder are the ones existing and I cant find any show/hide methods inside them :S

 

[Anachron]

CIContent

public method show takes boolean bol returns nothing
            call FogModifierStop(.visible)
            call DestroyFogModifier(.visible)
            
            set .viewing = bol
            
            //call EnumDestructablesInRect(CI_UI_RECT, Condition(function thistype.checkDest), null)
                
            if bol then
                if GetLocalPlayer() == Player(.Player) then
                    set .camX = GetCameraTargetPositionX()
                    set .camY = GetCameraTargetPositionY()
                    set .camZ = GetCameraTargetPositionZ()
                    set .camDist = GetCameraField(CAMERA_FIELD_TARGET_DISTANCE)
                endif
                
                set .visible = CreateFogModifierRect(Player(.Player), FOG_OF_WAR_VISIBLE, CI_UI_RECT, false, false)
                call .refresh()
                
                call PreventSpecificOrder(.inventory.getOwner(), "move", true)
                call PreventSpecificOrder(.inventory.getOwner(), "smart", true)
                
                static if LIBRARY_CIItemBoard then
                    call .inventory.showBoard(true)
                endif
            else
                set .visible = CreateFogModifierRect(Player(.Player), FOG_OF_WAR_MASKED, CI_UI_RECT, false, false)
                
                if GetLocalPlayer() == Player(.Player) then
                    call SetCameraPosition(.camX, .camY)
                    call SetCameraField(CAMERA_FIELD_ANGLE_OF_ATTACK, 305., 0)
                    call SetCameraField(CAMERA_FIELD_TARGET_DISTANCE, .camDist, 0)
                endif
                
                call ClearAllSpecificOrderPrevention(.inventory.getOwner())
                
                static if LIBRARY_CIItemBoard then
                    call .inventory.showBoard(false)
                endif
            endif
            
            call FogModifierStart(.visible)
        endmethod

You can use this to hook a show/hide action for the inventory of a player.

 

[Hashjie]

CIContent

public method show takes boolean bol returns nothing
            call FogModifierStop(.visible)
            call DestroyFogModifier(.visible)
            
            set .viewing = bol
            
            //call EnumDestructablesInRect(CI_UI_RECT, Condition(function thistype.checkDest), null)
                
            if bol then
                if GetLocalPlayer() == Player(.Player) then
                    set .camX = GetCameraTargetPositionX()
                    set .camY = GetCameraTargetPositionY()
                    set .camZ = GetCameraTargetPositionZ()
                    set .camDist = GetCameraField(CAMERA_FIELD_TARGET_DISTANCE)
                endif
                
                set .visible = CreateFogModifierRect(Player(.Player), FOG_OF_WAR_VISIBLE, CI_UI_RECT, false, false)
                call .refresh()
                
                call PreventSpecificOrder(.inventory.getOwner(), "move", true)
                call PreventSpecificOrder(.inventory.getOwner(), "smart", true)
                
                static if LIBRARY_CIItemBoard then
                    call .inventory.showBoard(true)
                endif
            else
                set .visible = CreateFogModifierRect(Player(.Player), FOG_OF_WAR_MASKED, CI_UI_RECT, false, false)
                
                if GetLocalPlayer() == Player(.Player) then
                    call SetCameraPosition(.camX, .camY)
                    call SetCameraField(CAMERA_FIELD_ANGLE_OF_ATTACK, 305., 0)
                    call SetCameraField(CAMERA_FIELD_TARGET_DISTANCE, .camDist, 0)
                endif
                
                call ClearAllSpecificOrderPrevention(.inventory.getOwner())
                
                static if LIBRARY_CIItemBoard then
                    call .inventory.showBoard(false)
                endif
            endif
            
            call FogModifierStart(.visible)
        endmethod

You can use this to hook a show/hide action for the inventory of a player.

thanks ones again, it works ;D!
I still have one question, I guess it will be my last

How do I call the command to destroy the inventory for a player?

I have a repicking trigger for hero's but I'm not quite sure how to destroy the inventory. Now whenever I repick a hero I have 2 inventory's of 2 hero's (which one of them is removed. Which also means the fakeinv unit still exists) for 1 player... that kind of bugs the inventory xD Does the fake inventory unit get removed whenever the inventory gets destroyed?

P.S. hope I'm not bothering you too much with questions :S

 

[Anachron]

thanks ones again, it works ;D!
I still have one question, I guess it will be my last

How do I call the command to destroy the inventory for a player?

I have a repicking trigger for hero's but I'm not quite sure how to destroy the inventory. Now whenever I repick a hero I have 2 inventory's of 2 hero's (which one of them is removed. Which also means the fakeinv unit still exists) for 1 player... that kind of bugs the inventory xD Does the fake inventory unit get removed whenever the inventory gets destroyed?

P.S. hope I'm not bothering you too much with questions :S

Not possible, you can manipulate the system a bit (tweak) and change the units for the inventory dummy + hero, so that it will work like that. (Remember to DESTROY all the items before changing the units)

 

[Hashjie]

Not possible, you can manipulate the system a bit (tweak) and change the units for the inventory dummy + hero, so that it will work like that. (Remember to DESTROY all the items before changing the units)

  private static method hook_ReplaceUnitBJ takes unit whichUnit, integer newUnitId, integer unitStateMethod returns nothing
        set removing[getIndex(whichUnit)] = true
    endmethod
    //Intercepts whenever RemoveUnit or ReplaceUnitBJ is called and sets a flag.

does this mean I can call ReplaceUnitBJ to replace the hero that is used for the inventory with another hero?
And does this also count for the fake inventory unit? (It doesn't matter for the fake inventory unit because I already found a way to replace that. But for the hero I haven't found a way yet )

 

[Anachron]

Nope, that is from another code that I did not write.

If you are not familiar with vJass, I would not use this system.

However, the CIContent includes the hero and the fakehero unit (saved) and you could write methods by yourself to change them.

 

[Hashjie]

Nope, that is from another code that I did not write.

If you are not familiar with vJass, I would not use this system.

However, the CIContent includes the hero and the fakehero unit (saved) and you could write methods by yourself to change them.

I'm still learning, and I will not quit untill I have fixed this
thanks for all your help.

 

[Anachron]

Yes, I would say check the CIContent struct.
Don't forget that you will need to destroy the inventory of the unit as well!

call CustomInventory.load(GetHandleId(theUnit))

And then create a new one.

You don't need to destroy the CIContent (The window), but you should replace the dummy unit.

 

[Hashjie]

Yes, I would say check the CIContent struct.
Don't forget that you will need to destroy the inventory of the unit as well!

call CustomInventory.load(GetHandleId(theUnit))

And then create a new one.

You don't need to destroy the CIContent (The window), but you should replace the dummy unit.

I recreated the dummy by making the fakeinv variable global. That seems to work. Now the only trouble I'm having is recreation of the inventory of the unit. I'll try the best I can, I think I'll get it to work

 

[Anachron]

I recreated the dummy by making the fakeinv variable global. That seems to work. Now the only trouble I'm having is recreation of the inventory of the unit. I'll try the best I can, I think I'll get it to work

Great, sounds awesome. Good luck!

 

[hell gate]

i regioniced that there is no equip and unequip method or am i worng? cO (@ Custom Item)

 

[Anachron]

Just give the item to the units, everything is done by default. (remove the items from the hero / drop it to remove from inventory).

 

[Hashjie]

a little question: when the inventory of the unit is destroyed you can still press escape to see the inventory? Because it seems like I have to disable that untill the player has picked his new hero.. :S
This is what happens:

a hero has been picked -> the inventory is created for that hero.
the player types -repick -> the inventory of the hero gets destroyed and the fake inventory unit gets removed.

the player presses escape without having a new hero -> gives the autoindex error for removed or decayed units. (problem #1) I know why it gives that error message... But what I found strange is that: how can a player press escape to see the inventory when the inventory is destroyed :S?

the player picks a second hero -> inventory is created for the hero with a fake inventory unit

the player presses escape while having the new hero -> The inventory does show for maybe half a second and then gets hided. (problem #2) I have no idea why this happens :S


I used debugmessages to find out if the handleId of the destroyed inventory is the same as the one being created but the handleId is the same so that couldn't be the problem

as what I had assumed:
call CustomInventory.load(GetHandleId(theUnit)) will destroy the inventory of the unit right :S?

then why can a player still press escape after it gets destroyed :S?
I also noticed that .inventory becomes 2 when the second inventory gets created. Does this mean that the player now has 2 inventory's?
How do I make sure that the first inventory gets completely removed?

I'm trying to understand it but it still is a bit too hard for me ><
Maybe it's better if I find someone who knows vJass better then I do and helps me to solve this.
This is too much time consuming for you and for me

 

[Anachron]

call CustomInventory.load(GetHandleId(theUnit)) will destroy the inventory of the unit right :S?

No, it just loads the inventory.

You should really translate the actions.

call CustomInventory.load(GetHandleId(theUnit)).destroy()

this destroys it.

then why can a player still press escape after it gets destroyed :S?
I also noticed that .inventory becomes 2 when the second inventory gets created. Does this mean that the player now has 2 inventory's?
How do I make sure that the first inventory gets completely removed?

Check above, this should be fixed when inventory is destroyed.

By the way, I stopped mapping, I am really sorry but I don't offer that much help anymore.

 

[Hashjie]

No, it just loads the inventory.

You should really translate the actions.

call CustomInventory.load(GetHandleId(theUnit)).destroy()

this destroys it.


Check above, this should be fixed when inventory is destroyed.

By the way, I stopped mapping, I am really sorry but I don't offer that much help anymore.

thanks man, I appreciate everything you did for me
I hope this will solve my problem. If it does I will stop asking these questions. I have already asked enough xD

and thanks for your time man

 

[Anachron]

Thanks for using this inventory, sadly I can not help people as much as I wanted because I am not spending any more time with mapping.

 

[hell gate]

Just give the item to the units, everything is done by default. (remove the items from the hero / drop it to remove from inventory).

i mean if you put something from the inventory to your equipment and put it back o your inventory. so i can add other item abilitys to the unit.

 

[Anachron]

i mean if you put something from the inventory to your equipment and put it back o your inventory. so i can add other item abilitys to the unit.

Oh well then use the set itemobj.onPickAct = funcion. (Inside the function you do the stuff). Don't forget that the onDropAct should remove the abilities.

 

[hell gate]

ok thx

 

[hell gate]

(sry for double post)
a small thing that optimize your sys a lot:
use this model as the selectors of the items View attachment InvisiblePlatform50.mdx
i tested it. it works perfect and you always hit the item you are clicking on xD
EDIT: the old one is: CustomWindow\Track75.mdx

 

[Anachron]

Thanks, the next version has a version that is about 1% of the size of this one.

 

[Spiral]

Murloc rpgs idea or so happen to look like it

 

[Heslakin]

(...)........ I GOING TO NEED IT!
____________

GIVE ME FOOD!

 

[Anachron]

Make sure you understand vJass.

 

[Chewii]

Its two things bothering me. The first one : When i change anything i can't start the map. Second: And why is it two shoulderpads icons ? xD

 

[Anachron]

You can change it if you like.
You need vJass in order to use this system.

I wonder if ANYBODY is reading the readme at all.

 

[Chewii]

I did but i skipped that part cuz i thought that vjass and Jass was the same thing xD sorry my bad :S

 

[Anachron]

Nope it isn't.

 

[Hellflash]

Hey guys i want to use this inventory System for my ORPG but everytime i save the map i got the error Unable to find textmacro "optional" can someone say me what to do?

 

[Anachron]

Another one not reading the readme.
You need the latest patch and JNGP 5d in order to use/test this system.

You can as well test it when you have a clean download file and then test in wc3 without opening it in the editor.

 

[Hellflash]

Sorry for the idiotic question i overlooked the readme so i dont knew that and thanks for the quick reply and the help

 

[Starquizer]

The map won't launch every time I start it. I launch it on v1.24 does it have anything to do with my version.

 

[Anachron]

Yes, can you guys please actually read the readme?

 

[CloudMax]

Yes, can you guys please actually read the readme?

I think the reason to why people does not read it is becouse it is named readme...
And that is just stupid.
Make a huge bolded red text in the description and tell them to read the readme.
Most people just avoid reading stuff becouse they are lazy or just think that it is some trash.
There should be a rule about reading the readme before asking a question actually.. Not to sound rude or something.. but it should be obvious to read the readme.

 

[Starquizer]

The map won't launch every time I start it. I launch it on v1.24 does it have anything to do with my version.

Yes, can you guys please actually read the readme?

I am not complaining that I can't use your system in my own map. The problem is that I can't test yours.

I have done what you said in the readme downloaded JASSNewGen 5d and then opened it but every time I test YOUR map the loading screen won't launch and I return to the main screen as if the map doesn't exist.

Your help please.

<< EDIT >>

I don't know how it worked. It seems it won't launch because the file was in many sub-folders and the path was too long to find, but I am not sure if this is the reason or not. Anyway thanks. I hope you finish this system.

Here are my comments/bugs in the systems:

1) In the black area where the GUI is, when I press the cancel button (click on the ground) it opens the inventory.
2) Sometimes when I click on an empty square in the inventory it selects the one that is below,above, right or left of it.

Other than that the system is good.

(+ rep)

 

[Vexsaluse]

how to use this

 

[gaby-boy]

Nice Job!

 

[Anachron]

Thanks for the feedback, but I don't work on it any longer.

 

[FLW]

Why do I jump error saving the map?

 

[Anachron]

Is ANYONE actually reading the readme? Dude, seriously, seek in this thread for errors and read the readme.