[vJass] (System) CustomInventory

[supertoinkz]

Why do I jump error saving the map?

Because you are using Vanilla WE or WE Unlimited.

 

[Krl70]

Uber! =O 70 pages of comments!

 

[Anachron]

While Krl70 has made a comment on page 70. What do I want more?

 

[Arisato]

WAOW, really useful!

 

[mobius1qwe]

well, the download is v0.2.xx which means it didn't acheived v1.0. So, I'm wondering here... what's missing? What this inventory system needs to acheive v1.0?
I tested it here and worked perfectly in the diablo III map. post of Diablo III Warcraft

 

[Anachron]

Well I use another counting method. And it misses a lot (like vendors and trade systems) to be 1.0.

 

[Catch_ya]

And it misses a lot (like vendors and trade systems) to be 1.0.

But will this ever be made?

 

[Anachron]

No, I stopped mapping, lol. Why does nobody get it. I stopped working on this system as well, but I still lurk around in the forums.

 

[jonhpath]

If i copy everything from the object editor in my map the destructibles and all wont have the same ID so i need to fix them all right?

 

[Anachron]

Set CISetup -> CI_NEW_MAP to true, save the map, close it and reopen it.

 

[jonhpath]

What will this boolean do? i mean what does setting this to new map will have to do with object ids?

EDIT: will jngp actualy copy the IDs too? my map already have a pretty loaded object editor so all the IDs from your pack must have already been used in my map..

 

[Catch_ya]

What will this boolean do? i mean what does setting this to new map will have to do with object ids?

EDIT: will jngp actualy copy the IDs too? my map already have a pretty loaded object editor so all the IDs from your pack must have already been used in my map..

Im pretty sure that with NEW_MAP set to true then it will generate destructables from the

//!

But I'm not sure, better wait for him to answer.

 

[jonhpath]

Well anyway i copied all the data in the object editor with jngp so i could manualy put the ID to theire original ones in the inventory system. I got it working somewhat...

EDIT: my problem is that i moved the area where the system is to -4600 -5000 but now it show just the borders. The Drop, Quit, slots, all the icones are not shown. Where can i modify the location of those? I can manage if i get that i think...

 

[Etzer]

Do you have all imports?

 

[Anachron]

Check CISetup -> CI_BASE_X and CI_BASE_Y

 

[Edazz]

Cant see the readme.

I dont have got the readme can someone post it?

 

[jonhpath]

I had the inventory fully working but it apeared right in the middle of my map so i had to change it.This is what i changed:

        constant    boolean CI_NEW_MAP                  = false
        constant    integer CI_UI_MAX_ITEMS             = 20   
        constant    boolean CI_UI_SHOW_ITEMS            = false
        constant    boolean CI_UI_AUTO_APPLY_BONUSES    = false
        constant    boolean CI_UI_AUTO_REMOVE_BONUSES   = false
        constant    boolean CI_UI_AUTO_CHECK_PICKUP     = false
        constant    real    CI_UI_BASE_X                = -4600.
        constant    real    CI_UI_BASE_Y                = -5000.
        constant    real    CI_UI_WIDTH                 = 2048.
        constant    real    CI_UI_HEIGHT                = 1024.
                    rect    CI_UI_RECT                  = null

but when i changed it all the icones sudently dissapeared...

EDIT: ic an still see all descriptions and click the buttons. Like move a potion to the belt...just see eveerything black

 

[Anachron]

Then make sure that the terrain level is the same as the terrain level from my testmap.

 

[jonhpath]

Lollll that was the problem! thanks a lot!

By the way euh... would you care explaining me a bit how the forging work? just an examble of when forging 3 items like clay +6, claw +9 and hood of cunning that would give a bonus for 2 items and another bonus when the 3 items are set... I dont know jass but with my logic i can manage, i already made items and integrated your script to my hero spawning system

EDIT: wow i just re read my post and i made big mistake lol i was thinking of sets at the same time as forging lol anyway i just need an exemple of sets i think i can figure out forging

 

[skiper]

Hm, after copy-pasting the system into my map, it's just showing me black tiles by pressing ESC. When I mouse over this space, the inventory notice pop ups, which says 'No item in this slot'. What could be a problem to this? All imports should be alright.

 

[Vercas]

Change the path of the imports, maybe?

 

[skiper]

I set them just as they're set at test map. Did I do wrong?

 

[GunSlinger]

the same thing happened to but i did't get the answer.

 

[Anachron]

Guys, you can't use my system without knowing vJass. This is a must. Also as I said, it's quite big and I can't help any noob to implement it in his map. Also I left mapping, which makes it harder to help.

 

[skiper]

Actually, the most of JASS functions can be done by person who doesnt know a thing about it, just following the example. As I checked the system, it seems to be fairly easy to add your items with all its customization, or, for example, change the interface itself. That way I understood and modified for myself JASS cast bar system already.
But you're right, I can't do a thing in code w/o having an example, neither I can find an explanation why it doesnt work for me. And that is the only thing I need help with. If anyone knows the solution, please, post it here.

 

[Anachron]

// Put this inside the test trigger
local CISet cs = 0

set cs = CISet.create('ItemTypeOfNewItem')
call cs.addReq('ItemTypeOfNewCondition', AmountOfRequiredType)

// Example - Will create 1x Claws of Attack +6 from 2x Claws of Attack +3
set cs = CISet.create('rat6')
call cs.addReq('rat3', 2)

Please note that I do not officially support this system anymore.

 

[skiper]

Yes, I know that. And I do not ask for help directly you, maybe some other people more-less familliar with this system would help me. But, as you probably realise, you know the most about the system and its issues, obviously because it was made by you
PS: What do you think about that code you've given to another guy? I think it's fairly easy to understand it when the example is given, so I can make some forging possibilies //if my inventory will be working, of course//
The same goes with every other function. Got my opinion now?

 

[Anachron]

I can't do everything that players want. I kept the demo simple and stupid to make it easy to understand.

 

[skiper]

Ok, I found the solution by myself. It was really simple, but I dont get it - WHY. The 'Model File' at every imported destructible wasnt set as it should be - still confused, why did it happen?.. So I set them all right, and the inventory started working.
Now I gonna lurk the code to know how to make some other hero to use the inventory. Currently, all the item pickups from another heroes make items just to disappear.
So, Scarlet, check your imported destructibles.

 

[skiper]

Pff, I'm dried. I have to set the inventory to the unit, which enters playable map area, and has player controller of course. That is what I got from the last try >.>

WARNING: Since user does not know anything about JASS, he won't be responsible for any JASSer's brain explosion.

scope test initializer init

function Trig_Now_Conditions takes nothing returns boolean
    if ( not ( GetPlayerController(GetOwningPlayer(GetEnteringUnit())) == MAP_CONTROL_USER ) ) then
        return false
    endif
    return true
endfunction

        private function Trig_Now_Actions takes nothing returns nothing
        local unit fakeInv = null
        local unit hero = null
        local integer i = 0
        
        loop
            exitwhen i >= 12

            if GetPlayerSlotState(Player(i)) == PLAYER_SLOT_STATE_PLAYING and GetPlayerController(Player(i)) == MAP_CONTROL_USER then
                set fakeInv = CreateInventoryUnit(Player(i), 'h000')
                set hero = GetEnteringUnit()
                call CreateInventoryUI(hero, fakeInv)
            endif
        
            set i = i +1
        endloop
    endfunction


endscope

//===========================================================================
function InitTrig_Now takes nothing returns nothing
    set gg_trg_Now = CreateTrigger(  )
    call TriggerRegisterEnterRectSimple( gg_trg_Now, GetPlayableMapRect() )
    call TriggerAddCondition( gg_trg_Now, Condition( function Trig_Now_Conditions ) )
    call TriggerAddAction( gg_trg_Now, function Trig_Now_Actions )
endfunction

Any help? :S

 

[Chewii]

note that Anachron left mapping so you should do a new thread and post it there.

 

[Thunderwrath]

this system is amazing, though im having trouble with a certain thing.

The items that are registered work well, but when i want to register an additional item, what do i write in the ci.dest = 'XXXX' in order for it to have an icon in the inventory, not just in the leaderboard, i could not find a place where you preset the it01 it02 it03 coat and other codes to show up?

 

[skiper]

this system is amazing, though im having trouble with a certain thing.

The items that are registered work well, but when i want to register an additional item, what do i write in the ci.dest = 'XXXX' in order for it to have an icon in the inventory, not just in the leaderboard, i could not find a place where you preset the it01 it02 it03 coat and other codes to show up?

Displayed icons are set in Destructibles. You create the new destructible, set the model file to imported 'iconbase', then set Replaceable texture to which you need. After doing so, press ctrl+D and check the ID of the destructible. That ID is what you're going to put to CI.Dest. Just check the destructibles, and, I'm pretty sure, you're gonna understand everything

 

[Anachron]

Skiper please note that you can only have one inventory for each player.
(Also you NEED to know JASS in order to use this system, how often do I have to repeat this?)

 

[baassee]

how often do I have to repeat this?)

Alot.

 

[Oziris]

Beyond godlike. You've out done yourself! Too bad your not modding anymore.

 

[Anachron]

Yes. That's why I hear often. ):

For all those who want to forbid some heroes/types to use/take items of a specific type, you can use this script:

[Put this inside Testing-Items]

//: Declared in CustomItem Line 29
    private function check takes CustomItem ciObj, unit ciUnit returns boolean
        if GetUnitTypeId(ciUnit) == 'utyp' then
            if GetItemTypeId(ciObj.getHandle()) == 'itype' then
                return false
            endif
        endif
        return true
    endfunction

And inside the init function you put this in the item creation:

        set ci = CreateCustomItem('I001')
        //set ci.class = ITEM_CLASS_TWOHANDER
        //set ci.dmg = 35
        //set ci.str = 7
        //set ci.dest = 'it03'
        //set ci.icon = "ReplaceableTextures\\CommandButtons\\BTNShamanMaster.blp"
        //set ci.name = "Shaman Claw"
        //set ci.desc = "Twohander item."
        //call ci.addSfx("Abilities\\Spells\\Human\\InnerFire\\InnerFireTarget.mdl", "overhead")
        call ci.setOnCheckFunc(check)

And that's it.

 

[jonhpath]

If anyone know how to get over the "check is not a member of CustomItem" error to make a hero unable to pick an item i'd appreciate you help me with it. thanks

I added the script anachron tells in CustomItem line 30 to 37, changed utype and itype to the unit and item's id i waned (u004 and imw1 in my case) and get that error. i also added call ci.setOnCheckFunc(check) under item imw1

 

[TheNewbye911]

Heya sorry to bother you but what does this stand for , I understood your code really easy , even not knowing really good jass c++ / php algorithms kinda helped me understand your code

set ci.dest = is setting the original destination , can you explain me what does that mean? because i kinda looked all over the forum

 

[Anachron]

ci.dest = ci.destructable = The ID of the destructable used to generate the item image on the wc3 world.

 

[Guhun]

Why cant i play this map.
None of the player slots appear, and when i try to test it i get back to the Wc3 main screen. :S

 

[Vercas]

Update to the last version of Warcraft III.

Player slots not appearing means there are errors in the map's Jass. (relative to your version)

So the only reason is:
Your version is below 1.23b!

 

[Guhun]

Thanks. I was opening with my map editing wc3, which is 1.21 cause newgen only works with that ver :S

 

[Anachron]

That is wrong, newgen works with every version.

 

[Vercas]

Thanks. I was opening with my map editing wc3, which is 1.21 cause newgen only works with that ver :S

And hive's most intelligent members banned JNGPS for being better and compatible with 1.23b+!

I still have that wonderful tool. I can send you the tool. If you want it, send me a private message.

 

[eleljrk]

To bad I'm not in the Credits..
Well, seems you where the first one to taste Director's Cut for a while.. (In the spells section!)

Nice work, with a "Highly Recommended" inventory system, I'm just about to use this for my little map.. (I'm kind of back..)

 

[Anachron]

Great, welcome back, and thanks for the feedback.

 

[Neverpr0more]

Great, Another Awesome Spell By You Anachron. Congrats.

 

[baassee]

Great, Another Awesome Spell By You Anachron. Congrats.

This aint a spell lol. It's a system.

 

[Anachron]

Haha, that was a nice post. That made my day. (And thank you)