Dr Super Good
Spell Reviewer
- Joined
- Jan 18, 2005
- Messages
- 27,258
Winners: kari0003 & mckill2009
Reviews:
Mckill2009
- Coding (8.5/10)
- Configuration (3/4)
- Efficiency (2.5/3)
- Bugs (3/3)
- The system has good configuration, but not perfect configuration. I mean, the interval should be configurable as well.
- The system is good in terms of the algorithms used and the algorithm complexity, but there are a couple of things:
- You're leaking one local player.
- Your TableArrays are too oversized. When you give a TableArray a size of 0x3000, it means you're sizing the first index. The second one can be up to 2.1 billion. It's oversized because you're only using a few index spaces in the system, so 0x3000 is way too much.
- There are no bugs that I could reproduce.
- Concept (7.5/10)
- Originality (2.5/5)
- Relevant (5/5)
The concept is not very original, as you have to agree that metal is very common and it would be the first thing most people would think of.
As for the theme-relevance, good job. It's completely relevant to the theme.
Total: (16/20)
kari0003
- Coding (6/10)
- Configuration (3/4)
- Efficiency (0/3)
- Bugs (3/3)
- Your configuration is incredibly versatile, but the problem is that it's not totally user-friendly. It would be more user-friendly if you had triggers that a user would use as functions. The user would set some temp variables, then run the triggers and the system would have all the data registered to it.
- Your onPeriod trigger can be much more efficient. It would be a good idea to use a unit group to store all the units currently producing wind. When a unit is constructed in a certain region, you can store the modifier used for him in a hashtable, or you can simply set the wind production rate he has. Actually, instead, store the index of where the modifier is stored in the hashtable for this unit, so if the user changes the value during the game, your onPeriod trigger would still be able to calculate a growth rate for the unit correctly by loading it from the hashtable.
- Don't use (Integer A) or (Integer B) because they are globals made to be used for all loops in your map, which is a terrible idea by Blizzard, because if the loops are nested, you can actually break a couple of things in the map. Use a custom global integer for each of your loops ^_^
- Dying unit -> Triggering unit (For speed. I didn't remove points for this of course)
- There are no bugs that I could reproduce.
- There are way too many leaks you're not removing, like the groups inside the onPeriod trigger, and the 2 locations inside the onConstructStart trigger.
- Concept (10/10)
- Originality (5/5)
- Relevant (5/5)
The system idea is quite good, the execution is awesome, and the idea is very relevant to the theme of the contest. Well done.
Total: (16/20)
This weeks task is to make an artillery spell. This spell basically has to deploy some kind of signal, wait a time and then barrage the area around the signal randomly with effects dealing damage or buffing (you can choose) enemies and allies. The units around the targeted area must have not a very low chance of being hit and not a 100% chance of being hit and the spell has to have at least 2 levels. The rest is up to you.
Winner - Diablo-dk
Submision - Orbital Bombardment
Award - 15 rep points
Contest Number 2
You have to make an ability that's somehow connected to mirror images. I don't make any restrictions, use your "imag(e)"-ination . You can either make a passive or a castable ability.
Winner - UnMi
Submision - Mirror of Truth
Award - 10 rep points
Contest Number 3
You have to make an ability that relates to Consumption. Consume their soul, eat them (consume them literally), it doesn't matter. It just has to consume something, somehow.
Winner - Paskovich
Submission - Infest
Award - 10 rep points
Contest Number 4
You have to make a spell that somehow involves movement. Ex: Knocking back an object, Making the caster run toward a point etc.
Winner - Silvenon
Submission - Lightning Fury
Award - 10 rep points
Contest Number 5
The spell must have to do with the conjuration of a being to do the bidding of the wizard, though the being need not be a direct summon. It can range from an old standard "Summon Water Elemental", etc, spell, to a spell that makes a flaming elemental charge the nearest enemy and explode, or ghosts that haunt a target/area, etc, etc.
Winner - Mini-Me
Submission - Haunt
Award - 10 rep points
Contest Number 6
The spell must leave a positive buff on the target friendly unit, that protects it from something (losing life, losing mana, spells, buffs, etc.) The rest is up to you.
Winner - HINDYhat
Submission - Soul Transfer
Award - 10 rep points
Contest Number 7
The spell must wreak havoc on things in its path, whether allies or enemies. (you pick if allies may be hit or not) Stay away from any sort of positive effect.
Winner - DiscipleOfLife
Submission - Draenei Bombing
Award - 10 rep points
Contest Number 8
The spell must manipulate magical elements: mana, buffs, other spells entirely, summoned units, (etc), can be affected. For example, the spell might add/remove buffs, reflect spells, etc.
Winner - Razorbrain
Submission - Nether Conversion
Award - 10 rep points
Contest Number 9
The spell must augment something, be it a unit's stats (like a summon, a friendly normal unit, the caster, etc...), an effect (eg "All DOT buffs on the target do 2x damage for the next 15 seconds"), abilities (eg "Frost Nova slows for 50% longer"), and so on.
Winner - Herman
Submission - Form of the Mutilator
Award - 10 rep points
Contest Number 10
'Tis the season to be jolly, and a snowy one at that! The spell must relate to winter in some way (though it doesn't have to be jolly crushing some poor soul with a giant shard of ice is fine).
Winner - XieLong
Submission - Hiemis Viburnum
Award - 10 rep points
Contest Number 11
The spell must bounce between more than two targets, affecting each in some way. (Like Chain Lightning or Healing Wave, for example).
Winner - Martin Barbov
Submission - Elemental Chain
Award - 10 rep points
Contest Number 12
The "spell" must be a physical ability, rather than a magical spell. This means that it should be something such as throwing a rock, slashing someone quickly, etc, and not a fireball, a blizzard, or such. Additionally, keep in mind that the spell should act like a physical attack in terms of Magic Immunity and Ethereal!.
Winner - Justify
Submission - Infinite Rush
Award - 10 rep points
Contest Number 13
The spell must follow two unique themes! Evil and Double-Edged Sword will be the themes to follow.
Double-Edged Sword: The spell must have an affect which has some penalty; for example, a damage spell may damage you too, or a healing spell might also heal the enemy.
Evil: The spell must relate to evil/dark magic.
Double-Edged Sword: The spell must have an affect which has some penalty; for example, a damage spell may damage you too, or a healing spell might also heal the enemy.
Evil: The spell must relate to evil/dark magic.
Winner - DiscipleOfLife
Submission - Torturing Frenzy
Award - 10 rep points
Contest Number 14
The spell must have an affect that not only harms an enemy in some way, but also returns an advantage from this to the caster and/or their allies. The best examples of this are Drain Life/Mana.
Winner - Martin Barbov
Submission - Heart's Wrest
Award - 10 rep points
Contest Number 15
The spell must relate to a trap or ward-like unit; that is, a stationary unit which affects the area around it in some way. Examples include Healing Ward, Sentry Ward, Stasis Trap, and Goblin Land Mine.
Winner - Hanky
Submission - Vast Plain
Award - 10 rep points
Contest Number 16
The spell must relate to nature, from trees and other plants to animals, to life-related magic, and so on, and so forth.
Winner - Eccho
Submission - Ancestral Protection
Award - 10 rep points
Contest Number 17
The spell must surprise the user. Thus your caster should do unpredictable things, like teleport behind a enemy. For example: Blink strike, Windwalk, Santa coming out of a present.
Winner - Paladon
Submission - Rockfall
Award - 10 rep points
Contest Number 18
Two spells with individual effects which can be combined for another effect. An example would be the two spells of the Brewmaster: Breath Of Fire, Drunken Haze
Winner - xD.Schurke
Submission - Charge Spell
Award - 10 rep points
Contest Number 19
The spell must do something funny yet creative enough to still be viable to use in a serious map. Can be light humor, dark humor, slapstick humor, but not obscene things.
Winner - Garfield1337
Submission - Chicken Burst
Award - 10 rep points
Contest Number 20
The idea here is to copy a spell from another game. Yep, should be pretty simple. Final Fantasy, God of War, Dragon Ball Z, even another Blizzard game, just make sure it follows the rules (MUI, leakless, cool).
Winner - emjlr3
Submission - 1000 Needles (from Final Fantasy)
Award - 10 rep points
Contest Number 21
The goal is to create a new type of resource with unique methods of collection and possibly a purpose. The most important thing here is system configuration, because a good system is a flexible one.
Winners - kari0003 and mckill2009
Awards - 25 rep points
The Hive Workshop looks forward to seeing the list of winners grow...
Last edited by a moderator: