• 🏆 Texturing Contest #33 is OPEN! Contestants must re-texture a SD unit model found in-game (Warcraft 3 Classic), recreating the unit into a peaceful NPC version. 🔗Click here to enter!
  • It's time for the first HD Modeling Contest of 2024. Join the theme discussion for Hive's HD Modeling Contest #6! Click here to post your idea!

1.24 Released!

Status
Not open for further replies.

PurplePoot

PurplePoot

PurplePoot

Level 40
Joined
Dec 14, 2005
Messages
10,532
1.24 has now been officially released. This means that spells section purge will be starting as soon as possible, and you should all be ready to re-release all old maps and spells which may be affected by the patch.

The changelog:

Code: 
--------------------------------------------------------------------------
Patch 1.24
--------------------------------------------------------------------------

PC WORLD EDITOR CHANGES

- Added new JASS hash table functions to replace the lost functionality from 
   fixing unsafe type casting.
   - Hash Table - Save Item Handle
   - Hash Table - Save Unit Handle
   - ...
   - Hash Table - Load Item Handle
   - Hash Table - Load Unit Handle
   - ...
   - Hash Table - Get Handle ID

FIXES

- Fixed an exploit related to unsafe type casting that allowed users to 
   execute arbitrary code in maps.
- Fixed the JASS unsafe type casting exploit ("return bug").
- Fixed several World Editor crashes.

Also, thanks to Glica for pointing out this bit that was only included on www.battle.net:

Code: 
• “Shadowing” global variables with local variables no longer is possible.
• Fixed a type conversion dealing with operators (i.e. adding a handle with an integer)
• Added the ability to store hashtable handles in a hashtable
• Added getSpellTargetX and getSpellTargetY natives
• Added a new base handle type “Agent” of which many types now extend from.
• Added a SaveAgentHandle native which can be used for saving most handle types
• Added a JASS optimization dealing with global variable change events.
• Increased max map file size from 4MB to 8MB.

Apparently the "return bug" workaround still has not been fixed, so hopefully blizzard will get on that already. Also, for all you JassNewGen/WEHelper/etc users, be careful; PJass will not report the Return Bug as a compile error.

  • First, ensure you have JassNewGenPack5d.
  • Next, open <your JNGP folder>\jasshelper\
  • Next, replace the common.j file and Blizzard.j file with the ones included in this post.

If you get a bunch of "unregistered native function" errors, make sure to select "Disable WE Syntax Checking" in the Grimoire menu.

--------

For people who can't successfully use the test map feature in JassNewGenPack, uncheck "Enable Reinventing the Craft" in the Reinventing the Craft menu.

--------

For those of you who are complaining that your map does not run after a successful compile, this is because it did not actually succeed in compiling; rather, pJass is still compatible with the return bug and thus will not report it as an error.

To fix this, try getting the raw JASS behind your vJASS code (if applicable) and then compiling it in a test map in the vanilla World Editor.


Also, be careful with Vexorian's Map Optimizer's older versions (the newest one is apparently mostly functional) (explanation).
 

Attachments

  • scripts.zip
    84.2 KB · Views: 690
Last edited:

PurplePoot

PurplePoot

PurplePoot

Level 40
Joined
Dec 14, 2005
Messages
10,532
Pelsen said:
Um, how to download 1.24. The download doesn't start for me on any server and on the westafll server i can't even connect.
Click to expand...
Worked fine for me, but a friend of mine had to reinstall wc3.

Ranger21 said:
Don't purge spell section and map section. New patch have to many errors.
Click to expand...
The maps section isn't being purged. The spells section will be, as the patch problems don't mean the return bug doesn't have to be removed.
 

DoOs_101

DoOs_101

DoOs_101

Level 12
Joined
Aug 7, 2004
Messages
875
This update is a total chaos, are the new natives even working properly? The update is mandatory now right, meaning its no longer beta? If so I'ma have to update some stuff with my two maps...

2aeuzio.jpg
 

Darkt3mpl3r

Darkt3mpl3r

Darkt3mpl3r

Level 6
Joined
Jan 6, 2006
Messages
204
PurplePoot said:
Replace the common.j in <your jngp folder>\JassHelper\ with the one in your War3Patch.mpq.
Click to expand...

I replaced both Blizzard.j and common.j

Can you please explain how to solve the problem with some more detail ?

I tried your files and the one in my *.mpq. No effect.

ps: I'm using the latest Jass New Gen Pack ( 1.5d )

edit: Same for De.Facto, Hanky & M]ath
 

Avrion

Avrion

Avrion

Level 2
Joined
Jun 1, 2008
Messages
20
Compile errors for Jasspack. Any way to fix? Inserting the blizzard.j and common.j doesn't work. This is what happens when I try to save any map.

Error.jpg
 
Last edited:

DoOs_101

DoOs_101

DoOs_101

Level 12
Joined
Aug 7, 2004
Messages
875
Rescue me!

I replaced CSCache calls with the hashtable natives call and removed all return bugs. Map compiled succesfuly, but when I try to test it, wc3 crashes.

Same thing happens when I try to select the map in wc3, nothing shows up, as if wc3 can't read the map.
 

skull09

skull09

skull09

Level 3
Joined
Jun 9, 2007
Messages
19
i suggest that you leave the editor alone because it's quite broken(trigger editor wise), just wait until blizzard fixes it. this is a wonderful chance to build patience!

lol
 

DoOs_101

DoOs_101

DoOs_101

Level 12
Joined
Aug 7, 2004
Messages
875
This is F!!
FFFFF!!!!!!!!!

I even disabled all the spells that uses Data structs because I heard typecasting also makes the world edit crash, but wth... same thing!

Is this intentionnaly done to screw my 3 months of work including my website that depends on my maps!!?!!? F blizzard if they don't solve this.

EDIT!!!!

This will thrill you all

I removed all triggers in my maps, scripts etc removed!

ERROR! ERROR! ERROR!
 

En_Fuego

En_Fuego

En_Fuego

Level 15
Joined
Sep 3, 2006
Messages
1,738
check this kinda stuff guy. some stuff changed...for example, if/else returning is different now.
masda70 said:
I just opened WorldEditor 1.24 (no JNGP, no hacks).

This compiles:

JASS: 
function test takes nothing returns boolean
   if false then
        return true
    elseif true then
         return true
    endif
    return false
endfunction

this doesn't compile:

JASS: 
function test takes nothing returns boolean
   if false then
        return true
    elseif true then
    endif
    return false
endfunction

The first error points at the "return false" line and says: "Invalid type for specified operator."

This compiles:

JASS: 
function test takes nothing returns boolean
    if false then
        return false
    elseif false then
        return false
    else

    endif
        call BJDebugMsg("test")
    return false
endfunction

This doesn't compile:

JASS: 
function test takes nothing returns boolean
    if false then
        return false
    elseif false then
        return false
    else
        call BJDebugMsg("test")
    endif

    return false
endfunction



When it compiles, I've noticed the expected behaviour (with a debug msg).
Click to expand...
 

En_Fuego

En_Fuego

En_Fuego

Level 15
Joined
Sep 3, 2006
Messages
1,738
I just revealed another f uped!

I created a blank map, tested it and WORLD EDIT CRASHED! Yet if I create a new map using normal WE, its fine.

JNGP 5d not compatible?!?!?!
Click to expand...

If you are using JassNewGenPack and need to fix it for 1.24, do the following:
First, ensure you have JassNewGenPack5d.
Next, open <your JNGP folder>\jasshelper\
Next, replace the common.j file and Blizzard.j file with the ones included in this post.

EDIT2:

This only seems to work for some people. Not sure what the problem is for the rest.
Click to expand...

try this. unless you're an unlucky person. also, I advise you relax. It's just warcraft III. I know it's frustrating, but you'll live.
 

DoOs_101

DoOs_101

DoOs_101

Level 12
Joined
Aug 7, 2004
Messages
875
En_Fuego said:
try this. unless you're an unlucky person. also, I advise you relax. It's just warcraft III. I know it's frustrating, but you'll live.
Click to expand...

Yep same thing hapened! maybe i have to copy paste using my own mpq.

EDIT* Same thing.. you kno what, ima just go to sleep and have a good dream! Hope everything will turn out good tmrw with a new patch!!! better be soon...
 

Darkt3mpl3r

Darkt3mpl3r

Darkt3mpl3r

Level 6
Joined
Jan 6, 2006
Messages
204
En_Fuego said:
try this. unless you're an unlucky person. also, I advise you relax. It's just warcraft III. I know it's frustrating, but you'll live.
Click to expand...

Yeah it's just that I'm working hard on Chernobyl - Lost Riddles and I want to release it. With the release of this map I'm totally done with war3. I just want to finish this one project. I took some time to work on it and I cannot test the stuff I'm creating. That's pretty bollocks.

But well, I'm not taking it too serious
 

Darkness-4ever

Darkness-4ever

Darkness-4ever

Level 9
Joined
Nov 4, 2007
Messages
931
Hmm, I did as purplepoot said but newgen still compiles it all without showin me the errors that I know are in there since it wont load, no idea what to do at this point.
 
Status
Not open for further replies.

Similar threads

xp3r009
  • Locked
Warcraft III - Version 1.24 is out
Replies
6
Views
1K
xp3r009
xp3r009
ACDS2
  • Locked
I2U in 1.24
Replies
3
Views
684
ACDS2
ACDS2
PurplePoot
  • Locked
1.24b Released!
2 3 4
Replies
173
Views
14K
PurplePoot
PurplePoot
PurgeandFire
Make a Map Work for Patch 1.24
Replies
12
Views
29K
doido
doido
Bribe
Handle
Replies
2
Views
2K
Bribe
Bribe
Top