Moderator
M
Moderator
12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.
Bribe
Further reviewed:
The test-map is really not good for showing off every skill. The "Esc" key should heal my heroes and restore their mana. Also, the blademaster enemy keeps respawning forever, there was no way I could really shake him and it made it disruptive for the testing environment.
This needs an update with a more suitable test-map.
Also needs an in-game screenshot.
Essence Shift- I recommend change the actions to this:
Fortune Reversal - (Target unit of ability being cast) should be stored into a variable because you reference it a lot.
(Owner of (Triggering unit)) -> (Triggering player)
Framerate intervals should be 0.03 seconds, no more no less, and more it's overkill any less people can spot the fakeness.
Devestating Strike Loop... wow, I don't know where to start. Less arrays would be a start (store Devastation_Time[Devastating_Mui_Loop] into a normal variable, for example, because it's more efficient)
"Unit is attacked" is abusable, can cause some of these things to be overpowered.
These things are basic patterns I've seen in many of your triggers. TONS of triggers. Just tons. One of the best things of all is that I couldn't find any leaks despite the amount of triggers! Great achievement! I want to see this in the "Approved" section, but please do some quality improvements from time to time on this, as I can still see room for improvement, just let me know when you do so I can re-review/approve it.
edit
17th of July
Magtheridon96:
Marked as "Needs Fix"
I would recommend caching the the triggering unit and the triggering player instead of repeating the calls multiple times.
Also, you need to address all the problems noted by Bribe and Maker (especially the leaks).
This will be approved after that.
IcemanBo: Too long as NeedsFix. Rejected.
Maker, Hive's Spellpack v2.1b, 15.11.2011
Reasons for rejection:
You have same actions in THEN and ELSE branches. Usually leak removals. Take them out of I/T/E.
You are using poor tree detection. -> http://www.hiveworkshop.com/forums/world-editor-help-zone-98/destroy-only-trees-194925/
Casting Force ability causes weird effect on units, seems non-reversable.
Penitence cancel shouldn't be on all the time.
Use skip remaining actions in the looping trigger hen correct unit is found.
Penitence doesn't turn off.
When you create special effects, you don't need to set them into a variable if you destroy them immediately. Use Destroy last created effect. You have this flaw in many triggers.
Frost Aura group 2 is not needed, use group 1.
Dual Weapon Mastery Attack shouldn't be on all the time.
Sonic Rush causes unit group leak when cast.
Multi shot causes unit group leak when cast.
Alpha Strike causes unit group leak when cast.
Multi shot causes unit group leak when stopping casting.
Eye of the Tornado Begin causes unit group leak when cast.
Tornado Jump screws up selection.
Eye of the Tornado Stop shouldn't be on all the time.
Meditate Loop, use x mod 25 = 0 in loop instead of multiple or values.
Meditate Stop not on all the time.
Wuju Style Learn shouldn't be limited to 4 levels.
Highlander Kills not on all the time.
Highlander Loop has Display text to all players.
Soul Vortex Try has display text to all players.
Soul catch causes unit group leak when cast.
Soul catch, effect on hands can't nbe referenced afterwards. Store them.
Remove invul abil from dummy.
Dummy uses upgrades.
Dummy gives lots of vision.
General comments:
You could have used better indexing. Removing non active instances, like in dynamic indexing.
You should share "temporary" global variables. You have way too many variables in the map.
Bribe
Further reviewed:
The test-map is really not good for showing off every skill. The "Esc" key should heal my heroes and restore their mana. Also, the blademaster enemy keeps respawning forever, there was no way I could really shake him and it made it disruptive for the testing environment.
This needs an update with a more suitable test-map.
Also needs an in-game screenshot.
Essence Shift- I recommend change the actions to this:
-
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
-
If - Conditions
- ((Triggering unit) has buff B000) Equal to true
-
Then - Actions
- Set Percent = 0.10
-
Else - Actions
-
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
-
If - Conditions
- ((Triggering unit) has buff B007) Equal to true
-
Then - Actions
- Set Percent = 0.15
-
Else - Actions
- Set Percent = 0.20
-
If - Conditions
-
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
-
If - Conditions
- Unit - Set mana of (Triggering unit) to ((Mana of (Triggering unit)) + ((Max mana of (Triggering unit)) x Percent))%
- Special Effect - Create a special effect attached to the overhead of (Triggering unit) using Abilities\Spells\Undead\ReplenishHealth\ReplenishHealthCasterOverhead.mdl
- Special Effect - Destroy (Last created special effect)
Fortune Reversal - (Target unit of ability being cast) should be stored into a variable because you reference it a lot.
(Owner of (Triggering unit)) -> (Triggering player)
Framerate intervals should be 0.03 seconds, no more no less, and more it's overkill any less people can spot the fakeness.
Devestating Strike Loop... wow, I don't know where to start. Less arrays would be a start (store Devastation_Time[Devastating_Mui_Loop] into a normal variable, for example, because it's more efficient)
"Unit is attacked" is abusable, can cause some of these things to be overpowered.
These things are basic patterns I've seen in many of your triggers. TONS of triggers. Just tons. One of the best things of all is that I couldn't find any leaks despite the amount of triggers! Great achievement! I want to see this in the "Approved" section, but please do some quality improvements from time to time on this, as I can still see room for improvement, just let me know when you do so I can re-review/approve it.
edit
17th of July
Magtheridon96:
Marked as "Needs Fix"
I would recommend caching the the triggering unit and the triggering player instead of repeating the calls multiple times.
Also, you need to address all the problems noted by Bribe and Maker (especially the leaks).
This will be approved after that.