Hive's Spellpack v2.2

[Moderator]

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

Reasons for rejection:
You have same actions in THEN and ELSE branches. Usually leak removals. Take them out of I/T/E.
You are using poor tree detection. -> http://www.hiveworkshop.com/forums/world-editor-help-zone-98/destroy-only-trees-194925/
Casting Force ability causes weird effect on units, seems non-reversable.
Penitence cancel shouldn't be on all the time.
Use skip remaining actions in the looping trigger hen correct unit is found.
Penitence doesn't turn off.
When you create special effects, you don't need to set them into a variable if you destroy them immediately. Use Destroy last created effect. You have this flaw in many triggers.
Frost Aura group 2 is not needed, use group 1.
Dual Weapon Mastery Attack shouldn't be on all the time.
Sonic Rush causes unit group leak when cast.
Multi shot causes unit group leak when cast.
Alpha Strike causes unit group leak when cast.
Multi shot causes unit group leak when stopping casting.
Eye of the Tornado Begin causes unit group leak when cast.
Tornado Jump screws up selection.
Eye of the Tornado Stop shouldn't be on all the time.
Meditate Loop, use x mod 25 = 0 in loop instead of multiple or values.
Meditate Stop not on all the time.
Wuju Style Learn shouldn't be limited to 4 levels.
Highlander Kills not on all the time.
Highlander Loop has Display text to all players.
Soul Vortex Try has display text to all players.
Soul catch causes unit group leak when cast.
Soul catch, effect on hands can't nbe referenced afterwards. Store them.
Remove invul abil from dummy.
Dummy uses upgrades.
Dummy gives lots of vision.

General comments:
You could have used better indexing. Removing non active instances, like in dynamic indexing.
You should share "temporary" global variables. You have way too many variables in the map.

Old reviews

Bribe

Further reviewed:

The test-map is really not good for showing off every skill. The "Esc" key should heal my heroes and restore their mana. Also, the blademaster enemy keeps respawning forever, there was no way I could really shake him and it made it disruptive for the testing environment.

This needs an update with a more suitable test-map.

Also needs an in-game screenshot.

Old Review (still applied)

Essence Shift- I recommend change the actions to this:

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • ((Triggering unit) has buff B000) Equal to true
  • Then - Actions
    • Set Percent = 0.10
  • Else - Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • ((Triggering unit) has buff B007) Equal to true
      • Then - Actions
        • Set Percent = 0.15
      • Else - Actions
        • Set Percent = 0.20
• Unit - Set mana of (Triggering unit) to ((Mana of (Triggering unit)) + ((Max mana of (Triggering unit)) x Percent))%
• Special Effect - Create a special effect attached to the overhead of (Triggering unit) using Abilities\Spells\Undead\ReplenishHealth\ReplenishHealthCasterOverhead.mdl
• Special Effect - Destroy (Last created special effect)

Use "set bj_wantDestroyGroup = true" instead of group set/pick/destroy.

Fortune Reversal - (Target unit of ability being cast) should be stored into a variable because you reference it a lot.

(Owner of (Triggering unit)) -> (Triggering player)

Framerate intervals should be 0.03 seconds, no more no less, and more it's overkill any less people can spot the fakeness.

Devestating Strike Loop... wow, I don't know where to start. Less arrays would be a start (store Devastation_Time[Devastating_Mui_Loop] into a normal variable, for example, because it's more efficient)

"Unit is attacked" is abusable, can cause some of these things to be overpowered.

These things are basic patterns I've seen in many of your triggers. TONS of triggers. Just tons. One of the best things of all is that I couldn't find any leaks despite the amount of triggers! Great achievement! I want to see this in the "Approved" section, but please do some quality improvements from time to time on this, as I can still see room for improvement, just let me know when you do so I can re-review/approve it.

edit
17th of July
Magtheridon96:

Marked as "Needs Fix"

I would recommend caching the the triggering unit and the triggering player instead of repeating the calls multiple times.
Also, you need to address all the problems noted by Bribe and Maker (especially the leaks).

This will be approved after that.

 

[Tiche3]

Uploading.... Done, i have uploaded a map to you guys and i will add more spell describtions and triggers. Does anyone know how to add pictures to this? ? then i will add pictures.

Tiche3

 

[Maker]

Essense Shift:
Not MUI and extremely simple.

Split mana
This should be inside the group loop:

• Custom script: call RemoveLocation(udg_Split_Mana_Group_Pos)

Calculate this outside the loop:

• Set Split_Mana_Divided = (Split_Mana_Amount / (Real((Number of units in Split_Mana_Group))))

Again a simple spell.

Reverse Polarity:
I think the concept isn't that great.

Chain Link, Borrowed Time, Force Staff, Empathic Warp, Penitence, Devastating Check, Burnout, Frost Aura:
Not MUI.

The problem with this spell pack is that the spells are either too simple or not MUI.

You just need more practise in spellmaking. You know how to clear leaks, that's good. Take a look at some MUI tutorial.

 

[baassee]

Why are these not MUI?

 

[Tiche3]

Essense Shift:
Not MUI and extremely simple.

Split mana
This should be inside the group loop:

• Custom script: call RemoveLocation(udg_Split_Mana_Group_Pos)

Calculate this outside the loop:

• Set Split_Mana_Divided = (Split_Mana_Amount / (Real((Number of units in Split_Mana_Group))))

Again a simple spell.

Reverse Polarity:
I think the concept isn't that great.

Chain Link, Borrowed Time, Force Staff, Empathic Warp, Penitence, Devastating Check, Burnout, Frost Aura:
Not MUI.

The problem with this spell pack is that the spells are either too simple or not MUI.

You just need more practise in spellmaking. You know how to clear leaks, that's good. Take a look at some MUI tutorial.

Fixed the inside/outside group.
The spells are as simple as the requesters wanted
Mui tutorial - the only one i have found is hashtables, sorry, not gonna happen. Altough i've tried to make a spell MPI, but it didn't work...
I would be glad if you helped me make the spells MUI

Why are these not MUI?

As i mentioned above

Tiche3

 

[baassee]

This and this. Use them.

 

[Spoontoobig]

Essense Shift - Make it MUI ! Spell is very useful for RPG's! Thank you *

 

[Tiche3]

This and this. Use them.

Thanks baassee, but when i wrote the previous message i went on my own and guess what? Chain Link is fully working MUI Spell, updating.

Essense Shift - Make it MUI ! Spell is very useful for RPG's! Thank you *

Oke, it will be like that, but first i will upload and then check

EDIT: Made it MUI, good luck

EDIT2: Wow, i think i'm getting the hang of this: Made Force Staff (item) fully MUI, write -no to disable enemies from using it on you non stop

EDIT3: Updated to version 1.4 - made Penintence fully MUI

Rate guys and comment.

Tiche3

 

[Dr. Boom]

Moin moin =)

=== My personal vote: REJECTION [1/5] ===
( Before shouting around read the review to understand this vote )

After downloading and testing the map, this is my review:

== Essence Shift ==
You can do this simple spell with a loop from 1 to 3 (max ability level), so you don't need this amount of triggers there.

== Split Mana ==
You don't need to set Split_Mana_Amount to 0.00, because as far as I know, real don't need to be nulled.

== The Health Problem ==
What the hell is this? - Looks no needed.

== Chain Link ==
What you did there. For MUI just use 1 one variable with 3 arrays not 3 different variables. This just use more memory
Also the "If - Then - Else", where you check if "Chain_Link_Mui_Turnoff Equal to 0" should be outside of the loop. As far as I know this is better.

== Unholy Plats ==
In this trigger, I think it would be enough, if you just use 1 location and one group variable only. First you set the location to the pos of triggering unit when one group for the allies. Use the same location for the pos of Picked unit. After this group actions,put the location to the pos of triggering unit again destroy group and re-set it for the enemy group.

== Spell of Randomness ==
As far as I can see, you don't need to store the effect into a variable. You directly remove it anway, and therefor no variable need.

== Mind Explosion ==
Same with the groups here, you just need one and also you don't need to store the effect, when the destroy trigger comes immediately.

== Force Staff ==
Again the MUI variables, one variable with 3 arrays ( actually you need only two ) but not three different variables.

== Every spell above then ==
I miss the MUI from now on. Also a lot of triggers for just one spell. I say ways, to reduce the amount of triggers, but would be senseless if I write everything down.

== The test map ==
Pure fail? No but somehow yes. 1) The staff in the inventory ( anyway when you create it you create a trigger with leaks ), but the tooltip is wrong also it's annoying when you just get pushed around. Also what is the camp for, I train units but nothing happen?

Whatever, why this map is called "Hives Spellback" and/or "Map to help Hivers"? Ok this can be helpful, I don't want say something different here, but for helping the map is to complex I think.

== So what we got now [End Rating]==
Yes it's hard to rate. We don't have any high GUI here, but this is no low GUI too ( in a low amount of cases ). But still this pack needs many improvements. Also the MUI fail at the last spells as far as I can see. SO this is against the rules, but you have many working stuff there ... BUT I say rejection UNTIL! you improve this pack a lot!

NOTE: My review is NOTHING! against the creator of the pack and NOTHING against the pack itself. But in this complex pack you can improve a lot of things!
When I see you work on it and improve it, I come back and review + rerate it.

Greetings and Peace
Dr. Boom

 

[Tiche3]

Moin moin =)

=== My personal vote: REJECTION [1/5] ===

First of all, thanks for reviewing my spells. The spell pack looks like... because this is the map i upload when i do a request for you guys, that's why there are stuff like 'the health problem' and that tavern

== Essence Shift ==
You can do this simple spell with a loop from 1 to 3 (max ability level), so you don't need this amount of triggers there.

Actually, if you could help me fix this, since i can't figure it out. (<.<)

== Split Mana ==
You don't need to set Split_Mana_Amount to 0.00, because as far as I know, real don't need to be nulled.

Done

== The Health Problem ==
What the hell is this? - Looks no needed.

Removed, look three quotes above

== Chain Link ==
What you did there. For MUI just use 1 one variable with 3 arrays not 3 different variables. This just use more memory
Also the "If - Then - Else", where you check if "Chain_Link_Mui_Turnoff Equal to 0" should be outside of the loop. As far as I know this is better.

Thanks, but i will stay with my own, since this is the first MUI spell in my life and this way I understand it better, sorry.

== Unholy Plats ==
In this trigger, I think it would be enough, if you just use 1 location and one group variable only. First you set the location to the pos of triggering unit when one group for the allies. Use the same location for the pos of Picked unit. After this group actions,put the location to the pos of triggering unit again destroy group and re-set it for the enemy group.

Done

== Spell of Randomness ==
As far as I can see, you don't need to store the effect into a variable. You directly remove it anway, and therefor no variable need.

Done

== Mind Explosion ==
Same with the groups here, you just need one and also you don't need to store the effect, when the destroy trigger comes immediately.

Done

== Force Staff ==
Again the MUI variables, one variable with 3 arrays ( actually you need only two ) but not three different variables.

As mentioned above this was the second MUI spell in my life, so i am sorry.

== Every spell above then ==
I miss the MUI from now on. Also a lot of triggers for just one spell. I say ways, to reduce the amount of triggers, but would be senseless if I write everything down.

Yeah, okay, thanks for reviewing

== The test map ==

Pure fail? No but somehow yes. 1) The staff in the inventory ( anyway when you create it you create a trigger with leaks ), but the tooltip is wrong also it's annoying when you just get pushed around. Also what is the camp for, I train units but nothing happen?

Done, removed the camp, since it was a request for one guy and it is not necessary here, about the Force Staff pushing non stop - just write -no and they will stop, this is just for testing purposes. Since i couldn't test it without num pads (i am using a laptop)

Whatever, why this map is called "Hives Spellback" and/or "Map to help Hivers"? Ok this can be helpful, I don't want say something different here, but for helping the map is to complex I think.

As mentioned above, this is the map in which i create and upload spells to help the people who asked for them.

== So what we got now [End Rating]==
Yes it's hard to rate. We don't have any high GUI here, but this is no low GUI too ( in a low amount of cases ). But still this pack needs many improvements. Also the MUI fail at the last spells as far as I can see. SO this is against the rules, but you have many working stuff there ... BUT I say rejection UNTIL! you improve this pack a lot!

Good criticism is always welcomed, thanks for your review.

NOTE: My review is NOTHING! against the creator of the pack and NOTHING against the pack itself. But in this complex pack you can improve a lot of things!
When I see you work on it and improve it, I come back and review + rerate it.

Meh, it's nothing personal, don't worry, i like that you reviewed it and of course i will improve and update my map

Tiche3

 

[Spoontoobig]

Good work, and good luck Tiche3, also you could make RPG spell pack simple, good, mui and dont know.. +REP!

 

[Midnighters]

== Essence Shift ==
You can do this simple spell with a loop from 1 to 3 (max ability level), so you don't need this amount of triggers there.

Actually, if you could help me fix this, since i can't figure it out. (<.<)

Would you like my help with this? It is easily done, I can set it up, but you will need to remove the leaks.

The easiest way to do so though, is in an if function check the level of the ability, like, "Level of [ABILITY] equal to 1" then you do your actions, and it will only do those actions when the level is one. Try it first, then if you can't get it, let me know.

 

[Zealon]

Wait, wheres the discription for Borrowed Time?

 

[Fallen Solar]

Borrowed Time is not MUI, it has an Wait action. use a timer instead.

 

[Zealon]

Okay, and your spellpack looks pretty awesome, nice work

 

[yeohxin]

Nice, good luck

 

[Tiche3]

Long time no see guys updated the version.

Version 1.6 - Added 5 new MUI spells, made some spells MUI currently in the pack.

EDIT: Updated again, added Multi Shot (MUI). Will be updating some new spells.

EDIT 2: Updated again, added Snipe Assasination Shot, Sneaky, Traceless Assasination (All spells are MUI).

Tiche3

 

[Dr. Boom]

Moin moin =)

Ok I'm back with a new computer and as I promised, I review your spell pack, so lets go.

=== General ===
1) Maybe you add in your conditions, when you pick units for example, if the picked unit/s is/are magic immune.
2) You don't need to store attached effects into a variable, as far as I know. You can destroy them the normal way.
3) Improve the test map. Just 2 Heroes of the same type with level 10 or so, place some enemy units (not just heroes, for the mind explosion spell for example)
4) You should think about, to make those spells in Jass/vJass, because I! think that this helps more then GUI, but ofc it's your choice.

=== Essence Shift ===
1) As far es I can see you can delete the full "or - any" condition, because you don't need to double check it.

=== Split Mana ===
1) I think you can use directly "Set Split_Mana_Amount = Mana of (Packed Unit), because the variable starts by 0 anyway.
2) Also I think you just need to pick all units in the group for one time not twice.

=== Impact ===
1) No hero on the map has this spell for testing.

=== Unholy Plats ===
1)No hero on the map has this spell for testing.
2) Also it's enough, if you just create the unit group once. Use the variable Unholy_Plats_Group for picking every unit without checking if ally or enemy. Then pick every unit in this group and then make the condition if ally or enemy inside the pick.
3) Also I think of a better effect of the healing, not just this poor yellow one ^^

=== Fortune Reversal ===
1)With this ability you can even heal the target enemy unit, don't know if that is a cool idea.
2) Also an effect at the target would be nice.

=== Spell of Randomness ===
1) No hero on the map has this spell for testing.
2) Also the spell could be a one level spell. Maybe you should increase the random stuff a little with each ability level.

=== Mind Explosion ===
1) Same, you just need to pick the unit group one time and check inside the Pick every units in ... if there is any hero or not.
2) If my calculation skill isn't failing here, the spell is a little to over powered I think. If the unit has 1000 mana then: [(1000) * (0.25 + (0.25 * level))] = 500. So if the level ability is 3, the picked units are instant dead. Also if the unit dies, again 300 damage ... which is a lot of damage at all.

=== Frost Aura (Loop) ===
1) As I see you pick every unit in Frost_Groupie_Two and in the first conditions you check, if the picked units aren't in this group, but where you pick every units into the Frost_Groupie_Two?

=== Sonic Focus ===
1) I don't understand the struct of this. First you check if "Focused Force is over 0", then you check if "Sonic Focus is level 1" then you check if "Focused Force is level 2" and then you don't have a then action, you use an else action. Explain this please, because I don't get the way.

Ok this all for now, don't have time to continue, but you got a small list now and lets see whats coming next.

Greetings and Peace
Dr. Boom.

 

[Tiche3]

Moin moin =)

Ok I'm back with a new computer and as I promised, I review your spell pack, so lets go.

Thanks for reviewing now i'm going to check all the things you pointed out for me

1) Maybe you add in your conditions, when you pick units for example, if the picked unit/s is/are magic immune.
2) You don't need to store attached effects into a variable, as far as I know. You can destroy them the normal way.
3) Improve the test map. Just 2 Heroes of the same type with level 10 or so, place some enemy units (not just heroes, for the mind explosion spell for example)
4) You should think about, to make those spells in Jass/vJass, because I! think that this helps more then GUI, but ofc it's your choice.

1) Done!
2) Yeah, might be so, but i've experienced things when they last longer than expected or just destroy at instant, only showing for like 0.1 second maybe i'll leave it this way
3) Improved! (changed the terrain to look better for the eye), grouped Heroes in a pair of two (except for the guy with non-Mui spells (3 of 'em)), placed some normal units for mind explosion spell
4) Meh, all i know about Jass is few custom scripts to destroy leaks. I will stay with GUI for now this spellpack needs to be simple for almost any hiver (since this spellpack is the spells requested in GUI )

=== Essence Shift ===
1) As far es I can see you can delete the full "or - any" condition, because you don't need to double check it.

It's there for the event checking, since if the event wouldn't be without any conditions as such (since the "Conditions" part are And all conditions are true always (but it doesn't show so)) and the part in the If-Then-Else is because it's different buffs for different skill levels, to reach multiinstansability

=== Split Mana ===
1) I think you can use directly "Set Split_Mana_Amount = Mana of (Packed Unit), because the variable starts by 0 anyway.
2) Also I think you just need to pick all units in the group for one time not twice.

Actually it must be set to that, because in the first pick, the units' mana is added to the "amount" and in the later pick the mana is split, because if it would be in one unit group pick, it would be splitted like this: Mana of first unit - 20, then it would be divided let's say by 5 and everyone would get 4 mana, then the other unit and blah blah

You know why is it like that? cause unit groups are like loops, but for each unit do actions Meh, hard to explain, try texting Game:text all (split_mana_amount) and you'll see what i mean

=== Impact ===
1) No hero on the map has this spell for testing.

Done!

1)No hero on the map has this spell for testing.
2) Also it's enough, if you just create the unit group once. Use the variable Unholy_Plats_Group for picking every unit without checking if ally or enemy. Then pick every unit in this group and then make the condition if ally or enemy inside the pick.
3) Also I think of a better effect of the healing, not just this poor yellow one ^^

1) Done!
2) Done!
3) Meh, haven't thought of that yet hard to find one

=== Fortune Reversal ===
1)With this ability you can even heal the target enemy unit, don't know if that is a cool idea.
2) Also an effect at the target would be nice.

1) One requester (Aspherant-Lucaz if i'm correct) asked for it to be like that and since it's a hive's spellpack and the spells are the ones people asked to be created, it's his idea
2) I might add it in the version 2

=== Spell of Randomness ===
1) No hero on the map has this spell for testing.
2) Also the spell could be a one level spell. Maybe you should increase the random stuff a little with each ability level.

1) Fixed! (;
2) I could do it like this, but the requester asked it to be like this, although i think i might change it in version 2

=== Mind Explosion ===
1) Same, you just need to pick the unit group one time and check inside the Pick every units in ... if there is any hero or not.
2) If my calculation skill isn't failing here, the spell is a little to over powered I think. If the unit has 1000 mana then: [(1000) * (0.25 + (0.25 * level))] = 500. So if the level ability is 3, the picked units are instant dead. Also if the unit dies, again 300 damage ... which is a lot of damage at all.

1) Done!
2) Actually numbers are still as requested, but i might change them if it's that overpowered (but you are the ones (hivers) who can change them for themselves depending on how and what they want of it

=== Frost Aura (Loop) ===
1) As I see you pick every unit in Frost_Groupie_Two and in the first conditions you check, if the picked units aren't in this group, but where you pick every units into the Frost_Groupie_Two?

It's like this because the frost_groupie picks the units that GET in the range and puts them in the group, which is the units that ARE inside and slows the units inside and if the unit reaches very slow movement speed or gets outside the are they are automatically (of course through triggers) removed from the group

=== Sonic Focus ===
1) I don't understand the struct of this. First you check if "Focused Force is over 0", then you check if "Sonic Focus is level 1" then you check if "Focused Force is level 2" and then you don't have a then action, you use an else action. Explain this please, because I don't get the way.

Meh, hard to explain, if the unit has the ability and it has reached it's max level (the dummy one) then it does nothin, else it increases

Ok this all for now, don't have time to continue, but you got a small list now and lets see whats coming next.

Greetings and Peace
Dr. Boom.

Thanks, but the TIME HAS COME TO IMPROVEEEE

Updated the spellpack: fixed some issues you told me to (thanks), polished some triggers (double thanks) and yeah.
Changed the terrain, made it a little bit more attractive to the eye and added 3 new MUI spells - Spinning Blow, Tornado Jump and Eye of the Tornado (also a new hero - Typhoon (tripely awesome ))

Tiche3

 

[Magtheridon96]

As you requested:

FULL REVIEW:

-Essence Shift:

*It may be simple, but it's pretty useful
*It is infact MUI, since it is instant and has no leaks

-Split Mana:

*I think this spell in the eyes of a player, would be extremely useful! I like it.
*It doesn't leak, it is MUI, and it's easy to implement.

-Impact:

*Good job on this spell.
*My only suggestion is that you would move the units to the position of the caster. This way, they will appear around him in a circle, and if they were originally next to him (closer than 250 range), it would look wierd how they would suddenly appear further away then they already were.

-Chain Link:

*Good Job!
*I think it would be better if the spell was channeling and if the targetted unit is incapable of movement.
*I also think it needs some DPS (damage per second) (20 would be suitable)

-Unholy Plats:

*I have no suggestions for this spell
*It's good, it's MUI, it's leakless; what more could anyone want?

-Fortune Reversal:

*Good job on this spell (coding-wise), but i honestly think it needs some reworking. It can heal enemy units. I suggest you make the spell set someone's mana to half his health and his health to double his mana. This way, the spell would be effective against strength heroes with low mana, but it would be horrible against intelligence mage heroes.
*It doesn't leak and it's MUI
*Also i think you should add some sort of special effect

-Spell of Randomness:

*Good job.
*I only suggest that you add more randomness in the spell:
-Random Special Effect
-Random Spell Buff for each individual unit (Slow, Stun, burn with DPS...)
*You could make the damage random this way:
-25% chance to deal 0 damage
-50% chance to deal 50-300 damage
-25% chance to deal 400 damage

-Spell Shield:

*It's aight.

-Mind Explosion:

*Good job on this spell
*I don't think it needs any modifications.

-Force Staff

*I think something's missing in this spell.
*This spell can make units move above terrain elevations. To get rid of that, you have to detect the z (as in the height) of the unit. If the difference of z of the unit is greater by a value of 64 or greater in one instant, then change the offset to a negative one for the next instant. (he'll go back and forth when he hits an elevation). This edit might make the spell non-MUI again, but it will be worth it, because i think you work something out with indexes or hashtables. If you want this to work, you have to make the spell loop every 0.02 seconds and you have to set the moving location's offset to 10.

-Penitence:

*I'm not exactly sure why, but the spell doesn't heal my allies when i cast it on them.

-Frost Aura:

*The special effect should be more.... frosty-like (lol)
*The icon could be changed
*It is MUI
*The buff needs to be changed. It says: This unit is under the effects of Brilliance aura; it is slowed constantly. The buff effect should be changed for the caster.

-Devastating Strike:

*The damage per slash needs to be increased slightly.
*The spell effect is great.
*The jump effect needs to be reworked using trigonometry (i dont know how since im taking trigonometry at the end of next trimester ). If you don't want to use trigonometry, you can use a height changing variable that decreases and half way throught the jump begins to increase.
****Sorry to complicate things ****

-Dual Weapon Mastery:

*This spell is creative, it's original (i think), and it's MUI

-Sonic Focus:

*Why didn't I think of that?!?
*This spell can really be useful.
*I found no problems with it. People might think it's inefficient, but it's ok since it's functional

-Triple Sonic Slash:

*I found no problems, just one question: Did you mean to repeat the following line of code twice:

Show

• Unit - Decrease level of Focused Force for (Triggering unit)

-Sonic Blaster:

*Good Job on this spell
*I also find no problems.
*I tested the MUI part, and yes it is 100% MUI (Oh yeah.. I'm very skeptical -.-)

-Sonic Rush:

*Excellent!
*Leakless, Mui, Good effects, ....

-Multi-Shot:

*No problems with this spell.
*Good job
*Maybe you can add a knockback of some sort when each arrow hits an enemy unit.

-Snipe Assassination Shot:

*Okay lol

-Sneaky:

*Can you slightly increase the font of the floating text and make the color red or green (whichever seems more related to agility to you; i'd say red).

-Traceless Assassination:

*Excellent Spell idea.
*It might be imbalanced, but that should fixed by the user.
*Just one thing: If an enemy unit has magic sentry or truesight, the ability wouldn't work.
*To fix this, just detect if any units in range have magic sentry or truesight and disable it temporarily.

-Bleed:

*It was an awesome idea to make the spell an auto-casting one ( u probably had no idea xD ).
*It doesn't bug.
*I only suggest that you let the effect last longer.

-Spinning Blow:

*My only comment involves the sound of the spell. It's okay, but it needs to be changed.

-Tornado jump:

*You shouldn't hide the caster because it would ruin the effect, so i suggest you constantly shrink him, then move him to the targeted point and he grows back to normal size. (Pretty good effect huh?)

-Eye of the Tornado:

*An excellent spell. It is MUI.
*I found that if a unit is affected by this spell by 2 casters he would move in an 8 loop (by "8" i mean like the shape of the loop). That's awesome.
*And instead of removing the dummies, you can add expiration timers.

-Empathetic Warp:

*I can only comment in-depth on this spell after it has been made MUI.
*The idea is good though.
*I found no leaks, so, good.

-Borrowed Time:

*It doesn't work completely. If you killed the caster in a One-hit KO, he would die in an instant. I tried. (Again... i'm very skeptical -.-)
*I like the idea of this spell though

-Burnout:

*Very creative idea for a spell.
*It isn't MUI, so you can fix that using hashtables. ( i think )


------------------------------------------------------------------------
There you have it. A review that took me 2 hours to make since i tested each spell many times and reviewed the code twice.
------------------------------------------------------------------------

I hope you'll listen to some of my suggestions.
That would be highly appreciated.

PS. This review PWNS!!

 

[Arisato]

atlast you uploaded the CHain Link used for my map : )

 

[Dr. Boom]

Moin moin =)

Well, after a friend use something of this pack which didn't work how he wanted, I looked again to this pack and got the following:

=== Multishot ===
1) When she fires up her arrows, a arrow sound should be played, can be optional.
2) Also wondering, when I cast the spell, then she stands for 1 or 2 seconds and then she fire her arrows. This waittime should be removed or putted into a variable.
3) I see that a target can be hit by all arrows if the target is to close. Maybe you should add a boolean variable, if the target only should get damaged by one arrow or by all.

=== Traceless Asasination ===
1) You can add an effect when she cast it.

=== Split Mana ===
1) Somehow I try to understand the sense of this spell? Mean drain mana from his allies is somehow useless with no other effect^^
2) Also you just need one location variable for this spell. When you set up the first group you can remove it and then use this location again for the (Position of (Picked Unit)) in the second group action

=== Penitence ===
1) When the caster cast it, I think an immediately damage/heal should come up, not first after some duration.

=== Bleed ===
1) Wondering why you can target allies with it?
2) You should set this "15% of damage by distance" into a variable, so everyone can modify this by his own.
3) Same thing about the bleed time. (I think this is the duration of the spell right?)

=== Chain Link ===
1) I saw the the lightning is attached to the feet of the target. Here you should use the custom script "AddLightningEx()", to make this chain at the body of the target.

call AddLightningEx(String name of the lightning,true,x of caster,y of caster,z of caster(height),x of target, y of target,z of target(height))

=== Devastating Strike ===
1) When someone wants, that the first strike before flying, deals damage and the target get killed by this damage, then the caster is still unable to walk or do something else, until the full duration is gone.
2) Also I'm sure that you don't need two loops for it.

=== Reverse Polarity ===
1) This spell is too simple isn't it. Try to code it like this, that all the target are fast dragged to him instead of being ported instant in front of the caster.

=== Unholy Plats ===
1) Well, why not using an attached effect here too? Then you can delete the use of a second point variable.

=== Frost Aura ===
1) Why this aura only works for enemy heroes? (Because the Grunts on the testmap didn't get slowed nor the effect comes up)
2) Also for not being a overpower spell, you shouldn't make it as a condition if the current MS of the picked unit is under 20. Make instead something like this: Current MS of the picked unit is under (Default MS of picked unit) / 3.

=== Snipe Assasination Shot ===
1) Don't ask me HOW! this happen (someone with better GUI knowledge should think of this) but I detected a bug. When I cast this spell and she fire the arrow up, then under some conditions when the target unit is moving, the arrow is flying around the target through the air, even when the target is dead =O

I tried to screen it (Red = arrow - Blue = target alive

After sometime target was dead, but arrow still spinning ...

Again I don't know how this happen, but Maker has very high GUI skills, you should ask him for example if you don't know the error

=== Tornado Jump ===
1) Well it isn't a jump, it's more a port, so you should make something here

=== General ===
1) Well you don't need store attached effects into variables. The thing is, if you immediately destroy the effect, these effects are shown up to 5 seconds anyway.
2) In each trigger, you have to null unit variables. (Well it's in Jass, so I think it's in GUI too!)
3) In spells where you use more then 3 times (TriggeringUnit) or (Target unit of ability being cast), you should store them into a variable and refer to the variable. This (TriggeringUnit) and (Target unit of ability being cast) and so on, always call another function themself.
4) For example "Penitence" is a channel spell, but you don't need to check in 2 other triggers, if the unit is still casting the ability or used something else. You can do the following main condition in the loop trigger:

• (Current order of Penitencer[Penitence_Mui_Loop]) Equal to (Order(channel))

If this is true then all actions happen, else (so if not true) then resett everything or what ever. ( In this caste channel is the order of the spell!! )

Well now I need to go to the city, but I think you have some stuff now to fix and to change here, I will review the pack after some changes when I have time =)

Greetings and Peace
Dr. Boom

 

[Arisato]

The pack was awesome : )
PSr.Boom , i thought you always use Moin moin (jk)

 

[xDeathKnightx]

This is awesome. Great work. 5/5

 

[Tiche3]

Thank you guys for all the criticism on how and what should be improved. I already have a bit fixed version, but i will only upload it when i finish most of all of your suggestions

Tiche3

 

[Maximum_Evil]

It got 5 starts but it rejected? Hmmmm...

 

[Tiche3]

It got 5 starts but it rejected? Hmmmm...

Ummm... I didn't upload the newest and improved, fixed version here. Didn't finish ALL the things the moderators wanted me to. So it's like that but i hope i will make it soon

EDIT, MEGA EDIT: Uploaded a new version!!! changes are in the changelog. Uploaded a screenshot, uploaded few times but the screenie doesn't change.

The test-map is really not good for showing off every skill. The "Esc" key should heal my heroes and restore their mana. Also, the blademaster enemy keeps respawning forever, there was no way I could really shake him and it made it disruptive for the testing environment.

I think this is fixed

This needs an update with a more suitable test-map.

Also needs an in-game screenshot.

Tried to do it, but the screenie doesn't update will try few times a bit later

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • ((Triggering unit) has buff B000) Equal to true
  • Then - Actions
    • Set Percent = 0.10
  • Else - Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • ((Triggering unit) has buff B007) Equal to true
      • Then - Actions
        • Set Percent = 0.15
      • Else - Actions
        • Set Percent = 0.20
• Unit - Set mana of (Triggering unit) to ((Mana of (Triggering unit)) + ((Max mana of (Triggering unit)) x Percent))%
• Special Effect - Create a special effect attached to the overhead of (Triggering unit) using Abilities\Spells\Undead\ReplenishHealth\ReplenishHealthCasterOverhead.mdl
• Special Effect - Destroy (Last created special effect)

Done!

Use "set bj_wantDestroyGroup = true" instead of group set/pick/destroy.

A question: may i still use the set/pick/destroy? I'm very used to doing this since i began triggering. It would just kill me to do this (can't fix my brain).

Fortune Reversal - (Target unit of ability being cast) should be stored into a variable because you reference it a lot.

Done!

(Owner of (Triggering unit)) -> (Triggering player)

If my eyes didn't fail me it's done in all the triggers it could be done (;

Framerate intervals should be 0.03 seconds, no more no less, and more it's overkill any less people can spot the fakeness

This is another thing may i still use the 0.04 seconds, not only because i'm used to it but for me it's better to calculate the ticks (25=1 second and etc.) since 0.03 is kind of a periodic number, so it would be hard for me to change all the triggers ;( (because of the reasons i explained above)

Devestating Strike Loop... wow, I don't know where to start. Less arrays would be a start (store Devastation_Time[Devastating_Mui_Loop] into a normal variable, for example, because it's more efficient)

Question: since it is a MUI spell, wouldn't changing an array into a normal variable ruin all the spell?

"Unit is attacked" is abusable, can cause some of these things to be overpowered.

I'm sorry but i will leave it as it is. FOR NOW until i get the hang of the damage detection system.

These things are basic patterns I've seen in many of your triggers. TONS of triggers. Just tons. One of the best things of all is that I couldn't find any leaks despite the amount of triggers! Great achievement! I want to see this in the "Approved" section, but please do some quality improvements from time to time on this, as I can still see room for improvement, just let me know when you do so I can re-review/approve it.

Thank you for reviewing this spellpack. I hope i didn't fail your expectations. ):

Tiche3

 

[Zanekok]

First four spells are from League of Legends-Master Yi but gj

 

[Tiche3]

Another Update (2 of them, to be exact) added a lot of things. And in the second update, created a tavern for heroes. All of the changes are in the change-log.

Sorry Dr.Boom and Magtheridon96 for not uploading your suggested things but i hope in the future i will do them and this pack will be more awesome

EDIT: Currently implemented a Damage Detection system made by Weep. Made it to detect differently spell and melee damage. But the problem with this is that you need to custom damage every normal, usual Warcraft3 spell you have if you want this to work properly, else basic Warcraft 3 spells will cause their damage to be treated as Melee Damage. This is the current stage. I've fixed some issues such as Reverse Polarity. (Made it to damage through triggers=spell damage, not melee damage) I hope i will get to work on Unholy Plats and make it fully custom thus meaning a whole new spell which would use only dummy units and move them. That is for now.

Tiche3

 

[Dimo]

This map corrupted mine, all of sudden all of the triggers on my map disabled and give me error when i try to turn them back on!