[vJass] (System) CustomInventory

[Adiktuz]

When the hero dies, you can still open the inventory. But when you pick a potion and try to place it into the hero inventory (at the inventar the 4 []), then the item is dropped on the system and lost.

You can put a filter urself on the part which opens the inventory which checks if the hero is alive or not... ^.^

because as baassee said...

 

[Anachron]

Okay guys, I will try to write a little documentation because as it seems, people are still using this inventory.

Thanks all for using. If I get my QX412 laptop back I may also fix a few bugs. Is someone nice enough to make a list of known bugs?

Thanks all for feedback and using.

 

[Laiev]

Just found this. Other bugs was related to JH outdated or JNGP bugged.

 

[Anachron]

What? Just one bug? And I didn't really get what he meant by "Hero dies" and "Drop item".

 

[baassee]

What? Just one bug? And I didn't really get what he meant by "Hero dies" and "Drop item".

Oh my you're back! Or were you just lurking in the shadows.

 

[Anachron]

No, I haven't logged in for like one or two years
I didn't get the laptop back yet so I can't make the documentation.
Unless someone sends me all the 46 scripts seperated as .j or .txt file.
(I gief cookies, of course!)

 

[Laiev]

@Anachron

Anything else?

 

[Anachron]

Thanks a lot. I will try to write a documentation when I have time.

 

[shinji]

Does this take ages to import?? Like I have to set like a lot of variables depending in the numbers of item in your map??

 

[Adiktuz]

To import, not... But to implement, yes...

 

[shinji]

Hmm... I've used this if it doesn't take ages to import. I'll just use the blizzard inventory.

 

[Adiktuz]

well, you need to put some time if you want the awesomeness that FS systems provide... XD...

 

[shinji]

Yeah. But my map will be fine with only 6 slots.

 

[Adiktuz]

if you want an easier to use FSI [less functionalities of course], there is Ghost's (old), and I think the more recent one in GUI was made by Maddeem...

 

[shinji]

Well... I'll make a simple one only for my map.

 

[Xonok]

I can't agree about JASS skills being needed. I can only read JASS, not write, but i'm still using this system. All i can't do is adding or modifying modules.

 

[Adiktuz]

Reading/understanding jass is a jass skill...

btw if you can't write jass then how have you written the necessary codes to make each item work? thru custom script in GUI? that is JASS too...

 

[Xonok]

Writing in GUI doesn't mean the same as writing pure code in JASS. How do i do it? It's so simple to understand for me, i just make items like in the example. No skills in that, except understanding the code.

 

[Dr. Boom]

Moin moin =)

oO didn't really noticed that Anachon returned. Well I see his post is nearly a year ago and he didn't understand what bug I had, so I post it and hopefully he or someone else will see it then^^

Edit: omg .. the video is not so bright as the preview of it so don't worry...

Greetings and Peace
Dr. Boom

 

[Anachron]

Holy crap, I did not account that.
Thanks for the bug, I check if I can get JNGP to work and will fix the bug.

Edit:
I did not really return. Just checking the forum from time to time.

Edit2:
I just released 0.2.2.6. The bug should be fixed now!
Additionally I attached a little description about classes to the first page, so developers can see what the classes are for!

 

[gorillabull]

you dont need trackables to display the item stats on a multiboard you can just use destructible tooltips, otherwise this sys tem is 2.5x faster thanother gui versions there is no delays etc

 

[Adiktuz]

what's destructible tooltips???

 

[Anachron]

I am not sure you understand my library.
I use trackables only for displaying item icons and actions for FullScreenUI.
There is no way how to use trackable/destructable (icons??) for the Board itself.

Thanks for the feedback though!

I think one of the best thing is that this system does not disselect hero and you can still cast spells and all.

 

[gorillabull]

no no no thats not what i meant, you create a trackable for each "item" in the "inventory" and when the user moves the cursor over the "item" the trackable fires and a multiboard is created displaying the "item" stats etc. what i meant you could do is only set the "item" (which is a destructible) 's "Text - Name" to the "tooltip" on the multiboard and you get a similar result like a hero inventory eg the tooltip appears above the "item" there are some disadvantages to this 1. the destructible model "iconbase" displays its tooltips at random points 2. the tooltips cannot be too long

something like this

show

 

[Anachron]

You know that that item cannot be displayed since it gives "Permission Denied" error?
URL is: https://lh5.googleusercontent.com/J...0TL0ciuIJZ9_v2iT68aworX-qee11RJ2ORo5sx6Nf5dCY

Edit: Guys, would you rather:
1.) Have an insanely small inventory area
2.) Are able to scroll pages for the inventory
3.) Have a shop system
4.) Have a trade system
5.) Have a save/load generator?

 

[Dr. Boom]

1.) Why? It's small enough.
2.) Sounds like my idea gets to work - yes!
3.) No, what for...
4.) Drop item; trading done
5.) Don't we have enough of these already >_>

6.) But what you can make is a mailbox system with item attachments! Like for ORPG maps, one player sends a message and an item to some other player. Then 3 days later this player joins the ORPG and got message and item. Impossible but you should try it =)

 

[baassee]

I'd say 3. would be cool.

 

[Anachron]

@Dr. Boom: Okay, I will try 2.
@baassee: With pages per class (weapon/defense) or scrollable (pages, check 2.)?

 

[baassee]

Pages per class so it's easy to find whatever thing you are looking for.

 

[Anachron]

Okay, sounds reasonable.
Is anyone actually using this?

 

[baassee]

I got it implemented in my Master Arena v4.0 backup yet no idea if I should use it in a REALLY small AOS map

 

[Anachron]

Maybe I should update other systems (just like CustomMissile or CustomAttack) which can be used for smaller maps aswell

 

[baassee]

UPDATE CUSTOM MISSILE (althought I think I have one spell using it atm). However I don't think people would use CustomAttack but it would be really cool to implement

 

[Anachron]

Okay, in my "System giveaway" thread there is latest CustomMissile version. (None-working for now)

I think I will update it when there is nobody else using my Inventory right now.

 

[jxtranghero]

Can I ask if this worked with with "CODEGEN" to save? thanks and have a nice day.

 

[Anachron]

Well you can make it work by using the first post and getting the item information.

 

[TwoVenomous]

i have a problem when i save map

i have 2 library called tables, but they are different. how can i solve this problem ?

this is the other tables i'm talking about :

Hidden

library Table // made by Bribe, special thanks to Nestharus, version 3.0.0.0
/*
    API
    
    ------------
    struct Table
    | static method create takes nothing returns Table
    |     create a new Table
    |    
    | method destroy takes nothing returns nothing
    |     destroy it
    |    
    | method flush takes nothing returns nothing
    |     flush all stored values inside of it
    |    
    | method remove takes integer key returns nothing
    |     remove the value at index "key"
    |    
    | method operator []= takes integer key, $TYPE$ value returns nothing
    |     assign "value" to index "key"
    |    
    | method operator [] takes integer key returns $TYPE$
    |     load the value at index "key"
    |    
    | method has takes integer key returns boolean
    |     whether or not the key was assigned
    |
    ----------------
    struct TableArray
    | static method operator [] takes integer array_size returns TableArray
    |     create a new array of Tables of size "array_size"
    |
    | method destroy takes nothing returns nothing
    |     destroy it
    |
    | method flush takes nothing returns nothing
    |     flush and destroy it
    |
    | method operator size takes nothing returns integer
    |     returns the size of the TableArray
    |
    | method operator [] takes integer key returns Table
    |     returns a Table accessible exclusively to index "key"
*/
    
globals
    private hashtable ht = InitHashtable() //The last hashtable you need
    private integer more = 2 //Index generation for Tables (above 2)
    private integer less = 0 //Index generation for TableArrays (below 0)
endglobals
    
private struct dex extends array
    static method operator size takes nothing returns Table
        return 1
    endmethod
    static method operator list takes nothing returns Table
        return 2
    endmethod
endstruct
    
private struct handles extends array
    method has takes integer key returns boolean
        return HaveSavedHandle(ht, this, key)
    endmethod
    method remove takes integer key returns nothing
        call RemoveSavedHandle(ht, this, key)
    endmethod
endstruct
    
private struct agents extends array
    method operator []= takes integer key, agent value returns nothing
        call SaveAgentHandle(ht, this, key, value)
    endmethod
endstruct
    
//! textmacro NEW_ARRAY_BASIC takes SUPER, FUNC, TYPE
private struct $TYPE$s extends array
    method operator [] takes integer key returns $TYPE$
        return Load$FUNC$(ht, this, key)
    endmethod
    method operator []= takes integer key, $TYPE$ value returns nothing
        call Save$FUNC$(ht, this, key, value)
    endmethod
    method has takes integer key returns boolean
        return HaveSaved$SUPER$(ht, this, key)
    endmethod
    method remove takes integer key returns nothing
        call RemoveSaved$SUPER$(ht, this, key)
    endmethod
endstruct
private module $TYPE$m
    method operator $TYPE$ takes nothing returns $TYPE$s
        return this
    endmethod
endmodule
//! endtextmacro
    
//! textmacro NEW_ARRAY takes FUNC, TYPE
private struct $TYPE$s extends array
    method operator [] takes integer key returns $TYPE$
        return Load$FUNC$Handle(ht, this, key)
    endmethod
    method operator []= takes integer key, $TYPE$ value returns nothing
        call Save$FUNC$Handle(ht, this, key, value)
    endmethod
endstruct
private module $TYPE$m
    method operator $TYPE$ takes nothing returns $TYPE$s
        return this
    endmethod
endmodule
//! endtextmacro
    
//! runtextmacro NEW_ARRAY_BASIC("Real", "Real", "real")
//! runtextmacro NEW_ARRAY_BASIC("Boolean", "Boolean", "boolean")
//! runtextmacro NEW_ARRAY_BASIC("String", "Str", "string")
    
//! runtextmacro NEW_ARRAY("Player", "player")
//! runtextmacro NEW_ARRAY("Widget", "widget")
//! runtextmacro NEW_ARRAY("Destructable", "destructable")
//! runtextmacro NEW_ARRAY("Item", "item")
//! runtextmacro NEW_ARRAY("Unit", "unit")
//! runtextmacro NEW_ARRAY("Ability", "ability")
//! runtextmacro NEW_ARRAY("Timer", "timer")
//! runtextmacro NEW_ARRAY("Trigger", "trigger")
//! runtextmacro NEW_ARRAY("TriggerCondition", "triggercondition")
//! runtextmacro NEW_ARRAY("TriggerAction", "triggeraction")
//! runtextmacro NEW_ARRAY("TriggerEvent", "event")
//! runtextmacro NEW_ARRAY("Force", "force")
//! runtextmacro NEW_ARRAY("Group", "group")
//! runtextmacro NEW_ARRAY("Location", "location")
//! runtextmacro NEW_ARRAY("Rect", "rect")
//! runtextmacro NEW_ARRAY("BooleanExpr", "boolexpr")
//! runtextmacro NEW_ARRAY("Sound", "sound")
//! runtextmacro NEW_ARRAY("Effect", "effect")
//! runtextmacro NEW_ARRAY("UnitPool", "unitpool")
//! runtextmacro NEW_ARRAY("ItemPool", "itempool")
//! runtextmacro NEW_ARRAY("Quest", "quest")
//! runtextmacro NEW_ARRAY("QuestItem", "questitem")
//! runtextmacro NEW_ARRAY("DefeatCondition", "defeatcondition")
//! runtextmacro NEW_ARRAY("TimerDialog", "timerdialog")
//! runtextmacro NEW_ARRAY("Leaderboard", "leaderboard")
//! runtextmacro NEW_ARRAY("Multiboard", "multiboard")
//! runtextmacro NEW_ARRAY("MultiboardItem", "multiboarditem")
//! runtextmacro NEW_ARRAY("Trackable", "trackable")
//! runtextmacro NEW_ARRAY("Dialog", "dialog")
//! runtextmacro NEW_ARRAY("Button", "button")
//! runtextmacro NEW_ARRAY("TextTag", "texttag")
//! runtextmacro NEW_ARRAY("Lightning", "lightning")
//! runtextmacro NEW_ARRAY("Image", "image")
//! runtextmacro NEW_ARRAY("Ubersplat", "ubersplat")
//! runtextmacro NEW_ARRAY("Region", "region")
//! runtextmacro NEW_ARRAY("FogState", "fogstate")
//! runtextmacro NEW_ARRAY("FogModifier", "fogmodifier")
//! runtextmacro NEW_ARRAY("Hashtable", "hashtable")
    
struct Table extends array
    
    // Implement modules for intuitive type-syntax
    implement realm
    implement booleanm
    implement stringm
    implement playerm
    implement widgetm
    implement destructablem
    implement itemm
    implement unitm
    implement abilitym
    implement timerm
    implement triggerm
    implement triggerconditionm
    implement triggeractionm
    implement eventm
    implement forcem
    implement groupm
    implement locationm
    implement rectm
    implement boolexprm
    implement soundm
    implement effectm
    implement unitpoolm
    implement itempoolm
    implement questm
    implement questitemm
    implement defeatconditionm
    implement timerdialogm
    implement leaderboardm
    implement multiboardm
    implement multiboarditemm
    implement trackablem
    implement dialogm
    implement buttonm
    implement texttagm
    implement lightningm
    implement imagem
    implement ubersplatm
    implement regionm
    implement fogstatem
    implement fogmodifierm
    implement hashtablem
    
    method operator handle takes nothing returns handles
        return this
    endmethod
    
    method operator agent takes nothing returns agents
        return this
    endmethod
    
    // set this = a[GetSpellAbilityId()]
    method operator [] takes integer key returns Table
        return LoadInteger(ht, this, key)
    endmethod
    
    // set a[389034] = 8192
    method operator []= takes integer key, Table a returns nothing
        call SaveInteger(ht, this, key, a)
    endmethod
    
    // set b = a.has(2493223)
    method has takes integer key returns boolean
        return HaveSavedInteger(ht, this, key)
    endmethod
    
    // call a.remove(294080)
    method remove takes integer key returns nothing
        call RemoveSavedInteger(ht, this, key)
    endmethod
    
    // Remove all data from a Table instance
    method flush takes nothing returns nothing
        call FlushChildHashtable(ht, this)
    endmethod
    
    // local Table a = Table.create()
    static method create takes nothing returns Table
        local Table this = dex.list[0]
        
        if this == 0 then
            set more = more + 1
            set this = more
        else
            set dex.list[0] = dex.list[this]
            call dex.list.remove(this)
        endif
        
        debug set dex.list[this] = -1
        return this
    endmethod
    
    // Removes all data from a Table instance and recycles its index.
    //
    //     call a.destroy()
    //
    method destroy takes nothing returns nothing
        debug if dex.list[this] != -1 then
            debug call BJDebugMsg("Table Error: Tried to double-free instance: " + I2S(this))
            debug return
        debug endif
        
        call this.flush()
        
        set dex.list[this] = dex.list[0]
        set dex.list[0] = this
    endmethod
    
endstruct
    
struct TableArray extends array
    
    //Returns a new TableArray to do your bidding. Simply use:
    //
    //    local TableArray ta = TableArray[array_size]
    //
    static method operator [] takes integer array_size returns TableArray
        local Table a = dex.size[array_size] //Get the unique recycle list for this array size
        local TableArray this = a[0]         //The last-destroyed TableArray that had this array size
        
        debug if array_size <= 0 then
            debug call BJDebugMsg("TypeError: Invalid specified TableArray size: " + I2S(array_size))
            debug return 0
        debug endif
        
        if this == 0 then
            set less = less - array_size
            set this = less
        else
            set a[0] = a[this]  //Set the last destroyed to the last-last destroyed
            call a.remove(this) //Clear hash memory
        endif
        
        set dex.size[this] = array_size //This remembers the array size
        return this
    endmethod
    
    //Returns the size of the TableArray
    method operator size takes nothing returns integer
        return dex.size[this]
    endmethod
    
    //da[integer a].unit[integer b] = unit u
    //da[integer a][integer c] = integer d
    //
    //Inline-friendly when not running in debug mode
    //
    method operator [] takes integer key returns Table
        static if DEBUG_MODE then
            local integer i = this.size
            if i == 0 then
                call BJDebugMsg("IndexError: Tried to get key from invalid TableArray instance: " + I2S(this))
                return 0
            elseif key < 0 or key >= i then
                call BJDebugMsg("IndexError: Tried to get key [" + I2S(key) + "] from outside TableArray bounds: " + I2S(i))
                return 0
            endif
        endif
        return this + key
    endmethod
    
    //Destroys a TableArray without flushing it; assumed you'd call .flush()
    //if you want it flushed too. This is public so that if you are flushing
    //instances the whole time you don't waste efficiency when disposing the
    //TableArray.
    //
    method destroy takes nothing returns nothing
        local Table a = dex.size[this.size]
        
        debug if this.size <= 0 then
            debug call BJDebugMsg("TypeError: Tried to destroy an invalid TableArray: " + I2S(this))
            debug return
        debug endif
        
        if a == 0 then
            //Create an array to index recycled instances with their array size
            set a = Table.create()
            set dex.size[this.size] = a
        endif
        
        call dex.size.remove(this) //Clear the array size from hash memory
        
        set a[this] = a[0]
        set a[0] = this
    endmethod
    
    //All you need to know about this one is that it won't hit the op limit.
    private static method clean takes Table a, integer end returns nothing
        local integer i = a + 5000
        if i < end then
            call clean.evaluate(i, end)
            set end = i
        endif
        loop
            call a.flush()
            set a = a + 1
            exitwhen a == end
        endloop
    endmethod
    
    //Flushes the TableArray and also destroys it. Doesn't get any more
    //similar to the FlushParentHashtable native than this.
    //
    method flush takes nothing returns nothing
        local integer end = this.size + this
        debug if this == end then
            debug call BJDebugMsg("TypeError: Tried to flush an invalid TableArray instance: " + I2S(this))
            debug return
        debug endif
        call clean.evaluate(this, end)
        call this.destroy()
    endmethod
    
endstruct
    
endlibrary

i used them for item drop systems.. hope anyone would help me

 

[Anachron]

Maybe rename it?
I suggest rename the version from Bribe since I used Table by Vexorian in 1000 places.

 

[TwoVenomous]

Maybe rename it?
I suggest rename the version from Bribe since I used Table by Vexorian in 1000 places.

where and how should i rename it?

tried to rename the trigger

• Table Bribe

it's still showing the same error

tried renamed the library name

library Table Bribe

still not working

i got this compile error error

Error 1

line xxxx: not a valid library declaration: [Bribe]?

library BribeTable

library TableBribe

library Tables

i got this

Error 2

line xxxx: missing requirement : Table (libraries cannot contain scopes)

 

[Anachron]

Sorry but seriously, think about it before doing.
You have a struct Table. The trigger name does not matter.
When you change the struct name (which you have to) you have to check the other libraries and wherever you read Table you have to change it to the new table name.

So instead of

 library xyz requires Table

you have

 library xyz requires BribeTable

But don't do this with my libraries.

 

[TwoVenomous]

Sorry but seriously, think about it before doing.
You have a struct Table. The trigger name does not matter.
When you change the struct name (which you have to) you have to check the other libraries and wherever you read Table you have to change it to the new table name.

So instead of

 library xyz requires Table

you have

 library xyz requires BribeTable

But don't do this with my libraries.

thanks, it worked and i learned something new
+rep

 

[Anachron]

You are welcome.
I hope you enjoy my Inventory System.

 

[baassee]

Or you use the Table BC library so it works for both Vex and Bribe versions ^^

 

[Almia]

Anachron,
can send me the codes? that of shadowvs' is a madness.

 

[Anachron]

What codes do you need? Everything is inside the map.

 

[Almia]

Well,i dont like to open the map and read the codes.
That's how lazy i am

 

[Anachron]

You know that this map uses about 46 libraries?
If you are too lazy to open it, it's not for you

 

[Almia]

Then im going to open it XD

 

[DiggetyBo]

Hey man, first off props for this system, it's so versatile. Very well scripted too, I'm so bad at vjass, but your system inspired me to get back into it. I'm literally doing backflips for being able to use it.

I got everything imported successfully, no problems there. However, I was hoping you could point me the right direction quick. I want the inventory to be constructed at the start location for each player. I have it so each players start location is at an empty part of the map where there is room for the construction of the inventory destructibles. Technically all I have to do is define the 'point' right? After that each player inventory will correspond to that players hero, right? I don't really have to edit anything futher, its already mui from what I can tell. I was looking in the CISetup trigger and tried the following:

rect CI_UI_RECT = GetPlayerStartLocation(Player(i))

It says error, undeclared variable. I guess I don't remember much about vjass.

Am I in the right place? And sorry if you already answered a question like this, but I double checked all your notes and almost every page on this forum.

Also I wanted to ask if it was possible to directly add stats to items that are mathematical expressions, not just values, i.e.
(This is from the "Test" trigger)


set ci.dmg = 2*GetHeroLevel(hero)

or maybe something like

set ci.dmg = native GetRandomReal takes real 20., real 50. returns real

Would the ability libraries ect. handle these expressions properly and add the right amount of damage as is? If not would there be an easy tweak somewhere to adjust things properly, or are these things too unpractical? So far I haven't figured this out yet either.

Hopefully after a little hint my intuition will kick in haha. Thanks a bunch.

 

[ZhengHe]

Sorry but seriously, think about it before doing.
You have a struct Table. The trigger name does not matter.
When you change the struct name (which you have to) you have to check the other libraries and wherever you read Table you have to change it to the new table name.

So instead of

 library xyz requires Table

you have

 library xyz requires BribeTable

But don't do this with my libraries.

Can you explain more clearly, i have change name of Bribe Table struct and got an error

Line xxxx: method create must return BribeTable

    static method create takes nothing returns Table