Random Spell Pack v1.4

[Moderator]

23:11, 16th Jun 2010
Hanky:
Looks good even if I don't like the indexing system. But well, approved!

 

[Deuterium]

Well, I only checked spells and not triggering...

Crystal is definetly creative... yet I see you Pause the target... well I don't like that cause it clears the Unit's panel... but it's really no big deal.

Other three spells... not original... I mean, I think Rmx already made the Seazure and Fireball ones, or something commong at least... and Ball Lightning also has been already done.

Btw, couldn't you find a better name for spell pack? I mean, the only time Random sounded creative to me was when it was used by Deadmau5 to call his album: Random Album Title

Other than that, the skim through triggers shows you're doing good with spell making

Keep it up... and actually, start learning vJass

 

[MortAr]

Hm, damn good.

Review

Idea/Originality/Creativity: 9/10
Triggering/Coding: 10/10
Discription/Tooltips: 9/10
Eye Candy/SFX: 9/10
MUI: +5

Overall: 42 = Recommended.

-10/45 = FAIL
-20/45 = Lacking
-30/45 = Acceptable
-40/45 = Recommended
-45 = Highly Recommended

At all, I've sum suggestions:
You can make the big-fireball to move just the the tiny ones when its explodes, it will better
The both fireball and the lightningball height is a bit too much, reducing it might be good.

That's all, and of course, 5/5 rate.

 

[NFWar]

Deuterium, I looked at your comment, so:
-Yes you are right, pausing units dont must be used so much.
I can stun target too instead of pause. I think Like that I will do at next update.
-Ofcorse theare many spells at hive. It is my first Spell Pack and I started from "easy"
just like RMX sugest me/
-Better name... huh... uhum... ghuh... I dont know much words
Gona use a book

 

[Deuterium]

The thing is... "easy" could be creative you know... I mean, check my spell-pack, they're all easy spells... yet almost none has been done before.

There are alot of ideas which you could do that no one have done before...

 

[baassee]

blah pause here pause there, doesnt matter really but seed got some good points as always, and I dont dare to review lawl

 

[Deuterium]

and I dont dare to review lawl

Hehehe

 

[NFWar]

WARNING:
Spell Fireball cause map to lag
I am working on that but fail to fix it for now.

Not anymore. I have fixed that. Look Comments lower.

 

[Deuterium]

Humm? Point out where the leak is... maybe someone can help.

 

[NFWar]

Humm? Point out where the leak is... maybe someone can help.

I have spend 8 hours to fix it but fail.
cant fing what is wrong. Had rebuilded spell 2 times.
I dont even know what leak...

 

[Deuterium]

If you don't know what leaks... how could you know it leaks in the first place!? :s

PLEASE don't tell me you're using stupid leak checker? Because that doesn't function quietly well as far as I know...

 

[NFWar]

If you don't know what leaks... how could you know it leaks in the first place!? :s

PLEASE don't tell me you're using stupid leak checker? Because that doesn't function quietly well as far as I know...

After casting 1,2,3 spell a lot of times (kiled all units with 1st, 2nd...)
map dont lag. After using Fireball 10 times I saw small lag...
Caster a lot of times Fireball - mega lag at map.

 

[Deuterium]

That doesn't mean it leaks it could mean alot of things... why don't you post your triggers here so that people can see it without downloading the map or using WE?

 

[NFWar]

Here is seting trigger:

Seting Trigger

• Fire Ball Setings
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Fireball
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • FB_Skip Equal to 0
      • Then - Actions
        • Trigger - Turn on Fire Ball Loop <gen>
      • Else - Actions
    • Set FB_Skip = (FB_Skip + 1)
    • Set FB_Times = (FB_Times + 1)
    • Set FB_Off[FB_Times] = True
    • -------- ---------------------------------------------------------------------------------------------------------------------------------------------------------- --------
    • -------- I have set 1 more boolean variable. It check if missile is "big" or "small". "Big" are fireballs what Hero make. "Small" are fragments. So by cheking this boolean variable actions for "small" and "big" missiles will be not same. --------
    • -------- Fireball mooving an same height and impact on enemys. Fragments move with parabola and cause small AoE damage --------
    • -------- ---------------------------------------------------------------------------------------------------------------------------------------------------------- --------
    • Set FB_Big[FB_Times] = True
    • -------- ---------------------------------------------------------------------------------------------------------------------------------------------------------- --------
    • Set FB_Hero[FB_Times] = (Casting unit)
    • Set FB_Point[0] = (Position of (Casting unit))
    • Set FB_Point[1] = (Target point of ability being cast)
    • -------- ---------------------------------------------------------------------------------------------------------------------------------------------------------- --------
    • -------- Lets set angle, damage, distance, speed, AoE etc. --------
    • -------- ---------------------------------------------------------------------------------------------------------------------------------------------------------- --------
    • Set FB_Angle[FB_Times] = (Angle from FB_Point[0] to FB_Point[1])
    • Set FB_Distance[FB_Times] = 800.00
    • Set FB_Speed[FB_Times] = 15.00
    • -------- ---------------------------------------------------------------------------------------------------------------------------------------------------------- --------
    • Set FB_Damage[FB_Times] = (60.00 + (60.00 x (Real((Level of Fireball for (Casting unit))))))
    • Set FB_AoE[FB_Times] = 250.00
    • Set FB_Colision[FB_Times] = (50.00 + (20.00 x (Real((Level of Fireball for (Casting unit))))))
    • Set FB_Fragments[FB_Times] = (2 + (1 x (Level of Fireball for (Casting unit))))
    • -------- ---------------------------------------------------------------------------------------------------------------------------------------------------------- --------
    • -------- Set scaling of dummy. Biger damage - biger dummy :) --------
    • -------- ---------------------------------------------------------------------------------------------------------------------------------------------------------- --------
    • Set FB_Scale = (90.00 + (10.00 x (Real((Level of Fireball for (Casting unit))))))
    • Unit - Create 1 Dummy for (Owner of FB_Hero[FB_Times]) at FB_Point[0] facing FB_Angle[FB_Times] degrees
    • Set FB_Missile[FB_Times] = (Last created unit)
    • Animation - Change FB_Missile[FB_Times] flying height to 40.00 at 0.00
    • Animation - Change FB_Missile[FB_Times]'s size to (FB_Scale%, FB_Scale%, FB_Scale%) of its original size
    • -------- ---------------------------------------------------------------------------------------------------------------------------------------------------------- --------
    • -------- Just with 1 special effect dummy dont looks good. Lets create 2 effects :) --------
    • -------- ---------------------------------------------------------------------------------------------------------------------------------------------------------- --------
    • Special Effect - Create a special effect attached to the chest of FB_Missile[FB_Times] using Abilities\Weapons\RedDragonBreath\RedDragonMissile.mdl
    • Special Effect - Create a special effect attached to the chest of FB_Missile[FB_Times] using Abilities\Weapons\FireBallMissile\FireBallMissile.mdl
    • Custom script: call RemoveLocation ( udg_FB_Point[0] )
    • Custom script: call RemoveLocation ( udg_FB_Point[1] )

Here is Loop Trigger:

Loop Trigger

• Fire Ball Loop
  • Events
    • Time - Every 0.02 seconds of game time
  • Conditions
  • Actions
    • -------- ---------------------------------------------------------------------------------------------------------------------------------------------------------- --------
    • -------- Every FB_Times become FB --------
    • -------- ---------------------------------------------------------------------------------------------------------------------------------------------------------- --------
    • For each (Integer FB) from 1 to FB_Times, do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • FB_Off[FB] Equal to True
          • Then - Actions
            • Set FB_Point[2] = (Position of FB_Missile[FB])
            • Set FB_Point[3] = (FB_Point[2] offset by FB_Speed[FB] towards FB_Angle[FB] degrees)
            • Unit - Move FB_Missile[FB] instantly to FB_Point[3]
            • -------- ---------------------------------------------------------------------------------------------------------------------------------------------------------- --------
            • -------- Distance is descreased by speed every time when missile move. --------
            • -------- ---------------------------------------------------------------------------------------------------------------------------------------------------------- --------
            • Set FB_Distance[FB] = (FB_Distance[FB] - FB_Speed[FB])
            • -------- ---------------------------------------------------------------------------------------------------------------------------------------------------------- --------
            • -------- Below is condition which check if missile is "big" or "small". --------
            • -------- ---------------------------------------------------------------------------------------------------------------------------------------------------------- --------
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • FB_Big[FB] Equal to True
              • Then - Actions
                • -------- ---------------------------------------------------------------------------------------------------------------------------------------------------------- --------
                • -------- If it is, then actions for fireball will be runing --------
                • -------- ---------------------------------------------------------------------------------------------------------------------------------------------------------- --------
                • Set FB_Group[FB] = (Units within FB_Colision[FB] of FB_Point[3] matching (((((Matching unit) is Magic Immune) Equal to False) and (((Matching unit) is A structure) Equal to False)) and (((((Matching unit) is A flying unit) Equal to False) and (((Matching unit) is dead) Equal to
                • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                  • If - Conditions
                    • (Number of units in FB_Group[FB]) Greater than 0
                  • Then - Actions
                    • -------- ---------------------------------------------------------------------------------------------------------------------------------------------------------- --------
                    • -------- Fireball just tuch something, Lets create Explosion! :D --------
                    • -------- ---------------------------------------------------------------------------------------------------------------------------------------------------------- --------
                    • Special Effect - Create a special effect at FB_Point[3] using Objects\Spawnmodels\Other\NeutralBuildingExplosion\NeutralBuildingExplosion.mdl
                    • Special Effect - Destroy (Last created special effect)
                    • -------- ---------------------------------------------------------------------------------------------------------------------------------------------------------- --------
                    • -------- Group will be destroyed and set again, because uther units theare will be damaged --------
                    • -------- ---------------------------------------------------------------------------------------------------------------------------------------------------------- --------
                    • Custom script: call DestroyGroup ( udg_FB_Group[udg_FB] )
                    • Set FB_Group[FB] = (Units within FB_AoE[FB] of FB_Point[3] matching (((((Matching unit) is Magic Immune) Equal to False) and (((Matching unit) is A structure) Equal to False)) and (((((Matching unit) is A flying unit) Equal to False) and (((Matching unit) is dead) Equal to Fals
                    • Unit Group - Pick every unit in FB_Group[FB] and do (Actions)
                      • Loop - Actions
                        • Unit - Cause FB_Hero[FB] to damage (Picked unit), dealing FB_Damage[FB] damage of attack type Spells and damage type Fire
                    • Custom script: call DestroyGroup ( udg_FB_Group[udg_FB] )
                    • -------- ---------------------------------------------------------------------------------------------------------------------------------------------------------- --------
                    • -------- Distance being 0 because fireball impact on unit and will not move anymore --------
                    • -------- ---------------------------------------------------------------------------------------------------------------------------------------------------------- --------
                    • Set FB_Distance[FB] = 0.00
                    • Set FB_Point[4] = (Position of FB_Missile[FB])
                    • -------- ---------------------------------------------------------------------------------------------------------------------------------------------------------- --------
                    • -------- Here it is. Below is loop which set up fragments. --------
                    • -------- ---------------------------------------------------------------------------------------------------------------------------------------------------------- --------
                    • For each (Integer A) from 1 to FB_Fragments[FB], do (Actions)
                      • Loop - Actions
                        • Set FB_Skip = (FB_Skip + 1)
                        • Set FB_Times = (FB_Times + 1)
                        • Set FB_Off[FB_Times] = True
                        • -------- ---------------------------------------------------------------------------------------------------------------------------------------------------------- --------
                        • -------- FB_Big will be false because it is just small fragment :P --------
                        • -------- ---------------------------------------------------------------------------------------------------------------------------------------------------------- --------
                        • Set FB_Big[FB_Times] = False
                        • -------- ---------------------------------------------------------------------------------------------------------------------------------------------------------- --------
                        • Set FB_Hero[FB_Times] = FB_Hero[FB]
                        • -------- ---------------------------------------------------------------------------------------------------------------------------------------------------------- --------
                        • -------- MaxDistance and height are needed for parabola calculation --------
                        • -------- ---------------------------------------------------------------------------------------------------------------------------------------------------------- --------
                        • Set FB_Angle[FB_Times] = (FB_Angle[FB] + (Random real number between -60.00 and 60.00))
                        • Set FB_Distance[FB_Times] = (Random real number between 200.00 and 400.00)
                        • Set FB_MaxDistance[FB_Times] = FB_Distance[FB_Times]
                        • Set FB_Speed[FB_Times] = (FB_MaxDistance[FB_Times] x 0.02)
                        • Set FB_Height[FB_Times] = (Random real number between 100.00 and 200.00)
                        • -------- ---------------------------------------------------------------------------------------------------------------------------------------------------------- --------
                        • -------- Fragments will deal 4 times leaser damage. Reduce IT! :) --------
                        • -------- ---------------------------------------------------------------------------------------------------------------------------------------------------------- --------
                        • Set FB_Damage[FB_Times] = (FB_Damage[FB] / 4.00)
                        • Set FB_AoE[FB_Times] = 150.00
                        • -------- ---------------------------------------------------------------------------------------------------------------------------------------------------------- --------
                        • -------- Scale is half (50 %), but you can change it. --------
                        • -------- ---------------------------------------------------------------------------------------------------------------------------------------------------------- --------
                        • Set FB_Scale = 50.00
                        • Unit - Create 1 Dummy for (Owner of FB_Hero[FB_Times]) at FB_Point[4] facing FB_Angle[FB_Times] degrees
                        • Set FB_Missile[FB_Times] = (Last created unit)
                        • Animation - Change FB_Missile[FB_Times]'s size to (FB_Scale%, FB_Scale%, FB_Scale%) of its original size
                        • Special Effect - Create a special effect attached to the chest of FB_Missile[FB_Times] using Abilities\Weapons\RedDragonBreath\RedDragonMissile.mdl
                    • -------- ---------------------------------------------------------------------------------------------------------------------------------------------------------- --------
                    • -------- Upper loop action used just 1 point. Remove to do not cause leaks --------
                    • -------- ---------------------------------------------------------------------------------------------------------------------------------------------------------- --------
                    • Custom script: call RemoveLocation ( udg_FB_Point[4] )
                  • Else - Actions
              • Else - Actions
                • -------- ---------------------------------------------------------------------------------------------------------------------------------------------------------- --------
                • -------- This actions will be done if Missile is not "Big", it is fragment height changed to parabola variable to give a look of arc --------
                • -------- ---------------------------------------------------------------------------------------------------------------------------------------------------------- --------
                • Set FB_Parabola[FB] = (((4.00 x FB_Height[FB]) / FB_MaxDistance[FB]) x ((FB_MaxDistance[FB] - FB_Distance[FB]) x (FB_Distance[FB] / FB_MaxDistance[FB])))
                • Animation - Change FB_Missile[FB] flying height to FB_Parabola[FB] at 0.00
            • -------- ---------------------------------------------------------------------------------------------------------------------------------------------------------- --------
            • -------- Distance is 0, then missile killed --------
            • -------- ---------------------------------------------------------------------------------------------------------------------------------------------------------- --------
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • FB_Distance[FB] Less than or equal to 0.00
              • Then - Actions
                • -------- ---------------------------------------------------------------------------------------------------------------------------------------------------------- --------
                • -------- W8! Not all missiles diying at same way! Fragments deal damage when diying! :) --------
                • -------- ---------------------------------------------------------------------------------------------------------------------------------------------------------- --------
                • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                  • If - Conditions
                    • FB_Big[FB] Equal to False
                  • Then - Actions
                    • Set FB_Group[FB] = (Units within FB_AoE[FB] of FB_Point[3] matching (((((Matching unit) is Magic Immune) Equal to False) and (((Matching unit) is A structure) Equal to False)) and (((((Matching unit) is A flying unit) Equal to False) and (((Matching unit) is dead) Equal to Fals
                    • Unit Group - Pick every unit in FB_Group[FB] and do (Actions)
                      • Loop - Actions
                        • Unit - Cause FB_Hero[FB] to damage (Picked unit), dealing FB_Damage[FB] damage of attack type Spells and damage type Fire
                    • Custom script: call DestroyGroup ( udg_FB_Group[udg_FB] )
                    • -------- ---------------------------------------------------------------------------------------------------------------------------------------------------------- --------
                    • -------- Special effect for eyecandy and sound of effect destroyed --------
                    • -------- ---------------------------------------------------------------------------------------------------------------------------------------------------------- --------
                    • Special Effect - Create a special effect at FB_Point[3] using Abilities\Weapons\RedDragonBreath\RedDragonMissile.mdl
                    • Special Effect - Destroy (Last created special effect)
                  • Else - Actions
                • -------- ---------------------------------------------------------------------------------------------------------------------------------------------------------- --------
                • -------- Finaly kill missile! :P --------
                • -------- ---------------------------------------------------------------------------------------------------------------------------------------------------------- --------
                • Unit - Kill FB_Missile[FB]
                • -------- ---------------------------------------------------------------------------------------------------------------------------------------------------------- --------
                • -------- FB_Skip reduced by 1, because it check if some spells are runing --------
                • -------- ---------------------------------------------------------------------------------------------------------------------------------------------------------- --------
                • Set FB_Skip = (FB_Skip - 1)
                • Set FB_Off[FB] = False
                • -------- ---------------------------------------------------------------------------------------------------------------------------------------------------------- --------
                • -------- If FB_Skip is 0, then no spells are exist. Loop shud repeat 0 times (FB_Times set to 0 too) and turn trigger off. Dont need trigger to run when no spells are runing :P --------
                • -------- ---------------------------------------------------------------------------------------------------------------------------------------------------------- --------
                • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                  • If - Conditions
                    • FB_Skip Equal to 0
                  • Then - Actions
                    • Set FB_Times = 0
                    • Trigger - Turn off (This trigger)
                  • Else - Actions
              • Else - Actions
            • -------- ---------------------------------------------------------------------------------------------------------------------------------------------------------- --------
            • -------- Almost forgot ^^ Clear leaks ^^ --------
            • -------- ---------------------------------------------------------------------------------------------------------------------------------------------------------- --------
            • Custom script: call RemoveLocation ( udg_FB_Point[2] )
            • Custom script: call RemoveLocation ( udg_FB_Point[3] )
          • Else - Actions

I dont found any leak but spell still leak.

 

[Deuterium]

Oh man you should have done that a long time ago!

Here it is:

• Special Effect - Create a special effect attached to the chest of FB_Missile[FB_Times] using Abilities\Weapons\RedDragonBreath\RedDragonMissile.mdl
• Special Effect - Create a special effect attached to the chest of FB_Missile[FB_Times] using Abilities\Weapons\FireBallMissile\FireBallMissile.mdl

You don't only need to remove the unit you attach the effects too... but store the effects into variables and destroy them too.

Effects are the things that cause the most lag if not destroyed (that's an educated guess, I might be wrong)...

 

[NFWar]

Oh man you should have done that a long time ago!

Here it is:

• Special Effect - Create a special effect attached to the chest of FB_Missile[FB_Times] using Abilities\Weapons\RedDragonBreath\RedDragonMissile.mdl
• Special Effect - Create a special effect attached to the chest of FB_Missile[FB_Times] using Abilities\Weapons\FireBallMissile\FireBallMissile.mdl

You don't only need to remove the unit you attach the effects too... but store the effects into variables and destroy them too.

Effects are the things that cause the most lag if not destroyed (that's an educated guess, I might be wrong)...

I think you are wrong, Ball Lighting have 3 effects at Dummy chest.
I killed all units at map just with ball Lighting ability and still no lag.
I even reduce damage to cast it more times.

Realy, gona try your sugestion, but i think it is wrong...

EDIT: Lag remain so leak still too
Effects attached to dummy destroys automaticaly when dummy dies

 

[Deuterium]

Man, leak and lag are two whole different things!

Effects attached to dummy destroys automaticaly when dummy dies

No they don't...

There's nothing in Warcraft that "destroys automatically" unless you're using some advance GUI system...

 

[NFWar]

Man, leak and lag are two whole different things!


No they don't...

There's nothing in Warcraft that "destroys automatically" unless you're using some advance GUI system...

If you have effect leaks, indead you will lag

I found what problem is... it is not effects on dummy
It is spell data
Fireball spell made from shockwave.
Ball Lighting is base of Fireball but it is made from Carrion Swarm.
I make to Hero create Fireball when using Ball Lighting.
Killed all units at map - no lag. Then it is no effect leaks.
Changed to Fireball... it is lag again.
It means without any doubt what Shockwave do something and cause lag
I have no uther pheory

 

[Deuterium]

Why don't you use "Channel" as the dummy ability? It is the simplest and best to use and fully adjustable... just make sure to pick the "Visible" option as you're editing the ability object...

 

[NFWar]

I have changed dummy ability for Fireball. It works and dont lag after many casts.
Seems like Shockwave is not good for dummy ability.
Updated!.


Not so soon coming new spell pack!
Explosive Spell Pack v1.0

Spell Pack allready got 2 spells:
-Jumping Bomb
-Sticky Bomb
And 1 popular system:
-Knockback

NOTE: Explosive spell pack is released with just 2 spells.
So it is not spell pack anymore but just 2 spells

 

[Deuterium]

Well glad to know it works fine now =)

 

[Rmx]

The Spellpack is lovely, so far no leaks was found.

Review -

Fire Ball --- Simple and not so creative, but for my taste it was simply lovely.

Teleknetic s... --- I did 2 spells with same thing ext... but your spell is just faster, doesn't leak and somehow lovely

Cryst.. --- The most creative spell in your spellpack love it

Ball of lightning --- Like fire ball comment

Overall -- 3.5/5

Great spellpack .. you are way WAY way better than before ... keep up the good work

 

[NFWar]

I am fully agree with review.
Some spells are not new (like FireBall)
I dont even know what you have made Telekinatik seazure before^^
Deuterium says me what RMX made something like that...

 

[Freeze87]

Very nice spell pack +rep

 

[Dr Super Good]

The documentation is totally usless when it comes to importing the map with no prior experience. A member called WorldEdit tried to use this spell in his map and had no clue where to begin. Especially since you use an imported custom model for the dummy unit and no not mention to the potential users that the spell requires a dummy with that imported model.

Action annotation is ample and I am not complaining about that, but honestly the import documentation is non existant so I have no clue how you expect people with no prior importing experience to use it.

 

[aider]

WOW, every spell in this spell pack fits to my map, thanks alot for making this! GJ.
But is the Fireball lag thing fixed? Will the map still lagg alot if you have casted alot of fireballs?

 

[aider]

And another thing..

What IS this? Most of the spells I copy to my map is GUI etc. So I see alot of errors, and is able to see whats missing and fix it. But these errors, I just can't figure out. Anyone else got them?

EDIT: It looks like its the Shield Bash triggers that cause the whole thing, but still can't figure it out .__.

 

[aider]

No one else get errors when copying Shield Bash?

 

[Zpider]

I had no problems whatsoever with Shield Bash, you must be doing something wrong.

 

[CoLd Bon3]

This is pretty good! )

 

[Hazop / Sarven]

HOW DO I get dee Fireball in my ting, I dont want it to be a hero ability,

 

[KILLCIDE]

Go to the object editor ability and set Hero Ability to false.

 

[Hazop / Sarven]

Go to the object editor ability and set Hero Ability to false.

Ik spell still isn't working

 

[KILLCIDE]

No idea what you mean by that.

 

[Hazop / Sarven]

No idea what you mean by that.

I know how to make it a unit instead of hero ability, but the spell dosent work regardless

 

[KILLCIDE]

"Spell doesnt work" isn't very helpful. You should specify what about it doesnt work and possibly posting the test map.

 

[Hazop / Sarven]

"Spell doesnt work" isn't very helpful. You should specify what about it doesnt work and possibly posting the test map.

IT WORKZ! I just forgot the Dummy unit

(Edit) How do I edit damage

 

[Ricola3D]

Telekinesis is amazing ! I also personnaly like Crystalisation. Good job pal !

 

[ShadowMidas]

Best Spellpack ever!