Fireform v1.4

[Moderator]

Submission: Fireform v1.3 Date: 12.07.2015 Status: Approved Rating: 3/5 Review Link Moderator: IcemanBo

Older

Fireform 1.2 | Reviewed by BPower | 13.06.2015 [COLOR="gray" [COLOR="gray" [COLOR="gray" [COLOR="gray" [COLOR="gray" Concept[/COLOR]] Morphs the casting units into flames, while moving him from A to B. In general a very simple concept, which reminds me of Waveform from Dota. While moving the caster still stays vulnerable to enemies. Optional checking for close trees is a fitting addition to the concept of the spell. Code[/COLOR]] The spell is MUI, leakless and seems to work. Destroying tree is an optional toogle by setup, but you always do it within the loop. Your code structure is not perfect, as you would also move a dead caster for one tick. Your velocity ( speed[level]*0.03 ) could be calculated during the cast event. Wc3 doesn't determine between damage type fire and magic. It's all damage type magic. Objects[/COLOR]] Tooltips and object data is ok. The tree destroyer dummy should use invulnerability for safety reasons. Effects[/COLOR]] The effect is simple, but fits to the spell It's quite fun to cast. Rating[/COLOR]] CONCEPT CODE OBJECTS EFFECTS RATING STATUS 3/5 2.5/5 4/5 2.5/5 3/5 NEED FIX

old

14:41, 22nd Apr 2015
IcemanBo: http://www.hiveworkshop.com/forums/spells-569/fireform-v1-1-a-264834/#post2677752

 

[Kazeon]

Kinda overpowered. How about every unit only get damaged once per wave.

But you got nice solid effect here.

 

[Rheiko]

Not overpowered actually, I forgot to add some lines of trigger for the units to get damaged once per wave. xD

I'm thinking of replacing hide with invisibility because the caster's vision is gone whenever hide trigger is in effect.

I will update it soon, I guess.

------------------
Edit: UPDATED

 

[ILH]

This one looked like my blink spell

Anyways, your spell has a pretty simple concept, what about adding more effects like "stun", "burn" or something? Might be useful, tho.

 

[Rheiko]

I just made this out of boredom since I can't finish my other spell. Might be adding burn effect in the next version though. Thanks, ILH.

 

[Daffa]

Great job!

Here are some useful suggestions :
Make animation configurable.
Make vertex coloring configurable.
Perhaps make loop configurable, in case 0.03 is too heavy for some. But I highly doubt that.
Optionally, you give players a state reference for morphing, especially when it starts or ends. But that would rather make this a system, and that's overkill I think.

 

[IcemanBo]

• Create your own dummy unit instead of using the default peasant.
• Directly deindex an instance if caster is dead.
• GUI array variables are initialisized for index 0 and 1. So afaik this leaks:
  

  Custom script: set udg_FF_DamagedUnits[udg_FF_Max_Index] = CreateGroup()

  ... when the index equals 1 in your case.
• The speed calculation could be done once onInit.
  You can do it for example in a unconfigurable part.
• The effect should be configurable.
• Attack- Damage type should be configurable.

Spell is simple, but looks cool.

 

[Rheiko]

Darn it, I missed simple things. Thanks Bo.

 

[Rheiko]

... GUI array variables are initialisized for index 0 and 1. So afaik this leaks: ...

I destroy the variable in the de-index part. Does it still leak?

The speed calculation could be done once onInit.
You can do it for example in a unconfigurable part.

but I gotta make the speed configurable according the level of ability which i don't think it can be done OnInit, can it?

------------------
UPDATED

 

[Elprede]

Group[0] and Group[1] are created once you create the array, so when you create groups for these indexes, you leak the previous groups.

 

[Daffa]

Cmiiw, But the leak occurs only once, which shouldn't be a big deal.
And fixing them would be quite tedious. At that rate it should go to Unit Indexer or Hashtables instead.

 

[Rheiko]

Group[0] and Group[1] are created once you create the array, so when you create groups for these indexes, you leak these groups.

I see. Mind telling me how to prevent the leak?

 

[Elprede]

Check whether groups are null before creating them.

You can cache Speed * 0.03 onCast.

 

[IcemanBo]

Don't make any checks/actions in loop other than deindex if caster is dead and/or spell should finish.

 

[Rheiko]

IcemanBo, I actually don't get it, which checks/actions?

 

[IcemanBo]

Heyho, sorry for late reply.

I meant there are some operations done, even caster is dead for example, and so should be instantly deindexed.

As SetUnitX/Y is used, casting units may get to unwated locations.
For example deep water, or out of map.

group[0] and group[1] are automatically initialisized for gui variables.

 

[Rheiko]

UPDATED
------------------

I hope I have fixed them all correctly. Though I don't really know how to prevent a dead caster from moving for one tick.

 

[IcemanBo]

If you move the If/Then/Else for deindexing on top of the loop, the instance won't do any operations anymore.

 

[Ofel]

Cool. From me, maybe you should lengthen the prefix. It can collide with spells like Fury Fire, Fading Feeling (lol), and so on.

 

[Rheiko]

Updated it once more, but i won't consider it an update. Just a fix, thanks to IcemanBo

Ofel
nah, let them do it themselves. :b

 

[IcemanBo]

• Set FF_ReachedDist[FF_Current_Index] = (FF_ReachedDist[FF_Current_Index] + (FF_Speed[FF_Level[FF_Current_Index]] x 0.03))

^Here the velocity variable could be used.

The velocity is not being deindexed properly.

Basicly you don't have to "null" primitive types like integer/reals. They won't leak.
The only one that would make sense I can see is the "ReachedDistance[index]",
because you want to reset it before next instance will use it. But also for this I would
personaly would feel better if you would set it to 0 onIndex, and not onDeindex, as it's like a better place to "prepare" an instance.

 

[Rheiko]

Fixed
----------

 

[IcemanBo]

Hello.

Note in import instructions to copy the dummy unit.

-------- The range of your ability -------- Set FF_Speed[1] = 1250.00 Set FF_Speed[2] = 1250.00 Set FF_Speed[3] = 1250.00

^This is actually not true. It is not the range of the ability, but only the speed.

The distance is actually this:

Set FF_Distance[FF_Max_Index] = (Distance between TempPoint and TempPoint2)

^So the point where you cast only matters for distance.

You can make the distance now configurable, as well, then you need an other array,
or you let it with going forward explicitly to casting point, but the documentation but be changed that it's only speed.

Beside that it is approveable and I will instantly do on update.
If you make more changes please quickly say it, then I will need to check demo again.

 

[Rheiko]

^This is actually not true. It is not the range of the ability, but only the speed.

Ah, it's because I deleted the range that I forgot to correct that instruction.

You can make the distance now configurable, as well, then you need an other array,
or you let it with going forward explicitly to casting point

I'll just let it with going forward explicitly to casting point.

I'll update it soon enough.

------------
UPDATED

 

[IcemanBo]

Hello. Note in import instructions to copy the dummy unit.

^Please, this. You have import instructions here in thread, so you can do this without updating the submission.

Concept is clear, simlple, but not unique.
Code works fine, it's leakess and MUI.
Effect is a simple periodical creation at unit's position.
It's nothing special or fancy, but looks good and is sufficient for the also simple concept.

I don't see anything wrong no more in code. Make the change mentioned above.

3/5
Approved

 

[Ofel]

Finally approved.
Congrat, pal.

 

[Daffa]

Yay! About time it got approved
Congrats Rheiko!

 

[Rheiko]

Thankies.

 

[SteakMediumRare]

hot

hot.

 

[Rheiko]

Thank you.

 

[Aleister]

Useful!

 

[Acolite333]

Sorry to Necro this thread, but I was just wondering if I could get some advice on why this isn't working in my map. All I did was copy and paste the triggers and variables, ability, and dummy unit as is into my map but for whatever reason it doesn't seem to work in my map... I don't know what I'm doing wrong.

 

[Bribe]

I suggest posting on the triggers and scripts forum or World Editor Help Zone as there will likely be a long turnaround time on this thread to await a response.

 

[Pyrogasm]

You need to be more specific about what "isn't working". Are you sure all the appropriate variables were created when pasting? Did you update the rawcodes for the spell/units/other spells in the config?

 

[Acolite333]

You need to be more specific about what "isn't working". Are you sure all the appropriate variables were created when pasting? Did you update the rawcodes for the spell/units/other spells in the config?

Sorry about that! I attached the current version of my map to my first comment, showing all my information. Here I have attached another version, where all I have done is copy and paste the variables, ability, and dummy unit exactly as they appear in the original map and deleted all the extras I had. The only thing I made myself is the base unit with the spell (but it's the same base unit and model the OG map has). I haven't really edited anything and yet for whatever reason it still doesn't work like it does in the test map.

I copied the variables folder first the first time, then the config, cast, and loop triggers in that order.

The second time I tried to just copy the config, cast, and loop triggers and checked the automatically create unknown variables option to make sure it wasn't a copying mistake somehow.

Neither version seems to work in my map :/

 

[Daffa]

[Trigger] - [SOLVED] Trying to make a custom ability from The Hive Work

Hey everyone. I was wondering if I could get some help on making the downloaded FireForm Spell from the Hive work in another map. It works perfectly fine when I download the map there and test it in the map file, but when I copy the custom ability, custom units, variables, and then the triggers...

www.hiveworkshop.com

Bringing this thread since there is a hidden fault in the codes, should be considered for updating when you're around @Rheiko

 

[Rheiko]

Updated to v1.4:

• Added Prefix FF_ for some Temp Variables (FF_TempPoint, etc)
• Fixed FF_TempPoint missing reference by relocating it outside the ITE block inside loop trigger
• Fixed FF_ReachedDist not de-allocated properly, causing the spell ends too early in some cases
• Changed FF_TreeDestroyer name to FF_DummyCaster
• Added debuff effect (damage over time) if the spell hits enemy units

Thanks @Daffa for the heads up, I know it's kinda late now for an update, way too late in fact, but better late than never.
The hidden fault is another oversight from me, hopefully no more problem with the spell from now on.
I apologize for the problem the spell has caused, I guess that's it from me, cheers!