Assassinate v1.4

[Moderator]

15:28, 22nd Jul 2013
PurgeandFire: Good job. This spell is nicely coded and fun to play around with.

 

[deathismyfriend]

can u post the triggers plz.
u also need importing instructions.

edit: i was able to dl and i found a few mistakes.

u should not destroy the points in the then condition unless u make the point in there ( in this case u dont). these will leak whenever the else condition is run
anything u use twice or more store into a variable and use that. ex: picked unit is used a lot.
u leak a point. the assa_randompoint

 

[xyzier_24]

can u post the triggers plz.
u also need importing instructions.

edit: i was able to dl and i found a few mistakes.

u should not destroy the points in the then condition unless u make the point in there ( in this case u dont). these will leak whenever the else condition is run
anything u use twice or more store into a variable and use that. ex: picked unit is used a lot.
u leak a point. the assa_randompoint

ow, haha. thanks for checking it @deathismyfriend, i made this spell in just 1 day and i didn't rechecked it. again, thanks for checking my spell

 

[deathismyfriend]

np just next time can u post the triggers on here i normally never dl the spell to look at it.

 

[Losam]

Well, first, you must put the Triggers, by that way, other users can analyze their work.

 

[deathismyfriend]

Well, first, you must put the Triggers, by that way, other users can analyze their work.

Already mentioned that lol

 

[T. D. W.]

This Spell has troubles with MUI :/
You must add 2 casters in the test map when uploading a spell
Now, when i added 1 caster and casted them together, it ended up that the second caster was still disabled after the spell and invulnerable, and after that, i made the first caster cast it again, he ended up also disabled and invulnerable

The thing that causes this is this line:

• Set Assa_Max = (Assa_Max - 1)

When you reduce the max index by 1, when it was 2 before, when looping the spell, the 2nd array will be ignored and only the first will continue

Overall, it's a nice spell but with a MUI problem:
it should take a 2/5 but since it's cool with it's effects:

Rating

voting for: NEEDS FIX

 

[deathismyfriend]

the problem w MUI is that u dont de-index properly. u also handle the loop wrong. u should check out my tutorial things a GUIer should know. the chapter how to index shows u how to properly index loop and de-index

 

[T. D. W.]

^^ what deathismyname said, or if you want you can use hashtables (you can also find tutorials about them)

 

[deathismyfriend]

hashtables shouldnt be used for this kind of spell

 

[T. D. W.]

I firstly thought of that, but since it disables and makes the caster invulnerable, there are no problems for hashtables, the spell can not in any ways be cast twice by a single caster

 

[deathismyfriend]

that is true but also remember that hashtables are slower than using the indexing method that is being used. there are only some mistakes which can be easily fixed.

 

[T. D. W.]

there are only some mistakes which can be easily fixed

Very true
I would like to know why hashtables are slower than indexing?

 

[deathismyfriend]

its by the way that they are handled in wc3. they require more processing to use. in the case of lookup they are faster than arrays. but when loading and storing things they are slower. there are a few threads around that tells y exactly they are slower. u can look them up. i cant atm

 

[T. D. W.]

Makes sence, will check on that

 

[xyzier_24]

i tested it with 2 caster. when it the 1st caster casts the skill, then the 2nd will cast it after a while. it was working properly. but when both of them cast it at the same time, there are errors. why? please help, i'm not good at making MUI.

 

[deathismyfriend]

the problem is u dont de-index properly. i posted this above. u can look at my tutorial things a GUIer should know in the chapter how to index. that will show u how to properly index and de-index.

 

[xyzier_24]

i don't know which line of the de-indexing causes errors. i already checked deathismyfriend's "index : de-indexing" tutorial and it always cause me errors. why? please tell me what line do i need to change and what will i change it into?

 

[T. D. W.]

I told you, re-read my first coment

 

[Mouzyy]

Errm, i didnt read other comments in this talk, but - shouldnt uploaded spell also contain some tooltip, what exactly it does? Like, yep, i could read it whole and see for myself (i could, im too lazy now), but i think besides trigger of spell it should also contain few words what exactly it does, so we dont have to read it all and find out what it does + maybe some other stuff for lazy people like which values can be changed (range, AoE, damage, etc) by integers or wherever.

Just saying, its your first spell as you said, so, information for future and good luck fixing it if it still has got some problems (im afraid i cant help very much, Deathismyfriend and DotCa are skillas, im noob )

 

[T. D. W.]

Deathismyfriend and DotCa are skillas, im noob )

Do i know you , thx

 

[deathismyfriend]

u messed up here. its in the de-index part.

• Set Assa_Target[Assa_Loop] = Assa_Target[Assa_Loop]

u should put this after the loop not in the loop

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
• If - Conditions
• Assa_Max Equal to 0
• Then - Actions
• Trigger - Turn off (This trigger)
• Else - Actions

 

[Magtheridon96]

Hashtables are slower because the process of saving and loading data from a hashtable is not trivial like an array lookup. First, the passed indexes need to go through a hash function, then you'd have to query the data from a structure that may or may not be efficient depending on how Blizzard actually implemented the hashtable ;v

 

[T. D. W.]

Yeah, i've got the idea of it, but i still think hash are easier than indexing (that's my thought, you don't have to discuss it)

 

[DivineLight]

i like indexing much more than hash..
make this configurable please

 

[xyzier_24]

what line does cause the spell not to become MUI? and how can i fix it?

 

[PurgeandFire]

what line does cause the spell not to become MUI? and how can i fix it?

You should post the code in Triggers & Scripts and have someone help you work it out. Once it is finished, you can update the code and a mod will review it.

 

[Dr Super Good]

I believe I have resolve the MUI issue here. It was down to incorrect object move logic.

 

[GywGod133]

Why does not save the Picked Unit in Variable :/?

 

[Kazeon]

I think PnF missed one thing:

• Unit - Pause Assa_Caster[Assa_Max]

Thought it is not allowed. Better use a dummy unit with the same model as the Hero with locust or invulnerable ability, and hide the Hero somewhere. Or just don't pause the hero completely. Also making hero invulnerable while casting an ability is sometimes considered as imbalance.

Adding some configurable thingies will be nice

Post above me is right.

 

[D1vergent]

Looks nice.

 

[xyzier_24]

Why does not save the Picked Unit in Variable :/?

Where? Where? I can't find it.

 

[Trakya]

Would you make description about ability and what he does?

 

[xyzier_24]

Would you make description about ability and what he does?

Sure! It will take just a few minutes.

 

[jonbon29]

Very nice I'm looking forward to use this on my map.

 

[xyzier_24]

Very nice I'm looking forward to use this on my map.

Thanks, milord

 

[LeXuS123]

Wtf i can use in patch 1.22 and work fine


Good job

 

[Pyrogasm]

This one does not use hashtables so it will work. You can easily check the code to see if it uses something like hashtables that didn't exist in 1.22. Or, you know, update your game install. But I'm gonna guess since I've mentioned that in 3 different threads you've commented in about 1.22 that you're not going to do that.

 

[InSaNe_97]

Just beautiful, works, easy to implement, GUI friendly.

Edit:
I'm using this in My map.