Ignite v1.4

[Blightsower]

Requesting for approval

 

[Wrda]

• Set VariableSet IGT_TempCaster = (Triggering unit)
• Set VariableSet IGT_TempPlayer = (Triggering player)
• Set VariableSet IGT_TempLevel = (Level of IGT_MainAbility for IGT_TempCaster)
• -------- --------
• Set VariableSet IGT_Caster[IGT_Index] = IGT_TempCaster
• Set VariableSet IGT_Player[IGT_Index] = IGT_TempPlayer
• Set VariableSet IGT_Level[IGT_Index] = IGT_TempLevel

Why not simply use the latter? those temp variables look redundant.

• Set VariableSet IGT_Index2 = (IGT_Index2 + 1)
• Set VariableSet IGT_DamageGroupIndex[IGT_Index] = IGT_Index2
• Custom script: call DestroyGroup(udg_IGT_DamageGroup[udg_IGT_DamageGroupIndex[udg_IGT_Index]])
• Custom script: set udg_IGT_DamageGroup[udg_IGT_DamageGroupIndex[udg_IGT_Index]]=CreateGroup()

This seems overcomplicated, why not just call DestroyGroup(udg_IGT_DamageGroup[udg_IGT_Index]) and then recreate the group? You don't need this recycling going on.
Same in Ignite Effect, no need the IGT_Index2 variable either.

• Unit - Remove IGT_AbilityDisabler from IGT_Caster[IGT_Looper]
  • -------- --------
  • Set VariableSet IGT_DamageGroup[IGT_DamageGroupIndex[IGT_Looper]] = IGT_DamageGroup[IGT_Index2]
  • Set VariableSet IGT_Index2 = (IGT_Index2 - 1)
  • Set VariableSet IGT_Stage[IGT_Looper] = IGT_STAGE_DEINDEX

IGT_TAG_CASTER isn't being used at all in any comparison. In fact, IGT_TAG variables aren't needed, IGT_Tag array too.

• For each (Integer IGT_Looper) from 1 to IGT_EffectWaveCount[IGT_TempLevel], do (Actions)
  • Loop - Actions
    • Set VariableSet IGT_Index = (IGT_Index + 1)
    • -------- --------
    • Set VariableSet IGT_Caster[IGT_Index] = IGT_TempCaster
    • Set VariableSet IGT_Player[IGT_Index] = IGT_TempPlayer
    • Set VariableSet IGT_Level[IGT_Index] = IGT_TempLevel
    • Set VariableSet IGT_DamageGroupIndex[IGT_Index] = IGT_TempIndex
    • Set VariableSet IGT_BaseDamageTotal[IGT_Index] = IGT_BaseDamageTotal[IGT_Looper]
    • Set VariableSet IGT_DamagePerDebuffTotal[IGT_Index] = IGT_DamagePerDebuffTotal[IGT_Looper]
    • -------- --------
    • Set VariableSet IGT_ProjectileDistance[IGT_Index] = IGT_Radius[IGT_TempLevel]
    • Set VariableSet IGT_ProjectileSpeed[IGT_Index] = IGT_TempProjectileSpeed
    • Set VariableSet IGT_Angle[IGT_Index] = IGT_TempAngle
    • -------- --------
    • Unit - Create 1 Dummy (Generic) for Neutral Passive at IGT_Point1 facing IGT_Angle[IGT_Index] degrees
    • Set VariableSet IGT_FireTrailProjectile[IGT_Index] = (Last created unit)
    • -------- --------
    • Special Effect - Create a special effect attached to the IGT_FireNovaModelAttachment of IGT_FireTrailProjectile[IGT_Index] using IGT_FireNovaModel
    • Set VariableSet IGT_FireTrailSFX[IGT_Index] = (Last created special effect)
    • -------- --------
    • Set VariableSet IGT_Stage[IGT_Index] = IGT_STAGE_DAMAGE
    • Set VariableSet IGT_Tag[IGT_Index] = IGT_TAG_DUMMY
    • -------- --------
    • Set VariableSet IGT_TempAngle = (IGT_TempAngle - IGT_TempAngleAdjuster)
    • -------- --------

This is being done inside the main loop which also uses IGT_Looper, use IGT_Looper2 here instead, since the overwritting will skip some steps of some instances.


Dummy should have locust ability, but you don't even need dummies for this. You could use special effects, due to recent patches, you can also move them, and change orientation (in radians). Overall special effects are better than units, so you won't need this part that checks whether the dummies are in playable map area if you use effects:

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • (Terrain pathing at IGT_Point2 of type Walkability is off) Equal to False
    • ((Playable map area) contains IGT_Point2) Equal to True
  • Then - Actions
    • Custom script: call SetUnitY(udg_IGT_FireTrailProjectile[udg_IGT_Looper], GetLocationY(udg_IGT_Point2))
    • Custom script: call SetUnitX(udg_IGT_FireTrailProjectile[udg_IGT_Looper], GetLocationX(udg_IGT_Point2))
  • Else - Actions
    • Set VariableSet IGT_Stage[IGT_Looper] = IGT_STAGE_DEINDEX

The deindexing part is missing 2 variables IGT_BaseDamageTotal and IGT_DamagePerDebuffTotal.
Your targets allowed are hardcoded, a user may want this spell to affect magic immune or structures, or any other type. Make it configurable please.
You can make your resource description of the spell with greater detail.
What I don't get is that the spell only affects units with these debuffs? Are you sure about that? Seems weird to see great fire effects happening with this channeling spell and it not affecting anything.
It's a really great idea for a spell, I just have these 3 major issues, the deindexing, targets allowed and IGT_Looper oversight. Changing from dummy units to effects will make the quality better.
Needs fix.

 

[Blightsower]

Hello @Wrda, thank you for spending the time to read my triggers.
I made the following changes that you prescribed:

• 
  Unit - Remove IGT_AbilityDisabler from IGT_Caster[IGT_Looper]
  • 
    
    -------- --------
  • 
    
    Set VariableSet IGT_DamageGroup[IGT_DamageGroupIndex[IGT_Looper]] = IGT_DamageGroup[IGT_Index2]
  • 
    
    Set VariableSet IGT_Index2 = (IGT_Index2 - 1)
  • 
    
    Set VariableSet IGT_Stage[IGT_Looper] = IGT_STAGE_DEINDEX

IGT_TAG_CASTER isn't being used at all in any comparison. In fact, IGT_TAG variables aren't needed, IGT_Tag array too.

Removed the IGT_TAG_CASTER, IGT_TAG_DUMMY, and IGT_Tag. Those were vestigial codes that I should've seen before uploading.

• 
  For each (Integer IGT_Looper) from 1 to IGT_EffectWaveCount[IGT_TempLevel], do (Actions)
  • 
    
    Loop - Actions
    • 
      
      
      Set VariableSet IGT_Index = (IGT_Index + 1)
    • 
      
      
      -------- --------
    • 
      
      
      Set VariableSet IGT_Caster[IGT_Index] = IGT_TempCaster
    • 
      
      
      Set VariableSet IGT_Player[IGT_Index] = IGT_TempPlayer
    • 
      
      
      Set VariableSet IGT_Level[IGT_Index] = IGT_TempLevel
    • 
      
      
      Set VariableSet IGT_DamageGroupIndex[IGT_Index] = IGT_TempIndex
    • 
      
      
      Set VariableSet IGT_BaseDamageTotal[IGT_Index] = IGT_BaseDamageTotal[IGT_Looper]
    • 
      
      
      Set VariableSet IGT_DamagePerDebuffTotal[IGT_Index] = IGT_DamagePerDebuffTotal[IGT_Looper]
    • 
      
      
      -------- --------
    • 
      
      
      Set VariableSet IGT_ProjectileDistance[IGT_Index] = IGT_Radius[IGT_TempLevel]
    • 
      
      
      Set VariableSet IGT_ProjectileSpeed[IGT_Index] = IGT_TempProjectileSpeed
    • 
      
      
      Set VariableSet IGT_Angle[IGT_Index] = IGT_TempAngle
    • 
      
      
      -------- --------
    • 
      
      
      Unit - Create 1 Dummy (Generic) for Neutral Passive at IGT_Point1 facing IGT_Angle[IGT_Index] degrees
    • 
      
      
      Set VariableSet IGT_FireTrailProjectile[IGT_Index] = (Last created unit)
    • 
      
      
      -------- --------
    • 
      
      
      Special Effect - Create a special effect attached to the IGT_FireNovaModelAttachment of IGT_FireTrailProjectile[IGT_Index] using IGT_FireNovaModel
    • 
      
      
      Set VariableSet IGT_FireTrailSFX[IGT_Index] = (Last created special effect)
    • 
      
      
      -------- --------
    • 
      
      
      Set VariableSet IGT_Stage[IGT_Index] = IGT_STAGE_DAMAGE
    • 
      
      
      Set VariableSet IGT_Tag[IGT_Index] = IGT_TAG_DUMMY
    • 
      
      
      -------- --------
    • 
      
      
      Set VariableSet IGT_TempAngle = (IGT_TempAngle - IGT_TempAngleAdjuster)
    • 
      
      
      -------- --------

This is being done inside the main loop which also uses IGT_Looper, use IGT_Looper2 here instead, since the overwritting will skip some steps of some instances.

Changed IGT_Looper to IGT_Looper2

Your targets allowed are hardcoded, a user may want this spell to affect magic immune or structures, or any other type. Make it configurable please.

I'm not entirely sure how this one is usually handled so I added some booleans at the Init trigger. I hope my solution is satisfactory.

• 
  If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • 
    
    If - Conditions
    • 
      
      
      (Terrain pathing at IGT_Point2 of type Walkability is off) Equal to False
    • 
      
      
      ((Playable map area) contains IGT_Point2) Equal to True
  • 
    
    Then - Actions
    • 
      
      
      Custom script: call SetUnitY(udg_IGT_FireTrailProjectile[udg_IGT_Looper], GetLocationY(udg_IGT_Point2))
    • 
      
      
      Custom script: call SetUnitX(udg_IGT_FireTrailProjectile[udg_IGT_Looper], GetLocationX(udg_IGT_Point2))
  • 
    
    Else - Actions
    • 
      
      
      Set VariableSet IGT_Stage[IGT_Looper] = IGT_STAGE_DEINDEX

The deindexing part is missing 2 variables IGT_BaseDamageTotal and IGT_DamagePerDebuffTotal.

Added, IGT_BaseDamageTotal and IGT_DamagePerDebuffTotal to the deindex

You can make your resource description of the spell with greater detail.

Improved my description by providing more details about the concept.

• 
  Set VariableSet IGT_TempCaster = (Triggering unit)
• 
  Set VariableSet IGT_TempPlayer = (Triggering player)
• 
  Set VariableSet IGT_TempLevel = (Level of IGT_MainAbility for IGT_TempCaster)
• 
  -------- --------
• 
  Set VariableSet IGT_Caster[IGT_Index] = IGT_TempCaster
• 
  Set VariableSet IGT_Player[IGT_Index] = IGT_TempPlayer
• 
  Set VariableSet IGT_Level[IGT_Index] = IGT_TempLevel

Why not simply use the latter? those temp variables look redundant.

Removed IGT_TempPlayer from the cached values. IGT_TempCaster is later used within the loop after the trigger is turned on to track the caster. IGT_TempLevel is also used within the loop to reference some values.

Now, here are some justifications for the structure of the triggers mainly regarding the unit group and the choice of using units instead of special effects.

• 
  Set VariableSet IGT_Index2 = (IGT_Index2 + 1)
• 
  Set VariableSet IGT_DamageGroupIndex[IGT_Index] = IGT_Index2
• 
  Custom script: call DestroyGroup(udg_IGT_DamageGroup[udg_IGT_DamageGroupIndex[udg_IGT_Index]])
• 
  Custom script: set udg_IGT_DamageGroup[udg_IGT_DamageGroupIndex[udg_IGT_Index]]=CreateGroup()

This seems overcomplicated, why not just call DestroyGroup(udg_IGT_DamageGroup[udg_IGT_Index]) and then recreate the group? You don't need this recycling going on.
Same in Ignite Effect, no need the IGT_Index2 variable either.

IGT_Index2 is meant to track the instance of the spell so that enemies can only get hit by the spell once per cast. I understand that the spell removes debuffs but I'm worried that if the waves are configured to be too slow that it might cause the unit to be damaged by the spell again by a different wave of the nova.

Dummy should have locust ability, but you don't even need dummies for this. You could use special effects, due to recent patches, you can also move them, and change orientation (in radians). Overall special effects are better than units, so you won't need this part that checks whether the dummies are in playable map area if you use effects:

• 
  If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • 
    
    If - Conditions
    • 
      
      
      (Terrain pathing at IGT_Point2 of type Walkability is off) Equal to False
    • 
      
      
      ((Playable map area) contains IGT_Point2) Equal to True
  • 
    
    Then - Actions
    • 
      
      
      Custom script: call SetUnitY(udg_IGT_FireTrailProjectile[udg_IGT_Looper], GetLocationY(udg_IGT_Point2))
    • 
      
      
      Custom script: call SetUnitX(udg_IGT_FireTrailProjectile[udg_IGT_Looper], GetLocationX(udg_IGT_Point2))
  • 
    
    Else - Actions
    • 
      
      
      Set VariableSet IGT_Stage[IGT_Looper] = IGT_STAGE_DEINDEX

The dummy unit does indeed have the locust ability. This check is meant for doodads that blocks pathing. It will prematurely end the wave if it encounters a wall. Also, I encountered this special effects bug which apparently exists for years now where it doesn't show anymore when created on a point. This bug apparently happens when your computer is turned on for too long which is why i used locus dummy units for the effects. Reference for the mentioned bug.

Thanks again for looking into my triggers. I hope that the changes are to your liking. Also, this is my first spell after 8 years of not touching World Editor so please be patient with me. Please review my spell when you can.

Edit: Now uses special effects instead of dummy units for the firetrails since this solution fixed the issue.

 

[Wrda]

I'm not entirely sure how this one is usually handled so I added some booleans at the Init trigger. I hope my solution is satisfactory.

I'll help you there. So inside your "Unit Group - Pick every unit in IGT_TempGroup and do (Actions)" you would set a boolean variable, let's say ValidTarget = false, and then run a new created trigger with "Trigger - Run Trigger (ignoring conditions)", in which you can have all your conditions like you had before, if the conditions are passed, then you set ValidTarget = true. Back in your other trigger, inside "Unit Group - Pick every unit in IGT_TempGroup and do (Actions)" and after "Trigger - Run Trigger (ignoring conditions)" the rest of the actions should be inside an If Then Else block with "If ValidTarget is equal to true".
Also, you should use temp variables on the new trigger, the one which has the filters, such as the caster and the ability level, in order for the user access them.

Removed IGT_TempPlayer from the cached values. IGT_TempCaster is later used within the loop after the trigger is turned on to track the caster. IGT_TempLevel is also used within the loop to reference some values.

Now, here are some justifications for the structure of the triggers mainly regarding the unit group and the choice of using units instead of special effects.

IGT_Index2 is meant to track the instance of the spell so that enemies can only get hit by the spell once per cast. I understand that the spell removes debuffs but I'm worried that if the waves are configured to be too slow that it might cause the unit to be damaged by the spell again by a different wave of the nova.

All good

The dummy unit does indeed have the locust ability. This check is meant for doodads that blocks pathing. It will prematurely end the wave if it encounters a wall.

Oddly enough, it's not applying to trees, probably because of the AOE and executing before this check. But right now it also ends if it "collides" with cliffs, is this intentional?
There's a new problem when you replaced with special effects: since you made special effects Z position as 100, now it can be inside terrain (like inside cliffs) because it's an absolute coordinate, and not relative to the ground level it is at.
It's easy to fix so don't panic.
Create a new custom script (the green 01010101) icon and paste this there:

globals
    location LOC_Z = Location(0, 0)
endglobals

function GetTerrainZ takes real x, real y returns real
    call MoveLocation(LOC_Z, x, y)
    return GetLocationZ(LOC_Z)
endfunction

Next, before setting the Z position of the special effect "Special Effect - Set Position - Z of IGT_FireTrailSFX[IGT_Looper] to 100.00", create a new real variable, and make a custom script before using it:

• Custom script: set udg_IGT_LocZ = GetTerrainZ(GetLocationX(IGT_Point2), GetLocationY(IGT_Point2))
• Special Effect - Set Position - Z of IGT_FireTrailSFX[IGT_Looper] to (IGT_LocZ + 100.00)

That should do it.

Thanks again for looking into my triggers. I hope that the changes are to your liking. Also, this is my first spell after 8 years of not touching World Editor so please be patient with me. Please review my spell when you can.

Very well done for a washed up guy

 

[Rheiko]

This check is meant for doodads that blocks pathing.

Oddly enough, it's not applying to trees, probably because of the AOE and executing before this check. But right now it also ends if it "collides" with cliffs, is this intentional?

The reason for that is, that only checks for cliffs, it will not detect pathing of buildings and destructibles.
For that reason, some pathing check system is made:

• Check Walkability
• IsWalkabilityOff 1.2

 

[Wrda]

The reason for that is, that only checks for cliffs, it will not detect pathing of buildings and destructibles.
For that reason, some pathing check system is made:

• Check Walkability
• IsWalkabilityOff 1.2

Even though I knew that method and I usually use it I completely forgot about it (the hell am I doing at 6:37am?).

 

[Blightsower]

Spell has been updated.
* Corrected the Z height issue of the spell

Next, before setting the Z position of the special effect "Special Effect - Set Position - Z of IGT_FireTrailSFX[IGT_Looper] to 100.00", create a new real variable, and make a custom script before using it:

• 
  Custom script: set udg_IGT_LocZ = GetTerrainZ(GetLocationX(IGT_Point2), GetLocationY(IGT_Point2))
• 
  Special Effect - Set Position - Z of IGT_FireTrailSFX[IGT_Looper] to (IGT_LocZ + 100.00)

That should do it.

* Moved the unit damage filter outside of the damage loop

I'm not entirely sure how this one is usually handled so I added some booleans at the Init trigger. I hope my solution is satisfactory.

I'll help you there. So inside your "Unit Group - Pick every unit in IGT_TempGroup and do (Actions)" you would set a boolean variable, let's say ValidTarget = false, and then run a new created trigger with "Trigger - Run Trigger (ignoring conditions)", in which you can have all your conditions like you had before, if the conditions are passed, then you set ValidTarget = true. Back in your other trigger, inside "Unit Group - Pick every unit in IGT_TempGroup and do (Actions)" and after "Trigger - Run Trigger (ignoring conditions)" the rest of the actions should be inside an If Then Else block with "If ValidTarget is equal to true".
Also, you should use temp variables on the new trigger, the one which has the filters, such as the caster and the ability level, in order for the user access them.

* Added some doodads to demonstrate the desired effects of the walkability check

The dummy unit does indeed have the locust ability. This check is meant for doodads that blocks pathing. It will prematurely end the wave if it encounters a wall.

Oddly enough, it's not applying to trees, probably because of the AOE and executing before this check. But right now it also ends if it "collides" with cliffs, is this intentional?
There's a new problem when you replaced with special effects: since you made special effects Z position as 100, now it can be inside terrain (like inside cliffs) because it's an absolute coordinate, and not relative to the ground level it is at.
It's easy to fix so don't panic.
Create a new custom script (the green 01010101) icon and paste this there:

 

[Blightsower]

The reason for that is, that only checks for cliffs, it will not detect pathing of buildings and destructibles.
For that reason, some pathing check system is made:

• Check Walkability
• IsWalkabilityOff 1.2

I did it so that you can dodge the projectile by hiding behind some rocks and other doodads that blocks pathing. I've added some rocks and a barn to the test map to demonstrate.

 

[Rheiko]

Yes, I'm aware. Just to point out that it will still go through buildings and destructibles. If that is what you're aiming for, then you can keep it that way. I see no problem with that.

I tried your testmap with WC3CE and it seems like some special effects are not properly destroyed.
I haven't read your code yet so I'm not sure where the problem's coming from. Might worth checking out.

 

[Wrda]

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • IGT_IsIgnitable Equal to True
    • (IGT_Picked is alive) Equal to True
    • (IGT_Picked belongs to an enemy of IGT_Player[IGT_Looper].) Equal to True
    • (IGT_Picked is in IGT_DamageGroup[IGT_DamageGroupIndex[IGT_Looper]].) Equal to False

Move all conditions to the configuration trigger except "IGT_IsIgnitable Equal to true", if the user modifies them in a dumb way then it's their fault

• Then - Actions
  • -------- --------
  • Set VariableSet IGT_Point1 = (Position of IGT_Caster[IGT_Looper])
  • Set VariableSet IGT_Point2 = (IGT_Point1 offset by IGT_ProjectileDistance[IGT_Looper] towards IGT_Angle[IGT_Looper] degrees.)
  • -------- --------
  • Set VariableSet IGT_Angle[IGT_Looper] = (IGT_Angle[IGT_Looper] + IGT_TurnRate[IGT_Looper])
  • Set VariableSet IGT_ProjectileDistance[IGT_Looper] = (IGT_ProjectileDistance[IGT_Looper] - IGT_ProjectileSpeed[IGT_Looper])
  • -------- --------
  • Special Effect - Set Position - X of IGT_FireTrailSFX[IGT_Looper] to (X of IGT_Point2)
  • Special Effect - Set Position - Y of IGT_FireTrailSFX[IGT_Looper] to (Y of IGT_Point2)
  • Special Effect - Set Position - Z of IGT_FireTrailSFX[IGT_Looper] to 100.00
  • -------- --------
  • Custom script: call RemoveLocation(udg_IGT_Point1)
  • Custom script: call RemoveLocation(udg_IGT_Point2)

You missed a location of setting the Z of the effect with LocationZ, it's in IGT_STAGE_SPARKS stage.

Aside from that, looks good to approve

I tried your testmap with WC3CE and it seems like some special effects are not properly destroyed.
I haven't read your code yet so I'm not sure where the problem's coming from. Might worth checking out.

That's rather odd, probably worth sending to MindWorx.

 

[Rheiko]

That's rather odd, probably worth sending to MindWorx.

Yeah, WC3CE could be the problem. But I don't know. It kinda looks like an indexing problem.
Sorry for not reading the code, I'm resting at the moment. But look at this:

 

[Wrda]

Yeah, WC3CE could be the problem. But I don't know. It kinda looks like an indexing problem.
Sorry for not reading the code, I'm resting at the moment. But look at this:

No, you're right, it is also happening to me too. The way used to reach the deindexing stage is unconventional, I'll investigate this to the bone.

 

[Blightsower]

Map has been updated
* Fixed the location Z of cast
* Moved all of the damage filters to the config
* Fixed the weird visual special effect glitch

 

[Wrda]

Works spectacularly without flaws.

Approved



PS: Today we learned that special effects still exist after being destroyed, being able to destroy them again and showing its death animation, even after the decay time...brilliant.

 

[Blightsower]

Thank you for the approval and thank you for helping me find the bugs. @Wrda @Rheiko

 

[Rheiko]

PS: Today we learned that special effects still exist after being destroyed, being able to destroy them again and showing its death animation, even after the decay time...brilliant.

That is so weird, though. lol

Thank you for the approval and thank you for helping me find the bugs. @Wrda @Rheiko

No problemo

 

[Blightsower]

Added Ignite (Instant) v1.0 to the resource as requested.
Ignite (Instant) - a variant of Ignite that doesn't require the caster to fully channel the spell for it to release the nova.