Check Walkability

[Moderator]

Check Walkability | Reviewed by Maker | 9th Jul 2013

APPROVED

This is a very useful system, I can seet it being used widely. There could be a variable for the tolerance.

[tr]

 

[jonhysone]

This is epic . +rep !

 

[Daffa]

I really like it, why? It's useful + No more this kind of shits : "WTF? My Hero got stuck after use my KB!! Plz Help!! I use Pathing Check!!!"
+Rep

 

[Almia]

mckill description? XD

How about cacheing first GetEnumUnit then index it?

 

[Daffa]

Also, splitting the unused variables as a different trigger then make an unused trigger to store them is good enough I think

 

[T. D. W.]

Yay, checked it, so cool it's a 5/+rep

 

[PurgeandFire]

mckill description? XD

How about cacheing first GetEnumUnit then index it?

You mean GetEnumItem()? Eh, I thought of that, it *could* be a minor speed increase but it won't be anything in an actual scenario.

Anyway, most of the time that part won't even fire. It is just for the odd scenarios when there happens to be an item laying on the ground.

Thanks for the comments guys.

 

[Almia]

Ah sorry for dat typo XD
Yup, it is just minor

 

[watermelon_1234]

That's a very misleading screenshot.

Everything about the code and test-map is nice, of course.

Not really about your system, but I just find it somewhat lame to have to emulate function calls using triggers and global variables just so that GUIers minimize their use of custom scripts.

 

[PurgeandFire]

That's a very misleading screenshot.

Haha, I had to make it look epic. It reels you in, thinking that I made an awesome test map featuring a crazy duel between a tauren and a blood elf mage. Nope. muahaha

Not really about your system, but I just find it somewhat lame to have to emulate function calls using triggers and global variables just so that GUIers minimize their use of custom scripts.

I agree. It isn't really that efficient, either (TriggerExecute() calls). But ah well. GUI'ers find custom scripts scary. I can't really blame them either, since the default syntax checker for regular WE will slap you left and right for any mistake you make in the code (it'll throw 5-6 errors and disable the trigger, pretty annoying stuff).

But I agree, it is a pretty weird method and only promotes GUI even more. However, it is better than having them code things poorly (a lot of GUI spells have poor pathing checks). So in the end I decided to make this for them :[

P.S. Nice to see you back

 

[Daffa]

This + Knockback Spells = Total Awesomeness (for maps )

 

[Vinz]

I just made a knockback spell, just what I needed. It's perfect for checking pathing. Definitely a must-have for GUI users.

 

[Almia]

Uhh, I think I shall update my Knockback 2D

 

[zv27]

Maybe I'm wrong but this only supports location [udg_CP_Point] (missing coordinates)

With this, it is only possible to use this

set udg_CP_Point = GetOrderPointLoc()

set udg_CP_Point = GetSpellTargetLoc()

and so on...
[Very limited possibilities]

What if someone wants to use something like this
Example:

set udg_CP_X = GetOrderPointX()

set udg_CP_Y = GetOrderPointY()

set udg_CP_X = GetSpellTargetX()

set udg_CP_Y = GetSpellTargetY()

set udg_CP_X = GetUnitX(whichUnit)

set udg_CP_Y = GetUnitY(whichUnit)

set udg_CP_X = GetItemX(whichItem)

set udg_CP_Y = GetItemY(whichItem)

and so on...


Definitely, the system should support both options
This would make the system much more complete

 

[T. D. W.]

1. It's a system for GUIers... So they won't use the X and Y
2. There is something that is:

Set CP_Point = Point(X, Y)

 

[PurgeandFire]

@zv27: I'll add support for coordinates when I get back to my modding comp (probably won't get back until around Tuesday/Wednesday). I didn't really accommodate for coordinates since there aren't any GUI functions that really use them (or not much, aside from Point()). But I suppose it wouldn't hurt.

P.S. If you have any knowledge of JASS, I highly recommend using Rising_Dusk's version. It is far better for all intents and purposes since my method relies on a TriggerExecute per function call (to support easy usage with GUI). In most cases, the performance shouldn't matter since it is still a lightweight function, but it is still wiser to use the vJASS version if you know how.

 

[Kazeon]

• and (not IsTerrainPathable(x, y, PATHING_TYPE_WALKABILITY))

is not required to do EDIT: or may be I'm wrong

 

[Zwiebelchen]

Btw, does your method detect pathing set by call SetTerrainPathable( x, y, PATHING_TYPE_WALKABILITY, false )?

 

[PurgeandFire]

I can't be certain but hopefully that is covered by this:

 (not IsTerrainPathable(x, y, PATHING_TYPE_WALKABILITY)

Otherwise blizzard is dumb. This is a direct port of this:
http://www.wc3c.net/showthread.php?t=103862
To GUI, so it inherits all the same mistakes and issues (whatever they may be).

 

[SinnerPo]

Hey @PurgeandFire. It's pretty nice system, but I wonder: does it detect through the unit position? For example When U order unit to move on place that already contains someone near.

 

[PurgeandFire]

Hey @PurgeandFire. It's pretty nice system, but I wonder: does it detect through the unit position? For example When U order unit to move on place that already contains someone near.

I don't think it checks for units, but I am not 100% sure. Best way would be to test it.

There is a way to check for units using build orders, but it involves JASS.

 

[KILLCIDE]

My go to resource for all my missile-like spells

 

[Alethos]

So I'm guessing this is broken after 1.29.2's removal of item collision, yeah?

 

[PurgeandFire]

So I'm guessing this is broken after 1.29.2's removal of item collision, yeah?

Hmm, I'll have to test it. I hope it isn't broken, because this technique is used in a buttload of custom maps.

 

[Virus-X]

Simple but very important, 5* for you

 

[Oljin]

i used your system to improve about 3-5 spells in my map. your system is super useful and easy to use! great job!

 

[8gabriel8]

Only need to add this trigger to the system

• Check Walkability Load
  • Events
    • Game - A saved game is loaded
  • Conditions
  • Actions
    • Item - Hide CP_Item

 

[Prometheus3375]

What is the sense to hide common items and then unhide them? If an item is on (x, y) or near it, then (x, y) is not pathable.

 

[Almia]

What is the sense to hide common items and then unhide them? If an item is on (x, y) or near it, then (x, y) is not pathable.

the item is hidden after it has changed its position.

 

[Prometheus3375]

the item is hidden after it has changed its position.

I understand why after moving the checking item, it must be hidden again, but I didn't understand is the purpose of hiding other items. I tested and realize that units do not collide with items.