I will upload previews later.

Preview uploaded. Enjoy the spell guys!

 

Looks awesome!

 

Thanks!

 

A rough review:

It feels odd that the configurable parts of the spell sets are contained in the same trigger as the map exclusive creation of the demo unit. I suggest splitting each configurable part of each spell into their own triggers.

Upon close inspection of the trigger

P Happy Hour Detect

, it appears that the bonus is applied before the caster even gets to start the effects of its' spell, making it abusable in certain conditions. Changing the event such that the trigger runs on the start of the effect instead of the moment the spell is casted (unit begins casting) would be viable. Also, the Do nothing option in the Else-Actions branch can be removed.

Speaking of the Happy Hour ability, it's just something minor; why not use "less than" instead of "not equal to" comparator? Why hardcode the amount healed to just 6%, when it can be made configurable? Why heal the caster twice; once at the

P Happy Hour Detect

trigger, and another at the

P Happy Hour Cast

trigger?

Instead of having to manually listen to the creation of a dummy unit in trigger

P Happy Hour Dummy

, why not opt to register to the index event provided by the Unit Indexer that's included in the script?

Moving on to the Barrel Roll ability, the distance is computed based on a fixed value of 900, which coincides with the dummy ability given. Why not expose a variable that will hold said value, which will make it more convenient to update if one changes the missile speed in the dummy ability? (Even better, why not make it so that the variable reads the missile speed directly from the Object Data)

On trigger

Q Barrel Roll Start

, after assigning (Last Created unit) to BarrelRoll_DamagePicked, you can just refer to BarrelRoll_DamagePicked when getting the index of the unit instead of having to waste a function call (Last Created unit) which will return the same thing. Also,

Q Barrel Roll Start

and

Q Barrel Roll Damage Auto

can be merged into one trigger. (Again, why is the expiration timer of the cask unit a hardcoded field? (not configurable))

Now, with the Drunken Rage ability, merging the two triggers

W Drunken Rage Damage

and

W Drunken Rage DmgReduc

would be recommended, with each keeping their own logic intact.

Considering only those above, the ability set would need an update.

Awaiting Update​

 

Dang, that's a lot of things to update.

How?

 

By using the new natives related to Object Data manipulation. (If the version you have is 1.31+)

This is one possible method:

• Have a dummy unit hold the desired ability (via adding the ability)
• Assign the variable to what would be read with the Object Data functions.
• Remove the ability (and maybe the dummy unit).

Hopefully, there should be an expanded list of functions in the ability section, or if there isn't, you can copy something like this:

Code (vJASS):

set <var>[<level>] = BlzGetAbilityRealLevelField(BlzGetUnitAbility(<dummy>, <abilityId>), ABILITY_RLF_<SOMETHING>, <level> - 1)
set <var> = BlzGetAbilityIntegerField(BlzGetUnitAbility(<dummy>, <abilityId>), ABILITY_IF_<SOMETHING>)
 

This would be a helpful constant:

ABILITY_IF_MISSILE_SPEED

I also attached a common.j file for browsing the list of available constants related to object data manipulation (Some are working, others aren't)

 

• Custom script: set udg_BarrelRoll_CaskSpeed = BlzGetAbilityIntegerField(BlzGetUnitAbility(udg_BarrelRoll_TriggeringUnit, udg_BarrelRoll_Ability), ABILITY_IF_MISSILE_SPEED)

This returns 0.000 for some reason. "BarrelRoll_TriggeringUnit" was a dummy unit created right above this custom script.

 

That's because the ability code being used is not the dummy ability that actually throws the cask (which has the projectile speed). Try udg_BarrelRoll_DummyAbility instead as a parameter, ensuring that the BarrelRoll_TriggeringUnit is the dummy unit, and has the ability beforehand.

 

Aah, that works.

MAP UPDATED!

• v1.5 - Changes made to all abilities.

--------- Happy Hour:
--------- >> Heal amount now configurable.
--------- >> Changed event from "Begins casting" to "Starts casting".
--------- >> Minor condition tweaks and removed a Do Nothing trigger.
--------- >> Fixed a bug where the heal will cast twice.
--------- >> Cooldown dummy now spawns with Unit Indexer event.

--------- Barrel Roll:
--------- >> Cask travel speed now configurable.
--------- >> Cask duration now configurable.
--------- >> Assigned proper variables to the cask dummy.
--------- >> Merged

Q Barrel Roll Start

and

Q Barrel Roll Damage Auto

--------- Drunken Rage:
--------- >> Merged

W Drunken Rage Damage

and

W Drunken Rage DmgReduc

--------- >> Fixed damage reduction math ( It used to reduce all damage to 5 )

--------- Body Slam:
--------- >> Dash speed increased from 23.00 to 25.00
--------- >> Gragas now stops when he dies mid-dash.

--------- Explosive Cask:
--------- >> Cask travel speed now configurable.
--------- >> Dead enemies are no longer knocked away from the impact.

 

Noticed something odd about the damage reduction calculation in the current version.

(For Drunken Rage)

Damage reduction values per level are represented as decimals treated as percentages. (0.18 x 0.01 is 0.18% in practice, but was nominally 18%). As such, damage reduction computations often reduce too much damage, leaving it at a low threshold of 5 (a potentially-configurable part of the spell).

Adding a bit more configurability to the percentages themselves would be desired, such as the following ability description would show:

Configurable Percentages

(+70% Ability Power)
(+60% Ability Power)
(+1%)

The group handle

BodySlam_DashDmgGroup

could be optimized to filter the units inside the loop, instead of having to filter each unit on enumeration (matching unit equal to yadda yadda), in trigger

BodySlam ExplosiveCask Move

 

I've always find it weird how damage reduction is calculated. What should I do to make the math more precise?

I know. But I used a condition that detects if the group has any units that matches the inserted conditions. If such, than the caster will stop dashing and damages enemies in his frontal vicinity. As far as I know, there's not much ways that you can detect if a group with desired conditions is empty or not without the use of Matching Units.

 

My apologies for the late reply.

First, BaseDamageRdc should be set to what would be the desired percentage in decimal representation. Something like this (10%):

• Set DrunkenRage_BaseDmgRdc[1] = 0.10

Then, upon calculating the amount of damage to be received, it should somewhat look like this:

• Set CalculateDamage = (DrunkenRage_BaseDmgRdc[DrunkenRage_AbilityLevel] + ((Real((Intelligence of DrunkenRage_TriggeringUnit (Include bonuses)))) x 0.01))

A possible approach for this would be to do what was previously suggested above. If at least 1 unit passes the filter, then the usual stuff dealing with collision would be enforced, and a flag variable will be set to not repeat the process again, only being reset outside the loop. It will look like this:

• Set BodySlam_DashDmgGroup = (Units within 120.00 of BodySlam_Points[1])
• Unit Group - Pick every unit in BodySlam_DashDmgGroup and do (Actions)
  • Loop - Actions
    • Set BodySlam_DashDmgPicked = (Picked unit)
    • Set AbilityIndexer = (Custom value of BodySlam_DashDmgPicked)
    • If (All Conditions Are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • <Insert Conditions here>
      • Then - Actions
        • If <flag variable not flagged yet> then
          • Do Something with Special Effect and Collision
          • Flag the variable
        • Set BodySlam_Points[2] = (Position of BodySlam_DashDmgPicked)
        • Set BdSlmExpCask_KBTotalDistance[AbilityIndexer] = 90.00
        • Set BdSlmExpCask_KBSpeed[AbilityIndexer] = 3.50
        • Set BdSlmExpCask_KBAngle[AbilityIndexer] = (Angle from BdSlmExpCask_KBLocI to BodySlam_Points[2])
        • Unit - Cause BdysSlmExpCask_PickedUnit to damage BodySlam_DashDmgPicked, dealing CalculateDamage damage of attack type Magic and damage type Normal
        • Unit Group - Add BodySlam_DashDmgPicked to BdSlmExpCask_KBGroup
        • Special Effect - Create a special effect attached to the chest of BodySlam_DashDmgPicked using BodySlam_SFX[1]
        • Special Effect - Destroy (Last created special effect)
        • Custom script: call RemoveLocation(udg_BodySlam_Points[2])
      • <unflag flag variable>

 

What's a flag variable?

 

A boolean you set to true/false to indicate something did or didn't happen.

 

I see. Do I need to index the flag or not?

 

Nope. It's instantaneous, so one global variable will suffice.

 

MAP UPDATED!

• v1.8 - Ability ratios are now configurable. A few changes to Barrel Roll, Drunken Rage and Body Slam.

--------- Barrel Roll:
--------- >> Detonation effect size increased. (Just the sfx, not the range)

--------- Drunken Rage:
--------- >> Fixed damage reduction calculation.

--------- Body Slam:
--------- >> Unit Group detection now filters unit inside the group, making it easier to modify targets.

 

@MyPad

Uhh, any new reviews on the spell?

 

A worthy spellpack addition to the Hive's collection of resources.

Approved