Forgotten_Warlord's RPG Combopack v2.3

[Moderator]

17:59, 1st Mar 2011
Bribe:

Permanently rejected because it's full of leaks and conflicts with a lot of other systems, Forgotten_Warlord has made a point he will not update this.

 

[mnib]

looks leakless as for me ^^
+REP

 

[Nightmare Moon]

The Hero Selection system is really nice. I like it, even would like to use if had opportunity. Anyway this is useful and i rate it 5/5.

 

[Forgotten_Warlord]

Any more features you would like to see in an RPG combo pack?
Such as Damage Detect etc. Let me know.

 

[Dr. Boom]

Moin moin =)

=== My personal vote: APPROVAL [4/5] ===

Ok after downloading and testing I got the following review:

First of all I have to say, that I'm surprised. For the last 2 - 3 days nearly only s**t is uploading here ( sorry not all but many stuff ) and now you come up with a good system - I like it. But I have some improvements for you:

1) In the HS Initialization trigger you have a part where you pick up ( all players ) and check if there are users. In this part you should add following triggers:

• Trigger - Add to (Trigger) the event (Player - (Picked player) Presses/release the An Arrow key)

Do this for every trigger, you use those events and delete the events from the these triggers, where you use this event. This will save memory.
( You can do this for any trigger to reduce the value of event triggers )

2) In the trigger "HSRotationLoop" at the beginning you pick up a player group. You should use a player group variable and clear it at the end of the loop with

• Custom script: call DestroyForce(udg_Force)

I know Player force leaks are rar, but they exist and this how you avoid them.

3) In your "XPGain" trigger you pick at second a unit group. When you pick a unit group in any case it's leak. So type this custom script DIRECTLY BEFORE you pick the unit group:

• Custom script: set bj_wantDestroyGroup = true

.
This is easier, else you have to store this unit group into a variable and pick all units from the variable.

Ok that's all for now because don't see anything what can be improved for now. All in all, as I said, I'm surprised and I like your system, so I will give the approval status and [4/5]. Good job! But the thing is it's only 4/5 and I think about 5/5, but somehow I don't know. Maybe this whole system can be improved for the last point, but I don't know now =S

NOTE: My review is nothing against you nor your spell. These are just some points that need to be fixed.

Greetings and Peace
Dr. Boom

 

[Forgotten_Warlord]

Hmmm you know what I dont know why I didnt do that in the first place! I've dont that before damn I'm stupid lol

 

[rcshaggy]

Would be useful for a duel between some heroes and such.

 

[Dr. Boom]

Moin moin =)

Now I know, what could be missing:

First, the "choose system" starts with the paladin. But when I start the map and see the paladin first, the paladin description isn't shown. Also if I use -repick, the system starts with the paladin but the description isn't shown too.

Also, just an idea, how about sounds? That you create a boolean and a sound variable. In the sound variable with array, you store the sound of the hero. Maybe the ready sound or something. Now if someone set the boolean variable to true, the sounds are played and when false, they're not.

Slight note, when the system starts with the paladin, I select him and press up or down, then the selection is removed. Maybe you add something "if unit is selected - then select the new hero too - else not".

Yes that's all and I don't know what there can be improved more only write everything in vJass =D
Joke but I really think to change my 4/5 to 5/5, because I tested it more times and I like it more and more.

Greetings and Peace
Dr. Boom

 

[Forgotten_Warlord]

Well that sounds like a good idea and I'll make it display initial text after like 10 seconds

 

[Khaled]

I think more things usefull for RPG's would be a Damage Detection engine that can show the name of spells as well detecting heals and mana absorbs plus blocks

 

[Spoontoobig]

5/5 ! It's perfect ( I'm about exp system you also should make gold system) !!! Great 5/5 again +REP!

 

[Vlad727]

Usefull for mapmakers who just start with rpg-maps
4/5
+rep

 

[Forgotten_Warlord]

I will definitely add a bounty system as well as damage detect. spell abilities, I can do that too quite easily actually already have all these triggers in my head

 

[Vlad727]

I will definitely add a bounty system as well as damage detect. spell abilities, I can do that too quite easily actually already have all these triggers in my head

If only i could give you a 10 out of 5
cant wait till update

 

[Forgotten_Warlord]

DOnt worry will take me roughly 25 min to add those. Bounty system I might go into depth with though. But just need to get home to my computer to work on it and those will be added. It will be a nice RPG starter pack. I may perfect my old save/load system to it but that would take at least 2 days to recreate it from scratch. Though I guess I could actually make it simpler now that I'm thinking about it in my head while typing I could make the everything a set code, then add a - for code breaks, and add a numeric, alphabetic code scrambler, that goes by integers/variables that correspond with eachother. We'll see, there are already enough save/load systems in the hive that are better than what I can do, most likely.

Edit: Do you guys want Unit names to be color coded? like...
Paladin: Paladin information goes here!

Too late already implemented. if you guys REALLY want me to post the triggers I will but its a pain in the ass

 

[Radamanthis]

Look Awsome!, but can I use it in a multiplayer map? I mean, will it share the experience with the other allied players?

 

[Vlad727]

DOnt worry will take me roughly 25 min to add those. Bounty system I might go into depth with though. But just need to get home to my computer to work on it and those will be added. It will be a nice RPG starter pack. I may perfect my old save/load system to it but that would take at least 2 days to recreate it from scratch. Though I guess I could actually make it simpler now that I'm thinking about it in my head while typing I could make the everything a set code, then add a - for code breaks, and add a numeric, alphabetic code scrambler, that goes by integers/variables that correspond with eachother. We'll see, there are already enough save/load systems in the hive that are better than what I can do, most likely.

Edit: Do you guys want Unit names to be color coded? like...
Paladin: Paladin information goes here!

Too late already implemented. if you guys REALLY want me to post the triggers I will but its a pain in the ass

Well good luck with the Save/Load system
and yeah you should post the triggers.
and it is a good idea to use colour coded names (makes things clearer)

 

[Forgotten_Warlord]

ok well, I'll post them, and yes it is all MUI, if you want it to work for only allied players, make sure you add in a condition for allied to owner of killing unit.

right now its just enemy of triggering unit with in 1200 range.

Cant post the triggers right now cause last night we had an emergency and had to drive to town and i dont have my computer.

Do you guys want it to show hero stats under hero information? or would you prefer if that was just manually imputed into the hero information by the map maker? OR just leave it be

Next update I will have the new triggers up.

Edit: UP TO DATE WITH 2 NEW Features.

 

[baassee]

Is it just me or is the Hero Revival instant? Also the creep system is kinda meh, I'm not a fan of custom values for those purposes (I guess a GUIer would never use an autoindex system but still).

Hero selection is my favourite. Good job.

 

[Forgotten_Warlord]

Yeah, I can add a timer to the revive, but running back and paying gold is penalty enough for rpgs. and yes but I end up adding custom values for other purposes to units anyways including knock back systems etc. I could learn hash tables but that will take some time.

 

[baassee]

Yeah I guess it's enough with just the penalty hashtables isn't that bad actually, just takes alot of time in GUI to click

 

[Forgotten_Warlord]

yeah, when I get a hang of it it will cut my triggers down

 

[Spoontoobig]

Things that I didn't like and bugs:

*Example: Using mirror image got 1 illiusion I kill monster and i get instead 20 XP i get 40 xp ! I get experience from fuckin illiusion
* Then, bounty system bugged as well, gives gold only 1 time Killing first time monster and then it wont give gold anymore
* Then I can see that other players get xp and gold ;( thats totaly sux..
* Dmg Detect system is totaly SPAM of numbers ;(
* Hero choosing system, is it possible to make hero pick somewhere else and when picked move instantly to start zone region ?
* pff... dont remember anymore

Please fix this..

EDIT: OK ( Hero choosing system, is it possible to make hero pick somewhere else and when picked move instantly to start zone region ?) fixed was easy..

 

[Forgotten_Warlord]

Things that I didn't like and bugs:

*Example: Using mirror image got 1 illiusion I kill monster and i get instead 20 XP i get 40 xp ! I get experience from fuckin illiusion
* Then, bounty system bugged as well, gives gold only 1 time Killing first time monster and then it wont give gold anymore
* Then I can see that other players get xp and gold ;( thats totaly sux..
* Dmg Detect system is totaly SPAM of numbers ;(
* Hero choosing system, is it possible to make hero pick somewhere else and when picked move instantly to start zone region ?
* pff... dont remember anymore

Please fix this..

EDIT: OK ( Hero choosing system, is it possible to make hero pick somewhere else and when picked move instantly to start zone region ?) fixed was easy..

Well the start region is a point, so yes you can change it...
and I'll look into the illusion bug
Spam, yes but you can make them fade faster, and with slower attacks or single enemies, it wont spam...
and I havnt had that problem with the bounty system
It only adds XP and Gold if you are Allied. But I'll add more options

 

[Spoontoobig]

But It would be more perfect if you do that floating text will see own player not from all...

 

[Forgotten_Warlord]

well I could try something like that but it usually boots all other players... maybe not for floating texts not sure I'll try.

 

[xorkatoss]

awesome systems man !!
im really glad somebody finally made this !!
+rep from me and 5/5 ;p

i got an idea for mproving your hero selection system
how about when we have a hero selected...
we can press a button or say something like -animations
and a list of animations comes up and we can play his animations
for example, attack, stand, walk, death, spell throw, spell slam and many more ;p
i would appreciate it if you could add this option
(im only giving you ideas, you don't have to if you don't want to ;p)

 

[Forgotten_Warlord]

awesome systems man !!
im really glad somebody finally made this !!
+rep from me and 5/5 ;p

i got an idea for mproving your hero selection system
how about when we have a hero selected...
we can press a button or say something like -animations
and a list of animations comes up and we can play his animations
for example, attack, stand, walk, death, spell throw, spell slam and many more ;p
i would appreciate it if you could add this option
(im only giving you ideas, you don't have to if you don't want to ;p)

Sounds like an interesting idea for a hero viewer, but if someone wants something like that I'll make it custom for them, otherwise it could end up slowing the system down to be so bulky

 

[aki15]

Gonna use EXP system in Goblin Gladiators , but i will edit it a little .... 5/5 !

 

[Forgotten_Warlord]

NP, thats why its a starter pack
All systems are meant to be edited

 

[SexYFrostWyrM]

Very useful, not so hard to understand, to me it will be the base of every RPG map ill make ;-)
+rep

 

[Forgotten_Warlord]

Very useful, not so hard to understand, to me it will be the base of every RPG map ill make ;-)
+rep

Thanks, I'll be upgrading it as time goes on

 

[Vlad727]

Thanks, I'll be upgrading it as time goes on

Could you also make a camera system in wich we are able to see our character, have the real wow rpg feeling, but without the stupid click errors ( that you run back while trying to run forewards
you know what i mean)
That would be really nice

 

[Forgotten_Warlord]

Could you also make a camera system in wich we are able to see our character, have the real wow rpg feeling, but without the stupid click errors ( that you run back while trying to run forewards
you know what i mean)
That would be really nice

Well I've made many camera systems, and the best one is by the_witcher its in VJass, not GUI, but it really is the best. I dont have the best luck with tracking terrain height

 

[Orcnet]

You are definitely called the "Warlord"! you just made a really good system I like it 10/10!

 

[Bribe]

HRHeroDies

Game - Display to (Player group((Owner of (Triggering unit))))

- Leaks

(Owner of (Triggering unit))

- Spammed, store it once into a variable for quick reference.

Creep Respawn

- Custom value of units potentially conflicts with a lot of systems. This needs to use a hashtable instead.

Bounty System

Custom script: call DestroyForce(udg_BSPlayerGroup)

- This isn't a dynamic force (you never re-create it) so destroying it here will cause bugs the next time this action is executed.

You also leak a unit group here, and needlessly "pick all units" twice

DDInitialization

Trigger - Add to DamageDetection <gen> the event (Unit - (Triggering unit) Takes damage)

- This should be placed in the "Else - Actions" part as it wastefully creates an event for a null unit during map initialization.

XPGain

(Picked unit)

- You spam this. You should set that to a variable and use it for quick reference.

HSInitialization

(Picked player)

- You spam this as well.

HSPan Triggers

(Triggering player)

- You spam this as well.

Cinematic - Clear the screen of text messages for (Player group((Triggering player)))
Game - Display to (Player group((Triggering player)))

- Forces leak

HSRotationLoop

You do not need to set (All Players) to a variable, just use it directly.

(Player number of (Picked player))

- You spam this.

HSSelecting

(Player number of (Triggering player))

- Spammed as well.

HSRepicking

(Triggering player) and (Player number) are spammed.

Status: Rejected until updated.

 

[Forgotten_Warlord]

alright man w/e man, and if there are other systems that conflict with the custom values then they wont use that system. keeps it simple. I wont be updating it here so if anyone needs this system just message me.