Chain Frost v2.3 [GUI]

[Moderator]

Chain Frost v2.3 | Reviewed by Maker | 31.12.2014 [COLOR="gray" [COLOR="gray" [COLOR="gray" [COLOR="gray" [COLOR="gray" Concept[/COLOR]] The spell is useful but not original Triggers[/COLOR]] The triggering is quite basic, but does the job. Change the life < 0.41 to unit is not dead boolean. Objects[/COLOR]] Object editor data is a bit unfinished, no much formattion of tooltips and a missing learn hotkey for example. Effects[/COLOR]] You coul've done better with sound effects. There could be some effect when the projectile explodes the last time. Rating[/COLOR]] CONCEPT TRIGGERS OBJECTS EFFECTS RATING STATUS APPROVED

 

[deathismyfriend]

REVIEW

TRIGGER FIXES	Use comment instead of do nothing in this. If (iChainFrostIndex Equal to 0) then do (Trigger - Turn on Chain frost loop <gen>) else do (Do nothing) You should use an ITE instead of removing all units from group using the group creation. It makes it easier to read and edit.
FINAL RATING	Needs Fix

[/TD][/tr]
If you have any questions or problems with my review please tell me. Original Review Template by Doomlord.

 

[Almia]

Do Nothing is actually useless.
It just evaluates an empty function:

function DoNothing takes nothing returns nothing
endfunction

which can also slow up.

It is much better to use comment instead.

 

[deathismyfriend]

Do Nothing is actually useless.
It just evaluates an empty function:

function DoNothing takes nothing returns nothing
endfunction

which can also slow up.

It is much better to use comment instead.

thanks for posting the exact reason.

 

[NightSkyAurora]

You should use an ITE instead of removing all units from group using the group creation.

Are you talking about where I set the group? Then how can I make it choose the correct type of target at the first time using ITE?

 

[Razer!X]

I think he means you should set an appropriate condition or actions to stop the trigger by using ITE, if I'm not wrong.

 

[NightSkyAurora]

Changes are made

 

[deathismyfriend]

store picked unit b4 the ITE and use it in the conditions.

 

[NightSkyAurora]

store picked unit b4 the ITE and use it in the conditions.

Ok I did it

 

[deathismyfriend]

u missed one.

• Unit Group - Remove (Picked unit) from Temp_Group

change this to udg_Temp_Group

• Custom script: call DestroyGroup(GetLastCreatedGroup())

 

[Maker]

Use this, don't have the unit comarison as a condition:
Set Temp__Group = units in range
Remove frostTarget from group
Pick units in Temp_Group
...

Check iChainFrostIndex Equal to 0 only when you deindex
Abilities must support levels
In Stats you could set the ability and dummy unit type

 

[Kazeon]

• Set uChainFrostE[Temp_Int] = uChainFrostE[iChainFrostIndex]
• Unit - Remove uChainFrostE[Temp_Int] from the game

Do you know what are you doin there? It seems a little incorrect for me.

• Set uChainFrostC[iChainFrostIndex] = No unit
  • Set uChainFrostT[iChainFrostIndex] = No unit
  • Set uChainFrostE[iChainFrostIndex] = No unit
  • Set iChainFrostJumps[iChainFrostIndex] = 0

you are wasting time there..

 

[BPower]

you are wasting time there..

You might have a very very small reference leak, if you don't null units even if they are globals (untested).

 

[Maker]

-Leaks TempLoc
-Dummy gives lots of vision
-Remove invulnerability from dummy, it has Locust
-Tooltip is not great
-No importing instructions
-The ability uses spell channel anim, the hero does not have that

 

[Vinz]

I suggest you separate triggers with [/trigger] to make it more readable.

click

• (Life of Temp_unit) Less than 0.41

^That is not enough to check a unit's state.

Click

• Unit - Create 1 Chain frost for (Owner of uChainFrostC[iChainFrostIndex]) at Temp_Point facing Default building facing degrees

You can set the owner to Neutral Passive so the Player end game score isn't affected.

Additionally, the TempPoint3 in the 'Else' (DistanceBetweenPoints) is the same as TempPoint2

Good spell though.

 

[NightSkyAurora]

click

• (Life of Temp_unit) Less than 0.41

^That is not enough to check a unit's state.

Then how should I check if a unit is dead? the "is unit dead" condition is bugged.

Click

• Unit - Create 1 Chain frost for (Owner of uChainFrostC[iChainFrostIndex]) at Temp_Point facing Default building facing degrees

You can set the owner to Neutral Passive so the Player end game score isn't affected.

Thanks, I fixed that

Additionally, the TempPoint3 in the 'Else' (DistanceBetweenPoints) is the same as TempPoint2

Temp_Point2 is the dummy location's offset by speed and Temp_Point3 is the target's location where the effect is displayed. I prefer the effect to show as accurate as possible.

Good spell though.

Thanks Mythic

 

[Hazop / Sarven]

I made The ability non hero and human buuuuut it no work

 

[kirkask]

this spell is nicly done thx for sharing it