V3H's Trick'N'Shoot System V,5

[Moderator]

12th Dec 2015
IcemanBo: For long time as NeedsFix. Rejected.

18th Jul 2011
Maker:
Loop and removal triggers should be turned off when they are not needed.
The projectiles behave in a wrong way near cliffs and hills.
The projectile can spawn above the caster and the collision doesn't really work correctly.
I don't think using "unit comes within range" event is a good choise. It can add some lag, I didn't test that though.
Adding events like that kind of leaks since when the unit is removed from the game, the events are still there.

 

[Nillere]

Hmm, mind posting code?

And a thing that would be nice that i've seen some other projectile systems, is considering the Z and stuff, so, if that could be added, and that you improve things that might need to be improved, this might turn out quite good

 

[88WaRCraFT3]

P O S T T R I G G E R S!
srsly learn that -.-
EDIT: Nillere same time.
BTW: NFWar made this so it's absolutly not original.

 

[Vehster]

Wow, fast reply...

Why must the triggers be posted?
Have you tested the system?
It does consider Z which is flying height at the moment.

NFWar made something similar to this?
I couldn't find that.

 

[88WaRCraFT3]

http://www.hiveworkshop.com/forums/...7856/?prev=search=Bullet%20System&d=list&r=20
This is it. And it means that projectile would move with height of ground, you know projectile with just flying height would move like this .----...---- based on terrain, and with Z Checking it Goes straight ----------

 

[Vehster]

Well it is custom script as well meaning it isn't fully GUI.....
As well it is quite complex by looking at it.

 

[Manasurge]

Not really, changing it would greatly increase your chance of approval on this. It's low from the start considering there's already a better system on hive.

And always post triggers, very few ppl care to download the system to see the triggering.



Edit(Avoiding Double-post):

Well, if there's a better system then people will probably use that and if you don't see many using it then it probably means it's not usefull for the majority of maps.

 

[Vehster]

I hardly care for approval, I care more for helping people on hive.....
I made this to be fully GUI and nothing more, doesn't matter how low it is.
Sure there's better systems but do you see people using them?
It isn't a rule tho, then what use is WC3? I would spend two minutes to check a map instead of reading it on a site...

I will post the code just so if a mod comes by, they can't complain on that reason and reject it for that.
Nice signature Manasurge.

EDIT: I do not know how to post the code...

 

[Bribe]

To steer our discussion back to where it belongs, I'm replying to your visitor message here.

You should use "map initialization" as the init event and remove the wait as well, because if a unit is created within that 1 second it won't get registered by the system.

Setup trigger leaks twice here:

Unit - Create 1 oooo for (Owner of (Damage source)) at wleak[4] facing (Angle from (Position of (Damage source)) to (Position of (Triggering unit)))

>> What do you mean set the string if it has a model art?

You set the effect path to be the string you specified.

It looks like the damage amount also changes, not just the string art. So you want to set both a string and the damage variable, instead of duplicating every line of code. Code duplication in general is very bad practice because it adds to map file size, makes it hard to read and is also horrible to maintain.

You should also avoid using a location variable as an array. If you already know the index of an array (1, 2, 3, 4...) it should just be four variables var1, var2, var3.... Arrays are powerful objects and not to be treated as toys just for convenience (at least not in this case). The in-game execution of a single variable opposed to an array variable is also a big factor.

 

[Vehster]

What Bribe Replied Too

How does my setup trigger leak?

I duplicate my code to allow for body detection...
What do you mean set the string if it has a model art?
The collision is more then just SFX, it makes my system go to a 3D like level.

Why is Map Init better then Time Elapsed? I was told it leaks somewhat and decided to use something else... the wait can't affect anything for it is used last.
So creating it for a player leaks and setting its facing leaks too?
I still don't get where you are trying to say this at....
"You set the effect path to be the string you specified."
It is not just pure duplication, if you can identify the heights better to fit the unit it runs into then please show me, in GUI that is.
I know it adds to file size and horrible to maintain but it isn't that bad to read.
Why avoid making less variables and better compression?
Four variables seem like a waste of space to me, yes arrays are powerful and nice to use if you can use them correctly... They work fine as they are, do they not?
I don't see a difference in the execution of the two.

 

[Adiktuz]

IDK how this can be actually useful or provide an alternate for NFWar's system...

also the action Custom script is a part of GUI so its still GUI... but actually, GUI is just jass afterall...

and please post triggers... but considering that you said that this is FULL GUI, which by your standard does not use any Custom script action (though in reality, everything is changed to CS), then I would expect location leaks or using the move command...

anyway, lets see what will happen after you fix this... ^_^

 

[Vehster]

I umm exclude leaks since nobody has made a GUI equivalent in any new editor yet...

 

[Adiktuz]

arrays are pretty slower than normal variables and take more space... so if ur just using a few indexes, use different variables instead of arrays... you won't probably notice these thing early game, but as game time passes by, you'll more likely to see the effects... or I think, using /fps could actually show some effect early game...

 

[Bribe]

Unit - Create 1 oooo for (Owner of (Damage source)) at wleak[4] facing (Angle from (Position of (Damage source)) to (Position of (Triggering unit)))

The two location leaks here are (Position of (Damage source)) and (Position of (Triggering unit))).

I didn't say to remove the four if-blocks, I know why you have them there, what I am saying is instead of copying the blocks four times over, only set the variables that need to be set (effect path and damage) and put the block at the bottom, so the one block of code will work for any of the four different possibilities that can emerge out of that trigger.

Instead of:

if condition1 then
    //a bunch of stuff
elseif condition2 then
    //a bunch of stuff identical to the last block except with two different things

Turn it into:

if condition1 then
    //Set a couple of things
elseif condition2 then
    //Set a couple of things slightly differently
endif
//a bunch of stuff here that can work with any of those variables

>> I don't see a difference in the execution of the two.

Usually you won't and usually it won't matter, but I have compared the difference between using arrays and no arrays with a very high-speed timer and the speed jump is measureable.

Also, map init does not leak. Whoever told you that either miscommunicated or quoted someone else out of context

 

[Vehster]

Want to prove it that arrays are worse Adiktuz?

Edit: Nevermind.....

 

[Adiktuz]

Bribe is the one who tested that...

 

[Marcos DAB]

You should post triggers.

 

[Vehster]

I don't know how to post triggers so now I won't, anyone else is welcome to post them for me though if you guys really want it that bad, otherwise your stuck with having to download a map.

 

[Adiktuz]

Go to trigger editor, click the trigger, now on the part where you see the events/conds/actions, right click on the trigger name there (the one above the Events), then choose Copy as text, then...


[TRIGGER]
Paste here
[/TRIGGER]

 

[Vehster]

Your welcome to do it.

Otherwise I will do it when I add detection for destructibles/doodads.

 

[Bribe]

http://www.hiveworkshop.com/forums/miscellaneous-tutorials-456/how-easily-post-triggers-163285/

 

[Vehster]

EDIT: I can't figure out how to fix projectile collision.....

Why must map init be used?

It is better then making a generic event and a condition for it to take up extra space for the dummy removal.
How can collision be simplified more?

All the other ands that only had one condition in them were removed though, I had them there by accident

 

[Bribe]

1. Yes you can remove the first.
2. No I don't know everything but thank you for trying to be rude to me.
3. Map init doesn't create as many handles as the timer event.
4. "It is better then making a generic event and a condition for it to take up extra space for the dummy removal."

- Untrue, each time you create a new event it is taking up extra space in memory. When the dummy unit is removed, the event is not destroyed and exists as a memory leak, making this quite flawed.

5. Collision can be simplified by the method I showed you already, by setting a couple of variables and then having the one big block at the bottom.

 

[Midnighters]

Is it sad that I don't believe he made this?

 

[Vehster]

Why don't you believe?

Thanks Bribe, will update when I figure out how to stop projectiles from colliding...

Triggers have been posted.

 

[Midnighters]

Well, I believe you made it slightly more, now that you have figured out how to post triggers.

 

[Arisato]

Why must the triggers be posted?

Not everyone can open up warcraft