The Swarmer v.5

[Moderator]

4 Feb 2012
Bribe: Approved 3/5.

You don't need to check "(ASwarmer_Group is empty) Equal to true" before turning on the trigger, just check if the trigger is off (it is a less-heavy operation to do that).

You can delete this line: "Custom script: call DestroyGroup (udg_ASwarmer_TargetGroup)" because you already destroyed that group with "Custom script: set bj_wantDestroyGroup = true".

 

[Ender]

in your cast trigger you have a leak,

• Unit Group - Pick every unit in Swarmer_Targeting and do (Actions)
• Loop - Actions
• .some actions
• -------- --------
• Set Swarmer_Point[1] = (Position of Swarmer_E1[Swarmer_Int[1]])

you need to put the call RemoveLocation(udg_Swarmer_Point[1]) inside of the pick every units, as it is right now it leaks all but the last point set.

your method for looping through units could be better(but it is pretty good for first spell)
it loops through useless index's, and it is possible for it to hit the maximum array size, with non existent array's(though the latter is unlikely it still could conceivably happen)

 

[mckill2009]

Brief review as Im not testing the map yet;
- I think its better to set "S_Target_HeroOnly==false" if there are no heroes around.
- Never use arrayed variables unless needed, coz its slower than normal ones.
- Owner of (Triggering unit) >>> TriggerPlayer
- You can make a formula for "Set Swarmer_mA[Swarmer_Int[5]] = (Swarmer_A2[Swarmer_Int[5]] + 45.00)"
like this, instead of those elseif's...

• Set Swarmer_mA[Swarmer_Int[5]] = ((Swarmer_A2[Swarmer_Int[5]]) + (level of ability X 30) + 15.00)

- I recommend using Hanky's Dynamic Indexing System, or Bribe's UnitINdexer (I preffer the last)...

 

[Magtheridon96]

Ender is right about those leaks.
You should try using Hanky's Dynamic Indexing because it's much safer and faster than this.

@Ender, trust me, you won't have to worry about hitting the array limit here
No sane person would allow the spell to be cast 8191 times at once ^.^
Still, you're right about the fact that he should update the indexing.
-------

Also:

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • Or - Any (Conditions) are true
      • Conditions
        • Swarmer_Int[3] Equal to 1
        • Swarmer_Int[3] Equal to 2
  • Then - Actions
    • Set Swarmer_mA[Swarmer_Int[5]] = (Swarmer_A2[Swarmer_Int[5]] + (360.00 - (180.00 x (Real(Swarmer_Int[3])))))
  • Else - Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • Swarmer_Int[3] Equal to 3
      • Then - Actions
        • Set Swarmer_mA[Swarmer_Int[5]] = (Swarmer_A2[Swarmer_Int[5]] + 45.00)
      • Else - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • Swarmer_Int[3] Equal to 4
          • Then - Actions
            • Set Swarmer_mA[Swarmer_Int[5]] = (Swarmer_A2[Swarmer_Int[5]] + 75.00)
          • Else - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • Swarmer_Int[3] Equal to 5
              • Then - Actions
                • Set Swarmer_mA[Swarmer_Int[5]] = (Swarmer_A2[Swarmer_Int[5]] + 135.00)
              • Else - Actions
                • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                  • If - Conditions
                    • Swarmer_Int[3] Equal to 6
                  • Then - Actions
                    • Set Swarmer_mA[Swarmer_Int[5]] = (Swarmer_A2[Swarmer_Int[5]] + 165.00)
                  • Else - Actions

The procedural coupling is terrible here :O

It could be this:

• Init
  • Events
    • Map Initialization
  • Conditions
  • Actions
    • Set val[3] = 45.00
    • Set val[4] = 75.00
    • Set val[5] = 135.00
    • Set val[6] = 165.00

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • Or - Any (Conditions) are true
      • Conditions
        • Swarmer_Int[3] Equal to 1
        • Swarmer_Int[3] Equal to 2
  • Then - Actions
    • Set Swarmer_mA[Swarmer_Int[5]] = (Swarmer_A2[Swarmer_Int[5]] + (360.00 - (180.00 x (Real(Swarmer_Int[3])))))
  • Else - Actions
    • Set Swarmer_mA[Swarmer_Int[5]] = (Swarmer_A2[Swarmer_Int[5]] + val[Swarmer_Level[Swarmer_Int[5]]])

 

[Final-Burn]

Its a Great Idea, Just need better executed, I'll give you a...
[broke="4/5 Don't Give up!! +Rep!"]Reveal[/broke]
Oh and also, make the Food Level of the Rockets 0. And if it is over used it lags. Maybe Fix that? Other than that good!

 

[CoLd Bon3]

I don't know if someone mentioned it already, but there is a little problem - the dummies cost food. When you cast the spell many times - you get 'High Upkeep'.

The spell is awesome! Good job! 5/5!

 

[Magtheridon96]

No one downloads and tests spells anymore ^.^
The triggers in the description are enough for most of us

 

[Chuchulain]

Updated 01/31/12.

 

[xorkatoss]

No one downloads and tests spells anymore ^.^
The triggers in the description are enough for most of us

i do lol

ontopic:
the spell is really good but there are some things you could improve so 4/5 for now

what i have in mind:
all cannons target the unit with the lowest hp and it's a waste of cannons if a unit has about 50hp and get's targeted by 6 cannons lol
so what i have in mind is no improve the "intelligence" of the cannons, if unit has low hp that 1 cannon can kill it then only 1 cannon will focus on that unit and the other 5 will focus on another unit, if it requires 2 cannons(depending on dmg dealt by cannons) then only 2 cannons will target that unit and the rest will target other units...
plus another thing ill like to point out, it should first target heroes and then units with low hp, this feature will be very good for dota-like maps IMO

well that's all for now, thnx for wasting your time to read my comment!!;D

 

[CoLd Bon3]

I am too lazy to read the triggers! I turn on a Spell Map. I play with the spell for... lets say 1 hour then i turn off the War3 Editor. And after 30 mins i remember that i wanted to see the triggers of the spell. :X

Sorry for the off-topic post. I felt that i need to post that.

 

[Gen Bloodhorn]

as from the screenshot i say its an awesome idea

 

[maddeem]

I liked it but what I thought that it would break into minis before halfway reaching it's target then hone in. Still good though. And I agree, more intelligent missiles would be very neat.