[Question] Group Leaks

[Dr. Boom]

Seas =)

this only a question for understanding:

I now there are 2 ways of removing group leaks:

• Custom script: set bj_wantDestroyGroup = true

• Custom script: call DestroyGroup(udg_GroupVar)

Know I want ask what is better?

Because everyone say: bj functions are bad? But as I remember isn't blizzard using bj's? So this will mean Blizzard's trigger are bad?

Or you can say"no with set bj_wantDestroyGroup = true it's different? But why it would be different at this point?

Or you think the 2nd way is better - but for this you need a variable - and if use this maybe 100 times - is this bad aswell or no problem?

 

[Maker]

bj_wantDestroyGroup is faster according to what I've heard.

But it destroys the group immediatley after it has been used, that's why the other way is required in some cases.

 

[The Reborn Devil]

Yes, bj_wantDestroyGroup removes the group immediately after you run the "pick every ..."
The "Pick every.." function is called ForGroupBJ in JASS and here is the definition of it:

function ForGroupBJ takes group whichGroup, code callback returns nothing
    // If the user wants the group destroyed, remember that fact and clear
    // the flag, in case it is used again in the callback.
    local boolean wantDestroy = bj_wantDestroyGroup
    set bj_wantDestroyGroup = false

    call ForGroup(whichGroup, callback)

    // If the user wants the group destroyed, do so now.
    if (wantDestroy) then
        call DestroyGroup(whichGroup)
    endif
endfunction

 

[TriggerHappy]

So yea, it is faster but only works in GUI scenarios, unless you want to use ForGroupBJ in Jass.

 

[Dr. Boom]

Seas =)

Ok you say it's faster but I think I don't understand this "faster". If I use "bj_wantDestroyGroup = true" it destroy the group immediately after I run "pick every..."

But if I use "call DestroyGroup(udg_GroupVar)" - I know there are some actions before but there is no wait - or all those actions happen at the same time - so this isn't "faster" (?)

 

[TriggerHappy]

The first one is faster, but not by anything noticeable or by any speed that matters.
Though the first option allows you to not have to store the group into a variable.

So, just use the first option.

 

[baassee]

Hey isn't destroy group faster? as the first calls it? wouldnt it be faster doing the destroy?

 

[PurgeandFire]

Hey isn't destroy group faster? as the first calls it? wouldnt it be faster doing the destroy?

I'd assume so since they both lead to calling the DestroyGroup() func. Not that it really matters though, they are pretty even in terms of optimization and it won't really have an impact on your code.

But I'd suggest using DestroyGroup() for the most part since bj_wantDestroy is situational in the fact that it'll immediately be destroyed after ForGroup(). But all-in-all, it isn't something to really worry about.

 

[Dr Super Good]

call DestroyGroup(group)
...is the only way to destroy groups. Any others are high level interfaces to this native (the variable set thing) or not true.