Simple group leak question....

[sephiroth1234]

Does this way also clear the leak?

• Trigger
  • Events
  • Conditions
  • Actions
    • Unit Group - Pick every unit in (Playable map area) and do actions
      • MY ACTIONS
    • Custom script: set bj_wantDestroyGroup = true

Or this is the only proper way?

• Trigger
  • Events
  • Conditions
  • Actions
    • Custom script: set bj_wantDestroyGroup = true
    • Unit Group - Pick every unit in (Playable map area) and do actions
      • MY ACTIONS

 

[BoneBreaker]

I would do this instead:

• someTrigger
  • Events
  • Conditions
  • Actions
    • Set someGroup = (Units in (Playable map area))
    • Unit Group - Pick every unit in someGroup and do (Actions)
      • Loop - Actions
    • Custom script: call DestroyGroup(udg_someGroup)

 

[sephiroth1234]

No. I already know that.... I want to use set bj_wantDestroyGroup = true action to save performance and I only used the group one time.

 

[BoneBreaker]

In that case, the first trigger you posted won't work, and the second one will.

If you want to save performance avoid using GUI as it uses ForGroupBJ which is a stupid function.

 

[sephiroth1234]

I am not that experienced in Jass/vJass duh! I want to destroy the group dynamically through GUI.

 

[Pharaoh_]

There is not much of a difference between what BoneBreaker suggested and the second trigger you posted (because, like BoneBreaker said, the first one won't do anything). There are two things to consider:
• bj_wantDestroyGroup = true will destroy the first unit group created right after its use.
• The bj_wantDestroyGroup = true doesn't cause extra leak than the variable method (BoneBreaker's post), they clear the leak normally. I mostly use this method, so that I don't create unit group variables, but that's just me. ;]

 

[sephiroth1234]

So that means it is okay to put the custom script line below the group?

 

[Maker]

So that means it is okay to put the custom script line below the group?

If you use wantDestroyGroup, it must be before the unit group pick.

 

[MortAr]

For set bj_wantDestroyGroup = true is for ONE UNIT GROUP in that map
But MOST map have MORE than 1 Unit Group usage LoL
So, a call DestroyGroup(udg_Group) is strongly advised

Sense - you make none.

 

[Pharaoh_]

Yeah, hah.

defskull, that's not how bj_wantDestroyGroup works, I thought you realised it, when I told you about it.

Whenever you create a unit group (and you don't want a variable for that group), just add this line above the Unit group action: Custom script: set bj_wantDestroyGroup = true and it will clean the leak right after the Unit Group action.
You can use it for infinite amount of Unit Group picks, not just one.

What you should know is that this action:

• Unit Group - Pick every unit in (Units in (Playable Map Area)) and do (Actions)

internally picks a random generated unit group variable to count those units, defined in the Unit Group action (in this case, the units in Playable Map Area). When there is no leak removal (call DestroyGroup()), the leak will restrain that bit of memory used to create that random internally-generated group. So, the line "set bj_wantDestroyGroup = true" is actually a boolean which orders the next memory leak of a unit group to be destroyed.