Question about Leaks (Unit Group)

[chilla_killa]

Am I using the custom script right, so my trigger doesn't leak?

• Campfire Burn Off
  • Events
    • Time - Every 10.00 seconds of game time
  • Conditions
  • Actions
    • Custom script: set bj_wantDestroyGroup = true
    • Unit Group - Pick every unit in (Units of type Campfire (Fire)) and do (Actions)
      • Loop - Actions
        • Unit - Set mana of (Picked unit) to ((Mana of (Picked unit)) - 10.00)

 

[tjordell]

Yeah it works ^^. You can also, if you want, add the unit group into a variable and store it vefore using it and the after you can destroy it, but since that is just a safe way to make spells, you can use this easy way and pretty safe also (you're saving memory cuz the variable don't need to be created and you can have shorter trigger), so use this way you're using it now ^^.

 

[chilla_killa]

Thanks +rep
EDIT: Sorry can't give it to you now, I have given out to much reputation in the last 24 hours.
I will give you tommorow.

 

[Berb]

Actually that isn't true. This is the function he is referencing in his trigger:

function GetUnitsOfTypeIdAll takes integer unitid returns group
    local group   result = CreateGroup()
    local group   g      = CreateGroup()
    local integer index

    set index = 0
    loop
        set bj_groupEnumTypeId = unitid
        call GroupClear(g)
        call GroupEnumUnitsOfPlayer(g, Player(index), filterGetUnitsOfTypeIdAll)
        call GroupAddGroup(g, result)

        set index = index + 1
        exitwhen index == bj_MAX_PLAYER_SLOTS
    endloop
    call DestroyGroup(g)

    return result
endfunction

As you can see, bj_wantDestroyGroup is not factored in here, so the group will need to be destroyed manually via custom script. This function also leaks a variable reference of type group, it would seem (nothing you can do about that).

native DestroyGroup takes group whichGroup returns nothing

 

[Tiche3]

Maybe try doing something like this

• Events:
  • Time - Every 10.00 Seconds of the game time
• Conditions:
• Actions:
  • Set Campfire_Units=Unit in Campfire <gen>
  • Unit Group - Pick every units in (Campfire_Units) and do (actions):
    • Unit - Set Mana of (Picked Unit) to (Mana of Picked Unit) - 10
  • Custom Script: call DestroyGroup(udg_Campfire_Units)

 

[Justify]

Actually that isn't true. This is the function he is referencing in his trigger:

function GetUnitsOfTypeIdAll takes integer unitid returns group
    local group   result = CreateGroup()
    local group   g      = CreateGroup()
    local integer index

    set index = 0
    loop
        set bj_groupEnumTypeId = unitid
        call GroupClear(g)
        call GroupEnumUnitsOfPlayer(g, Player(index), filterGetUnitsOfTypeIdAll)
        call GroupAddGroup(g, result)

        set index = index + 1
        exitwhen index == bj_MAX_PLAYER_SLOTS
    endloop
    call DestroyGroup(g)

    return result
endfunction

As you can see, bj_wantDestroyGroup is not factored in here, so the group will need to be destroyed manually via custom script. This function also leaks a variable reference of type group, it would seem (nothing you can do about that).

native DestroyGroup takes group whichGroup returns nothing

Wrong. You shouldn't look for group creation but the ForGroupBJ! It doesn't matter how the enum function works.

function ForGroupBJ takes group whichGroup, code callback returns nothing
    // If the user wants the group destroyed, remember that fact and clear
    // the flag, in case it is used again in the callback.
    local boolean wantDestroy = bj_wantDestroyGroup
    set bj_wantDestroyGroup = false

    call ForGroup(whichGroup, callback)

    // If the user wants the group destroyed, do so now.
    if (wantDestroy) then
        call DestroyGroup(whichGroup)
    endif
endfunction

 

[Berb]

Awww!!! I was like "there's no way its in the ForGroupBJ - mind you I think that was posted at like 4AM last night so I was probably dead-tired.