[Trigger] Unit Group doesn't leak?

[xorkatoss]

Alright guys so I'm like 90% sure this doesn't leak but I wanted to have the opinions of others just to be sure.

Spoiler: GUI

• Power of Darkness loop
  • Events
    • Time - Every 6.00 seconds of game time
  • Conditions
  • Actions
    • Unit Group - Pick every unit in PowerOfDarkness_Group and do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • ((Picked unit) is alive) Equal to True
          • Then - Actions
            • Set VariableSet Local_p1 = (Position of (Picked unit))
            • Unit - Create 1 Dark Orb for (Owner of (Picked unit)) at Local_p1 facing Default building facing degrees
            • Unit - Add a 6.00 second Generic expiration timer to (Last created unit)
            • Custom script: call RemoveLocation(udg_Local_p1)
          • Else - Actions

Every 6 seconds it picks all units in the unit group and spawns a dark orb at their position, by logic the unit group doesn't leak because it's being used every 6 seconds.

It's not used for once and then forgotten. (therefore leak)

A simple workout to this would be to just use:

• Set VariableSet PowerOfDarkness_Group = (Units in (Playable map area) matching ((Unit-type of (Matching unit)) Equal to Warden))

and then destroy the unit group when finished.

So is my trigger ok or does it leak?

 

[FUJI]

I don't think so... where did you set that unit group variable anyway?

Regardless, as long you're done referencing with the variable it should be destroyed based on how many you've created. In your case, only one unit group is generated and you used it for enumerating only. Therefore, it should be destroyed once you're done using it.

 

[Dr Super Good]

As long as the same group object is reused constantly there is no leak.

 

[Pyrogasm]

I don’t think you understand what a leak actually is. It’s when you create some object (point, effect, group, etc.) and no longer need to use it but don’t destroy/remove the object. The concept of a “leak” is that it’s memory allocated for that object that doesn’t need to be used any more, but you don’t destroy it. If you then overwrite the variable referring to it the object is permanently allocated and can never be removed.

 

[xorkatoss]

@jakeZinc in a different trigger I add/remove units to that group, this was just the loop trigger
@Dr Super Good awesome thanks!
@Pyrogasm yes I know what a leak is lol...I just wanted to be sure