Periodic damage trigger not working

[ZiGOR]

Hi everyone! In my map I'm workin with kind of "ability power for heroes" and I faced such a problem with periodic damage:
For example - Shadow Strike:

• Events
• Unit - A unit starts the effect of an ability
• Conditions
• (Ability being cast) Equal to Shadow Strike
• Actions
• Unit - Cause (Casting unit) to damage (Target unit of ability being cast), dealing ((Real(Agility of (Casting unit)(include bonuses) x 0.5) damage of type Spells and damage type Shadow Strike
• Wait 1.00 seconds
• Unit - Cause (Casting unit) to damage (Target unit of ability being cast), dealing ((Real(Agility of (Casting unit)(include bonuses) x 0.5) damage of type Spells and damage type Shadow Strike
• Wait 1.00 seconds

... and 8 times such a way...

But it strikes only 1 time, and I need it to strike 8 times, why it doesn't work?

Than i tried to create dummy to strike target... no progress...
What should I do?

 

[WaterKnight]

The event response Casting Unit is probably cleared after the first wait, save it in another way.

 

[ZiGOR]

The event response Casting Unit is probably cleared after the first wait, save it in another way.

what way?
Like Variable "Shadow_Strike_Caster"?
I tried to do it, but it still doesn't work... I think it's "Wait 1.00 seconds" problem, how to manage it?

 

[WaterKnight]

For example. A single global variable restricts you to only one instance of this trigger simultaneously though. If another unit casts the same ability while the first has not finished, it will get into conflict.

Do the same with Target unit of ability being cast btw.

 

[ZiGOR]

For example. A single global variable restricts you to only one instance of this trigger simultaneously though. If another unit casts the same ability while the first has not finished, it will get into conflict.

Do the same with Target unit of ability being cast btw.

What about Picked unit in some group matching conditions?

 

[WaterKnight]

Waits do not work in ForGroup blocks. They cancel the iteration. Otherwise, Picked unit is local and safe. There are only some issues with the casting event responses.

 

[ZiGOR]

Waits do not work in ForGroup blocks. They cancel the iteration. Otherwise, Picked unit is local and safe. There are only some issues with the casting event responses.

and how can I set periodic trigger damage then?

 

[F1ashB0nd]

• Events
  • Unit - A unit starts the effect of an ability
• Conditions
  • (Ability being cast) Equal to Shadow Strike
• Actions
  • Custom script: local unit udg_Caster = GetTriggerUnit()
  • Custom script: local unit udg_Target = GetSpellTargetUnit()
  • Unit - Cause Caster to damage Target, dealing ((Real(Agility of Caster(include bonuses) x 0.5) damage of type Spells and damage type Shadow Strike
  • Wait 1.00 seconds...etc x8
  • ---Insert the below code at the end---
  • set udg_Caster = null
  • set udg_Target = null

this should make it MUI
you need to have two GUI unit variables called "Target" and "Caster"

Local variables are used first. If there are two variables of the same name, the compiler would use the local variable first.

Like WaterKnight said, you can't include waits in unit group actions. Nothing will work if you do.

EDIT: If there are two variables of the same name, [highlight]one local and one global[/code], the compiler would use the local variable first.

 

[ZiGOR]

So you want to say that there is no way to deal periodic damage to units in AoE that enters to Unit Group??

 

[ZiGOR]

I understood a little how to trigger spells to 1 target, but how to trigger, for example, Flame Strike, the Bloodmage ability? that deals periodic damage in AoE?

 

[F1ashB0nd]

There is, you can use timers instead, but that would require some cumbersome work. (To me, that is)

EDIT: I will give you an example in a while.

 

[ZiGOR]

There is, you can use timers instead, but that would require some cumbersome work. (To me, that is)

EDIT: I will give you an example in a while.

I will patiently wait!)

 

[WaterKnight]

You can use a For Each Integer-loop and put the ForGroup-block and Wait action inside. After all, you do not want to pick one target every second of that group but pick all targets in that group every second. You should however also localize the iteration variables for it to be MI.

 

[ZiGOR]

You can use a For Each Integer-loop and put the ForGroup-block and Wait action inside. After all, you do not want to pick one target every second of that group but pick all targets in that group every second. You should however also localize the iteration variables for it to be MI.

I hardly understand what you say

In my "Flame Strike" ability I use Flame_Strike_Group as UnitGroup matching conditions that units are in some distance from target point of ability being cast and then pick every unit in Flame_Strike_Group and do actions: cause casting unit to damage picked unit dealing damage multiplied to his Int, but it have to damage 3 times for 1 second, so it strikes only 1 time... that's the problem.

 

[WaterKnight]

• Events
  • Unit - A unit starts the effect of an ability
• Conditions
  • (Ability being cast) Equal to Shadow Strike
• Actions
  • Custom script: local unit udg_Caster = GetTriggerUnit()
  • Custom script: local unit udg_Target = GetSpellTargetUnit()
  • Custom script: local integer bj_forLoopAIndex
  • Custom script: local integer bj_forLoopAIndexEnd
  • For each (Integer A) from 1 to 8, do (Actions)
    • Loop - Actions
      • Unit Group - Pick every unit in <group> and do (Actions)
        • Loop - Actions
          • Unit - Cause Caster to damage (Picked unit), dealing ((Real(Agility of Caster(include bonuses) x 0.5) damage of type Spells and damage type Shadow Strike
      • Wait 1.00 seconds
  • Set Caster = No Unit
  • Set Target = No Unit

I do not really like the idea of overshadowing global variables though. That was not well supported in the past, do not know how it is nowadays.

 

[ZiGOR]

• Events
  • Unit - A unit starts the effect of an ability
• Conditions
  • (Ability being cast) Equal to Shadow Strike
• Actions
  • Custom script: local unit udg_Caster = GetTriggerUnit()
  • Custom script: local unit udg_Target = GetSpellTargetUnit()
  • Custom script: local integer bj_forLoopAIndex
  • Custom script: local integer bj_forLoopAIndexEnd
  • For each (Integer A) from 1 to 8, do (Actions)
    • Loop - Actions
      • Unit Group - Pick every unit in <group> and do (Actions)
        • Loop - Actions
          • Unit - Cause Caster to damage (Picked unit), dealing ((Real(Agility of Caster(include bonuses) x 0.5) damage of type Spells and damage type Shadow Strike
      • Wait 1.00 seconds
  • Set Caster = No Unit
  • Set Target = No Unit

I do not really like the idea of overshadowing global variables though. That was not well supported in the past, do not know how it is nowadays.

does it work for AoE abilities?

 

[F1ashB0nd]

This will be very messy to you, but I am using dynamic indexing to make this flame strike, so here you go, an advanced version.

Flame Strike

• FlameStrike Cast
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Flame Strike
  • Actions
    • Set FlameStrike_CurrentIndex = (FlameStrike_CurrentIndex + 1)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • FlameStrike_CurrentIndex Greater than FlameStrike_MaxIndex
      • Then - Actions
        • Set FlameStrike_Index[FlameStrike_CurrentIndex] = FlameStrike_CurrentIndex
        • Set FlameStrike_MaxIndex = FlameStrike_CurrentIndex
      • Else - Actions
    • Set FlameStrike_Temp = FlameStrike_Index[FlameStrike_CurrentIndex]
    • Set FlameStrike_Loc[FlameStrike_Temp] = (Target point of ability being cast)
    • Set FlameStrike_Caster[FlameStrike_Temp] = (Triggering unit)
    • Set FlameStrike_Duration[FlameStrike_Temp] = 2.00
    • Special Effect - Create a special effect at FlameStrike_Loc[FlameStrike_Temp] using Objects\Spawnmodels\Human\HCancelDeath\HCancelDeath.mdl
    • Special Effect - Destroy (Last created special effect)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (FlameStrike Loop <gen> is on) Equal to False
      • Then - Actions
        • Trigger - Turn on FlameStrike Loop <gen>
      • Else - Actions

• FlameStrike Loop
  • Events
    • Time - Every 0.10 seconds of game time
  • Conditions
  • Actions
    • For each (Integer FlameStrike_Loop) from 1 to FlameStrike_CurrentIndex, do (Actions)
      • Loop - Actions
        • Set FlameStrike_Temp = FlameStrike_Index[FlameStrike_Loop]
        • Custom script: set bj_wantDestroyGroup = true
        • Unit Group - Pick every unit in (Units within 200.00 of FlameStrike_Loc[FlameStrike_Temp] matching ((((Matching unit) is A structure) Equal to False) and (((Matching unit) is alive) Equal to True))) and do (Actions)
          • Loop - Actions
            • Unit - Cause FlameStrike_Caster[FlameStrike_Temp] to damage (Picked unit), dealing (50.00 / 10.00) damage of attack type Spells and damage type Fire
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • FlameStrike_Duration[FlameStrike_Temp] Less than or equal to 0.00
          • Then - Actions
            • Custom script: call RemoveLocation(udg_FlameStrike_Loc[udg_FlameStrike_Temp])
            • Set FlameStrike_Index[FlameStrike_Loop] = FlameStrike_Index[FlameStrike_CurrentIndex]
            • Set FlameStrike_Index[FlameStrike_CurrentIndex] = FlameStrike_Temp
            • Set FlameStrike_CurrentIndex = (FlameStrike_CurrentIndex - 1)
            • Set FlameStrike_Loop = (FlameStrike_Loop - 1)
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • FlameStrike_CurrentIndex Equal to 0
              • Then - Actions
                • Trigger - Turn off (This trigger)
              • Else - Actions
          • Else - Actions
            • Set FlameStrike_Duration[FlameStrike_Temp] = (FlameStrike_Duration[FlameStrike_Temp] - 0.10)

EDIT: here is the attachment

 

[WaterKnight]

You initially wrote to damage Target unit of ability being cast only, which is why it was strange that you mentioned ForGroup then. You can pick your group like you want. Maybe it even makes sense to store the group in a variable beforehand to ensure you always pick the same units. When you want to pick around a location e.g. the affected units could change otherwise. If you want to use Target point of ability being cast, that should also be saved.

• Events
  • Unit - A unit starts the effect of an ability
• Conditions
  • (Ability being cast) Equal to Shadow Strike
• Actions
  • Custom script: local unit udg_Caster = GetTriggerUnit()
  • Custom script: local unit udg_Target = GetSpellTargetUnit()
  • Custom script: local location udg_TargetPoint = GetSpellTargetLoc()
  • Custom script: local integer bj_forLoopAIndex
  • Custom script: local integer bj_forLoopAIndexEnd
  • Custom script: local group udg_YourGroup
  • Set YourGroup = pick units...
  • For each (Integer A) from 1 to 8, do (Actions)
    • Loop - Actions
      • Unit Group - Pick every unit in YourGroup and do (Actions)
        • Loop - Actions
          • Unit - Cause Caster to damage (Picked unit), dealing ((Real(Agility of Caster(include bonuses) x 0.5) damage of type Spells and damage type Shadow Strike
      • Wait 1.00 seconds
  • Set Caster = No Unit
  • Set Target = No Unit
  • Custom script: call RemoveLocation(udg_TargetPoint)
  • Custom script: set udg_TargetPoint = null

And yes, as you can see, it is quite a frequent practice to require local variables, which GUI does not allow.

 

[ZiGOR]

This will be very messy to you, but I am using dynamic indexing to make this flame strike, so here you go, an advanced version.

Flame Strike

• FlameStrike Cast
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Flame Strike
  • Actions
    • Set FlameStrike_CurrentIndex = (FlameStrike_CurrentIndex + 1)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • FlameStrike_CurrentIndex Greater than FlameStrike_MaxIndex
      • Then - Actions
        • Set FlameStrike_Index[FlameStrike_CurrentIndex] = FlameStrike_CurrentIndex
        • Set FlameStrike_MaxIndex = FlameStrike_CurrentIndex
      • Else - Actions
    • Set FlameStrike_Temp = FlameStrike_Index[FlameStrike_CurrentIndex]
    • Set FlameStrike_Loc[FlameStrike_Temp] = (Target point of ability being cast)
    • Set FlameStrike_Caster[FlameStrike_Temp] = (Triggering unit)
    • Set FlameStrike_Duration[FlameStrike_Temp] = 2.00
    • Special Effect - Create a special effect at FlameStrike_Loc[FlameStrike_Temp] using Objects\Spawnmodels\Human\HCancelDeath\HCancelDeath.mdl
    • Special Effect - Destroy (Last created special effect)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (FlameStrike Loop <gen> is on) Equal to False
      • Then - Actions
        • Trigger - Turn on FlameStrike Loop <gen>
      • Else - Actions

• FlameStrike Loop
  • Events
    • Time - Every 0.10 seconds of game time
  • Conditions
  • Actions
    • For each (Integer FlameStrike_Loop) from 1 to FlameStrike_CurrentIndex, do (Actions)
      • Loop - Actions
        • Set FlameStrike_Temp = FlameStrike_Index[FlameStrike_Loop]
        • Custom script: set bj_wantDestroyGroup = true
        • Unit Group - Pick every unit in (Units within 200.00 of FlameStrike_Loc[FlameStrike_Temp] matching ((((Matching unit) is A structure) Equal to False) and (((Matching unit) is alive) Equal to True))) and do (Actions)
          • Loop - Actions
            • Unit - Cause FlameStrike_Caster[FlameStrike_Temp] to damage (Picked unit), dealing (50.00 / 10.00) damage of attack type Spells and damage type Fire
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • FlameStrike_Duration[FlameStrike_Temp] Less than or equal to 0.00
          • Then - Actions
            • Custom script: call RemoveLocation(udg_FlameStrike_Loc[udg_FlameStrike_Temp])
            • Set FlameStrike_Index[FlameStrike_Loop] = FlameStrike_Index[FlameStrike_CurrentIndex]
            • Set FlameStrike_Index[FlameStrike_CurrentIndex] = FlameStrike_Temp
            • Set FlameStrike_CurrentIndex = (FlameStrike_CurrentIndex - 1)
            • Set FlameStrike_Loop = (FlameStrike_Loop - 1)
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • FlameStrike_CurrentIndex Equal to 0
              • Then - Actions
                • Trigger - Turn off (This trigger)
              • Else - Actions
          • Else - Actions
            • Set FlameStrike_Duration[FlameStrike_Temp] = (FlameStrike_Duration[FlameStrike_Temp] - 0.10)

EDIT: here is the attachment

It seems to me that there are minimum a half of superfluous code ^^,

 

[ZiGOR]

You initially wrote to damage Target unit of ability being cast only, which is why it was strange that you mentioned ForGroup then. You can pick your group like you want. Maybe it even makes sense to store the group in a variable beforehand to ensure you always pick the same units. When you want to pick around a location e.g. the affected units could change otherwise. If you want to use Target point of ability being cast, that should also be saved.

• Events
  • Unit - A unit starts the effect of an ability
• Conditions
  • (Ability being cast) Equal to Shadow Strike
• Actions
  • Custom script: local unit udg_Caster = GetTriggerUnit()
  • Custom script: local unit udg_Target = GetSpellTargetUnit()
  • Custom script: local location udg_TargetPoint = GetSpellTargetLoc()
  • Custom script: local integer bj_forLoopAIndex
  • Custom script: local integer bj_forLoopAIndexEnd
  • Custom script: local group udg_YourGroup
  • Set YourGroup = pick units...
  • For each (Integer A) from 1 to 8, do (Actions)
    • Loop - Actions
      • Unit Group - Pick every unit in YourGroup and do (Actions)
        • Loop - Actions
          • Unit - Cause Caster to damage (Picked unit), dealing ((Real(Agility of Caster(include bonuses) x 0.5) damage of type Spells and damage type Shadow Strike
      • Wait 1.00 seconds
  • Set Caster = No Unit
  • Set Target = No Unit
  • Custom script: call RemoveLocation(udg_TargetPoint)
  • Custom script: set udg_TargetPoint = null

And yes, as you can see, it is quite a frequent practice to require local variables, which GUI does not allow.

Why do you use for integer???

 

[WaterKnight]

To repeat the block within 8 times.

 

[F1ashB0nd]

You can not use waits in groups, so an easy walkaround would be using a loop.
You save the data of the caster and the target point in a local variable, and then use loops to pick units in range of the saved location, damage them, wait 1 second, and repeat until the loop ends.

 

[ZiGOR]

What's rong do I have here?:
View attachment Flame Strike ZiGOR Int Damage.w3x

 

[ZiGOR]

Wht's the difference between
local unit udg_Flame_Strike_Caster = GetTriggerUnit()
and
Set Flame_Strike_Caster = Triggering unit
???

 

[F1ashB0nd]

your global variable, Flame_Strike_Caster, in jass, is udg_Flame_Strike_Caster.

declaring a local variable udg_Flame_Strike_Caster will cause the map to use the local variable instead of the global variable. By doing this, GUI functions are also able to use the local variable, which is Flame_Strike_Caster in GUI.

For example,
you declare a global variable Integer and set its default value to 5.
you declare a local variable udg_Integer and set its value to 10.
In the same function with the declared local variable udg_Integer, udg_Integer will return 10. Outside the function however, udg_Integer returns 5.

Also,

• Set Flame_Strike_Caster = (Triggering Unit)

is equal to set udg_Flame_Strike_Caster = GetTriggerUnit()

 

[ZiGOR]

your global variable, Flame_Strike_Caster, in jass, is udg_Flame_Strike_Caster.

declaring a local variable udg_Flame_Strike_Caster will cause the map to use the local variable instead of the global variable. By doing this, GUI functions are also able to use the local variable, which is Flame_Strike_Caster in GUI.

For example,
you declare a global variable Integer and set its default value to 5.
you declare a local variable udg_Integer and set its value to 10.
In the same function with the declared local variable udg_Integer, udg_Integer will return 10. Outside the function however, udg_Integer returns 5.

Also,

• Set Flame_Strike_Caster = (Triggering Unit)

is equal to set udg_Flame_Strike_Caster = GetTriggerUnit()

Why can't I use global variable?

 

[ZiGOR]

Can you tell me what mistake I did here?

What's rong do I have here?:
View attachment 115392

 

[F1ashB0nd]

• For each (Integer A) from 1 to 3, do (Actions)
  • Loop - Actions
    • Unit Group - Pick every unit in Flame_Strike_Group and do (Actions)
      • Loop - Actions
        • Unit - Cause Flame_Strike_Caster to damage (Picked unit), dealing (((Real((Intelligence of Flame_Strike_Caster (Include bonuses)))) x 1.25) + 0.00) damage of attack type Spells and damage type Fire
        • Wait 0.20 seconds

As you can see, the wait is inside the unit group. You should make it like this:

• For each (Integer A) from 1 to 3, do (Actions)
  • Loop - Actions
    • Unit Group - Pick every unit in Flame_Strike_Group and do (Actions)
      • Loop - Actions
        • Unit - Cause Flame_Strike_Caster to damage (Picked unit), dealing (((Real((Intelligence of Flame_Strike_Caster (Include bonuses)))) x 1.25) + 0.00) damage of attack type Spells and damage type Fire
    • Wait 0.20 seconds

 

[ZiGOR]

• For each (Integer A) from 1 to 3, do (Actions)
  • Loop - Actions
    • Unit Group - Pick every unit in Flame_Strike_Group and do (Actions)
      • Loop - Actions
        • Unit - Cause Flame_Strike_Caster to damage (Picked unit), dealing (((Real((Intelligence of Flame_Strike_Caster (Include bonuses)))) x 1.25) + 0.00) damage of attack type Spells and damage type Fire
        • Wait 0.20 seconds

As you can see, the wait is inside the unit group. You should make it like this:

• For each (Integer A) from 1 to 3, do (Actions)
  • Loop - Actions
    • Unit Group - Pick every unit in Flame_Strike_Group and do (Actions)
      • Loop - Actions
        • Unit - Cause Flame_Strike_Caster to damage (Picked unit), dealing (((Real((Intelligence of Flame_Strike_Caster (Include bonuses)))) x 1.25) + 0.00) damage of attack type Spells and damage type Fire
    • Wait 0.20 seconds

it has no infuince to damage. there is still no damage))) check it out)))

 

[F1ashB0nd]

There is another problem. ForGroup runs on another function, which means the local unit udg_Flame_Strike_Caster's data will not reach there. I have fixed it for you.

 

[ZiGOR]

There is another problem. ForGroup runs on another function, which means the local unit udg_Flame_Strike_Caster's data will not reach there. I have fixed it for you.

I can't see difference) what did you change?)))
I checked it and still no damage from Flame Strike... can't get whass rong((((

 

[F1ashB0nd]

Maybe i have given the original one by accident. let me reattach it again.

edit
There is nothing wrong with the map, plus it has a very visible change. Maybe you loaded the original one instead?
By the way, my Warcraft III version is 1.24b, and i found out that the spell will glitch in 1.21b.

 

[ZiGOR]

Maybe i have given the original one by accident. let me reattach it again.

edit
There is nothing wrong with the map, plus it has a very visible change. Maybe you loaded the original one instead?
By the way, my Warcraft III version is 1.24b, and i found out that the spell will glitch in 1.21b.

What do you mean?
and yes, now it's realy changed)

 

[ZiGOR]

Why did you create LOOPER variable? it doesn't use anywhere)

I don't complete understand such manoeuvre like Caster2 = Caster
could you please explain what it gave and why?

And one more moment: do you know why Flame Strike's triggered damage damages caster??

 

[ZiGOR]

F1ashB0nd, before you left this topic, could you also help me to manage Acid Bomb ability the same way? Feature of this spell is that it periodically damages tagreted unit of ability being cast and all units in AoE around Target unit of ability being cast ^^

 

[F1ashB0nd]

Why did you create LOOPER variable? it doesn't use anywhere

I forgot to delete it. It was for testing purposes.

I don't complete understand such manoeuvre like Caster2 = Caster
could you please explain what it gave and why?

I need a global variable to temporarily store the data of Caster (since Caster is local, i cannot transfer the data to another function)
So, i created another global called Caster2 which stores the data of Caster to be used in the ForGroup function.

And one more moment: do you know why Flame Strike's triggered damage damages caster??

Add the condition in Unit Group: (Matching Unit) not equal to Flame_Strike_Caster

 

[ZiGOR]

Add the condition in Unit Group: (Matching Unit) not equal to Flame_Strike_Caster

I added, but he still damages himself and allies

 

[F1ashB0nd]

Here is the slightly altered version of Flame Strike known as Acid Bomb. You will need to add a delay before the effect happens, because the unit will already take damage before the missile touches it. You should consult others to help you as I will be absent for more than 12 hours starting from now. Good Luck in your progress!

You should also add in special effects or the spell would look really blank.

 

[ZiGOR]

Here is the slightly altered version of Flame Strike known as Acid Bomb. You will need to add a delay before the effect happens, because the unit will already take damage before the missile touches it. You should consult others to help you as I will be absent for more than 12 hours starting from now. Good Luck in your progress!

You should also add in special effects or the spell would look really blank.

Don't leave me alone! you didn't help me to fix Flame Strike yet((((

First of all - this Acid Bomb damages Caster again and buildings and it has not right damage delay)))

 

[F1ashB0nd]

Don't worry, i still had a little time to fix FlameStrike for you.

 

[ZiGOR]

nothing left but to leave my Acid Bomb to damage primary target only...

 

[ZiGOR]

Don't worry, i still had a little time to fix FlameStrike for you.

YYYYYYYEAH BABY!!! I think today I'll have a little progress with my other spells

GOOD JOB!) take +1 rep from me ^^,

 

[ZiGOR]

Here is the slightly altered version of Flame Strike known as Acid Bomb. You will need to add a delay before the effect happens, because the unit will already take damage before the missile touches it. You should consult others to help you as I will be absent for more than 12 hours starting from now. Good Luck in your progress!

You should also add in special effects or the spell would look really blank.

Don't worry about acid bomb. it's okay