[GUI] Conversation System

[Moderator]

10th Mar 2016, BPower:
Overall cool system.

Please change the function name from UniqueInit to InitConversationSystem.
Without Zinc, vJass or Wurst each variable and function names should be very descriptive to compensate the missing encapsulation.

The trigger names in the demo map should also be more descriptive.
"Init" and "loop" are unacceptable trigger names.

SaveOptions and UpdateText should also have a better name, which indicates that it belongs to the conversation system.
Maybe by using a prefix.

• Game - Display to (All players) the text: start

^That line shouldn't be in the final released version.

21 Feb 2016
BPower: needs fix

9th Feb 2016
IcemanBo: Post: http://www.hiveworkshop.com/forums/spells-569/gui-conversation-system-267614/index3.html#post2785223

 

[Chaosy]

Changelog:

1.0

-Uploaded

 

[Flux]

Just wondering, why didn't you code it in vJass all the way since it requires JNGP to use? Besides, it has a lot of custom scripts.

 

[Chaosy]

There were not a lot of custom scripts from the start. But then I wanted to merge 4-5 triggers into one (existing init trigger). That's when I was forced to add the jass.

And since I can only call functions that are above I had to use a scope since it moves the functions to the top. If it wasn't for the scope it would not be vjass.

 

[IcemanBo]

Libraries move code above, not scopes.

You declare scopes inside custom scripts to take usage of IntegerA/B loops? Seriously?
I badly insist you to change to plain JASS or vJASS, I won't support such a wild mix. (you hippie )

No, seriously. There's nothing bad in making a short useful and readable vjass code.
But the GUI just destroys it all. Really.

I like the idea much. I also used this kind of conversations in my own rpg,
and I was really happy with it.

I will check the code once it is updated.

 

[Chaosy]

Ah! Now I remember..

When I select which trigger I want to add actions to, the function needs to be above the code. Library init moved the code to the top which gave me undefined function so I used a scope instead.

A/B loops are generally accepted even if not optimal
If I make it in vjass it's harder to get it approved though. You perfectionists scared me away from going in full vjass. Well since you import a system to skip coding it yourself it doesn't mater how it looks as long as it's easy to use. I am aware that my mish-mash doesn't look good, but it's more efficient that the full GUI one so that's something.

 

[IcemanBo]

If action A is written in custom script or written in plain JASS does not change the result.
It will be the same, and I won't judge it differently to effiency etc only because there is the prefix "custom script".
But what I do judge is something like readability, clearness etc.

I'm sorry if you were scared away from it. But I also must say standards won't change just like that.

What maybe annoys some people is that there are plenty of opimizations can be done when using jass/vjass vs gui.
Like avoiding many bjs, directly using expressions to reduce amount of lines, different approaches that are case specific faster here or there,
correctly using of timer etc. But by working it will get used, and there won't be a problem with it after some time.

 

[Chaosy]

Since GUI stands for Graphical User Interface it's indeed GUI and nothing else. The GUI may contain vjass but if something is judged as vjass because there is less than 5% of it, then I don't even know what to say.

The triggers and/or code must be readable and clean. Messy code is very hard to moderate, and even harder for inexperienced users to deal with.

Inexperianced users wont use a full vjass system to begin with and remaking my system because it's hard to moderate is kinda silly (unless it's an extreme case). It's rude of me to put it that way but well.. that's how I feel about it.

 

[A Void]

I'd have to agree with Chaosy, GUI is much more preferred among many users.

 

[IcemanBo]

Writing in custom script is not using the graphical user interface anymore.
Custom sript can be seen like a port from GUI to JASS.

Guys, it's like you only put an other shell over the code. It IS the same only less readable.
It makes sense if you want to achieve something what you can't achieve in GUI.
Then you use few lines of custom script to achieve wanted result, and rest code stays GUI.
Writing something mostly only in custom script makes absolutly no sense to me.

Inexperianced users wont use a full vjass system

Only core would change. API not. So nothing could scare anyone. User don't have to read internal stuff.
Actually core would not change as well, but will only be more readable..

I'd have to agree with Chaosy, GUI is much more preferred among many users.

It is not GUI.

 

[A Void]

Writing in custom script is not using the graphical user interface anymore.
Custom sript can be seen like a port from GUI to JASS.

Guys, it's like you only put an other shell over the code. It IS the same only less readable.
It makes sense if you want to achieve something what you can't achieve in GUI.
Then you use few lines of custom script to achieve wanted result, and rest code stays GUI.
Writing something 100% in custom script makes absolutly no sense to me.


Only core would change. API not. So nothing could scare anyone. User don't have to read internal stuff.
Actually core would not change as well, but will only be more readable..


It is not GUI.

It's up to the author himself to decide whether this is GUI or Jass. You can't reject a resource only if you don't like the code platform it uses. Chaosy should fix up the remaining issues with his own freedom of coding based on the spell submission rules. It's not that of a big deal anyway...

Your spell must be made using Vanilla GUI (aka. Triggers), JASS, vJASS, Zinc and under very special circumstances, cJASS. No third party languages will be accepted. If you have designed such a language and wish to have it standardized, contact the staff and present your language.)

 

[IcemanBo]

I am here to tell the resource owner what is wrong and what can be optimized.
I stated why it has only disadvantages for you to do it like it is currently done,
and that there is absolutly no point in using custom script like this to achieve "better" judgement.

I don't understand your problem, A Void. Why do you jump now to approval/rejection?
The point was you both said, "it's good because this and that", and I say no, it isnt.

It's up to the author himself to decide whether this is GUI or Jass.

I don't know what you wanna say with that. Have you read my previous posts?

 

[Chaosy]

2. (computer science) a program that controls a display for the user (usually on a computer monitor) and that allows the user to interact with the system

GUI = Graphical User Interface

As long as the 'code' is displayed in the following UI which contains images therefore making it graphical.

• Melee Initialization
  • Events
  • Conditions
  • Actions

Then it is GUI.

Notepad is not considered an interface. I doubt it's considered to be graphical either.

 

[IcemanBo]

1. Writing custom script is not real GUI anymore.
2. Why now is jumped again, and now on the exact defitnion of GUI?

Come on, don't be a retard. Ask yourself. Is it senseful for you to write whole code fully in custom script?
Don't try to find other points you can claim to like "but it is gui", just to ignore my basic point. That this is completly senseless.

Btw, I'm not angry or something, but I want to have it clarified.

 

[SA Dashie]

Scripting like this is generally hard on the eyes.
I haven't coded in much GUI since I started vJass, although I don't find it easy to read GUI in pure unless it uses only necessary custom script like cleaning leaks, using GetLocalPlayer and maybe local variable (might of missed some things).

Anything above that should be coded in vJass even is it doesn't use to many of it's features.

Your spell must be made using Vanilla GUI (aka. Triggers), JASS, vJASS, Zinc and under very special circumstances, cJASS. No third party languages will be accepted. If you have designed such a language and wish to have it standardized, contact the staff and present your language.)

"Your spell must be made using Vanilla GUI (aka. Triggers)"
Hmm I wonder what it means by Vanilla?
I assume by requiring no 3rd party code compiler if needed for it to be called actual Vanilla GUI.
If it contains vJass code (yes even if it's 5% of your code) in your "GUI" it requires an editor that is compatible for vJass.
I find this to be a big nono and not GUI friendly anyway.

 

[A Void]

Scripting like this is generally hard on the eyes.
I haven't coded in much GUI since I started vJass, although I don't find it easy to read GUI in pure unless it uses only necessary custom script like cleaning leaks, using GetLocalPlayer and maybe local variable (might of missed some things).

Anything above that should be coded in vJass even is it doesn't use to many of it's features.



"Your spell must be made using Vanilla GUI (aka. Triggers)"
Hmm I wonder what it means by Vanilla?
I assume by requiring no 3rd party code compiler if needed for it to be called actual Vanilla GUI.
If it contains vJass code (yes even if it's 5% of your code) in your "GUI" it requires an editor that is compatible for vJass.
I find this to be a big nono and not GUI friendly anyway.

Custom Script function counts as a vanilla GUI because it is a graphical interface for a function. T̶h̶i̶s̶ ̶s̶y̶s̶t̶e̶m̶ ̶i̶s̶ ̶1̶0̶0̶%̶ ̶v̶a̶n̶i̶l̶l̶a̶ ̶G̶U̶I̶.̶

Vanilla GUI is unaffected, unmodded and unedited graphical interface for the way it was presented by Blizzard via normal World Editor. T̶h̶i̶s̶ ̶s̶y̶s̶t̶e̶m̶ ̶u̶s̶e̶s̶ ̶v̶a̶n̶i̶l̶l̶a̶ ̶G̶U̶I̶ and a moderator according to the rules cannot order author to change the coding language based on his preference.

Basically everything you would find in normal Blizzard's World Editor - Trigger Editor counts as vanilla. And custom script function is there.

I hope i wrote it clearly enough...

 

[edo494]

Custom script: private function myUniqueInit takes nothing returns nothing

Private is not available in Blizzard's world editor, so according to your explanation, the whole thing isnt gui at all.

 

[IcemanBo]

I just can't more disagree with your opinion. You are just wrong.
Feel free to ask other spell mods if it's counted as GUI when you vjass in custom script. Good luck.

 

[A Void]

Private is not available in Blizzard's world editor, so according to your explanation, the whole thing isnt gui at all.

If it is not available then it is just simply GUI and not vanilla. I've just explained what "vanilla GUI" term means.

You should remember that it still resides inside GUI regardless of being vanilla or not.
The rules probably stated that in a general term.

#IcemanBo you don't have to disagree with me, because there is nothing to agree to. His code is inside a graphical interface, thus it counts as GUI...

 

[SA Dashie]

This system is 100% vanilla GUI.

• Custom script: scope ConversationScope initializer myUniqueInit

Ok...

Btw I still stand on how you should code with the use of atleast jass if your going to break up your GUI with unique functions.
Splitting functions in GUI I personally find ugly.

Also if you convert to actually using vJass (past vanilla blizzard script) you could set up your own globals in libraries as private or public and a lot more.
Doing it this way is way easier to keep things organized when you get used to it and the users don't have to put up with global variables that aren't sure what the use of are when making their own part of their map.

 

[edo494]

well, vJass is also GUI now!

Hint: vJass is also coded in GUI application(text editor)

 

[SA Dashie]

Lol, ok let's just go with that 'den.

 

[Chaosy]

Hint: vJass is also coded in GUI application(text editor)

Notepad is not considered to be graphical nor interface, sorry.

well, vJass is also GUI now!

It's GUI which contains vjass.

Private is not available in Blizzard's world editor, so according to your explanation, the whole thing isnt gui at all.

Irrelevant. Like the system would not be Graphical User Interface anymore because of a few custom scripts.
Magical shit, man. Who knew there was a single line that magically converted the whole code from GUI to vjass, I might post this insane discovery in the lab!

_____________________________________________________________

Ok...

Btw I still stand on how you should code with the use of atleast jass if your going to break up your GUI with unique functions.
Splitting functions in GUI I personally find ugly.

Also if you convert to actually using vJass (past vanilla blizzard script) you could set up your own globals in libraries as private or public and a lot more.
Doing it this way is way easier to keep things organized when you get used to it and the users don't have to put up with global variables that aren't sure what the use of are when making their own part of their map.

It's ugly indeed. But I wanted to merge 3-4 triggers into one and that's the only way. If you know how to merge in a way without it.. well, then I am all for it. I added the scope because I had to, not because I wanted to. So no, I wont add more vjass unless there is some extremely huge benefit.

 

[edo494]

check your definitions on words graphical AND interface

 

[Chaosy]

If you count a white background as being graphical, sure. Then my drawings that I did when I was 3 is professional art too.

2. (computer science) a program that controls a display for the user (usually on a computer monitor) and that allows the user to interact with the system

Notepad does not do that.

Adding one line of code does not remove vanilla GUI properties.

 

[edo494]

writing 1 line of vJass code does not make it less Jass? No wait, it does, now you cant compile without third party software.

Your comparision is more than silly.

I am not the one mentioning notepad, you are. I said text editor, for instance notapd++, sublime text, hell, visual studio editor will do

 

[Chaosy]

No difference. The part of the editor where you write jass/vjass does not have any high lightning by default. You can remove TESH completely from the editor and it will work/compile just fine.

 

[SA Dashie]

Notepad is not considered to be graphical nor interface, sorry.

The features that are used to code vJass have a different editor than the normal default Blizzard Jass editor (which btw is plain text).
JNGP's Jass Helper has interface with it's coding with colour coordinated properties, lets your highlight native functions to look them up with a list of natives and other features.

It's ugly indeed. But I wanted to merge 3-4 triggers into one and that's the only way. If you know how to merge in a way without it.. well, then I am all for it. I added the scope because I had to, not because I wanted to. So no, I wont add more vjass unless there is some extremely huge benefit.

I am not going to recommend a way that can be done in Blizzard GUI.

If it contains vJass code (yes even if it's 5% of your code) in your "GUI" it requires an editor that is compatible for vJass.
I find this to be a big nono and not GUI friendly anyway.

Keywords guys, keywords.

 

[FaLLeN]

Hey nice one.
Just uploaded mine check it out http://www.hiveworkshop.com/forums/spells-569/conversation-1-0-0-a-267827/

tell me how it is ?

 

[Chaosy]

Updated. Replaced some jass hashtable save/load with the GUI version. Also made the duration configurable.

 

[IcemanBo]

• Add documentation. Describe how to use your system, mention possible limitations in case, etc.
• Replace Integer A/B loops with custom ones.
• Store responses that are used more often into variables.
• Use a variable that the user can set the player with. Calling SaveOptions function is not gui friendly at the moment.
• Your example is not good, because you leak player groups.

I still say my opinion that writing scopes via custom scripts is trash. It is doing negative on purpose.

I'm not sure the triggers in thread are up to date.

 

[Chaosy]

Updated.

-no longer using integer a/b
-improved the demo code in more than one way.

 

[Arad MNK]

Is this vJASS in Custom scripts?? This is totally new.

 

[IcemanBo]

• Example code still leaks memory.
• The system should not manipulate player's cam settings.
  When panning cam, or locking it, it might becomes in conflict with user code.
  Let the user handle such things.
• I would wish documentation, especially for the user, but also for the system.
• The event trigger (where player presses an arrow key) does not care
  about the unit which is in conversation but onyl about the string content.
  That's not good, because something like "Who am I?" may be used more often.
  The system should clearly differ between units that are currently in the conversation.
• All phrases, no matter how long one is, uses the same "conversation duration".
  That should be more dynamic and be adjustable to each new Transmission.

I've not read the system itself, but only the demo/usage for now, but
from what I could see from the interface is that it will need some more work.

 

[Emm-A-]

I would like to state, that the idea for this system is just genious!

You should also make it MUI by not only adding Player(0) in the initilaizer function of the scope to the KeyUp and Down functions.

And also isn't this code insanly funny? Seriously, this code is funny

 

[Chaosy]

It is MPI making it MUI would be quite impossible

 

[Emm-A-]

It is MPI making it MUI would be quite impossible

oops, sry I meant MPI.

But from what I see in the code, there is this in initializer of your scope:

• Trigger - Add to CS_temp_trigger the event (Player - Player 1 (Red) Presses the Up Arrow key)

Wouldnt you have to change this to something like Player(i) and do a loop for each playing player to be MPI?

 

[Chaosy]

Ohhhh, thanks for pointing that out. Much appreciated.
I will fix that within an hour or two.

edit: updated

 

[BPower]

Using a GUI/JASS code combination via custom script spiced with vJass keywords.
Simply no.

Your function names are too generic.
SaveOption /UpdateText ... You're just forcing code collision with other systems.

 

[Chaosy]

If you know an easier way to merge three triggers into one without getting the undefined function error I'll gladly update it.

I will change them.

 

[IcemanBo]

One way to take keep generic names is to take a good scope name and use public keyword.

so you would call it with "scopeprefix_" from outside, and normaly inside the scope.

 

[Zunariel]

I have built a similar system for my newest campaign I will probably preview in the Map Development section at the end of the week. The outcome is the same, of course I have built my system for single player but my system is completely GUI and way simplier (way less and smaller triggers). Maybe I will upload it soon, too.

 

[IcemanBo]

If chaosy provides almost the same functionality, maybe you can throw out some suggestions!

 

[Chaosy]

I might have found out how to make the system remove the scope.. gonna update this now..

edit:

System no longer uses a scope, fixed an important flaw since you could not use the arrow up key. No idea how I didn't notice that before.
I was thinking about the names for functions but it seems kind of silly to to add another keyword.
ConversationSaveOptions() is really long and a bit of annoyance to the user due that.

 

[Emm-A-]

As I really like the concept of this system, I honestly do not understand, why you do not use the potential of your system, chaosy. If I was you, I would add a few more functionalities as suggested above. E.g. I would make the time of transmissions adjustable etc. ...

Anyway, I think you have to remove this function whatever thing from your init, I think this should give you an error as there is no endfunction and also it has no use at all (?)

 

[Chaosy]

I am pretty sure they are adjustable?
Or maybe I am misunderstanding something.
And I would perhaps add those but I do not see any of those suggestions.
Unless it was suggest at the first page because I have not read those in a long while

It does not give an error, the system works and compiles.

 

[Zunariel]

Here I have uploaded my first preview and there you can also see my system. www.hiveworkshop.com/forums/map-development-202/teop-cenarius-return-276321/

 

[Peach Schnapps]

Forgive my noobness but is this MUI/Leakless?

 

[Pyrogasm]

This is MPI

So it works for one unit per player. This is the system that was remade into the other system you commented on. Same answer that if it leaked things it wouldn't be approved.