Great Tornado v1.2 GUI/MUI

[Moderator]

22:11, 16th Jun 2010
Hanky:
Leakless and MUI. Good job!

 

[refi]

Works on magic immune and flyiing units?! FTW?! too simple.

 

[GodLike]

It is your choice what to set in unit filter. May be you want tornado to suck in structures.

 

[88WaRCraFT3]

I think i know how it looks... Awesome!
5/5

 

[baassee]

instead of this "Classification" abuse the bug with Raven Form (medivh spell). Just add it and remove it.

 

[GodLike]

baassee, i use classification to increase/decrease flying height of Tornado units, instead of timers and other ways. if tornado is ancient then trigger decreases it's height and if it is not an ancient then the height increases. Just look at the trigger completely.

 

[baassee]

boolean?

 

[GodLike]

It is decision too but it requires one more global variable and will cause the same effect.

 

[baassee]

yeah ofc if not someone have a dummy picker and picks ancient units

 

[Berb]

I love how there are trees in the water; not to mention they are growing out of rocks.

and flyiing units?!

Last time I checked tornadoes affected things in the sky along with things on the ground.

Great Tornado

Very well put together spell. I really don't care about what units are allowed to be affected since that is so easy to change it's not even worth mentioning. From what I can see you've cleaned up all of your handles to an extent that is perfectly acceptable. I'm not sure whether or not you experienced bugs before uploading the spell, but I thought for sure I would catch you in a few places that I did not. Good job.

- I don't know what the standard on using groups in GUI is, but they always leak. Since you are constantly creating/destroying groups (for each spell cast) it may cause a lot of memory to be unnecessarily allocated. Again, I don't know the GUI standard for this.

- Since you are using custom script for creating/destroying your tornado/damage groups, you could easily import the "GroupUtils" library by Rising_Dusk and use "NewGroup()" and "ReleaseGroup()", respectively.

- You clean your unit groups very well, and transfer the units from each group appropriately. I thought I would catch you on this one, so good job

• Set GT_CastCount = (GT_CastCount + 1)

- The above trigger can be moved down to the bottom of the trigger so that the arrays start at index 0 rather than 1. There is no reason you need the 0 index so you might as well. Remember that you can also start your loop in the "GT Loop" trigger at 0 instead of 1 (as well as your "GT End" trigger).

- Don't use unit classification to determine whether or not you need to increase/decrease the tornado height. You already have your parallel array setup so just use a boolean array. It would probably be more efficient since a boolean is evaluated faster than a function is, or two for that matter ("Picked unit" is also a function-call).

- You could add configuration values for the maximum/minimum height values.

 

[GodLike]

1. Group Utils requires JNGP, but i wanted to create spell that can be used by novices in standart WE.
2. If i'll use array since 0 it will cause some problems.

Updated!

and plz ban the guy who rated it 1/5

 

[Berb]

I was able to get the spell working fine using the 0 index. There is no reason you need to omit it from the list of available indexes. Also for the sake of keeping this native to GUI/non JNGP, I guess it shouldn't be much of a problem. I just noticed that you could be doing that.

 

[redscores]

1. Group Utils requires JNGP, but i wanted to create spell that can be used by novices in standart WE.
2. If i'll use array since 0 it will cause some problems.

Updated!

and plz ban the guy who rated it 1/5

We can't ban people that easy.... you should get a bit more of a mature behavior if you want to work here.

 

[Klingo]

think this could be in a loop

• Unit - Create 1 Dummy_Tornado for (Owner of (Triggering unit)) at GT_TargetPoint[GT_CastCount] facing 0.00 degrees
• Unit Group - Add (Last created unit) to GT_TornadoGroup[GT_CastCount]
• Unit - Create 1 Dummy_Tornado for (Owner of (Triggering unit)) at GT_TargetPoint[GT_CastCount] facing 90.00 degrees
• Unit Group - Add (Last created unit) to GT_TornadoGroup[GT_CastCount]
• Unit - Create 1 Dummy_Tornado for (Owner of (Triggering unit)) at GT_TargetPoint[GT_CastCount] facing 180.00 degrees
• Unit Group - Add (Last created unit) to GT_TornadoGroup[GT_CastCount]
• Unit - Create 1 Dummy_Tornado for (Owner of (Triggering unit)) at GT_TargetPoint[GT_CastCount] facing 270.00 degrees
• Unit Group - Add (Last created unit) to GT_TornadoGroup[GT_CastCount]

 

[Berb]

We can't ban people that easy.... you should get a bit more of a mature behavior if you want to work here.

Surely a mature community would understand a joke.

 

[GodLike]

Updated! I think it will final version

 

[Tank-Commander]

Hmm I think

• Unit - Move (Picked unit) instantly to GT_LeakPoint[2]
• Unit - Make (Picked unit) face GT_CurrentFace over 0.00 seconds

Could be replaced with a 'move unit and face angle instantly' function which would look like this:

• Unit - Move (Picked unit) instantly to GT_LeakPoint[2] Facing GT_CurrantFace over 0.00 seconds

If I am not mistaken, however If I am then I apologise as I have not been into the trigger editor for quite some time now =P

 

[Berb]

That really isn't necessary, it would probably be better separate, actually.

function SetUnitPositionLocFacingBJ takes unit whichUnit, location loc, real facing returns nothing
    call SetUnitPositionLoc(whichUnit, loc)
    call SetUnitFacing(whichUnit, facing)
endfunction

This is what the "Move unit instantly facing angle" function looks like. As you can see, it is just a combination of the two. It may save him a function call, though.