Diabolic Edict v1.2 (GUI, but MUI)

[Moderator]

12th Dec 2015
IcemanBo: Too long time as NeedsFix. Rejected.

04:04, 15th Apr 2010
Dr Super Good:
I will be brief about whats wrong with this spell, this is not a full review but a quick glance.

What is wrong...
It leaks events - Each cast will leak 1 unit event to my knowledge, which is not acceptable as this is easilly avoided. Try using a timer instead.
Damage is not credited properly - Yes kills are credited to the right player, but not the right unit which would mess up some kill or exp systems. The hero should be credited with the kills as the spell is meant to come from him and does not spawn a summon (correct me if I am wrong).

 

[Lambdadelta]

I don't think negative regen is a good way of achieving MUI, when there are much better chocies, MUI GUI Array, Hashtable, Static Timer.

Negative regen is annoying to work with as well.

 

[Deuterium]

I agree with BlackRose... and spell idea is... meh... not that much of a nice idea.

 

[Diehard@Azeroth]

First of all, i commend you on coming up with a way rather than simply getting taught from others, this is a good sign. ( of course most of the time the converntional is best )

Anyhow... You really shoudlnt have used hp, but instead a generic timer which i think u already did, and if unit dies, unit type = bla bla, do whatever method you want. This way you dont leak a unit event after the unit dies so it doesnt keep memory, and is easier. But very creative idea, i havent thought about it. Good job my friend

To Deutrium and xBlackRose: No, there is absolutely no need to use arrays in such a simple spell since it is innecessary storage of variables and basically not needed. P.S. Now i go informal! trust me deuterium, its a better idea than arrays etc, of course there is the event leak, only thing stopping it from being better.

Good job my friend, but i really think u need to make special things with it, like a decay effect or so, instead of just killing a unit.

no i dont rate, but all in all, creative ^^

 

[Dj0z]

Well well the Hive standards sure raised by quite an amount in the meantime eh? :|
Back when i submitted this, noone had posted a decent GUI MUI tutorial, and hashtables, MUI GUI arrays etc were things you never heard about.

All i did was reuploading the exact same spell without actually updating it, but turns out it was not the way to go lol.

It's all fine though, that proves the quality of mapmakers, reviewers and players overall is improving, so we can be fairly proud when we get a nice review.


For my defense (lol ) i'll say that using the dummy unit with its negative regen saves me the use of some vars, so i thought i wasn't all that bad.

Anyways i shall give it a proper update corresponding the current standards when i got alil more time (school tests atm), and couple new customizable features, to make this like a GUI MUI spell template for mapmakers in need of something looking like that.

EDIT: added a note in the spell description to mention that state of fact.

 

[Lambdadelta]

To Deutrium and xBlackRose: No, there is absolutely no need to use arrays in such a simple spell since it is innecessary storage of variables and basically not needed. P.S. Now i go informal! trust me deuterium, its a better idea than arrays etc, of course there is the event leak, only thing stopping it from being better.

Good job my friend, but i really think u need to make special things with it, like a decay effect or so, instead of just killing a unit.

no i dont rate, but all in all, creative ^^

This is not a spell but:

I submit it as a template for other effects, and to show how to get limited but working local timers in GUI for Multi-Unit-Instanceability.

How accurate is negative regen on for fast periods? Like 0.001?

 

[baassee]

How accurate is negative regen on for fast periods? Like 0.001?

0.01 I think

 

[Deuterium]

Still, the most efficient way of making a spell MUI is through indexing... using anything other then indexing/hashtables is stupid. Specially since now there's a hashtables... very simple way of achieving MUI'ness.

 

[Dj0z]

Still, the most efficient way of making a spell MUI is through indexing... using anything other then indexing/hashtables is stupid. Specially since now there's a hashtables... very simple way of achieving MUI'ness.

Well i'm one of those mapmakers whose maps (only 1 for instance, but the one i worked on the most ) were broken by patch 1.24, and who got kinda disgusted about it. There was all this hashtable speech in that "evil" patch.

So, well for now, the word "hashtable" only makes me think about my map that got broken... I guess it's gonna last until the day i decide to go through the trouble of learning how to use it and eventually find it nice and interesting...

 

[Deuterium]

The weird thing is that GUI maps shouldn't have got affected by the new patch and should have still worked normally :s

 

[Dj0z]

Yea well Chaos Colossus is the broken map, it has non-negligible amouns of JASS triggers inside, and fixing them all will seem to take eternity.

My other 2 maps, using no JASS at all, still function properly though. But that didn't make me wanna use hashtables in them if that's what you mean. Actually i'm not quite sure about what you meant there tbh...

 

[Diehard@Azeroth]

cant continue this arguement, but in all simplicity, the positives outweigh the negatives in this one, as for the technique itself

 

[Dj0z]

Thanks

 

[ChaosKnight]

Can someone be kind to post code? Doesnt have WE on this comp.

 

[Dj0z]

Can someone be kind to post code? Doesnt have WE on this comp.

Erm, lol.
Since this elder spell that i had totally forgotten about just got unsurprisingly rejected, i will just remake it the neat way and when i'm done maybe i will paste the code for you if you still want it.