Dark Phase v1.1 [MUI]

[Moderator]

Could be useful. No leaks and it is MUI.

 

[haxel96]

Owner of DP_Caster[DP_Index2] -> Triggering Player

No. Triggering player does not work with this event.

 

[EvilCrizpy]

Owner of DP_Caster[DP_Index2] -> Triggering Player


This is unneeded for the casting.

• Events
• Conditions
• Actions
  • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    • DP_Index1 Equal to 0
    • Then - Actions
      • Trigger - Turn off Dark Phase Loop <gen>

You could make this more efficient by substituting (Last created unit) with a variable and using the variable.

Also, this spell is pretty much an effect spam/eyecandy in its current state, as its just a 'pretty' warstomp. It looks like the dummy unit's Warstomp inflicts the damage, instead of the hero, which is bad for various systems. I suggest making the hero inflict the damage instead of warstomp via

• Unit - Cause (unit) to damage (unit), dealing XXX damage of attack type Spells and damage type TYPE

The tooltip is bad, conflicts with Patrol.

I have changed the tooltip, and changed how damage is caused.
And Haxel explains why not to use Triggering Player; The first trigger has been changed, i forgot the change from

• Trigger - Turn Off

to

• Trigger - Turn On

No. Triggering player does not work with this event.

Anything else about the spell?

 

[Magtheridon96]

No. Triggering player does not work with this event.

How couldn't it

 

[EvilCrizpy]

Kk. I just tested it and it worked fine, and every other spell uses it. Mostly because the Owner of DP_Caster[DP_Index] is the Triggering player.

• Set DP_Caster[DP_Index2] = (Triggering unit)
• Unit - Create 1 DP_Dummy for (Owner of DP_Caster[DP_Index2]) at DP_TargetPoint[DP_Index2] facing Default building facing degrees

Hmmm Agreeeded, every other spell does use it, Guess i just never used it :')
Will just change that.

How couldn't it

I dont know? :'D

Off topic : your still copying my signature

 

[Magtheridon96]

your still copying my signature

Not really
I made mine a long time ago
I thought you copied mine because you have the same order, and a useless "My Resources #2" column
Also, "My maps" seems just as redundant

 

[EvilCrizpy]

Not really
I made mine a long time ago
I thought you copied mine because you have the same order, and a useless "My Resources #2" column
Also, "My maps" seems just as redundant

Shhhh
My second column is there for when i need it,
and well the "Maps" one is just there for show
Anyways back on-topic!

Changed to Kinda triggering player;
Used a variable

• Set DP_Player[DP_Index2] = (Owner of (DP_Caster[DP_Index2]))

 

[haxel96]

From what i know (I've learnt myself) Triggering Player only works with Player events, not Unit events like this, for example

• Player - Player 1 (Red) skips a cinematic sequence
• Player - Player 2 (Blue) skips a cinematic sequence

Then triggering player will refer to... the triggering player.

If it works for unit events too then I've learnt something new.

I like the spell, cool effects and leakless/MUI

 

[EvilCrizpy]

From what i know (I've learnt myself) Triggering Player only works with Player events, not Unit events like this, for example

• Player - Player 1 (Red) skips a cinematic sequence
• Player - Player 2 (Blue) skips a cinematic sequence

Then triggering player will refer to... the triggering player.

If it works for unit events too then I've learnt something new.

I like the spell, cool effects and leakless/MUI

Yes you learn something new every day,
and thankyou for the feedback.

 

[Bribe]

Your loop trigger looks like too much work for something so simple. You
can achieve the same thing using a timed life with each unit.

 

[EvilCrizpy]

Your loop trigger looks like too much work for something so simple. You
can achieve the same thing using a timed life with each unit.

The "DP_Dummy2" Uses a timed life, but the first dummy does not,
The loop trigger is just to remove any units that did not get the timed life "Just incase" and then destroy the unit group and first dummy.

 

[haxel96]

You should add that the spell requires JNGP for the indexing system to work.

 

[EvilCrizpy]

Yea, would help ifi had put that.
Added in the title!

 

[Bribe]

What about the indexing requires JNGP? Nothing looks special about it.

If you make it in GUI and you want the most people to use it, it should
be openable in World Editor.

vJass stuff should be the only things that requires JNGP.

I recommend World Editor over JGNP if you build GUI, because World
Editor has access to hashtables (very important).

 

[EvilCrizpy]

What about the indexing requires JNGP? Nothing looks special about it.

If you make it in GUI and you want the most people to use it, it should
be openable in World Editor.

vJass stuff should be the only things that requires JNGP.

I recommend World Editor over JGNP if you build GUI, because World
Editor has access to hashtables (very important).

Okay,
Yea i figured that when i was trying to write things in GUI using hashtables, was really work out that well.
Anyways done some small updates.

 

[kezzasauce]

if you zoom in you see cheat enabled xD

 

[EvilCrizpy]

if you zoom in you see cheat enabled xD

~ was just making it so you can see the spell

 

[ShiroiSenji]

Really nice spell also works good with other missiles like crushing wave and Animate dead.