IcemanBo:
-date: 3rd March 2015
-submission: Bloodstone (DotA) GUI v1.4

https://www.hiveworkshop.com/posts/2660263/

old

02:26, 3th Feb 2015
IcemanBo: https://www.hiveworkshop.com/posts/2648322/

12:50, 25th Jan 2015
IcemanBo: Needs Fix upon request.

 

Reviews

• 1.1 - IcemanBo
• 1.3 - IcemanBo
• 1.4 - IcemanBo - Approved

 

Pretty great, though the wait kinda annoys me a little, else seems fine, but I don't check the code fully yet.

 

@Daffa the Mage
The wait annoys you?
There are 2 waits in this trigger. One of them being the duration of how long the visual effect is shown.
The second one is a 1 second check to tell when the hero is revived.
The first one is visual only and therefor has no reason to be changed into a timer.
The other one does have a behavior difference but I would rather have a 1 second delay between the revive of the hero and the stuff that it should do than making an array of stuff or hashtable to save the hero and get its id by the handle of the timer.
There is no way you could do anything in that <1 second.

@Mythic
I actually was annoyed by the pick every unit but now that I think of it.
It has no actual difference between those two (Except for the visual and editable stuff.)

 

Not trying to be a prick but game-time waits leak a reference:

Code (vJASS):

function PolledWait takes real duration returns nothing
   @local timer t@
    local real  timeRemaining

    if (duration > 0) then
        set t = CreateTimer()
        call TimerStart(t, duration, false, null)
        loop
            set timeRemaining = TimerGetRemaining(t)
            exitwhen timeRemaining <= 0

            // If we have a bit of time left, skip past 10% of the remaining
            // duration instead of checking every interval, to minimize the
            // polling on long waits.
            if (timeRemaining > bj_POLLED_WAIT_SKIP_THRESHOLD) then
                call TriggerSleepAction(0.1 * timeRemaining)
            else
                call TriggerSleepAction(bj_POLLED_WAIT_INTERVAL)
            endif
        endloop
        call DestroyTimer(t)
    endif
endfunction
 

 

In that case I will put a nice function in the header that does exacly the same except for the leak... would you be satisfied then?

like this

Code (vJASS):

function CustomWait takes real duration returns nothing
    local timer t
    local real  timeRemaining

    set t = CreateTimer()
    call TimerStart(t, duration, false, null)
    loop
        set timeRemaining = TimerGetRemaining(t)
        exitwhen timeRemaining <= 0

        if (timeRemaining > bj_POLLED_WAIT_SKIP_THRESHOLD) then
            call TriggerSleepAction(0.5 * timeRemaining)
        else
            call TriggerSleepAction(bj_POLLED_WAIT_INTERVAL)
        endif
    endloop
    call PauseTimer(t)
    call DestroyTimer(t)
    set t = null
endfunction

 

There is no need to satisfy me, I just pointed it out. Also, only mods can decide if that's acceptable or not.

 

In that case I will use the standard wait timer.

I never said that you had to approve did I?

But for real, if a non-moderator can give proper/true/helpfull and clear feedback and suggestions, then it is equally appreciated as the feedback from a moderator.

Ofcourse I want to remove the pending and let my resources be approved but every feedback or suggestion helps to achieve that ain't I right?

EDIT: As I just took a better look at the wait function, I would not even create a new timer. I would make a timer at the start of the game that runs for one hour and get the (3600 - remaining time + 3600 * number of times that it ran out.) to get the game time instead.
With that, I reduce the amount of timers used in my custom polledwaits from (one for every polledwait) to ONE!
Next to that... Who doesn't want to be able to get the current gametime? There could be many stuff that would improve by using that variable.

 

Nor did I imply that, I was clarifying that only a mod can answer that question you asked.

People often use timers and its callback for that since it has better precision than sleeps.

 

I am aware of the inaccurate use of timers, it is clearly visible when you see the code of the PolledWait and I assume that TriggerSleepAction works almost the same.

But as I said before:
If there is no effect on behavior or data (which only leaves visual effect), like in the first wait timer, the prefect accuracy is not required.
For the second one there are two options:
1. Use a TriggerSleepAction and suffer from a <1 second delay.
2. Create a timer and save the hero and timer in an array (with indexer) or in a hashtable and retrieve them once the timer runs out.

I chose the first because the stuff that has to be made is too much to achieve such a small thing. I mean who can do something within less than one second to actually make any difference? You get the picture.

 

They do since PolledWait also uses sleep calls.

 

I think both of you should argue with Nestharus, who is an expert in timers

 

I wouldn't call this an argument, more like exchanging information.

 

Update - 1.1:
Now sets the dummy unit's experience to the experience of the owner of bloodstone.
This is required for level-dependant experience gain reduction.

 

Make more configurable. Like effect, range, specific values, etc.

onDeath -> "remove charges": You make two operations to calculate the correct charge. Just make "Chrages*0.66".

When you keep track of experience, do not hardcode the unit type.

We might talk about the wait loop some later.
Also, you use "Wait 3,62 seconds". Im curious of where this strange value come from.
By the way, waits are not that accurate. It does not make much sense to make such precice values. (though it's nothing bad to trying be accurate^^)

Why do you increase charges onAcivation?

In trigger "Aquire Item" loop from 1-6, not 0-6. Also you do not need the "And - All Conditions" block.
The only scenario an "And -All Conditions" block is useful may be in combination with an "Or - Any Condition" block.

Your "lose item" will never remove the unit from ManaRegeneration.
1) You use the "Add to group" function.
2) The boolean check will never match. It doesn't work like this. Find an other way.

The trigger condition in "Add charge":
Just PickAllUnitsInRange, and make the filter yourself by using If/Then/Else inside the enumeration function.
Currently the line is very lond and just unreadable. It would be better like mentioned.

Both death triggers could be combined into one. We try to practice the DRY principle: "Don't repeat yourself."

I have no idea about this dota related stuff, but for a fan it might be useful.

 

Yea the second wait timer is made because I don't want to limit the user to the blizzard revive system... Because AoS maps almost never use the regular revive.

The first wait timer is a little more interesting indeed.
As soon as I get home, I will place the wait timer test map in my latest post in this thread.
I will also change the regular wait timer with my Game Time Wait...
Just a bit optimization of wait timers.

I activate an item... It removes a charge... I add a charge.
Good enough?
I cannot add a charge when the hero dies because if he died on a natural way he would gain a free stack!

In fact, I never played the original dota
It was on request for a fan.

Will do.

 

Hm, PolledWait() does not null the timer after removed, in the implemented function.

Sounds plausible.

 

Sounds more like a feature... but then a glitch.
When you have 9 stacks for example.
When you die regulary you have 9 - (9*0.66(=3)) = 6 stacks.
When you activate the item (you use a stack), you will have 9 - 1 = 8 stacks.
Then you die and you will have 8 - (8*0.66(=3)) = 5 stacks.
That is a glitch... I don't like glitches enough.

That is true...

Here is my version of PolledWait(). It is more accurate but can be shorter than the requested duration.
You get (ussually) a maximum difference between -0.075 and +0.075.
The real difference is mostly 0 or +/-0.025.
It cannot be used below 1 second though. But I would never tell someone to use wait timers or custom waits for those duration just because of how "TriggerSleepAction()" works.

It also does not make a timer for each wait. Instead it uses one global timer which is the gametime. It is very easy code:

Code (vJASS):

/////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
//
//  Header File
//
/////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
function GetGameTime takes nothing returns real
    return 3600*udg_GTS_Hours + TimerGetElapsed(udg_GTS_Timer)
endfunction

function GameTimeWait takes real duration returns nothing
    local real starttime = GetGameTime()
    local real endtime = GetGameTime() + duration
    local real remainingtime
    local real timerfactor
   
    if (duration > 0) then
        loop
            if GetGameSpeed() == MAP_SPEED_SLOWEST then
                set remainingtime = endtime - GetGameTime() - 0.045
            elseif GetGameSpeed() == MAP_SPEED_SLOW then
                set remainingtime = endtime - GetGameTime() - 0.035
            elseif GetGameSpeed() == MAP_SPEED_NORMAL then
                set remainingtime = endtime - GetGameTime() - 0.075
            elseif GetGameSpeed() == MAP_SPEED_FAST then
                //Untested yet
                set remainingtime = endtime - GetGameTime()
            elseif GetGameSpeed() == MAP_SPEED_FASTEST then
                //Untested yet
                set remainingtime = endtime - GetGameTime()
            endif
           
            exitwhen remainingtime <= 0
            if remainingtime > 1 then
                call TriggerSleepAction(0.5 * remainingtime)
            endif
            call TriggerSleepAction(0.05 * remainingtime)
        endloop
    endif
    set udg_TempReal = GetGameTime() - starttime
endfunction

/////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
//
//  Trig_GTS_System
//
/////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
function GTS_Add_Hour takes nothing returns nothing
    set udg_GTS_Hours = udg_GTS_Hours + 1
endfunction

function InitTrig_GTS_System takes nothing returns nothing
    set udg_GTS_Timer = CreateTimer()
    call TimerStart(udg_GTS_Timer, 3600, true, function GTS_Add_Hour)
endfunction

It is that simple. I am too lazy to do the FAST and FASTEST part because if I want those two I need to make triggers to set the game speed to those values.
When using + and - you switch between SLOWEST, SLOW and NORMAL.

EDIT:
Sorry about the range and stuff but those things are only used once.
I don't like having a lot of global variables that I never use.
Because the effects are GUI, I do not have to change them. And many people can read the effect data without a problem.
So I don't really see the point of having 10 extra variables if everyone already is able to change it. Sorry if you feel offended.

-----------------------------------------------------------------------------------------------------------------------------------------------------
-----------------------------------------------------------------------------------------------------------------------------------------------------
-----------------------------------------------------------------------------------------------------------------------------------------------------

Update 1.2

I just released version 1.2

Here are the changes:

• Merged the two "A unit dies" triggers to one.
• Fixed a bug where units would not be removed from the mana regeneration group.
• Made a variable for the ex-hardcoded dummy hero.
• Replaced Wait gametime with a custom wait timer which is more accurate and uses a global timer.
• A little code optimization.