Multiboard DotA 82% v1.4

[Moderator]

There is too much wrong in too many ways. I'm going to do something I normally never do and stop this thread by rejecting the whole system and send it straight to the graveyard.

http://www.hiveworkshop.com/forums/spells-569/multiboard-dota-82-v1-4-a-246844/index2.html#post2500490

Requires tons of fixes.
I suggest you make a thread in Triggers&Scripts.

12:23, 6th Feb 2014
BPower:
Things that leak
- Get rid of the waits
- loops would shorten the code by lot.
- Anything used more than once/twice should be stored into a variable
- You only have to register a leave event if that player is actually playing

 

[Rheiko]

Fix the tags...
They hurt my eyes ._.

 

[deathismyfriend]

You leak player groups.
Never use integer A / B. They are slower and less efficient than your own custom integer.
Don't use waits as they can break triggers and are very inaccurate.
Anything used twice or more store into a variable and use the variable.

For the MB Player Has Left A Game trigger. Don't use all the BJs.

 

[zv27]

I'll tell you one thing.Original Dota MB does not use "Wait"(I know this because I have the original dota map)Why not use it? Because it's shit.So throw that shit(Wait!)

 

[UngThanhNhan]

Nice! This is the best multiboard I really need now!

 

[Daffa]

As DIMF said.

In addition to that :
[1] Waits can be replace with timer instead, if not, erased completely
[2] Some part of trigger can be looped and the trigger still executes properly,this allows us to see more mistakes and such to improve you

Indonesia

Seperti kata DIMF (Deathismyfriend)

Tambahan dari itu :
[1] Wait bisa diganti dengan Timer (cari di Countdown Timer kalo di GUI), jika tidak, hindarilah menggunakan wait.
[2] sebagian trigger bisa menggunakan loop supaya lebih tersusun dengan rapi, sehingga kami bisa mencari kesalahan2 dalam triggering mu supaya kami bisa membuat resources ini lebih baik.

 

[UngThanhNhan]

But I see there are a few negative points in your trigger, as no annotations specific to the command line of their functions

 

[Daffa]

MB Player Leaves a Game can be optimized using loops and cleaning the BJ will help a lot.

 

[BPower]

Not better than before. Everything can be shortened by a lot for instance through loops from player 1 to 12.

Prevent attack shouldn't be part of the system. It's also inaccurate, because iirc DotA checks for buffs aswell.
Are you providing the multiboard or do you want to create some sort of Dota feature pack?

 

[yanchespenda]

Are Me Using Manually

If Then Else
If Player Red Equal Is Playing
Actions
Set Multiboard.......

Are This Right ??

 

[Kazeon]

dota multiboard?

that will be cool if you also make a same multiboard at the end of dota.. you know what I mean

 

[Justin Weaver]

Yes.. The expansion one

 

[deathismyfriend]

I see this has been updated but what was actually updated ?

I don't see any of the fixes I mentioned above in post number 3.

 

[Justin Weaver]

Should i only copy the variables with MB_??

 

[deathismyfriend]

Should i only copy the variables with MB_??

You shouldn't use this yet it has tons of problems with it.

 

[yanchespenda]

I see this has been updated but what was actually updated ?

I don't see any of the fixes I mentioned above in post number 3.

Update In Multiboard Create...

Change From ForLoopIndexA To if then else...

Thanks To Your Comment

 

[deathismyfriend]

Update In Multiboard Create...

Change From ForLoopIndexA To if then else...

Thanks To Your Comment

I don't see what got changed.

• For each (Integer A) from 1 to 10, do (Actions)
• Loop - Actions
• Multiboard - Set the text for Va[(Integer A)] item in column 1, row ((Position of (Triggering player) in MB_Lederboard[1]) + 2) to (Colour[(Player number of (Triggering player))] + Has Left A Game|r)
• -------- Change Shared Unit Player --------
• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
• If - Conditions
• (Triggering player) Equal to Player 2 (Blue)
• Then - Actions
• Player - Make (Triggering player) treat Player 3 (Teal) as an Ally with shared vision and full shared units
• Player - Make (Triggering player) treat Player 4 (Purple) as an Ally with shared vision and full shared units
• Player - Make (Triggering player) treat Player 5 (Yellow) as an Ally with shared vision and full shared units
• Player - Make (Triggering player) treat Player 6 (Orange) as an Ally with shared vision and full shared units
• Else - Actions
• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
• If - Conditions
• (Triggering player) Equal to Player 3 (Teal)
• Then - Actions
• Player - Make (Triggering player) treat Player 2 (Blue) as an Ally with shared vision and full shared units
• Player - Make (Triggering player) treat Player 4 (Purple) as an Ally with shared vision and full shared units
• Player - Make (Triggering player) treat Player 5 (Yellow) as an Ally with shared vision and full shared units
• Player - Make (Triggering player) treat Player 6 (Orange) as an Ally with shared vision and full shared units

The above shows inefficient code / Integer A loop / location leaks.

 

[yanchespenda]

I don't see what got changed.

• For each (Integer A) from 1 to 10, do (Actions)
• Loop - Actions
• Multiboard - Set the text for Va[(Integer A)] item in column 1, row ((Position of (Triggering player) in MB_Lederboard[1]) + 2) to (Colour[(Player number of (Triggering player))] + Has Left A Game|r)
• -------- Change Shared Unit Player --------
• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
• If - Conditions
• (Triggering player) Equal to Player 2 (Blue)
• Then - Actions
• Player - Make (Triggering player) treat Player 3 (Teal) as an Ally with shared vision and full shared units
• Player - Make (Triggering player) treat Player 4 (Purple) as an Ally with shared vision and full shared units
• Player - Make (Triggering player) treat Player 5 (Yellow) as an Ally with shared vision and full shared units
• Player - Make (Triggering player) treat Player 6 (Orange) as an Ally with shared vision and full shared units
• Else - Actions
• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
• If - Conditions
• (Triggering player) Equal to Player 3 (Teal)
• Then - Actions
• Player - Make (Triggering player) treat Player 2 (Blue) as an Ally with shared vision and full shared units
• Player - Make (Triggering player) treat Player 4 (Purple) as an Ally with shared vision and full shared units
• Player - Make (Triggering player) treat Player 5 (Yellow) as an Ally with shared vision and full shared units
• Player - Make (Triggering player) treat Player 6 (Orange) as an Ally with shared vision and full shared units

The above shows inefficient code / Integer A loop / location leaks.

It Change Shared of Hero.. Like DotA, if the palyer has left a game, the system respond with shared hero of player units to her Allied.. It Using Manually

Sorry If You Not Understand From My Quote

 

[deathismyfriend]

I understand what it does perfectly fine.
It leaks locations / uses integer A loop / is inefficient.

 

[BPower]

There is a lot of trash inside the. You can believe me when I tell you that the DotA multiboard and gameplay mechanics are not even close to your attempt.
Furthermore the system will happily desync and crash them game, as you run net traffic code in a local block.

The "ai system" does not apply for computer players, but for all players.

You have a shitload of leaks in your code.

This is the first time, but I will not set this to "Need Fix", I will reject the submission.