[vJass] (System) CustomInventory

[CHA_Owner]

Well i hope this will work on fixing it since i would really like to use this.

 

[Anachron]

And then you can finally see how great this is!

 

[Vercas]

Done... I cannot test it now, so we'll need someone with the bug!
Take the .mdx file and import it in your map.
Take the .tga file and import it with the following path:
" Textures/ARGB-1x255x255x255.tga "
(without spaces)

I hope it works! Else I will get emo...

 

[CHA_Owner]

Testing now will edit post after.

EDIT*

Tested it and it failed now theres no slots there all just black squares but atleast no more white boxes lol

 

[Vercas]

I am so freaking nervous.

 

[Anachron]

Like CHA_OWNER said, they don't work ):

 

[CHA_Owner]

Edited my post with a attachment screeny

 

[Vercas]

Yep, the destructables are the problem then!
They don't show or get removed.


I-said-use-images-not-destructables-but-everyone-ignores-me!

Make the destructables selectable... Are they there? :|

 

[Anachron]

Images bug, have a limit and are using much more memory. Also, they can not overwrite a model with a new texture. Its really my last thing I would do.

 

[Vercas]

I will use images for my system.

They might use much more memory but you will never use a thousand images...
Textsplats... They don't lag, even when you move them! (This means re-creating them every period of time!)
255 characters in one textsplat... low velocity, set the interval to 0.01
No lag with 1.80 GHz and 1023 MB RAM.

 

[Anachron]

Your system?
And can you please continue fixing the problem?

 

[Vercas]

My systems. A big WIP.

I can continue, but it's obvious the problem are not the trackables.
The problem are the destructables and all I'll ever recommend is using units or images. Never destructables. They suck.

 

[Anachron]

Well, they haven't had any bug yet so I thought they were ok. Also , units and images also have a lot of bugs.

Whats the system about?

 

[Vercas]

Systems.
Basic interfaces made of images.
They require something...
Spellbook, talent tree, npc interaction, inventory&equipment, social status and more.

The_Witcher is taking care of the interface system. I am taking care of the virtual-level calculations, structs... Things that are not directly shown in the game.

 

[Switch33]

Just a random thought. Maybe it has something to do with changing Fixed Rotation (set in the object editor) by setting the rotation via triggers? That would maybe mean more refresh time.

As far as the bug with the fog from clock time, just add on Fog Visibility-True and some value for the radius and I think there might be no more weird fog at the bottom during daytime/nighttime shift.

I still can't get the white icon bug to appear. The problem with picking up items too fast and forming a weird forged item still occurs though. And not only does it still occur it also has the weird thing where whatever item is in the first slot disappears till you re-open the inventory when you try to move the bugged forged item.

 

[Anachron]

I still can't get the white icon bug to appear. The problem with picking up items too fast and forming a weird forged item still occurs though. And not only does it still occur it also has the weird thing where whatever item is in the first slot disappears till you re-open the inventory when you try to move the bugged forged item.

*
That's not weird. Its basically because the inventory is protecting the items and never freeing them. (Because they are used again before freeing)

 

[Vercas]

I took a very close look at the system.
My opinion is that your functions and methods are too complicated.
You need to generalize a lot of stuff and completly separate the inventory module from the actual interface module.
The interface should get and send feeds from and to the inventory.
Now they are bound to each other.
That is a weakness.

That's just my advice.

 

[Anachron]

I took a very close look at the system.
My opinion is that your functions and methods are too complicated.
You need to generalize a lot of stuff and completly separate the inventory module from the actual interface module.
The interface should get and send feeds from and to the inventory.
Now they are bound to each other.
That is a weakness.

That's just my advice.

Excuse me, it already is?!

Check out:
All stuff bound to the interface is called CW, while the inventory is called CI.
CW = The interface, meaning the interface action, buttons and such.

The CI librarys are the core, which has the functionality, but is called by CW.

 

[Vercas]

It is but at the same time it is not in my opinion.
It just doesn't feel right to me the way you intersect them.

 

[Anachron]

Believe me, I spend a lot of time grouping library and actions into the correct container.
If you get handy with CustomInventory, you'll see why and how I managed it.
And I think you'll like it.

Btw, I only insect once, in CustomInventory library there is a method to the CWWindow, else there are only links between the UI and the CustomInventory, not the other way around.

 

[Vercas]

How can I explain it...
The CW basicly extends CI.
(I'm not asking you to recode it, but it just looks rough to me.)

 

[Anachron]

The CW basicly extends CI.

Nope, CustomWindow is a system for its own made to show windows to local players only.
CustomInventory uses this system to show its FullScreen Inventory window.

 

[Vercas]

The way I am making my systems is extending the interface with the actual system. This way, if I have a clean and usefull interface, I can do whatever I need in the system without probably having to fix the interface bugs.

 

[Anachron]

But that bounds interface with the actual system, that's exactly what I do not want.

I can everytime do an spellbook based inventory system out of this because of that flexible programming design.

 

[Vercas]

No no no. The interface is a completly independant system.
Other systems require and use the interface. That's the idea.
In your case, the interface uses the system.

 

[Anachron]

Yes, it has to, hasn't it? :S

 

[Vercas]

It would sound more logical for the system to use the interface features.

The OS uses the kernel, not the opposite.

 

[Anachron]

Excuse me? The OS arleady uses the kernel, while the kernel is the CustomInventory, and the OS is the CustomWindow.

 

[Vercas]

See? This is the thing.
The kernel should be CustomWindow and the OS should be Custom Inventory!
That would sound more logical, don't you think?

 

[Anachron]

Nope.
CustomWindow is just optional, while the CustomInventory is required.
This system is about the inventory, not the fullscreen UI.

 

[Vercas]

Without the fullscreen UI it cannot give any output or take any input.
That's the logic.

 

[Anachron]

Without the fullscreen UI it cannot give any output or take any input.
That's the logic.

Wrong it can, that's the logic.
(You can still disable the whole UI stuff and use it instead of your normal 6 slot inventory, so the system functionality can be used in standard inventory.)

 

[Slaydon]

Is it possible to make the UI in the editor, not triggers and place items and still stats and stuff will be applied if its there, like in a load code with that.

 

[karland90]

you mean just like it was before Anachron made them be created ingame?

 

[Anachron]

What karland said, I already had it like that, but TriggerHappy and I weren't that glad of the fact that you have to CnP all that stuff.

Also its NOT possible to load ANY inventory data BEFORE map initialisation, because on map initialisation I initialize my system. After that its possible to save / load anything from my inventory system.

(I also mentioned somewhere that I was going to do a save/load system for my inventory)

 

[Catch_ya]

What karland said, I already had it like that, but TriggerHappy and I weren't that glad of the fact that you have to CnP all that stuff.

Have you updated the system so the borders generate itself instead of that it is already made in the editor?

Also its NOT possible to load ANY inventory data BEFORE map initialisation, because on map initialisation I initialize my system. After that its possible to save / load anything from my inventory system.

Ofc not. =)

(I also mentioned somewhere that I was going to do a save/load system for my inventory)

Yes you did, just can't remember where though. I don't want to look though 300 posts.

 

[Slaydon]

I mean, would it get the data from the destructable just if i place it manually?

 

[Anachron]

Have you updated the system so the borders generate itself instead of that it is already made in the editor?

Yes, the object editor objects automatically generate themself on save aswell as the borders on map start.

Yes you did, just can't remember where though. I don't want to look though 300 posts.

I think it was somewhere in the Diablo III Warcraft thread, lol.

I mean, would it get the data from the destructable just if i place it manually?

Creating the destructables manually would not get the data. How should it?

 

[Slaydon]

Maybe you could implement a small module that checks which destructable (which i had)

I just say that would make it abit easier to test stuff and so on, oh well,

Hero give item (item)

would work well enough

 

[Anachron]

Maybe you could implement a small module that checks which destructable (which i had)

I just say that would make it abit easier to test stuff and so on, oh well,

Hero give item (item)

would work well enough

Excuse me? How the hell should the system know which destructables belongs to what?
I will never support anything like that, since its automatically generated on map initialisation, no need for user placement.

 

[CloudMax]

Maybe im outdated now, i just looked like the posts fast becouse i do not have much time, but you guys said that the problem was that the models didnt load the textures, making them appear white.
That is wrong. I have the white slot problem myself, and if i scroll, the buttons will start to flash and you will see what is in the slot, so that means that it is loaded.

 

[Anachron]

So its back to the height problem. Well I guess I will try some "hacks" now.
Thanks for the input.

 

[Vercas]

But i think you should at least use 1-alpha texture on your trackable models.

I need to know something vital about your model.
On 1.00 scale and completly plate on the ground, what is it's size in units?

 

[Anachron]

I think 64.

 

[Vercas]

64x64 is precisely what I need for my systems!
The trackables of the interface I have are ~160x~160.

Do you allow me to use the model?

 

[Anachron]

Sure, they are opensource anyway.

 

[Vercas]

Thanks a lot!!

 

[diabloj]

When I test my map after CnP everything into my map it starts and an error comes up telling me ''Warcraft 3 has stoped working''
What should I do? I really want a FSI :S
Edit: It also happens when I do it on test map!

 

[Anachron]

You should wait a bit longer and not press on the wc3 window while loading and such.

(Or maybe you have done something wrong on import or have a wrong JNGP version)

 

[karland90]

or maybe you dont know what JNGP is and that you need it.