Spirit of the Forest v1.5

[Moderator]

Spirit of the Forest v1.5 | Reviewed by BPower | 11.07.2015 [COLOR="gray" [COLOR="gray" [COLOR="gray" [COLOR="gray" [COLOR="gray" Concept[/COLOR]] Wisps are circulating around the caster, damaging nearby units and themself. Their death ends in a small dentonation. Hero stats decreasment adds a unique character to the spell. Code[/COLOR]] The spell is MUI, leakless and working. Objects[/COLOR]] Object data appears to be ok. Effects[/COLOR]] Effects are sufficient. Good job. Rating[/COLOR]] CONCEPT CODE OBJECTS EFFECTS RATING STATUS 3.5/5 3/5 4/5 4/5 3.75/5 APPROVED

 

[Chaosy]

Seems pretty simple. If you remove the comments it's barely any code

 

[Flux]

I've seen other spells that are simpler than this. Besides, this spell is not extremely simple otherwise I would not receive it as a request in the first place.

Spells must be useful. Extremely simple, cinematic, or other spells which have no place in a game will not be accepted.

EDIT:
- Now it is a little more complicated, I made the newly summoned spirit to have equal angular distance with the other spirits, instead of just spawning at a random angular position.
- Maximum number of spirits per level also changed.

 

[Wasabee]

Wow thanks it's awesome.

 

[jonbon29]

Looks awesome, the way it is a passive and will create spirits that will circle around the hero is kinda cool. I'll be using this once it gets approved.

 

[IcemanBo]

- Why do you want them clickable/useable and showing hp? This is untypical.
- How you came to decrease stats when a new spirit is created. I don't see much relation in the concept.
- When addind a new spirit the angles screw up. It looks unfluent.
- I don't very like you work so much with adding/removing abilities from object editor. It's better when it's triggered.
User would have much more power when in comes to configuration.
- All spell related stuff, also initialiazions should be included into spell folder.

-------- An SOTF_speed of 10.8 is equal to 1 revolution per second -------- Set SOTF_spiritSpeed = 5.40

^What is a "recolution per second"? Also note that it's the speed per interval. (0.03)
- You don't necessarily need to normalize angle. 10, for example will be same as 370.
- Don't hardcode. Put the dummy unit into a variable.
- Responses used multiple times should be stored into variables to boost performance. (LastCreatedUnit)

 

[Flux]

- Why do you want them clickable/useable and showing hp? This is untypical.

The original request was to make the spirits clickable to show their HP. Anyway, if you think it is better for them to be locust I can change it.

- How you came to decrease stats when a new spirit is created. I don't see much relation in the concept.

Just to add more effect. Do you want me to remove this as well?

- When addind a new spirit the angles screw up. It looks unfluent.

That is because the angular distance between spirits changes. Example, if I have 3 spirits, each is 120 degree apart to each other. When another spirit is summoned, they became 90 degree apart.

- I don't very like you work so much with adding/removing abilities from object editor. It's better when it's triggered.
User would have much more power when in comes to configuration.

Noted and I will try to improve it.

- All spell related stuff, also initialiazions should be included into spell folder.

Noted.

-------- An SOTF_speed of 10.8 is equal to 1 revolution per second -------- Set SOTF_spiritSpeed = 5.40

^What is a "recolution per second"? Also note that it's the speed per interval. (0.03)

It is how many times the spirit will revolve around the caster per second. If it is equal to 10.8, then the spirit will complete a full revolution in exactly 1 second. Yeah it does depend on the interval.

- You don't necessarily need to normalize angle. 10, for example will be same as 370.
- Don't hardcode. Put the dummy unit into a variable.

Noted.

- Responses used multiple times should be stored into variables to boost performance. (LastCreatedUnit)

Ok I will store them to a variable.

 

[IcemanBo]

The original request was to make the spirits clickable to show their HP. Anyway, if you think it is better for them to be locust I can change it.

Atm user can select dummies and even (try) to cast abilities, order unit, etc. Dummies
should not show these charesteristics.
So I think yes, it should not be. But if you say it may be needed good way to have it optional though. (boolean = true/false)

Just to add more effect. Do you want me to remove this as well?

No, you can let it. I just wondered about the concept.

It is how many times the spirit will revolve around the caster per second.

Ah, my bad.^^ ... "Circulation" would be easier to understand for me, but you are right.

 

[Flux]

Spell Updated to v1.2

 

[Flux]

Spell Updated to v1.3

Store all abilty ids used for integer comparisons into variables.
These variables have to be setup in the configuration trigger.
This also includes the spirit of the forest buff.

Store the integer for the dummy unit into a variable and use it in your code.

Done, but I don't get the point.

Turn on the loop trigger only in case it is off. You can use the
same method for checking as you do when you turn it off. ( FirstOfGroup )
For this you have to move the GroupAddUnit function below.

Done.

Object editor based damage is not very welcome
in public spell submissions. It wouldn't be too hard to
change to triggered damage instead.

The world editor already has the ability so triggering it seems kinda redundant. Besides its not difficult to change it. Another thing is, this will increase the codes in the loop trigger that runs every 0.03 second. I have to create a new group consisting of all enemies then pick all the units within that group and decrease their life. That doesn't seems efficient compared to just using the Immolation.

ADDITIONAL EDIT:
Removed the Spell Book and used a 0,-11 coordinate for the button to be hidden

 

[BPower]

Done, but I don't get the point.

This way configuration is kept under one trigger. It's also a very minor speed improvement
as you replace a function call with an non-constant integer.

The world editor already has the ability so triggering it seems kinda redundant. Besides its not difficult to change it. Another thing is, this will increase the codes in the loop trigger that runs every 0.03 second. I have to create a new group consisting of all enemies then pick all the units within that group and decrease their life. That doesn't seems efficient compared to just using the Immolation.

GroupEnumUnitsInRange is quite fast. If I would have to guess, I would say Blizzard does the
same for Immolation internally. ( some way immolation also has to enumerate close units.
Btw you would be suprised how slow GUI is compared to JASS. It's literally two worlds.

Oject data isn't really good for abilities, especially when it comes to dealing damage.

Removed the Spell Book and used a 0,-11 coordinate for the button to be hidden

I read about this and I don't know if it works on every kind of engine.
I don't consider this update as a benefit at all, but also not negative.

 

[Flux]

GroupEnumUnitsInRange is quite fast. If I would have to guess, I would say Blizzard does the
same for Immolation internally. ( some way immolation also has to enumerate close units.
Btw you would be suprised how slow GUI is compared to JASS. It's literally two worlds.

Oject data isn't really good for abilities, especially when it comes to dealing damage.

So I just have to trigger immolation and it will be approved?
You said GUI is slowed compared to Jass and I totally agree, that is why I think I should not trigger immolation coz I think Immolation is coded in Jass Script internally.

 

[BPower]

trigger immolation.

 

[Flux]

Your variable names are not consistent. Chose either a small letter
or a capital one after the SOFT_ prefix. Currently it's a wild mix.

Done. I chose small letter sucg as SOTF_attributeEffect.

Your hashtable should also have the SOFT_ prefix

Done.

Here you should used previously stored SOFT_tempUnit

• Unit - Set level of SOTF_DPS for (Last created unit) to SOTF_tempInteger

Removed because it is no longer needed since I triggered immolation.

Object editor based damage is not very welcome
in public spell submissions. It wouldn't be too hard to
change to triggered damage instead. It's not as
expensive as you think.

Immolation is now triggered.

Added:
- Configurable DPS per level in triggers (mentioned above).
- Configurable AoE per level in triggers.
- Configurable Special Effects in triggers.

 

[IcemanBo]

First, good to see that you triggered the AOE damage now.
But I still I mark some things that can be optimized:

Hashtable - Save SOTF_tempAngle as (Key SOTF_Angle) of (Key (Last created unit)) in SOTF_hashtable Hashtable - Save Handle OfPDD_target as (Key SOTF_Caster) of (Key (Last created unit)) in SOTF_hashtable

LastCreatedUnit -> Set SOTF_tempUnit

In your periodic trigger you can change something similar:
PickedUnit -> SOTF_tempUnit
(Don't forget the part where you clean hashtable)

OwnerOfCaster might also be stored into hashtables, as it's called on periodic event.

Set SOTF_tempGroup = ...

^When doing this just pick all units in range.
Then immediatly set your variable to "PickedUnit",
and then filter all units with help of "If/Then/Else multiple".
You also will gain readability of the filter.

Please make the damage and attack type configurable for user.
It's always good if these things can be changed easily, instead of having it hardcoded.

(Life of SOTF_tempUnit) Less than or equal to 5.00

^What if the "selfDamage" is higher than 5? Please also take care of it.

 

[Flux]

Hashtable - Save SOTF_tempAngle as (Key SOTF_Angle) of (Key (Last created unit)) in SOTF_hashtable Hashtable - Save Handle OfPDD_target as (Key SOTF_Caster) of (Key (Last created unit)) in SOTF_hashtable

LastCreatedUnit -> Set SOTF_tempUnit

In your periodic trigger you can change something similar:
PickedUnit -> SOTF_tempUnit
(Don't forget the part where you clean hashtable)

I have already thought of this but I can't find how to do it. Unit variables just don't appear in the drop down menu. Do you know how?

OwnerOfCaster might also be stored into hashtables, as it's called on periodic event.

Since you said "might", I'll assume this is optional. I just think it is slower to store them in hashtable and retrieve them than just using OwnerOfCaster.

Set SOTF_tempGroup = ...

^When doing this just pick all units in range.
Then immediatly set your variable to "PickedUnit",
and then filter all units with help of "If/Then/Else multiple".
You also will gain readability of the filter.

Done, but I haven't uploaded the update yet because I still have a question in my first statement above.

Please make the damage and attack type configurable for user.
It's always good if these things can be changed easily, instead of having it hardcoded.

Will do.

(Life of SOTF_tempUnit) Less than or equal to 5.00

^What if the "selfDamage" is higher than 5? Please also take care of it.

Ok I changed it to if Life <= selfDamage.

 

[BPower]

I have already thought of this but I can't find how to do it. Unit variables just don't appear in the drop down menu. Do you know how?

Not supported in GUI. There might be a specific type of variable, but it's not important
in your case. Just leave it as it is ( key of last created unit ).

Since you said "might", I'll assume this is optional. I just think it is slower to store them in hashtable and retrieve them than just using OwnerOfCaster.

An hashtable lookup will turn out to be faster ( just because you asked )
For this spell it doesn't matter and can be left as OwnerOfCaster.
GUI itself is such a slowpoke.
Applying changes here can be considered as micro-optimization.

 

[Flux]

Spell updated to v1.4

 

[BPower]

In on damage event, you don't use the variable for the attribute effect ability.
Change that. ( otherwise the spell will 99% not work correctly after importing it
to another map )

 

[Flux]

You leak an effect handle in OnDamage

No the effect gets destroyed when the wisp dies.

SOFT attribute effect in OnDamage should be added/increased via the stored variable.

will do.

I just saw that you use tempUnit and tempUnit2 in the loop trigger.
Actually you can handle everything via tempUnit. ( tempUnit2 is not required )

you mean like this

• Set SOTF_tempGroup = (Units within SOTF_aoe[SOTF_tempInteger] of SOTF_tempLoc2)
  • Unit Group - Pick every unit in SOTF_tempGroup and do (Actions)
    • Loop - Actions
      • Set SOTF_tempUnit = (Picked unit)
      • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        • If - Conditions
          • (SOTF_tempUnit is alive) Equal to True
          • (SOTF_tempUnit belongs to an ally of (Owner of SOTF_caster)) Equal to True
        • Then - Actions
          • Unit - Cause SOTF_caster to damage SOTF_tempUnit, dealing SOTF_damage[SOTF_tempInteger] damage of attack type SOTF_attackType and damage type SOTF_damageType
          • Special Effect - Create a special effect attached to the origin of SOTF_tempUnit using SOTF_damagedSpEffect
          • Special Effect - Destroy (Last created special effect)
        • Else - Actions
  • Set SOTF_tempUnit = (Picked unit)
  • Custom script: call DestroyGroup(udg_SOTF_tempGroup)

Can Wisps use denotate, if they are dead?
( eventually you kill your wisps with -damage/second. )

No, that is why when their HP is less than or equal to their self damage, before the next loop runs (which will kill them), it will cast detonate. Basically, it cast detonate before it dies.

 

[BPower]

No the effect gets destroyed when the wisp dies.

You mean blizzard checks internally every effect placed on a unit which gets removed and removes it?
I doubt this very much.

No, that is why when their HP is less than or equal to their self damage, before the next loop runs (which will kill them), it will cast detonate. Basically, it cast detonate before it dies.

I missed that. Your are right.

For the unit thingy. Yes

 

[Flux]

You mean blizzard checks internally every effect placed on a unit which gets removed and removes it?
I doubt this very much.


I missed that. Your are right.

For the unit thingy. Yes

Hmm, you are right
http://www.hiveworkshop.com/forums/...tached-unit-destroy-when-unit-removed-206630/
http://www.hiveworkshop.com/forums/...estroyed-when-unit-they-attached-dies-235741/
http://www.hiveworkshop.com/forums/...stroy-special-effects-made-unit-group-215398/

The effects disappearing made me assume it was removed when the unit dies.

 

[BPower]

Changes made. Approved and rated with 3.75 which results into 4.