[GUI] Spirit of Fire v1.5

[Moderator]

11:52, 14th Jun 2014
BPower:

• When you check your spell carefully, you will realise that the location variable SoF_TempLoc3 is not required. You could handle everything with two location variables.
• SoF_Level still shouldn't be an array, but a non array variable.
• You don't have to remove the dummy unit. It's already set to "Does not decay, can't raise".
• I like the concept, however it's not really complicated to code by oneself. I'll rate it with useful

Approved

old

16:15, 12th Jun 2014
BPower:
Set to Need Fix until changes are made.

22:54, 10th Jun 2014
BPower:
Check out my last post. This is soon ready for approval.

09:01, 4th May 2014
BPower:
Refer to my last post.

 

[GywGod133]

RECOMMENDED ICON


Just click this icon

 

[ILH]

Looking good

 

[BPower]

There is no benefit in destroying the map init trigger.

SoF_Start:

Hanky's indexing template is totally fine. I recommend you take a look into this, just to be aware of an alternative way of indexing.
The one I posted is also faster to type on the keyboard (less lines of code).

SoF_AoePoint is equal to Sof_TempPoint, remove one of them from your code. Here is also a location leak.
SoF_TempPoint_Copy is not even used, remove it. Furthermore "Copy" is not a good name for a variable.
Btw for the whole script you only need 1 non array location variable.

Loop:

You don't have to null player variables, as they are constant handles. We don't expect it in GUI code, but you can null the effect variable SoF_SFX.

You should use one dummy caster per spell instance or just one for the whole game season. Currently you create one each 0.03 seconds, which causes a huge amount of extra computation time.
You can ask for help if you don't know how to achieve this.

The rotation speed should be configurable for the user.

 

[BPower]

Towards your question:

1. You create one unit variable in the variable editor
2. In your init trigger you create one dummy caster and set it to this variable.
3. Add the dummy ability to the unit, it has to have 0 cooldown and no manacost
4. In the loop you move the dummy caster unit to the desired point, change ownership to the owner of the casting unit and order the dummy ability.
5. Due to 0 cd and 0 manacost you can order the ability all the time.

That's it.

 

[deathismyfriend]

There is no benefit in destroying the map init trigger.

Removing old unused triggers is actually beneficial as it releases unused memory. If any events are added it also destroys them and releases the memory from them. It also takes triggers with events that can repeat out of the queue causing a small speed increase.

Releasing all unused triggers can make a map last longer if that map has a chance of hitting the memory limit for WC3. ( Around 1.85gb)

 

[BPower]

Good way to use a dummy caster:

• Example
  • Events
    • Map initialization
  • Conditions
  • Actions
    • -------- Needs ability locust and should use the model file dummy.mdx --------
    • Custom script: set udg_DummyCaster = CreateUnit(Player(15), udg_DummyCasterId, 0,0,0)

• Loop
  • Events
  • Conditions
  • Actions
    • -------- Actions before --------
    • Unit - Move DummyCaster instantly to MyPoint
    • -------- Owner of caster may be stored in a player variable. --------
    • Unit - Change ownership of DummyCaster to (Owner of (Triggering unit)) and Retain color
    • Unit - Order DummyCaster to Human Mountain King - Storm Bolt (Picked unit)
    • -------- Owner of caster may be stored in a player variable. --------
    • Unit - Change ownership of DummyCaster to Neutral Passive and Retain color
    • -------- Actions after --------

 

[Deleted member 219079]

What kind of indexing you use?

 

[BPower]

• Custom script: set udg_SoF_Real[ udg_SoF_TempInt] = (udg_SoF_Real[ udg_SoF_TempInt] - 0.03125)

Instead of 0.03125 you should use udg_SoF_Loop

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • Or - Any (Conditions) are true
      • Conditions
        • SoF_FireBallAngle[SoF_TempInt] Equal to 0.00
        • SoF_FireBallAngle[SoF_TempInt] Equal to 360.00
  • Then - Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • SoF_FireBallAngle[SoF_TempInt] Equal to 0.00
      • Then - Actions
        • Set SoF_FireBallAngle[SoF_TempInt] = SoF_SpinSpeed
      • Else - Actions
        • Set SoF_FireBallAngle[SoF_TempInt] = 0.00
  • Else - Actions

Here is a problem, it should be less or equal and greater than or equal, because if the periodic spin value isn't a divider of 360 it doesn't work the way you have it now.

Apart from that it's ok.

 

[BPower]

yes you are.

 

[BPower]

SoF_Level doesn't have to be an array and fix the other two things I mentioned.
I just saw you have a location leak in the SoF Dummy trigger.
Furthermore there is a location leak in SoF Start trigger, when creating the special effect.
In this trigger you could store "TriggeringUnit" into a variable.