[GUI] Heath & Mana bar system v1.5

[Moderator]

22:41, 8th Mar 2014
PurgeandFire: (old) Review:
http://www.hiveworkshop.com/forums/2537794-post18.html

Changes made. Approved. Nicely made system.

 

[nhocklanhox6]

Too advance ==!

 

[deathismyfriend]

Don't use integer A /B they are slower and less efficient.

Remove this BJ LoadIntegerBJ

You need to null these at the end of the functions. local player

 

[nhocklanhox6]

Don't use integer A /B they are slower and less efficient.

It's just an example about how to show/hide bar >.<

 

[deathismyfriend]

It's just an example about how to show/hide bar >.<

Still it's bad to use them in example triggers as people think it is ok to use in normal triggers.

Also i edited my above post.

 

[Maker]

I don't think local players need to be nulled. I really should test it once more but I'm out of time.

 

[DeuceGorgon]

Thank youuuu so much!

 

[Wrda]

How to show bar if they're an allies

• Show Bars Enemies
  • Events
    • Player - Player 1 (Red) types a chat message containing -showe as An exact match
  • Conditions
  • Actions
    • -------- SHOW BARS TO ENEMIES --------
    • -------- For example: I will show bars for all enemies of Neutral Player --------
    • For each (Integer A) from 1 to 12, do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        • If - Conditions
          • ((Player((Integer A))) is an enemy of Neutral Hostile) Equal to True --> Ally????
        • Then - Actions
          • -------- Add current unit and enemies player --------
          • Set HM_Current_Unit = Wisp 0004 <gen>
          • Set HM_Current_Player = (Player((Integer A)))
          • -------- Hide/Show bars --------
          • Set HM_Do_Hide = False
          • -------- Run this trigger to operate this action --------
          • Trigger - Run HM Hide Bars To Player <gen> (ignoring conditions)
        • Else - Actions

Huh? Correct me if I'm wrong, but I guess you meant "ally" not enemy here. Didn't see the rest, but it seems to look very fine. Good job

 

[nhocklanhox6]

Huh? Correct me if I'm wrong, but I guess you meant "ally" not enemy here. Didn't see the rest, but it seems to look very fine. Good job

Alaways confused T.T, i'm wrong >.<....

 

[BPower]

I don't think local players need to be nulled. I really should test it once more but I'm out of time.

Yes, I've read it many times that nulling player variables is redundant. I think once Dr. Super Good argument was: it will leak a maximum of 16 handles. (and a lot of explanation why)

 

[abcde]

OMG! God sent you to the Earth! Thats what I'm looking for a long time
Thank you!)) + rep
Merry Xmas for all Hive member!

 

[edo494]

keep in your head this rule: only null agents that can be constructed and if they have potential to be removed from game
Player is not group or unit, it cant just be deconstructed or created at will, and even if player leaves, you will have leak of like 4 bytes, and since there are only 16 players, you will leak maximum of 16 handle id leaks
I think risking leak of 64 bytes is nothing compared to the amount of time lost nulling players over and over again(both development speed and game speed)

on topic: this looks pretty good the images, cant check ingame because of mobile

 

[Legal_Ease]

There should be a simple way to import this and have every unit with mana automatically have a mana bar. Its not fun to have to add a mana bar during the game. Please revise. Also, there is no need to remake a health bar since most players keep the health bars on during games. I grant you this - the bars look good and its a great addition to the spell section but its a bit useless without a functional way to implement it. On/Off commands don't make the game more fun. These should be done by trigger and should be simple. There should be triggers marked with comments that say "disable this trigger to hide enemy bars," or "enable this trigger to make bars on heroes only." You should explain how to make these modifications so that people can use this spell. I worked on this for a while and can't get it. It could have been so much cooler. Explain & Simplify!

 

[BPower]

I guess its pretty much the same as the vJass version and just made to make it available for GUI'ers aswell.
Judging from the screenshot it looks great and useful.

Like the vJass version bars could be added and removed via UnitIndexer plus a UnitFilter and a boolean enabled = ?.

 

[EyeCandy]

Hmm, I don't like thick mana bar. How to configure thickness? Could someone point me to the right trigger code? I can see how u can adjust height.

Anyway very good system for my MOBA map.

 

[EyeCandy]

There should be a simple way to import this and have every unit with mana automatically have a mana bar. Its not fun to have to add a mana bar during the game. Please revise. Also, there is no need to remake a health bar since most players keep the health bars on during games. I grant you this - the bars look good and its a great addition to the spell section but its a bit useless without a functional way to implement it. On/Off commands don't make the game more fun. These should be done by trigger and should be simple. There should be triggers marked with comments that say "disable this trigger to hide enemy bars," or "enable this trigger to make bars on heroes only." You should explain how to make these modifications so that people can use this spell. I worked on this for a while and can't get it. It could have been so much cooler. Explain & Simplify!

Why health bar? An issue with Warcraft 3 is that unit health bar sizes aren't consistent.

Add Mana bar? Run trigger when hero enters map. remove bar when hero dies, hides, leaves map.

 

[PurgeandFire]

Review:

• If you want to this system show error messages-
  
  Just remove "debug" in front of the error messages.

  You actually just need to enable debug mode. I think it is an option under "Grimoire", or maybe "Jasshelper". I don't remember. But that is how you should display debug messages--not by removing the debug keyword. That is too much work.
• If you're going to use JASS, remove some of the BJ's. BJDebugMsg is fine, but fix the LoadIntegerBJ().
• In the illusion checker plug-in, you forgot to null local unit f. Also, you shouldn't group every single unit on the map. It can be a big performance drop if it is a really big map. You should take advantage of something like GroupEnumUnitsOfPlayer instead.
• Fix the trigger tags for System Period in the spell description.

Otherwise, it is pretty good. I haven't thoroughly checked "System Period" though. I'll wait for the trigger tags to be fixed.

 

[PurgeandFire]

In your illusion checker, you use a globals block. If you want this to be completely GUI-friendly, then I recommend using a global from the variable editor instead (otherwise the system will require vJASS. That is okay, but since the rest of the system doesn't use vJASS, you might as well make that change).

Also, when does illusion checker run? I can't check the map atm. I just want to know where it is used.

 

[nhocklanhox6]

@PurgeandFire
----------------

when does illusion checker run? I can't check the map atm. I just want to know where it is used.

In the period trigger

• Trigger - Run Illusion Checker Plugin <gen> (ignoring conditions)

 

[kamyflex]

Good Day and thanks for such an awsome system
What i want to do is to colorize the Health bar to Green and Red, Green for Team 1 and Red for Team 2, so what i did is modifying Elphis-Nyuu.Blp from green to white, like that:

and i tried to colorize the lightning using GUI command :

Lightning - Change color of HM_LightningH[HM_MUI] to (0.00 1.00 0.00) with 0.80 alpha

in order to turn the white Bar into Green but it does not work, can you help with this ?

- it will be also good if you remove the ManaBar file and just use a white model bar and colorize it in blue

 

[Legal_Ease]

Why health bar? An issue with Warcraft 3 is that unit health bar sizes aren't consistent.

Add Mana bar? Run trigger when hero enters map. remove bar when hero dies, hides, leaves map.

I can't believe this system was accepted. It crashes a map if you apply it to more than a hand-full of units. I wasn't good enough to make the adjustments myself last time I posted but I tried it again, because I have been trying to get manabars in my maps.

I did this as suggested:

trigger

• Add Bars
  • Events
    • Map initialization
  • Conditions
  • Actions
    • Visibility - Disable fog of war
    • Visibility - Disable black mask
    • Custom script: set bj_wantDestroyGroup = true
    • Unit Group - Pick every unit in (Units in (Playable map area)) and do (Actions)
      • Loop - Actions
        • -------- Remember: If you don't want to disable Fog of War, you must put this line on the first of Add Bar Trigger and then Enable again --------
        • -------- -- --------
        • -------- ADD UNIT TO SYSTEM --------
        • -------- Add Unit, Bar and Scale --------
        • -------- Unit you want to add bar --------
        • Set HM_UnitAddBars = (Picked unit)
        • -------- Unit scale (optional, you can choose the value whatever you want ^^) --------
        • Set HM_UnitSetScale = 1.00
        • -------- Allow system to create Heath Bar --------
        • Set HM_ActiveHeathBar = True
        • -------- Allow system to create Mana Bar --------
        • Set HM_ActiveManaBar = True
        • -------- Run this trigger to operate this action --------
        • Trigger - Run HM System Run <gen> (ignoring conditions)
        • -------- ---- --------
        • -------- And then, enable again --------
        • -------- -- --------
    • Visibility - Enable fog of war
    • Visibility - Enable black mask

...and you got it ... el crasho. This system is only good for a few units. It should say so. Having this system here discourages others from creating other ones, for fear it won't be as good and will be rejected.

Now, there is a chance I am wrong, so if someone can prove it to me, with say a .w3x where 20 or more units are using the bar without lag, I will gladly remove this post. Otherwise, this should be removed, it is a practically useless system.

 

[AnonymousPro]

interesting code

 

[Moises08x]