Charge of Darkness v1.5

[Moderator]

30th Jan 2012
Bribe: Thanks for making the updates. Rating upgraded to 4.25/5 (Recommended).

 

[Laiev]

You forget to use call this.deallocate() at your destroy method.

 

[jim7777]

updated as fast as i can consecutively >

i don't know why i can't use release timer on destroy
TimerUtils is giving out random errors, either Double Free or attempt to release null timer blah blah blah

 

[Bribe]

You are getting double-frees because there are some cases where you are destroying the instance/releasing the timer 2x.

            static if DISABLE_STOP then
                set dat.wait = dat.wait + INTERVAL
                if dat.wait >= 0.20/*good value*/ and GetUnitCurrentOrder(dat.caster) == OrderId("holdposition") then
                    call SaveBoolean(ht,GetHandleId(dat.caster),1,true) //we need to do this D:
                    if not IssueImmediateOrder(dat.caster,"holdposition") then //detect if the unit can do any orders, if not, 99% it is stunned or disabled.
                        @call ReleaseTimer(dat.time)
                        call dat.destroy()@
                    endif
                    call RemoveSavedBoolean(ht,GetHandleId(dat.caster),1)
                    set dat.wait = 0
                endif
            else
                call IssueImmediateOrder(dat.caster,"holdposition")
            endif
            if IsUnitType(dat.target,UNIT_TYPE_DEAD) then
                static if CHANGE_ONDEAD then
                    call UnitRemoveAbility(dat.target,BUFF_ID)
                    call DestroyEffect(dat.eff)
                    set tmp = dat
                    set dat.target = GetClosestUnitInRange(tx,ty,RADIUS,Filter(function thistype.Filt))
                    if dat.target == null then
                        @call ReleaseTimer(dat.time)
                        call dat.destroy()@
                    else
                        set str = TARGET
                        if not IsPlayerAlly(GetLocalPlayer(),dat.owner) then 
                            set str = ""
                        endif
                        set dat.eff = AddSpecialEffectTarget(str,dat.target,"head")
                    endif
                else
                    @call ReleaseTimer(dat.time)
                    call dat.destroy()@
                endif
            elseif IsUnitType(dat.caster,UNIT_TYPE_DEAD) or IsUnitPaused(dat.caster) then
                @call ReleaseTimer(dat.time)
                call dat.destroy()@
            endif
            if not IsUnitType(dat.target,UNIT_TYPE_DEAD) then
                call SetUnitX(dat.caster,x)
                call SetUnitY(dat.caster,y)
                call SetUnitFacing(dat.caster,angle*bj_RADTODEG)
                static if KNOCKBACK_PATH then
                    set tmp = dat
                    call GroupEnumUnitsInRange(tmpGroup,x,y,KNOCK_RADIUS,Filter(function thistype.Filt))
                    call ForGroup(tmpGroup,function thistype.KnockBack)
                endif
                if dist <= DETECTOR_RANGE and GetUnitAbilityLevel(dat.target,BUFF_ID) == 0 then
                    call DummyCaster[FAERIE_ID].castTarget(dat.owner,1,OrderId("faeriefire"),dat.target)
                endif
                if dist <= STUN_RANGE then
                    call DummyCaster[STUN_ID].castTarget(dat.owner,dat.lvl,OrderId("firebolt"),dat.target)
                    call IssueTargetOrder(dat.caster,"attack",dat.target)
                    @call ReleaseTimer(dat.time)
                    call dat.destroy()@
                endif
            endif

I also recommend using FirstOfGroup loop with a null filter, instead of using the filter. This saves RAM, processor and HD space.

 

[jim7777]

no no no no no no no no no no no no no no no no
i removed the ReleaseTimer from those lines, but weird.. i'll try it again

ok lemme use firstofgroup after i eat
want some cookies?

EDIT:
Updated

 

[Bribe]

Yeah, but you are still in some cases calling .destroy() more than once on an instance, and when that happens you release the same timer twice. You should set a boolean when you destroy so that you don't re-destroy later in the function.

 

[jim7777]

I guess return is a nice thing

right??

or should i really use an epic boolean

I really should use an epic boolean..

EDIT:

UPDATED

 

[RakEnRoL]

The knockback thing lags. D:

 

[jim7777]

Updated again

forgot to add the static ifs

 

[Bribe]

Pro tip: instead of adding units to a group and checking if they are in the group, just use a hashtable and do this: call SaveBoolean(ht, this, GetHandleId(unit), true), instead of GroupAddUnit. Instead of GroupRemoveUnit: call RemoveSavedBoolean(ht, this, GetHandleId(unit)). Instead of DestroyGroup: call FlushChildHashtable(ht, this).

If you are a "pro user" you can also do this using a TableArray, instead.

 

[LuizBills]

you can to use too CTL, instead TU.

 

[jim7777]

perhaps i might just use the hashtable instead of tablearray
since some people still use the old table, and just for this spell, they need to freaking change everything they have

and on the CTL, i can't understand how to use that >
I need a demo map LOL

lemme update soon, just taking photographs of some sort for a while

 

[Bribe]

If you can't figure out CTL, then you can look at Timer32 which was the premise for it: http://www.thehelper.net/forums/showthread.php/132538-Timer32

But CTL is pretty simple. You just put your "every 0.03 seconds" stuff in here:

implement CTLExpire
    //Put your "onLoop" stuff here
implement CTLEnd

Off Topic

just taking photographs of some sort for a while

That's what she said.

 

[jim7777]

eh
How to stop CTL timer hmm is it like the ReleaseTimer?? 'cause i'm wondering if I can really use it since i need to stop the timer sometimes via OnOrder method

meanwhile, why does facebook edit thumbnail not working D:

still gonna fix the group stack... What if the knockbacked unit blinks in front of the caster

EDIT
Updated to fix the group stack problem

 

[Bribe]

You should enclose the declaration line of lpsfx with this static if: "static if not LOOPING_SFX then", so it would look like:

        @static if not LOOPING_SFX then@
            effect lpsfx = null
        @endif@

It is easy to use CTL:

1) Make your struct one that extends array
2) Implement the CTL modules.
3) Your .deallocate() and .allocate() methods act as "ReleaseTimer/NewTimer". Seriously.

 

[mateuspv]

I think the effect used in magic is this:

http://www.hiveworkshop.com/forums/models-530/arcane-wave-65880/?prev=t=8&r=200&d=list&page=3

 

[jim7777]

Oh okay.. lemme try
btw how to highlight jass codes O.O so amazzziinnnggg LOL

meh... i don't like importing stuffs

OffTopic

EDIT
ohh.. it is just showing member redeclared: destroy
O.O helpppp
I'm not in the mood to make some logic. >

EDIT 2
Updated to v1.3
Meh, i won't use CTL for now

 

[Losam]

Jim7777 Dear, I Have Some Suggestions for your Enchantment (Not that it was good, just my opnioes).

Tip:

When an enemy unit collides with any hero who uses this Enchantment This unit is pushed due to the collision and moreover, it is flawed and is dizzy.

Peace and God's grace be with you all!

 

[jim7777]

ohh... so you want me to remove that??
o.o

perhaps i might remove/fix that thing

 

[Jolly_jumper]

Hmm it gives me some error messages when i try to save map and the spell doesn't work when i try to use it....btw i suggest u try making the spell so u don't have to target the unit to activate it...would be enough just targetting on ground I might suggest adding this to a custom game called Warlock, but i need to try it first hehe wondering if it stops/crashes into it's target or if it goes straight through....and i do hope u can adjust damage and maybe even speed?

 

[jim7777]

are you sure you set up the configuration part properly?

the speed can be adjusted in the configuration part

and are you sure you are using JassNewGen??