Spinning Ward v1.0

[Moderator]

Spinning Ward v1.0 | Reviewed by Maker | 9th November 2013 [COLOR="gray" [COLOR="gray" [COLOR="gray" [COLOR="gray" [COLOR="gray" Concept[/COLOR]] The concept is pretty simple, a ward that hurls projectiles everywhere It works and I can see this used in a Warcraft map Triggers[/COLOR]] Good triggering and quite efficient also Your custom value of bj_DEGTORAD is inaccurate Your custom value of bj_RADTODEG is inaccurate You don't have to check if the stage is 5 There is a slight performance issue with simultaneouts multiple casts, but luckily it can be configured Objects[/COLOR]] The tooltip is nice though it has a few grammar issues The dummy unit is properly configured There is no follow through time so the casting animation is aborted abruptly Effects[/COLOR]] The sounds and visual effects are enjoable and not too massive Rating[/COLOR]] CONCEPT TRIGGERS OBJECTS EFFECTS RATING STATUS APPROVED

 

[T. D. W.]

1.0 Review

Personal Words

Review

Suggestions

Rating

Judgement

Note

Before even looking at the code, just by testing, i first thought you used KB3D, because it has similar effects :3

This Spell is not JASS, but only GUI, though it SHOULD be coded in JASS, almost all the lines are Custom Scripts, i strongly suggest you to convert it to JASS and keep the GUI Init Trigger, like Infernal Cyclone or other

Well, There is nothing wrong here it seems, good spell

Change the Wisp Explosion Fx into something more fitting

You asked if you could have the User's Cut 6/5... See the rating, then continue:

Surprise me with Eye-Candyness Add fitting Fxs, features, whatsoever can make this spell extraordinary! By then, maybe, you can get 6/5

If You want me to review an Update of This Spell, Please Notify me this by VM or PM

 

[Rheiko]

i wonder why even when you could use normal gui trigger you still use custom script

anyway, awesome spell

 

[Ofel]

@Jad
Surprise you? I've got all the fitting fxs and some addition but i'm not sure you'll get suprised...

@Rheiko
+Rep (as a reply for the rep you gave just recently)

 

[Rheiko]

i don't remember i gave you a rep?
and i'm too lazy to check it at your profile =P

 

[Ofel]

it's when you're spreading...you just giving rep to random people and say "spreading"...

 

[T. D. W.]

Surprise me by combining fitting Fxs, whatsoever they are, or where they come
for instance, Wisp Explosion is not fitting at all with all the orange and red Fxs, a more color fitting thing (at least) will be better, even maybe the same Fx but recolored like this one
You'll start understanding me.. a little later like JakeZinc

 

[nhocklanhox6]

Long time no see ^^, anyway. Nice spell, good confiiguration.

use GetWidgetX/Y instead of GetUnitX/Y

 

[FUJI]

Off-Topic: Ofel Is BACK xD!!!!!!!!!!!

Hmm.. nice spell, may I review it tomorrow xD.

EDIT: Review

Spinning Ward v1.0
This spell had been reviewed by jakeZinc.

The triggering does not have an error, and it is leakless, fully MUI Spell.

The documentation in configuration is really nice but below the "end of configuration" must be documented because what if the users touch that and made the spell cause some errors, you must put a documentation like "Don't touch below these lines"

• -------- Determines the missile scale size --------
• Set SW_MissileScale = 0.80
• -------- Determines the missile flying arc height --------
• Set SW_MissileArcHeight = 0.40

These stuffs can be supported every level because what if the user wants a HUGE ward in the 3rd level of the ability
Other than that the configuration values is pretty well fine and it is complete.

Beautiful spell and it is fun to cast!

It can drops a huge FPS below and it does lag when you casted it two times so maybe reducing some effects

/****************************************************************************
*                                                                           *
*                            Spinning Ward v1.0                             *
*                                 by Ofel                                   *
*                                                                           *
*****************************************************************************
*                                                                           *
*  + Requirements:                                                          *
*    - None.                                                                *
*                                                                           *
*  + How to import?                                                         *
*    - Open File --> Preferences... Enable the "Automatically create        *
*      unknown variables while pasting trigger data".                       *
*    - Export dummy.mdx from Import Manager (F12) and import it to your     *
*      map.                                                                 *
*    - Copy Spinning Ward ability in Object Editor (F6).                    *
*    - Copy Spinning Ward Dummy unit in Object Editor (F6).                 *
*    - Copy all Spinning Ward triggers. Tips: Just copy the category.       *
*                                                                           *
*  When pasting the triggers, some trigger actions will may be disabled,    *
*  so make sure to enable it. Also, don't forget to configure SW_Ability    *
*  and SW_DummyType in the Spinning Ward Init trigger.                      *
*                                                                           *
*  If you any question or suggestion about this spell, contact me by        *
*  sending Private Message (PM) or leave Visitor Message (VM), but you'll   *
*  need to register on The Hive Workshop first.                             *
*                                                                           *
*****************************************************************************
*                                                                           *
*  + Requested by:                                                          *
*    - None.                                                                *
*                                                                           *
*  + Inspired by:                                                           *
*    - Serpent Ward spell.                                                  *
*    - Volcano spell.                                                       *
*                                                                           *
*  + Credits:                                                               *
*    - Vexorian: dummy.mdx model.                                           *
*                                                                           *
*  + Changelog:                                                             *
*    - v1.0: Initial version.                                               *
*                                                                           *
****************************************************************************/

It has a requirement instruction, It has credits, It has changelog, It has contact to the author, Nice importing instruction and you add a borders to make it really nice.

The special effects are fitting the concept of the spell and the spinning ward is swag and beautiful, but like Jad said, the wisp explode model does not fit the spell

Useful from the great clashes and AoS maps!.

• Custom script: set udg_SW_Angle[udg_SW_MaxIndex] = udg_SW_Angle[0] * 0.01747

why don't use bj_DEGTORAD? seems it is calculated by bj_PI/180.00 = 0.0174532925199444, so it is considering that you must use bj_DEGTORAD but I think it is not harm in the code.

• Special Effect - Create a special effect attached to the origin of SW_Dummy[SW_MaxIndex] using SW_OrbModel
• Set SW_AttachedModel[SW_MaxIndex] = (Last created special effect)

can be merged into 1 line like you did from the others but I think it is depends from you ^^.

• Custom script: call SetUnitScale(udg_SW_Dummy[udg_SW_MaxIndex], udg_SW_BallScale, 0, 0)

Why don't use GUI Script in this stuff?.

• Custom script: set udg_SW_HarvestOrder = OrderId("harvest")
• Custom script: set udg_SW_Harvester = CreateUnit(Player(15), 'hpea', 0, 0, 0)
• Custom script: call UnitAddAbility(udg_SW_Harvester, 'Aloc')
• Unit - Hide SW_Harvester

you must add harvester ability to the unit because may the users edit the peasant with no harvest ability.

Decent and Beautiful Tooltip!!!!!!! and supported from every levels!

Rejected: 1-10
Unacceptable : 11-30
Lacking : 31-49
Useful : 50-69
Recommended : 70-90
Highly Recommended : 91-100
Director Cut : 101-105

1) Triggering - 18/20
2) Documentation - 9/10
3) Importing Instruction - 10/10
4) Special Effects - 15/15
5) Usefulness - 12/20
6) Tooltip - 10/10
7) Configuration - 8/10

Total Score - 82/105
jakeZinc Rating - 4.3/5
Status - Recommended and expecting vote for Approval

 

[Ofel]

What a perfect review, jack!
Can you do this on every pending spells?

Ok, here's some answer of your questions...
+ Why don't use bj_DEGTORAD?
- It's suggested by nhocklanhox6
+ Why don't use GUI Script in setting the dummy scale?
- It will set the percentage scale. I prefer to set it like setting in Object Editor

 

[T. D. W.]

It's better to use the numbers instead of bj_DEGtoRAD or any other constant

 

[Rheiko]

why is that?

 

[T. D. W.]

Instead of making the system look for the constant.. It is faster and more efficient to directly do the opperation

 

[Rheiko]

you are sounds like mag =.=

 

[T. D. W.]

Well, for instance, me and mag are from the same country, and this sentence was more taken from bowser499

 

[FUJI]

What a perfect review, jack!
Can you do this on every pending spells?

Ok, here's some answer of your questions...
+ Why don't use bj_DEGTORAD?
- It's suggested by nhocklanhox6
+ Why don't use GUI Script in setting the dummy scale?
- It will set the percentage scale. I prefer to set it like setting in Object Editor

I guess your right ^^ but we don't know what is the right value for that and maybe from that value "0.01747" may let it slide in bugs because it is calculated by bj_PI/180.00 = 0.0174532925199444 but I think there's no wrong with that .