Demon Spinning v1.03

[Moderator]

Reviewed by Maker, Demon Spinning v1.03, 27th Dec

Approved. The main reason for low rating is the FPS drop it causes. Try casting it with two units at the same time, both ahaving the ability at level 3. The effect is good, but the spell idea could be more original. Suggestions for improvements Make it support more than three levels properly The spell creates hundreds of units per cast at level 3. That is quite much The spell is performance heavy and can lag on some computers Instead of DS_End trigger, you could check the current order of the caster in the looping trigger Improve the English in your importing instructions. The instructions can be a bit confusing Tooltip could benefit from slight improvements. Spelling, missing spaces and some non capital letters for example. Look at standard Blizzard tooltips I'd use 0.03 seconds for the interval, 0.04 seconds looks choppy to me

Old review

Maker, Demon Spinning v1.01, 22nd Dec

Required changes to be approved You should use level of ability at the time of casting The spell goes on even after the caster is dead The spell creates 744 units per cast at level 3. That is simply too much. Make the number of units and unit creation iterval configurable The spell is performance heavy and can lag on some computers Optional Instead of DS_End trigger, you could check the current order of the caster in the looping trigger Improve the English in your importing instructions. The instructions can be a bit confusing Tooltip could benefit from slight improvements. Spelling, missing spaces and some non capital letters for example. Look at standard Blizzard tooltips I'd use 0.03 seconds for the interval, 0.04 seconds looks choppy to me

 

[Magtheridon96]

Holy shit, I need to test this.

edit

The effects are wonderful, but the testmap isn't the best ;/
You should set the cooldown to 0 and give us multiple testers with 2^31-1 mana and hp

As for the triggers, here, I posted them for you in English:

Triggers

DS Init

• DS Init
  • Events
    • Map initialization
  • Conditions
  • Actions
    • -------- Each Array of this Variable set the number of Circles for a specific Level. --------
    • -------- Chaque Déploiement de cette Variable détermine le nombre de Cercles pour un Niveau spécifique. --------
    • Set DS_NumberOfCircle[1] = 2
    • Set DS_NumberOfCircle[2] = 4
    • Set DS_NumberOfCircle[3] = 6
    • -------- Each Array of this Variable set the Area of Effect for each Circle. --------
    • -------- Chaque Déploiement de cette Variable détermine la Zone d'Effet de chaque Cercle. --------
    • Set DS_CircleAoe[1] = 200.00
    • Set DS_CircleAoe[2] = 230.00
    • Set DS_CircleAoe[3] = 260.00
    • Set DS_CircleAoe[4] = 290.00
    • Set DS_CircleAoe[5] = 320.00
    • Set DS_CircleAoe[6] = 350.00
    • -------- Each Array of this Variable set the Circle's Direction and the Angle Interval between each Ball of each Circle. --------
    • -------- Chaque Déploiement de cette Variable détermine la Direction du cercle et l'Angle d'Intervalle entre chaque Boule de chaque Cercle. --------
    • -------- Set it to a Positive value for turning from North to East and to a Negative value for turning from North to West. --------
    • -------- Mettez le Ã* une valeur Positive pour que le cercle tourne dans le sens des Aiguilles d'une Montre et Ã* une valeur Négative pour que le cercle tourne dans le sens Inverse des Aiguilles d'une Montre. --------
    • Set DS_CircleDirectionAndSpeed[1] = 25.00
    • Set DS_CircleDirectionAndSpeed[2] = -25.00
    • Set DS_CircleDirectionAndSpeed[3] = 25.00
    • Set DS_CircleDirectionAndSpeed[4] = -25.00
    • Set DS_CircleDirectionAndSpeed[5] = 25.00
    • Set DS_CircleDirectionAndSpeed[6] = -25.00
    • -------- Each Array of this Variable set the Start Angle of each Circle. --------
    • -------- Chaque Déploiement de cette Variable définis l'Angle de Départ de chaque Cercle. --------
    • -------- 0.00 (or 360.00) is equal to the Facing of the Caster Unit. --------
    • -------- 0.00 (ou 360.00) est égal Ã* l'Angle de l'Unité Déclencheuse. --------
    • Set DS_CircleStartAngle[1] = 0.00
    • Set DS_CircleStartAngle[2] = 0.00
    • Set DS_CircleStartAngle[3] = 120.00
    • Set DS_CircleStartAngle[4] = 240.00
    • Set DS_CircleStartAngle[5] = 240.00
    • Set DS_CircleStartAngle[6] = 120.00
    • -------- Each Array of this Variable set the Damages deals by each Ball for each Level. --------
    • -------- Chaque Déploiement de cette Variable détermine les Dommages infligés par chaque Boule pour chaque Niveau. --------
    • Set DS_BallDamages[1] = 50.00
    • Set DS_BallDamages[2] = 75.00
    • Set DS_BallDamages[3] = 100.00
    • -------- Each Array of this Variable set the Life stolen by each Ball for each Level. This don't add damages ! --------
    • -------- Chaque Déploiement de cette Variable détermine la Vie volée par chaque Boule pour chaque Niveau. Cela ne rajoute pas de Dommages ! --------
    • Set DS_BallLifeSteal[1] = 25.00
    • Set DS_BallLifeSteal[2] = 37.50
    • Set DS_BallLifeSteal[3] = 50.00
    • -------- Each Array of this Variable set the Area of Effect of the Damages deals by each Ball for each Level --------
    • -------- Chaque Déploiement de cette Variable détermine la Zone d'Effet des Dommages infligés par chaque Boule pour chaque Niveau. --------
    • Set DS_BallDamagesAoe[1] = 80.00
    • Set DS_BallDamagesAoe[2] = 80.00
    • Set DS_BallDamagesAoe[3] = 80.00
    • -------- Each Array of this Variable set the Height Increase for each Ball for each CIrcle --------
    • -------- Chaque Déploiement de cette Variable détermine l'Incrémentation de Hauteur pour chaque boule de chaque Cercle. --------
    • Set DS_BallHeightIncrease[1] = 5.00
    • Set DS_BallHeightIncrease[2] = 5.00
    • Set DS_BallHeightIncrease[3] = 5.00
    • Set DS_BallHeightIncrease[4] = 5.00
    • Set DS_BallHeightIncrease[5] = 5.00
    • Set DS_BallHeightIncrease[6] = 5.00
    • -------- Each Array of this Variable set the Speed and the Direction of each Ball for each Circle. --------
    • -------- Chaque Déploiement de cette Variable détermine la Vitesse et la Direction des Boules pour chaque Cercle. --------
    • -------- Set it to a Positive value for turning from North to East and to a Negative value for turning from North to West. --------
    • -------- Mettez le Ã* une valeur Positive pour que le cercle tourne dans le sens des Aiguilles d'une Montre et Ã* une valeur Négative pour que le cercle tourne dans le sens Inverse des Aiguilles d'une Montre. --------
    • Set DS_BallDirectionAndSpeed[1] = 5.00
    • Set DS_BallDirectionAndSpeed[2] = -5.00
    • Set DS_BallDirectionAndSpeed[3] = 5.00
    • Set DS_BallDirectionAndSpeed[4] = -5.00
    • Set DS_BallDirectionAndSpeed[5] = 5.00
    • Set DS_BallDirectionAndSpeed[6] = -5.00
    • -------- Each Array of this Variable set the Duration of the Spell for a specific Level. --------
    • -------- Chaque Déploiement de cette Variable définis la Durée du Sort pour un Niveau Spécifique. --------
    • Set DS_Duration[1] = 20.00
    • Set DS_Duration[2] = 25.00
    • Set DS_Duration[3] = 30.00
    • -------- This is the special effect at Ball Spawn. --------
    • -------- L'effet spécial lors du Spawn d'une Boule. --------
    • Set DS_Effect = Abilities\Spells\Human\Feedback\ArcaneTowerAttack.mdl
    • -------- Create and Store Hashtable --------
    • -------- Crée et Store une Hashtable --------
    • Hashtable - Create a hashtable
    • Set DS_Hashtable = (Last created hashtable)

DS Cast

• DS Cast
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Demon Spinning
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (DS_CastersGroup is empty) Equal to True
        • (DS_BallsGroup is empty) Equal to True
      • Then - Actions
        • Trigger - Turn on DS Loop <gen>
        • Trigger - Turn on DS End <gen>
        • Trigger - Turn on DS UDie <gen>
      • Else - Actions
    • Unit Group - Add (Triggering unit) to DS_CastersGroup
    • Hashtable - Save DS_Duration[(Level of Demon Spinning for (Triggering unit))] as 0 of (Key (Triggering unit)) in DS_Hashtable
    • Hashtable - Save 0.00 as 1 of (Key (Triggering unit)) in DS_Hashtable
    • Hashtable - Save 0 as 2 of (Key (Triggering unit)) in DS_Hashtable

DS Loop

• DS Loop
  • Events
    • Time - Every 0.04 seconds of game time
  • Conditions
  • Actions
    • Unit Group - Pick every unit in DS_CastersGroup and do (Actions)
      • Loop - Actions
        • Set DS_TempUnit = (Picked unit)
        • Hashtable - Save ((Load 0 of (Key (Picked unit)) from DS_Hashtable) - 0.04) as 0 of (Key (Picked unit)) in DS_Hashtable
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Load 0 of (Key (Picked unit)) from DS_Hashtable) Less than or equal to 0.00
          • Then - Actions
            • Unit Group - Remove DS_TempUnit from DS_CastersGroup
            • Hashtable - Clear all child hashtables of child (Key (Picked unit)) in DS_Hashtable
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • (DS_CastersGroup is empty) Equal to True
                • (DS_BallsGroup is empty) Equal to True
              • Then - Actions
                • Trigger - Turn off DS End <gen>
                • Trigger - Turn off DS UDie <gen>
                • Trigger - Turn off (This trigger)
              • Else - Actions
          • Else - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Load 2 of (Key (Picked unit)) from DS_Hashtable) Greater than or equal to 5
          • Then - Actions
            • Hashtable - Save ((Load 1 of (Key (Picked unit)) from DS_Hashtable) + 1.00) as 1 of (Key (Picked unit)) in DS_Hashtable
            • Hashtable - Save 0 as 2 of (Key (Picked unit)) in DS_Hashtable
            • Set DS_CasterLocation = (Position of DS_TempUnit)
            • For each (Integer A) from 1 to DS_NumberOfCircle[(Level of Demon Spinning for DS_TempUnit)], do (Actions)
              • Loop - Actions
                • Set DS_BallLocation = (DS_CasterLocation offset by DS_CircleAoe[(Integer A)] towards (((Facing of DS_TempUnit) + DS_CircleStartAngle[(Integer A)]) + ((Load 1 of (Key (Picked unit)) from DS_Hashtable) x DS_CircleDirectionAndSpeed[(Integer A)])) degrees)
                • Unit - Create 1 DS Ball for (Owner of DS_TempUnit) at DS_BallLocation facing Default building facing degrees
                • Hashtable - Save (Integer A) as 0 of (Key (Last created unit)) in DS_Hashtable
                • Hashtable - Save Handle OfDS_TempUnit as 1 of (Key (Last created unit)) in DS_Hashtable
                • Animation - Change (Last created unit) flying height to 0.00 at 1000000.00
                • Special Effect - Create a special effect at DS_BallLocation using DS_Effect
                • Special Effect - Destroy (Last created special effect)
                • Unit Group - Add (Last created unit) to DS_BallsGroup
                • Unit - Add a 6.00 second Generic expiration timer to (Last created unit)
                • Custom script: set bj_wantDestroyGroup = true
                • Unit Group - Pick every unit in (Units within DS_BallDamagesAoe[(Level of Demon Spinning for DS_TempUnit)] of DS_BallLocation matching (((Matching unit) belongs to an enemy of (Owner of DS_TempUnit)) Equal to True)) and do (Actions)
                  • Loop - Actions
                    • Unit - Cause DS_TempUnit to damage (Picked unit), dealing DS_BallDamages[(Level of Demon Spinning for DS_TempUnit)] damage of attack type Chaos and damage type Universal
                    • Unit - Set life of DS_TempUnit to ((Life of DS_TempUnit) + DS_BallLifeSteal[(Level of Demon Spinning for DS_TempUnit)])
                • Custom script: call RemoveLocation(udg_DS_BallLocation)
            • Custom script: call RemoveLocation(udg_DS_CasterLocation)
          • Else - Actions
            • Hashtable - Save ((Load 2 of (Key (Picked unit)) from DS_Hashtable) + 1) as 2 of (Key (Picked unit)) in DS_Hashtable
    • Unit Group - Pick every unit in DS_BallsGroup and do (Actions)
      • Loop - Actions
        • Set DS_BallLocation = (Position of (Picked unit))
        • Set DS_CasterLocation = (Position of (Load 1 of (Key (Picked unit)) in DS_Hashtable))
        • Set DS_BallLocationNew = (DS_CasterLocation offset by DS_CircleAoe[(Load 0 of (Key (Picked unit)) from DS_Hashtable)] towards ((Angle from DS_CasterLocation to DS_BallLocation) + DS_BallDirectionAndSpeed[(Load 0 of (Key (Picked unit)) from DS_Hashtable)]) degrees)
        • Set DS_TempReal = ((Current flying height of (Picked unit)) + DS_BallHeightIncrease[(Load 0 of (Key (Picked unit)) from DS_Hashtable)])
        • Unit - Move (Picked unit) instantly to DS_BallLocationNew, facing DS_BallLocation
        • Animation - Change (Picked unit) flying height to DS_TempReal at 10000000.00
        • Custom script: call RemoveLocation(udg_DS_CasterLocation)
        • Custom script: call RemoveLocation(udg_DS_BallLocation)
        • Custom script: call RemoveLocation(udg_DS_BallLocationNew)

DS End

• DS End
  • Events
    • Unit - A unit Is issued an order targeting an object
    • Unit - A unit Is issued an order targeting a point
    • Unit - A unit Is issued an order with no target
  • Conditions
    • ((Triggering unit) is in DS_CastersGroup) Equal to True
  • Actions
    • Unit Group - Remove (Triggering unit) from DS_CastersGroup
    • Hashtable - Clear all child hashtables of child (Key (Triggering unit)) in DS_Hashtable
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (DS_CastersGroup is empty) Equal to True
        • (DS_BallsGroup is empty) Equal to True
      • Then - Actions
        • Trigger - Turn off DS Loop <gen>
        • Trigger - Turn off DS UDie <gen>
        • Trigger - Turn off (This trigger)
      • Else - Actions

DS UDie

• DS UDie
  • Events
    • Unit - A unit Dies
  • Conditions
    • (Unit-type of (Triggering unit)) Equal to DS Ball
  • Actions
    • Hashtable - Clear all child hashtables of child (Key (Triggering unit)) in DS_Hashtable
    • Unit Group - Remove (Triggering unit) from DS_BallsGroup
    • Unit - Remove (Triggering unit) from the game
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (DS_CastersGroup is empty) Equal to True
        • (DS_BallsGroup is empty) Equal to True
      • Then - Actions
        • Trigger - Turn off DS Loop <gen>
        • Trigger - Turn off DS End <gen>
        • Trigger - Turn off (This trigger)
      • Else - Actions

Now, let's move on to optimizations shall we? :>

edit

For DS Cast:
- Cache (Triggering unit) into a unit variable (TempUnit)
- Cache Key(TempUnit) into an integer variable: Custom script: set udg_TempInteger = GetHandleId(udg_TempUnit)

For DS Loop:
- Cache Key(Picked unit) -> Custom script: set udg_TempInteger = GetHandleId(udg_DS_TempUnit) and use TempInteger instead.
- Cache (Last created unit) and other functions into temporary variables
- You can use 0 as the rate for changing the flying height instead of using 1000000 because 0 makes it instant.
- Cache the level of the ability into a variable because you're referencing it hundreds of times in there (The Group enumerations repeat the enclosed code multiple times)

For DS End:
- Cache (Triggering unit) for efficiency and instead of using that "Clear all child .." line, use this custom script: call FlushChildHashtable(udg_DS_Hashtable, GetHandleId(udg_DS_TempUnit))
This way, you'd actually gain something from caching the triggering unit.

For DS UDie:
- Same as DS End, cache the triggering unit and instead of "Clear all child ..", use this: call FlushChildHashtable(udg_DS_Hashtable, GetHandleId(udg_DS_TempUnit))

[------------End of Optimizationfag talk------------]
Hope this helps :>

 

[Vladadamm]

Ty, magtheridon, i'll do the changes soon.

 

[wickedcool]

holy shit lots of sperm cells flying damn!!
btw awesome spell!

 

[Magtheridon96]

holy shit lots of sperm cells flying damn!!

Indeed
They're actually wands

 

[Da Fist]

holy shit lots of sperm cells flying damn!!
btw awesome spell!

Heh, I have the same thought when I saw this spell

Pretty cool though, Awesome Vlad

EDIT: Looks awesome in-game!

 

[RakEnRoL]

Wow! I like what I see here. Will test it.

 

[wickedcool]

Heh, I have the same thought when I saw this spell

you can use "lots of puny lil baby frogs swimming around lol"

 

[Vladadamm]

Changes are done, except for the 0.04 periodic --> 0.03, since i prefer avoid lag when you use the spell with a not very good computer.

 

[RakEnRoL]

Hello, I like this spell a lot. The effects is really cool. The coding is pretty clean at least. So, this is a job well done.

Rating: 4.5/5
The movement of the effects are awesome
Well, the effects doesn't do anything much
In my view, it lags when you channel too much of them.
The spell is special because of the effects nothing more
I like it.

 

[Vladadamm]

Version 1.02 uploaded.

I added 2new variables for have more configs and reduce lags if wanted. I also improved the EN Import Notice.

Enjoy it.

 

[Vladadamm]

Version 1.03 uploaded.

I stored the Level of Ability at the moment of casting and i tried to diminue lags on Test Map.

 

[Adiktuz]

the spell looks good, I just hope no one spams this spell... ^_^

 

[Final-Burn]

Fantastic Spell. +Rep. I wonder If I can change the Circle Effect. Good job Anyway

EDIT AFTER TEST:
HOLY CRAP THATS LAGGY AT LEVEL 2 + 3

 

[Vladadamm]

If the spell will lag or not, this depend of multiple parameters ^^ Just on the test map, i've based it on the esthetics, and not on the performance.

Since i did it for a contest on another forum, and i wasn't able to lose points cauz' to lags since it was removable with all the variable sets and also, i won points in esthetics ^^

 

[Final-Burn]

Oh okay. You know. This is a Great Spell. With all the Evil looking sperms (Jokes) But you should perfect it with reduce of lag. Because I open it and tried level 1: Worked Fine. Level 2: Holy Burn! Alt + F4. So if you fix that. I will 5/5 And Rep you.

 

[Vladadamm]

I have just set it to tests parameters, it's to you to configure all the variables as you want. If there is about 15 variables for the spells configurations, there is a reason ^^

 

[Vladadamm]

I added a video of the spell in the Spell Description.

 

[kakuzu]

It has a great animation .

 

[kruzerg]

i use this spell in my map, i need reduce loop time to 0.08 or 0.1 sec to reduce lag
but the 1st time i cast this spell in my map the 1st 20 seconds will be lag
after that not lag anymore no matter how many times i cast this spell
why is that?

this is unperfect spell btw since the lag is the problem