Double Spinning Blade v1.1.5

[Ofel]

@Rheiko
really? you're saying well...
if not because my dad, i may need several years to make my english a bit better like now...

 

[Rheiko]

i learn them by myself :\
and i improve them from internet and games
cuz english lesson is really slow, and boring

 

[Malhorne]

i learn them by myself :\
and i improve them from internet and games
cuz english lesson is really slow, and boring

So true~

Anyway change the recycling to make this approved \o/

 

[Rheiko]

recycling?

 

[Malhorne]

Oups de-indexing sry was thinking to another thing xD !

 

[Ofel]

Wow, this is a simple spell but has many posts!

 

[Rheiko]

the best thing from my spell, that is

 

[Rheiko]

updated v1.1

 

[deathismyfriend]

updated v1.1

Please read my posts. They have some improvements that this spell needs. You did fix the de-indexing problem but missed the other stuff i said.

 

[Rheiko]

and what is that? i'm sure i've fix them already

 

[deathismyfriend]

Store picked unit before the ITE and use the variable in the conditions.

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
• If - Conditions
• ((Picked unit) belongs to an enemy of DSB_Owner[DSB_Current_Index]) Equal to DSB_Conditions[1]
• ((Picked unit) is alive) Equal to DSB_Conditions[2]
• ((Picked unit) is Magic Immune) Equal to DSB_Conditions[3]
• ((Picked unit) is A structure) Equal to DSB_Conditions[4]
• ((Picked unit) is in DSB_UnDamage_Group[DSB_Current_Index]) Equal to DSB_Conditions[5]
• Then - Actions
• Set TempUnit = (Picked unit)

Move your turn off ITE in the loop trigger into the de-indexing portion of the spell.

You also leak tempPoint and tempPoint2 in your looping trigger.

 

[Rheiko]

about ITE yes, it's my mistake
gonna fix it ASAP

about TempPoint and TempPoint2, where?

 

[Rheiko]

UPDATED v1.1.1

 

[deathismyfriend]

Here.

Leaks

• Set TempPoint = (Position of DSB_Dummy[DSB_Current_Index])
• Set TempPoint2 = (TempPoint offset by (DSB_Distance x 0.03) towards DSB_Angle[DSB_Current_Index] degrees)
• Unit - Move DSB_Dummy[DSB_Current_Index] instantly to TempPoint2
• Set DSB_Damage_Group[DSB_Current_Index] = (Units within DSB_AoE of TempPoint)
• Unit Group - Pick every unit in DSB_Damage_Group[DSB_Current_Index] and do (Actions)
• Loop - Actions
• Set TempUnit = (Picked unit)
• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
• If - Conditions
• (TempUnit belongs to an enemy of DSB_Owner[DSB_Current_Index]) Equal to DSB_Conditions[1]
• (TempUnit is alive) Equal to DSB_Conditions[2]
• (TempUnit is Magic Immune) Equal to DSB_Conditions[3]
• (TempUnit is A structure) Equal to DSB_Conditions[4]
• (TempUnit is in DSB_UnDamage_Group[DSB_Current_Index]) Equal to DSB_Conditions[5]
• Then - Actions
• Unit - Cause DSB_Caster[DSB_Current_Index] to damage TempUnit, dealing DSB_Damage[DSB_Ability_Level[DSB_Current_Index]] damage of attack type Spells and damage type Normal
• Special Effect - Create a special effect attached to the DSB_Special_Effect_Location of TempUnit using DSB_Special_Effect
• Special Effect - Destroy (Last created special effect)
• Unit Group - Add TempUnit to DSB_UnDamage_Group[DSB_Current_Index]
• Else - Actions
• Custom script: call DestroyGroup(udg_DSB_Damage_Group[udg_DSB_Current_Index])
• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
• If - Conditions
• DSB_Destroy_Tree Equal to True
• Then - Actions
• Destructible - Pick every destructible within DSB_AoE of TempPoint and do (Actions)
• Loop - Actions
• Set TempDest = (Picked destructible)
• Unit - Order DSB_Destroyer to Harvest TempDest
• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
• If - Conditions
• (Current order of DSB_Destroyer) Equal to (Order(harvest))
• Then - Actions
• Destructible - Kill TempDest
• Else - Actions
• Unit - Order DSB_Destroyer to Stop
• Else - Actions
• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
• If - Conditions
• (DSB_Dummy[DSB_Current_Index] is dead) Equal to True
• Then - Actions
• Custom script: call DestroyGroup(udg_DSB_UnDamage_Group[udg_DSB_Current_Index])
• Custom script: set udg_DSB_UnDamage_Group[udg_DSB_Max_Index] = CreateGroup()
• Set DSB_Stage[DSB_Current_Index] = 2
• Custom script: call RemoveLocation(udg_TempPoint2)
• Set TempPoint2 = (Position of DSB_Caster[DSB_Current_Index])
• Unit - Create 1 DSB_Dummy_Type2 for DSB_Owner[DSB_Current_Index] at TempPoint facing TempPoint2
• Set DSB_Dummy2[DSB_Current_Index] = (Last created unit)
• Unit - Add a DSB_Dummy2_Lifetime second Generic expiration timer to DSB_Dummy2[DSB_Current_Index]
• Animation - Change DSB_Dummy2[DSB_Current_Index]'s vertex coloring to (DSB_Dummy2_RED%, DSB_Dummy2_GREEN%, DSB_Dummy2_BLUE%) with DSB_Dummy2_Transparency% transparency
• Animation - Play DSB_Dummy2[DSB_Current_Index]'s DSB_Dummy2_Animation animation
• Custom script: call RemoveLocation(udg_TempPoint)
• Set TempPoint = (Position of DSB_Dummy2[DSB_Current_Index])
• Set DSB_Angle[DSB_Current_Index] = (Angle from TempPoint to TempPoint2)
• Set TempPoint3 = (TempPoint offset by DSB_Start_Range towards DSB_Angle[DSB_Current_Index] degrees)
• Unit - Remove DSB_Dummy[DSB_Current_Index] from the game
• Unit - Create 1 DSB_Dummy_Type for DSB_Owner[DSB_Current_Index] at TempPoint3 facing DSB_Angle[DSB_Current_Index] degrees
• Set DSB_Dummy[DSB_Current_Index] = (Last created unit)
• Unit - Add a ((DSB_Distance x 0.03) x 0.03) second Generic expiration timer to DSB_Dummy[DSB_Current_Index]
• Custom script: call RemoveLocation(udg_TempPoint)
• Custom script: call RemoveLocation(udg_TempPoint3)
• Else - Actions
• Custom script: call RemoveLocation(udg_TempPoint)
• Custom script: call RemoveLocation(udg_TempPoint2)

You need to remove the point handle before you overwrite it.

 

[Rheiko]

sorry but i kinda hard to understand which one is it?

 

[Ofel]

@dimf
Unreadable...
But not bad

 

[Rheiko]

☆i guess he is using mobile or somethin'☆

 

[deathismyfriend]

sorry but i kinda hard to understand which one is it?

i said already it is in your loop trigger. Find the right spot then look at the point variables. Then you can find the problem

 

[Rheiko]

that's my problem and my weakness, i can't find my mistakes by myself

 

[deathismyfriend]

I showed you where it was and told you how to fix it.

 

[Rheiko]

i will fix it ASAP

 

[Maker]

You should get rid of the unit dies trigger.

 

[Rheiko]

why? if i remove them, dummy will play death animation :\

UPDATED v1.1.2

 

[FUJI]

why? if i remove them, dummy will play death animation :\

use a dummy model created by vexorian in that way you can attach shadow hunter in that dummy then destroy that sfx. So in that way you're not needed now to create a Dummy Removal Trigger but it depends on you what you want .

 

[Rheiko]

link please

 

[FUJI]

^ I don't know where it is maybe in wc3 threads. Tell Ofel where did he download that model or use the spell of Ofel that uses that model like "Seeking Cluster Rockets" then export and import the model " dummy.mdx "

 

[nhocklanhox6]

Cool spell. 4/3

 

[Rheiko]

what's that supposed to mean?

 

[nhocklanhox6]

That mean: this spell 3/5 but i want to give 4/5 => 4/3, just kidding, 4/5 for this cool spell

 

[Rheiko]

ow, okay

 

[Rheiko]

UPDATED v1.1.3

 

[Malhorne]

W8 a bit before bumping each time you made an update x)
Since 4h isn't long xD

 

[Rheiko]

there is a limitation for an update?
so each time you update the reader should wait for a certain hour?
no no no

 

[Malhorne]

I said that you don't have to bump always
There is too much messages in this thread xD

 

[Rheiko]

but you yourself just make this thread much longer than it's need

 

[T. D. W.]

Review

Suggestions

Rating

None, Good spell, and very useful
You can add a boolean that makes the following:
if true, the shadow will appear and throw the blade back
if false, the blade will just disappear without any shadow
the reason?:
many people that are not very good at triggering do not know how to create a line damaging spell, meaning it only damages units once, they know to make loop damaging

Add a delay before the blade is thrown back, to maintain the animation of the shadow, to make it look more real
and make the shadow a little less invisible, he does not appear well in the game

 

[Rheiko]

^thanks

 

[Rheiko]

*bump*

UPDATED v1.1.4

Note: i'm a bit confused where should i put the turn off ITE, if what i did was wrong please tell me

 

[T. D. W.]

That is right

 

[Rheiko]

okay then

 

[T. D. W.]

Review

Suggestions

Rating

Judgement

My Words

Very neat spell, and great work

The Delay added before the throw back is still a suggestion

If You want me to review an Update of This Spell, Please Notifiy me this by VM or PM, +rep

 

[DESTROYER123]

Gonna use it for my samurai!
5/5

 

[NightStalker]

why did you create arrays for ability level, angle, caster, conditions, damage, dummy unit etc.

I'm trying to make my own spell with using triggers and i'm studying over your triggers i use just the type of the variable like the caster is a unit type variable not unit array .

Can you explain the reason i'm just wondering if yours is more efficient by this way.

 

[Rheiko]

i did it for its MUI-ness (MUI = Multi Unit Instanceable) so multiple unit could cast it at the same time
i use indexed array method

 

[FUJI]

why did you create arrays for ability level, angle, caster, conditions, damage, dummy unit etc.

I'm trying to make my own spell with using triggers and i'm studying over your triggers i use just the type of the variable like the caster is a unit type variable not unit array .

Can you explain the reason i'm just wondering if yours is more efficient by this way.

If you see some are arrays, It is called Indexed Arrays. This method can do a MUI ( Multi - Unit Instanceability ). These method needed a two integer variables, Allocating into the execution and deallocating or recycling in the loop. There are some methods making your spell MUI. Indexed Arrays, Dynamic Indexing, Linked List, Hashtable, Unit Indexer.

So you want to learn what Rheiko does a method??? Read here: Dynamic Indexing

 

[Rheiko]

thanks for explaining it jakeZinc

 

[NightStalker]

thank you guys, both of you this made a lot of things clear in my mind i'm just getting into these mui spells with triggers and i used your triggers for my spell but i don't know thich code is for which action so my spell has got a lot of issues

 

[FUJI]

Don't afraid to post the problem in WEHZ [ World Editor Help Zone ] or T&S [ Triggers and Scripts ]

 

[Rheiko]

Updated v1.1.5

 

[FUJI]

Hmmm.. might I review the v1.1.5 later ^^.