[General] Removing nothing

[RandomUser]

Is there any performance loss when you remove non-existent abilities from unit, or when removing unit from unit group in which he is not consists?
Thanks in advance and +rep to everyone.

 

[PurgeandFire]

It is fine. Nothing bad will happen.

 

[RandomUser]

So, when adding ability that unit already have, nothing bad will happen, too?

 

[sethmachine]

Yes it doesn't do anything bad. I suppose you're doing this because it makes your code more general? As in whatever triggers you adding the ability could be a unit that already has it

 

[Chaosy]

generally if something is not found the line wont run. Or well it will run but you wont notice anything.

 

[BPower]

Nothing bad will happen as everyone stated already.

The UnitAddAbility/UnitRemoveAbility natives return a boolean.

If you add an ability to a unit which that unit already has --> nothing happens and the function will return false.
If you remove an ability from a unit which that unit doesn't have --> nothing happens and the function will return false.

How to we use that to our benefit:

if UnitAddAbility(unit, ability) then
    call KillUnit(unit)
else
    //
endif

 

[RandomUser]

Thanks!

 

[WaterKnight]

In these specific case, it does not matter. It takes a bit of performance for the function call, of course. However, you should not assume that every function is protected against each kind of invalid input. For example trying to destroy already destroyed lightnings regularly induces fatal error despair.

 

[Dr Super Good]

For example trying to destroy already destroyed lightnings regularly induces fatal error despair.

Yes except that is cleaning up something that does not exist. This is altering something that does exist.