Physical Damage Detection for GUI v1.3.0.0

[Wietlol]

It should work properly, otherwise it wouldnt be approved.

You could (for a test case) damage the attacking unit to see if you can deal damage.
If so, the problem was probably with your group enumeration.

 

[Sunchips]

It should work properly, otherwise it wouldnt be approved.

You could (for a test case) damage the attacking unit to see if you can deal damage.
If so, the problem was probably with your group enumeration.

Are you sure?

This is a crude and leaking, but simple example of what I mean. This chrashes the game.

• Damage Event
  • Events
    • Game - PDD_damageEventTrigger becomes Equal to 1.00
  • Conditions
  • Actions
    • Unit Group - Pick every unit in (Units within 512.00 of (Position of PDD_source) matching ((((Matching unit) is alive) Equal to True) and (((Matching unit) belongs to an enemy of (Owner of PDD_source)) Equal to True))) and do (Actions)
      • Loop - Actions
        • Unit - Cause PDD_source to damage (Picked unit), dealing 10.00 damage of attack type Normal and damage type Normal

Edit: I read up a bit and realized I need to use the function UnitDamageTargetEx
I'm not that familliar with functions, could someone try and explain to me how to type it in to the GUI action Call custom script?

Edit 2: Nvm I figured out by checking the testmap triggers.

 

[Wietlol]

Ow wait, sorry, I thought this was Bribe's DDS.

Yea, you have to use a custom script (or maybe a trigger call if lfh implemented that) to deal damage if the event was the onDamage event.
It is not really nice, but it works... to an extend.

 

[Darkfang]

Sometimes when I cast a spell, it seemingly randomly sometimes heals the enemy rather than damaging it. Doesn't seem to matter whether or not the spell is custom or standard. Also it goes back to working just fine, then back to healing them again, etc. I can't pinpoint any reason that this would happen. It just seems like it all of a sudden starts reversing the damage I should be doing and making it heal instead. I thought it might have been because I was using an older version or I accidentally messed with the code somewhere, but I re-installed the newest version and it still happens. Anybody ever have this problem or know what's causing it?

Something odd happens to me too, I use this system in a Moba map and it seems that from time to time some abilities/heroes start dealing double damage and some things stop working, I don't know why actually, after a few seconds everything goes back to normal e.e

 

[The Wanderer]

Hi there! Is it possible to make a spell that reduces all incoming damage to zero while reflecting damage at the same time? I tried to make a spell and it reduced the damage to zero the entire test run.

 

[Darkfang]

Hi there! Is it possible to make a spell that reduces all incoming damage to zero while reflecting damage at the same time? I tried to make a spell and it reduced the damage to zero the entire test run.

Yeah, it is easy to do, just save the amount in a variable before setting it to 0, include the target in a group or make a unit variable to make sure the damage doesnt return eternally (prevent bugs) and cause the target to damage the source by said amount you previously saved in the variable. I recommend you to actually do various triggers when handling the damage detection system; by example I have an entire row of different triggers for A: primal events, b physical damage (modifications, amplifications, reductions, and then backfire damage and life steal) and then I have the row of the spell damage, and also you can create "true damage" by using groups or integers.

You can also use the function damage target ex :V but I don't use functions

 

[The Wanderer]

Yeah, it is easy to do, just save the amount in a variable before setting it to 0, include the target in a group or make a unit variable to make sure the damage doesnt return eternally (prevent bugs) and cause the target to damage the source by said amount you previously saved in the variable. I recommend you to actually do various triggers when handling the damage detection system; by example I have an entire row of different triggers for A: primal events, b physical damage (modifications, amplifications, reductions, and then backfire damage and life steal) and then I have the row of the spell damage, and also you can create "true damage" by using groups or integers.

You can also use the function damage target ex :V but I don't use functions

Wow thanks sir! A good amount of hours running around in darkness ended in a short beam of light! I'll try it and message you if i have any difficulties.

EDIT: Got confused in the storing damage before setting to zero part. Does it work on continous damage like multiple attackers, DOT, etc.?

 

[Darkfang]

Wow thanks sir! A good amount of hours running around in darkness ended in a short beam of light! I'll try it and message you if i have any difficulties.

EDIT: Got confused in the storing damage before setting to zero part. Does it work on continous damage like multiple attackers, DOT, etc.?

Damage is just a Real Numbers variable, it should work on any of it, by example in my map if I want to do something specific like adding damage on-hit I just create a dummy attacker for neutral passive with 0 damage (with both a magic attack and a hero attack to attack ethereals if necesary and magic immune), the mana of the dummy is the stored damage, and the custom value serves as the key array for the hero variable I use as reference (but you can use a hashtable and unit ID as key), so when the dummy attacks (event) I cause the hero to deal damage equal to the mana of the dummy, and so on. To set the type of damage I just put them in a group, "OnAttackMagicDamage" "OnAttackPhysicalDamage" "OnAttackTrueDamage", I may also put them on other groups for more special effects.

Another recommendation is to have by example a trigger of primary events in spell damage. In my map I've made my heroes abilities to deal 0.25 damage and things like that (numbers below 1) so I detect them on the early stages and add special things to abilities and modifiers (make them scale with agility, attack damage, or other custom stats).

Other trick to add on hits to basic attacks is to sacrifice either the orb of venom or the orb of corruption and set it's duration to 0.01 seconds, so when the unit has the buff and the attacker is "Xtype" you can run custom events on calculation, you can also use the Poison Arrow ability for this of course to have another different ability.

For on death effects just make a trigger called post damage, in the last events if the damage is bigger than current life run X event.

Btw make sure the dummy unit is a flying unit, worker and a structure (building cast and attack super super quick), make sure it's attack animation has a delay of something like 0.05 or 0.10 to avoid bugs, and create a trigger that causes AI to ignore guard position of any created dummy (entering unit) in the map to avoid further bugs.

 

[TheAyalalalalon]

I have a problem
I dont know why but the "Damage event" trigger adds a scroll of speed ability to all units (even buildings)

I know is this trigger because i disabled it and the skill was not added

 

[Wietlol]

Read how to configure this system.

 

[chanckaka]

Hello, may I ask you a question?
if I have so much hero and spell that need this system, should I include all spell in single trigger?
If yes, this trigger will have so much "if else", may be 100+, will the performance become slow? (Also it will be more difficult to manage spell)
If no, some spell may used to block or decrease damage, but it may overwrite by other trigger that placed below it?

Sorry for bothering you.

 

[Wietlol]

1, may I ask you a question?
No.

2, should I include all spell in single trigger?
Dunno.

3, will the performance become slow?
Not slower, probably faster, but still relatively slow for computers.
If you have separate triggers with a condition (or if statement in the actions) it will run that boolean expression.
In the case of triggers, evaluating the conditions and possibly executing the actions on top of the boolean expression.
In the case of a list of if statements, the overhead of the condition evaluations and action executions is removed.
So in essence, it is more efficient.
However, you pay a lot to get that little efficiency. You pay maintainability.

4, but it may overwrite by other trigger that placed below it?
Depends on how you use it.
If you just use if/then then both effects can be applied.
If the effects are something like "Set Damage = Damage + 10", then the damage will increase in both cases.
So overwriting is not really a thing.
However, some effects may not "work" how you want them to do.

For example, I have a buff that inreases my damage by 10, and I have a buff that increases my damage by 100%.
If I do (dmg + 10) -> (dmg * (1+1.00)) = (2dmg + 20)
If I do (dmg * (1+1.00)) -> (dmg + 10) = (2dmg + 10)
So, depending on which order the effects are applied, it may have different outcome.

That is why I would recommend to have different variables, like flatDamage and percentDamage.
Then, the above example would have (flatDamage + 10) -> (percentDamage * (1+1.00)) -> (flatDamage * percentDamage) = (2dmg + 20)
Ofcourse different variables for everything, including the block you mentioned.

Most times, these are quite hard to fix if you bind yourself to whatever you have.
Most times, the differences arent really notable or even matter (when they do matter however, it is frustrating).
Your game will still run with these flaws.

TLR
Dont worry about performance.
Dont worry about logical mistakes. However, do think twice about how your logic works.
Do care about organizing your triggers to make them maintainable.

 

[chanckaka]

1, may I ask you a question?
No.

2, should I include all spell in single trigger?
Dunno.

3, will the performance become slow?
Not slower, probably faster, but still relatively slow for computers.
If you have separate triggers with a condition (or if statement in the actions) it will run that boolean expression.
In the case of triggers, evaluating the conditions and possibly executing the actions on top of the boolean expression.
In the case of a list of if statements, the overhead of the condition evaluations and action executions is removed.
So in essence, it is more efficient.
However, you pay a lot to get that little efficiency. You pay maintainability.

4, but it may overwrite by other trigger that placed below it?
Depends on how you use it.
If you just use if/then then both effects can be applied.
If the effects are something like "Set Damage = Damage + 10", then the damage will increase in both cases.
So overwriting is not really a thing.
However, some effects may not "work" how you want them to do.

For example, I have a buff that inreases my damage by 10, and I have a buff that increases my damage by 100%.
If I do (dmg + 10) -> (dmg * (1+1.00)) = (2dmg + 20)
If I do (dmg * (1+1.00)) -> (dmg + 10) = (2dmg + 10)
So, depending on which order the effects are applied, it may have different outcome.

That is why I would recommend to have different variables, like flatDamage and percentDamage.
Then, the above example would have (flatDamage + 10) -> (percentDamage * (1+1.00)) -> (flatDamage * percentDamage) = (2dmg + 20)
Ofcourse different variables for everything, including the block you mentioned.

Most times, these are quite hard to fix if you bind yourself to whatever you have.
Most times, the differences arent really notable or even matter (when they do matter however, it is frustrating).
Your game will still run with these flaws.

TLR
Dont worry about performance.
Dont worry about logical mistakes. However, do think twice about how your logic works.
Do care about organizing your triggers to make them maintainable.

Woo my friend, you give me a great inspiration, I'm extremely grateful to you! Thanks!

 

[TheAyalalalalon]

What's exactly"attack type universal"?

 

[The Wanderer]

What's exactly"attack type universal"?

I forgot who told me but i think its an attack type that doesnt have armor or spell reduction.

 

[TheAyalalalalon]

I forgot who told me but i think its an attack type that doesnt have armor or spell reduction.

oooh i see.
And how can i trigger the spell damage for the system. I´ve made some abilities but how can i set the pdd_amount to, for example, magic damage?

 

[The Wanderer]

oooh i see.
And how can i trigger the spell damage for the system. I´ve made some abilities but how can i set the pdd_amount to, for example, magic damage?

Make variables for your spells, for example "Spell_DamageType" or "Spell_DamageAmount" or "Spell_AttackType" and set them to whatever you want. I'm not very familiar with attack and damage types so just explore and figure them out yourself.

 

[goldviper]

Please some1 help me some questions because this is important on my map ?
this system detect physic dmg Before reduction (the actualy att dmg of the unit before check armor type n armor value) or dmg After reduction (the HP actualy loss after take dmg ; hp removal )
Eg, i want to mimic the Cleave ability , unit A attack unit B (X armor) and cleave 100% to unit C (99999 armor) , i know that cleave ignore armor value so in here C still take dmg but not equal to the dmg unit B take ( because B have X armor and C's armor ignore = 0armor )
my english not good ,sry if you dont understand

 

[Wietlol]

It gives the damage taken (as in the value that the health will be reduced with).
It still gives the event before the actual health has been reduced.

 

[goldviper]

So with my Cleave ability ,when i hit a illusion that take x4 dmg more than normal (eg 100x4 HP) then nearby normal unit HP will be reduce the same ?
Im looking for the way to separate between dmg Before Reduction and dmg After Reduction in my spells
Eg: with dmg Before Reduction i can make ability that return the dmg and not depend how many HP attacked unit loss ,like X att dmg attack unit have 9999armor but return X dmg not 0 dmg
or some shell ability , dmg go through Shell then go through armor after , ect.
I also has abilities that use dmg After reduction value too . Any suggest for my map ?
Im newbie ,sorry if i request too much

 

[Wietlol]

You could simulate the attack to find out the damage reduction factor.
Then you do the calculations backwards.

There should be a snippet somewhere here that does that.

 

[TheAyalalalalon]

Hello
I have a question about the system and the damage triggers.
I noticed if i use an ability and i trigger the spell damage (example : 200 damage from object editor + 200 damage from triggers) and the event begins it does not detect the damage from the trigger but only from the ability
How can i fix it?

Example trigger that does not run the event:

• Ability
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Something
  • Actions
    • Unit - Cause (Casting Unit) to damage (Target unit of ability being cast), dealing 200 damage of attack type Spells and damage type Enhanced

Event

• Detect Spell Damage
  • Events
    • Game - PDD_damageEventTrigger becomes Equal to 1.00
  • Conditions
    • PDD_damageType Equal to PDD_SPELL
  • Actions
    • Set PDD_amount = (PDD_amount x 0.50)

Recapitulating: The trigger reduces the ability damage but not the triggered damage

Is There Anything That i did Badly?

 

[Wietlol]

I think because Enhanced damage is not considered spell damage.
The "Spells" part in your damage action is not a damage type, it is an attack type.

So, with that in mind, it doesnt pass the condition, so doesnt apply the actions.
Try with "Magic" damage type.

 

[TheAyalalalalon]

It works!! Thank you!

 

[TheAyalalalalon]

Hello
I need some help with the custom script because i want to modify the PDD_AMOUNT damage type (like doing bonus magic damage on auto attacks)

• Custom script: call UnitDamageTargetEx(udg_source, udg_target, stored_amount, false, false, ATTACK_TYPE_MAGIC, DAMAGE_TYPE_UNIVERSAL, null)

How can i set the amount to a Variable like this

• DA
  • Events
    • Game - PDD_damageEventTrigger becomes Equal to 1.00
  • Conditions
    • PDD_damageType Equal to PDD_PHYSICAL
    • PDD_source Equal to Hero
  • Actions
    • Set QDamage = (0.40 x ((Real((Intelligence of Hero (Include bonuses))))))
    • Custom script: call UnitDamageTargetEx(udg_source, udg_target, udg_QDamage, false, false, ATTACK_TYPE_MAGIC, DAMAGE_TYPE_UNIVERSAL, null)

Whatever number i put here it keeps doing 0 damage or auto disabling the trigger because of code errors

 

[Wietlol]

udg_source, udg_target are not just placeholders?
Try to replace those with udg_PDD_source and udg_PDD_target.

Maybe the problem is with the damage event, but I do not really know this one.

 

[TheAyalalalalon]

It did not work but it seems i have found a way to do it correctly

I am posting it for everybody that had the same issue

If you use a regular...

• Unit - Cause PDD_SOURCE to damage PDD_TARGET, dealing Variable damage of attack type Spells and damage type Magic

...with the trigger damage event

The game would crash instantly
Instead you can store another variable and use the trigger with no problem at all

• NigromanteDA
  • Events
    • Game - PDD_damageEventTrigger becomes Equal to 1.00
  • Conditions
    • PDD_damageType Equal to PDD_PHYSICAL
  • Actions
    • Set QSrc = PDD_source
    • Set QObj = PDD_target
    • Set QDamage = X
    • Set PDD_AMOUNT = PDD_AMOUNT
    • Unit - Cause QSrc to damage QObj, dealing QDamage damage of attack type Spells and damage type Magic

Note : You should set the pdd amount like i did because if you dont it will be replaced by the damage trigger

 

[Xonok]

That's not what the real problem is. Why it breaks is that you cause damage from a damage handler, which in turns runs the damage handles, which causes damage, which runs the handler... It's an infinite loop.
To prevent that you need to use UnitDamageTargetEx or otherwise avoid causing the handler to run again.

 

[TheAyalalalalon]

That's not what the real problem is. Why it breaks is that you cause damage from a damage handler, which in turns runs the damage handles, which causes damage, which runs the handler... It's an infinite loop.
To prevent that you need to use UnitDamageTargetEx or otherwise avoid causing the handler to run again.

I understand, but it seems that with the trigger I made it can be done without using a TargetEx custom script

 

[zv27]

It seems that this system is somehow broken.
With this system it is simply impossible to create an absorbing shield.

 

[TheAyalalalalon]

It seems that this system is somehow broken.
With this system it is simply impossible to create an absorbing shield.

It was the first thing I did
I will show you the trigger later

 

[btdonald]

It seems that this system is somehow broken.
With this system it is simply impossible to create an absorbing shield.

It's bugged with Life Drain, Mana Shield, you can check GUI Damage Engine of Bribe to understand clearly.

 

[TheAyalalalalon]

Hello!

I have been doing some triggers with the system and i have found a problem that i can not solve.

It follows that the PDD_amount action for modify the damage from a source works perfectly fine with all of my custom abilities but this one

• Pasaje HDps
  • Events
    • Time - Every 0.24 seconds of game time
  • Conditions
  • Actions
    • -------- DMG --------
    • Unit - Cause Ability to damage AbilityQTarget, dealing (3.25 x (Real((Level of Pasaje for Ability)))) damage of attack type Spells and damage type Magic
    • Unit - Cause Ability to damage AbilityQTarget, dealing (((0.01 / 4.00) x AbilityQTargetMAXHP) + 0.00) damage of attack type Spells and damage type Magic
    • -------- DMG% --------
    • Unit - Cause Ability to damage AbilityQTarget, dealing (((AbilityQTargetMAXHP - (Life of AbilityQTarget)) / AbilityQTargetMAXHP) x (0.50 x (3.25 x (Real((Level of Pasaje for Ability)))))) damage of attack type Spells and damage type Magic
    • -------- DMG%% --------
    • Unit - Cause Ability to damage AbilityQTarget, dealing (((AbilityQTargetMAXHP - (Life of AbilityQTarget)) / AbilityQTargetMAXHP) x (0.50 x ((0.01 / 4.00) x AbilityQTargetMAXHP))) damage of attack type Spells and damage type Magic
    • Set QPasajeCount = (QPasajeCount + 0.25)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • QPasajeCount Equal to 5.00
      • Then - Actions
        • Trigger - Turn off (This trigger)
      • Else - Actions

The previous trigger is turned on by this one, just in case

• Pasaje
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Pasaje
  • Actions
    • Set IncreaserQTarget = (Target unit of ability being cast)
    • Set IncreaserQTargetMAXHP = (Max life of IncreaserQTarget)
    • Set QPasajeCount = 0.00
    • Trigger - Turn on Pasaje HDps <gen>

This damage over time works the same with every character in the map, except those with a trigger of PDD_amount damage reduction

• piel de roca
  • Events
    • Game - PDD_damageEventTrigger becomes Equal to 1.00
  • Conditions
    • PDD_target Equal to whatever
    • PDD_damageType Equal to PDD_SPELL
  • Actions
    • Set PDD_amount = (PDD_amount x 0.40)

May someone tell me how to solve this?

 

[TheAyalalalalon]

It seems that this system is somehow broken.
With this system it is simply impossible to create an absorbing shield.

Here is the shield i promise


With these triggers the shield increases its life every time <your unit> casts a spell
The text will change its color from green to red based on the life remaining
The shield only protects your unit from Physical damage (you are able to change it)


ShieldVariables

• enginer variable
  • Events
    • Unit - A unit Learns a skill
  • Conditions
    • (Learned Hero Skill) Equal to Shield of Fate
  • Actions
    • Set SF_Caster = (Learning Hero)
    • Set SF_EscudoMaxReal[1] = 500.00
    • Set SF_EscudoMaxReal[2] = 850.00
    • Set SF_EscudoMaxReal[3] = 1100.00
    • Trigger - Turn off (This trigger)

Shield cast

• SF init
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Casting unit) Equal to SF_Caster
  • Actions
    • Floating Text - Destroy SF_EscudoText
    • Set SF_Real = (SF_Real + (Real((Intelligence of SF_Caster (Include bonuses)))))
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • SF_Real Greater than SF_EscudoMaxReal[(Level of Shield of Fate for SF_Caster)]
      • Then - Actions
        • Set SF_Real = SF_EscudoMaxReal[(Level of Shield of Fate for SF_Caster)]
      • Else - Actions
    • Special Effect - Create a special effect attached to the origin of SF_Caster using Abilities\Spells\Undead\AntiMagicShell\AntiMagicShell.mdl
    • Set SF_EscudoSE = (Last created special effect)
    • Floating Text - Create floating text that reads (String(SF_Real)) above SF_Caster with Z offset 0.00, using font size 10.00, color (100.00%, 100.00%, 100.00%), and 0.00% transparency
    • Set SF_EscudoText = (Last created floating text)
    • Trigger - Turn on SF text <gen>

Shield Current Life

• SF text
  • Events
    • Time - Every 0.05 seconds of game time
  • Conditions
  • Actions
    • Floating Text - Change the position of SF_EscudoText to SF_Caster with Z offset 0.00

OnDamageShield

• OnDamage Copiar
  • Events
    • Game - PDD_damageEventTrigger becomes Equal to 1.00
  • Conditions
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • PDD_damageType Equal to PDD_PHYSICAL
      • Then - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • PDD_target Equal to SF_Caster
          • Then - Actions
            • Set SF_Real = (SF_Real - PDD_amount)
            • Set PDD_amount = (PDD_amount - SF_Real)
            • Floating Text - Change text of SF_EscudoText to (String(SF_Real)) using font size 10.00
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • (Level of Shield of Fate for SF_Caster) Greater than or equal to 1
              • Then - Actions
                • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                  • If - Conditions
                    • SF_Real Less than or equal to (SF_EscudoMaxReal[(Level of Shield of Fate for SF_Caster)] x 1.00)
                    • SF_Real Greater than (SF_EscudoMaxReal[(Level of Shield of Fate for SF_Caster)] x 0.50)
                  • Then - Actions
                    • Floating Text - Change the color of SF_EscudoText to (0.00%, 100.00%, 0.00%) with 0.00% transparency
                  • Else - Actions
                • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                  • If - Conditions
                    • SF_Real Less than or equal to (SF_EscudoMaxReal[(Level of Shield of Fate for SF_Caster)] x 0.50)
                    • SF_Real Greater than (SF_EscudoMaxReal[(Level of Shield of Fate for SF_Caster)] x 0.25)
                  • Then - Actions
                    • Floating Text - Change the color of SF_EscudoText to (100.00%, 100.00%, 0.00%) with 0.00% transparency
                  • Else - Actions
                • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                  • If - Conditions
                    • SF_Real Less than or equal to (SF_EscudoMaxReal[(Level of Shield of Fate for SF_Caster)] x 0.25)
                  • Then - Actions
                    • Floating Text - Change the color of SF_EscudoText to (100.00%, 0.00%, 0.00%) with 0.00% transparency
                  • Else - Actions
              • Else - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • PDD_amount Less than or equal to 0.00
              • Then - Actions
                • Set PDD_amount = 0.00
              • Else - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • SF_Real Less than or equal to 0.00
              • Then - Actions
                • Set PDD_amount = PDD_amount
                • Set SF_Real = 0.00
              • Else - Actions
          • Else - Actions
      • Else - Actions

I know about leak in memory and so but you may fix them

 

[Cake is a Lie]

Ok,at first I looked at this...my 'lil mind is...you know,twisted. But when I learned this trigger,it really helped me a lot! Thanks!

 

[Devalut]

It seems that this system is somehow broken.
With this system it is simply impossible to create an absorbing shield.

It's Astonishingly Simple in bribe's system, I can post one later on for you today

 

[Darkfang]

Cannibalize does not work with this system either, if a unit is channeling cannibalize and its hit by a damage modification it will stop using cannibalize, therefore canceling the effect and destroying the corpse... I love this system but well, I will have to learn how to cope with it.

 

[Mirage1]

Well, have anyone tested if this is still working? I have tested the system in patch 1.30.1 and when a unit kills a foe using magic damage the XP and gold are not credited for the killing unit. You can easily test this by adding neutral hostile units. I highly prefer this system so I would like to see this issue fixed.

 

[chopinski]

Well, have anyone tested if this is still working? I have tested the system in patch 1.30.1 and when a unit kills a foe using magic damage the XP and gold are not credited for the killing unit. You can easily test this by adding neutral hostile units. I highly prefer this system so I would like to see this issue fixed.

I have the same problem. Recently imported this system into my map and it was doing great until i tested it with the newest version 1.30.2. Also if you create units at the exact frequency that the system clear memory, 60.0 seconds i think, the system do not work properly for those units. Plz mrs looking_for_help try fixing it, your system is awesome and very usefull, but if we cannot credit killing units than its usefullness gets greatly reduced.

 

[Mirage1]

The way I found was by manually add gold and xp to the killer. I've posted this so long ago that I almost forgot. (i never noticed the memory clear stuff, maybe it's a 1.30.2 bug idk)

 

[looking_for_help]

Thanks for the feedback. Just for information, I decided to wait with any updates/bugfixes until the patches are more stable, because otherwise it will result in potentially duplicate/obsolete work...

 

[chopinski]

The way I found was by manually add gold and xp to the killer. I've posted this so long ago that I almost forgot. (i never noticed the memory clear stuff, maybe it's a 1.30.2 bug idk)

How did you do that? In my game i cant even refer to KillingUnit(). I think i can only wait for a fix now.

 

[chopinski]

Thanks for the feedback. Just for information, I decided to wait with any updates/bugfixes until the patches are more stable, because otherwise it will result in potentially duplicate/obsolete work...

Ok, and thx for responding so quickly. Keep up the great work.

 

[Map Designer]

@Maker

is it more efficient to do multiple events of (damage event trigger becomes equal to 1), and add condition there for unit restriction?
or is it more efficient to make them all in one event and put all conditions in IF statements?

or is it irrelevant and equally good?

 

[Pyrogasm]

Irrelevant though filtering at the triggerconditions level is slightly more efficient.

 

[Palette]

Damn, this is useful and very easy to use, understand and manipulate. Thanks for making this tbh

 

[Palette]

I just noticed that damaging low hp units with spells will likely not give you bounty/gold for the kill

 

[OverClocked]

it seems to not work properly when i use the variables more than 1 time in the same trigger at the same time

 

[Bribe]

it seems to not work properly when i use the variables more than 1 time in the same trigger at the same time

I'm not sure what the exact problem is, but it could be that your resource is dealing recursive damage. I recommend using Damage Engine 5.2.0.1 as it compensates for all possible recursive situations - and even has backwards-compatibility with this resource.

 

[Bribe]

I would like to contribute this script which uses the anti-recursion method introduced in Damage Engine 5.1 which works thanks to the new 1.31 natives.

One need only to replace the PDD script with the below, as well as revert any changes to Runed Bracers/Locust Swarm and perhaps delete the 2 custom abilities as they are no longer needed.

This script is the lightest possible version of PDD and has been tested.

globals
    constant integer PDD_MAX_RECURSION = 16 //looking_for_help recommends using UnitDamageTargetEx to avoid recursion.
    timer PDD_timer = CreateTimer()
    boolean PDD_started = false
    boolean PDD_recursive = false
    unit array PDD_sources
    unit array PDD_targets
    real array PDD_amounts
    attacktype array PDD_attacks
    damagetype array PDD_damages
    weapontype array PDD_weapons
endglobals

//////////////////////////////////////////////////////////////////////////////////
//  User functions
//////////////////////////////////////////////////////////////////////////////////

function GetUnitLife takes unit u returns real //not needed, exists for backwards-compatibility
    return GetWidgetLife(u)
endfunction

function GetUnitMaxLife takes unit u returns real //not needed, exists for backwards-compatibility
    return GetUnitState(u, UNIT_STATE_MAX_LIFE)
endfunction

function SetUnitLife takes unit u, real newLife returns nothing //not needed, exists for backwards-compatibility
    call SetWidgetLife(u, newLife)
endfunction

//not really needed, exists for backwards-compatibility and recursion protection
function UnitDamageTargetEx takes unit source, unit target, real amount, boolean attack, boolean ranged, attacktype attackType, damagetype damageType, weapontype weaponType returns boolean
    local integer i = udg_PDD_damageType
    if i != udg_PDD_CODE then
        set udg_PDD_damageType = udg_PDD_CODE
        call UnitDamageTarget(source, target, amount, attack, ranged, attackType, damageType, weaponType)
        set udg_PDD_damageType = i
        return true
    endif
    return false
endfunction

////////////////////////////////////////////////////////////////////////////////////
//  Damage Engine
////////////////////////////////////////////////////////////////////////////////////

function AfterDamage takes nothing returns nothing
    local integer i = 0
    if udg_PDD_damageType < 0 then
        loop
            exitwhen i == udg_PDD_allocatedAttacks
            set udg_PDD_damageType = udg_PDD_CODE
            call UnitDamageTarget(PDD_sources[i], PDD_targets[i], PDD_amounts[i], true, false, PDD_attacks[i], PDD_damages[i], PDD_weapons[i])
            set i = i + 1
        endloop
        set udg_PDD_allocatedAttacks = 0
        set udg_PDD_damageType = -1
    endif
endfunction

function AfterDamagePrep takes nothing returns nothing
    set PDD_started = false
    call AfterDamage()
endfunction

function DamageEngine takes nothing returns boolean
    local real r = GetEventDamage()
    local integer i
    call AfterDamage()
    if r != 0.00 then
        if not PDD_recursive then
            set udg_PDD_amount = r
            set udg_PDD_source = GetEventDamageSource()
            set udg_PDD_target = GetTriggerUnit()
     
            // Determine the damage type
            if udg_PDD_damageType != udg_PDD_CODE then
                if BlzGetEventAttackType() != ATTACK_TYPE_NORMAL then
                    set udg_PDD_damageType = udg_PDD_PHYSICAL
                else
                    set udg_PDD_damageType = udg_PDD_SPELL
                endif
            endif

            set PDD_recursive = true
            set udg_PDD_damageEventTrigger = 0.00
            set udg_PDD_damageEventTrigger = 1.00
            set PDD_recursive = false

            call BlzSetEventDamage(udg_PDD_amount)
            set udg_PDD_damageType = -1
            if udg_PDD_amount <= 0.00 then
                call AfterDamage()
            endif
        else
            set i = udg_PDD_allocatedAttacks
            if i < PDD_MAX_RECURSION then
                set udg_PDD_allocatedAttacks = i + 1
                set PDD_sources[i] = GetEventDamageSource()
                set PDD_targets[i] = GetTriggerUnit()
                set PDD_amounts[i] = r
                set PDD_attacks[i] = BlzGetEventAttackType()
                set PDD_damages[i] = BlzGetEventDamageType()
                set PDD_weapons[i] = BlzGetEventWeaponType()
                if not PDD_started then
                    set PDD_started = true
                    call TimerStart(PDD_timer, 0.00, false, function AfterDamagePrep)
                endif
            endif
            call BlzSetEventDamage(0.00)
        endif
    endif
    return false
endfunction

////////////////////////////////////////////////////////////////////////////////////
//  Initialization
////////////////////////////////////////////////////////////////////////////////////

function InitTrig_DamageEvent takes nothing returns nothing
    local trigger t = CreateTrigger()
    call TriggerRegisterAnyUnitEventBJ(t, EVENT_PLAYER_UNIT_DAMAGED)
    call TriggerAddCondition(t, Filter(function DamageEngine))
    set t = null

    set udg_PDD_damageType = -1
    set udg_PDD_PHYSICAL = 0
    set udg_PDD_SPELL = 1
    set udg_PDD_CODE = 2
endfunction