Damage Detection System (GUI) For Reforged v0.6b

[Bribe]

Damage Engine already works with Reforged, uses a well-established API and does a lot more, more accurately, etc.

 

[M4gz]

Damage Engine already works with Reforged, uses a well-established API and does a lot more, more accurately, etc.

Thanks for you comment. That system using native reforged functions and variables. It saves tones lines of unnecessary JASS code and gives overall same as other damage engines. For example in your great DDS is a big problem to detect Attack type is normal i was need to detect if not a spell but it doesnt works in every case. That solution can easly filtering by damage and attack types, or in lightweight version just by BOOL is attack type is normal = false

 

[Pyrogasm]

Damage Engine can modify damage in the damaged event, but this system cannot. For that reason alone I would never use this, as modifying event damage is often one of the core things you want to do with a DDS.

This system should use the new “any unit takes damage” event instead of manually adding specific unit events for all units on the map. This method results in many erroneous and useless events populating the trigger. I do not know of a reason this is explicitly bad but it surely can’t be good.

 

[M4gz]

Damage Engine can modify damage in the damaged event, but this system cannot. For that reason alone I would never use this, as modifying event damage is often one of the core things you want to do with a DDS.

This system should use the new “any unit takes damage” event instead of manually adding specific unit events for all units on the map. This method results in many erroneous and useless events populating the trigger. I do not know of a reason this is explicitly bad but it surely can’t be good.

Thanks for your comment. That system made on GUI triggers and its not able to use event like "any unit damaged" blizzard gives only event "specific unit event" but in other way it makes more accurate and less costly solution if you need to determinate units to save resources. Can you show "erroneous and useless events populating the trigger" for me to fix it. As for me that is what blizzard's did to make in game DDS more friendly.
About modify damage you have same variables as in DDS and you can deal extra damage as you like. You have type of damage, amount, target and source - just make 1 trigger to deal damage to the target as type and amount you want - it's just 1 action. I was thinking about that but as i get the right way is to make it clean and let maker to do what he wants with damage.
PS it's a damage detect system not a damage modify system.

 

[Uncle]

Isn't there a limit with using Specific Unit Events like this? I'm pretty sure after a certain number of units are added to the Events it will stop supporting newer units.

 

[Lt_Hawkeye]

I'm not sure what patch you are on, but Blizzard did made available a "any unit damaged" event in the latest patches. Bribe's Damage Engine essentially adds this jass only(afaik) event to GUIers. Since I don't have reforged, I have no clue if blizzard added the event to GUI.

What Pryogasm meant was is that these events you add to the trigger will stay after the unit dies, essentially causing a permanent leak since the events are no longer in use or traceable until the trigger is destroyed (jass only)

 

[Uncle]

He's using:

• Trigger - Add to Damage Engine Core <gen> the event (Unit - (Triggering unit) Takes damage)

I'm like 90% sure this will stop working once you add a certain number of units.

 

[Pyrogasm]

That system made on GUI triggers and its not able to use event like "any unit damaged"

Blizzard did made available a "any unit damaged" event in the latest patches. Bribe's Damage Engine essentially adds this jass only(afaik) event to GUIers.

I forgot it was JASS only but yes this is what I meant.

Can you show "erroneous and useless events populating the trigger" for me to fix it.

What Pryogasm meant was is that these events you add to the trigger will stay after the unit dies, essentially causing a permanent leak since the events are no longer in use or traceable until the trigger is destroyed

About modify damage you have same variables as in DDS and you can deal extra damage as you like.

I can't deal negative damage to reduce the damage dealt by something.

PS it's a damage detect system not a damage modify system.

modifying event damage is often one of the core things you want to do with a DDS

 

[Bribe]

Thanks for you comment. That system using native reforged functions and variables. It saves tones lines of unnecessary JASS code and gives overall same as other damage engines. For example in your great DDS is a big problem to detect Attack type is normal i was need to detect if not a spell but it doesnt works in every case. That solution can easly filtering by damage and attack types, or in lightweight version just by BOOL is attack type is normal = false

Looks like Blizzard quietly added a nee native! I'm preparing an update to Damage Engine in light of this exciting news! Nice discovery, +rep

 

[M4gz]

Thank you all for your interest. I changed the event made generic event instead of specific as you told. Unfortunately in WE Reforged (Im using regular WE in Reforged) event is not exists and i was need to make like that:

• Damage Engine Event
  • Events
    • Map initialization
  • Conditions
  • Actions
    • Set VariableSet Damage_Trigger = Damage Engine Core <gen>
    • Custom script: call TriggerRegisterAnyUnitEventBJ(udg_Damage_Trigger, EVENT_PLAYER_UNIT_DAMAGED)

Variable Damage_Trigger is not necessary you can replace it with trigger name in custom script.
Also found an interesting thing how to detect last hit (dying moment)

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • (Life of (Damage Target)) Less than or equal to (Damage taken)
  • Then - Actions
    • Game - Display to (All players) the text: Unit is dead (lasth...
  • Else - Actions

 

[M4gz]

New Verison 0.3
Now its possible to use damage modifier as you like. It can be possitive to deal extra damage or reduce incoming damage. Or negative to up hp.
Just set variable value:

• Set VariableSet Damage_modifier = 10.00

Or

• Set VariableSet Damage_modifier = -100.00

Damage Engine can modify damage in the damaged event, but this system cannot. For that reason alone I would never use this, as modifying event damage is often one of the core things you want to do with a DDS

Done.

 

[M4gz]

Added tests for reccursions in 0.3b version in Event trigger. System is safe out of it.
What I need to add or change for approval?

 

[Bribe]

Looks like Blizzard quietly added a nee native! I'm preparing an update to Damage Engine in light of this exciting news! Nice discovery, +rep

Never mind! Uninstalling Reforged nuked my entire Maps folder, so the progress I made in implementing this is gone.

 

[M4gz]

Never mind! Uninstalling Reforged nuked my entire Maps folder, so the progress I made in implementing this is gone.

Sad to hear that. Could you give a review or some ideads to make it better

 

[Bribe]

Sad to hear that. Could you give a review or some ideads to make it better

Philosophically I am against having two differing systems with two different sets of APIs. If the idea is that you want yours to be a minimalist Damage Engine, I give you permission to have your API match mine so that implementers can at least have an easier time switching between the two.

As far as approvals go, I'm thankfully no longer a moderator so that's up to them to decide.

 

[M4gz]

Philosophically I am against having two differing systems with two different sets of APIs. If the idea is that you want yours to be a minimalist Damage Engine, I give you permission to have your API match mine so that implementers can at least have an easier time switching between the two.

As far as approvals go, I'm thankfully no longer a moderator so that's up to them to decide.

Thanks for answer. Ill try to implement with your system. If i add Armor type and Defence type (Do i need to store both types? Or only Defence type) And do i need to store these type/types for both - Source and Target unit or only for target?

 

[M4gz]

Update 0.4 : now its possible to detect targets type of defense (normal/heavy/fort/hero and so on)
-------
Update 0.4b : now its possible to detect targets type of armor (flesh/metal/wood/stone and so on)

 

[M4gz]

Update 0.5 : New event added when damage has been modified. You can handle new event after modification to get new value of damage and, for example, do extra damage or what you need.
----------------
Update 0.5a : Added extra handle for damage modification. Now it is possible to catch the event after 1st damage modification and after 2nd damage modification. For example tt would be usefully if you need to modificate damage by item then by passive skill and so on. You can add any count of handling just copypaste that part of code in core and change damage_event variable to +1

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • Damage_modifier Not equal to 0.00
  • Then - Actions
    • Custom script: call BlzSetEventDamage(udg_Damage_modifier)
    • Set VariableSet Damage_amount = (Damage taken)
    • Set VariableSet Damage_event = 2.00
  • Else - Actions

Next will be = 3.00 then = 4.00 and so on.
----------------
Update 0.5b : added damage key now you can get uniue key and compare it in future damage modifications to prevent useless conditions. For example make 1 time a key allow you to detect if event call was from point where you generate it.

 

[M4gz]

Update 0.6 Now varibables and methods compare with Bribe's DDS. Also added new methods, events and detections.

 

[SpasMaster]

I've gone through the description and features and I can't seem to find what does this system provide that @Bribe 's Damage Engine doesn't?

Even worse, it seems to include things directly based off of Bribe's Damage Engine.

Keep in mind that it needs to have something unique otherwise it would contradict the Resource Submission Rules (Models, skins, icons, spells).

All and any resources (including spells and systems) should provide something that users don't already have in the site.

If there is a such unique feature in the system, then I'd suggest focusing on it and building the system around it. Explain in the description what people can find in your system that they can't elsewhere. I may be wrong, but I haven't noticed one.

 

[Bribe]

@M4gz originally found this cool new native that led to me updating to Damage Engine 5.5, so I'm interested to see if he/she will cook up another new, undiscovered thing with this resource.

 

[M4gz]

Thanks for your anwers!

I've gone through the description and features and I can't seem to find what does this system provide that @Bribe 's Damage Engine doesn't?

Even worse, it seems to include things directly based off of Bribe's Damage Engine.

Keep in mind that it needs to have something unique otherwise it would contradict the Resource Submission Rules (Models, skins, icons, spells).
View attachment 348359
All and any resources (including spells and systems) should provide something that users don't already have in the site.

If there is a such unique feature in the system, then I'd suggest focusing on it and building the system around it. Explain in the description what people can find in your system that they can't elsewhere. I may be wrong, but I haven't noticed one.

Differences:
1 - To detect Damage Type/Armor Type/Defense Type/Weapon Type/Attack Type BOOL variables are used. Instead of custom integer. for example - if (DEFENSE_TYPE_MEDIUM == true)
2 - To change Damage Type/Attack Type new variables are used.
for example - DamageEventDamageT == Spell)
3 - To change Armor Type/Defense Type/Weapon Type used BOOL variables. Just set value to TRUE and engine will change the type.
4 - It is made on triggers that allows you to simply understand and change according to needs.
5 - New Event Response and Variables from Blizzard are used.
6 - Its lighter and less coded - Just 1 trigger which makes all work.

@M4gz originally found this cool new native that led to me updating to Damage Engine 5.5, so I'm interested to see if he/she will cook up another new, undiscovered thing with this resource.

Only in 1 place i used same condition as in Bribe's DDS AttackType != null in isSpell detection method. I used it to compare with condition who used it already and prevent breaks.

 

[Bribe]

When setting the armor type or defense type, it doesn't make sense to use a boolean...

as then you have to check in your resource which boolean is set.

Which boolean do you choose, in case of multiple TRUE values?

You then have to un-set all of the booleans at the end to ensure there are no misflags.

I don't like the syntax of "DamageEventXT == DAMAGE_CONSTANT_VARIABLE" particularly much, and booleans clean up that a bit, but I don't think this is the answer.

 

[M4gz]

Thanks for Your answer

When setting the armor type or defense type, it doesn't make sense to use a boolean...

as then you have to check in your resource which boolean is set.

Which boolean do you choose, in case of multiple TRUE values?

You then have to un-set all of the booleans at the end to ensure there are no misflags.

I don't like the syntax of "DamageEventXT == DAMAGE_CONSTANT_VARIABLE" particularly much, and booleans clean up that a bit, but I don't think this is the answer.

As you see armor and defense type changing using common variables not boolean.
Boolean used ONLY for Weapon type because that type of variable doesnt exists in GUI.
1st Boolean will be used in list of variables i think its a logical. What case to use several same modifications at the same time?
At the end of what? Bool is used only for weapon types and it compare previous value with new one (if it exists). They are nulled after event.
Yes that syntax is not pretty looks buy if used these names i was need to use the same. But booleans make it clean and remove part of code and variables.
Also that resource gives a good and easy explaination of DDS in GUI and a lot of ways to change/edit/modify without any JASS/LUA knowledges.

 

[Teo_omant]

If you deal damage inside the damage detection function, everything breaks and all damage is set to 0. How can I do additional damage (without increasing the current one) inside the function? I first need to deal damage to one target, and then additional damage to targets around it.

 

[Bribe]

If you deal damage inside the damage detection function, everything breaks and all damage is set to 0. How can I do additional damage (without increasing the current one) inside the function? I first need to deal damage to one target, and then additional damage to targets around it.

The resource you are replying to is unapproved and - according to the author- still in beta testing. If you want a working damage system for all needs, you need look no further than Damage Engine 5.5.0.0

 

[Teo_omant]

Bribe Yes, I've seen your system. I found it too cumbersome, too many settings and not enough hints (for me personally). And then I opened it and immediately see what and where to install. In your system, I didn't fully understand how your trigger "Set damage" differs from "Damage tag". I didn't find any hints on how to use "on AOE" or what the "On Zero"trigger is. Etc. Need more hints for noobs like me.

 

[Bribe]

Bribe Yes, I've seen your system. I found it too cumbersome, too many settings and not enough hints (for me personally). And then I opened it and immediately see what and where to install. In your system, I didn't fully understand how your trigger "Set damage" differs from "Damage tag". I didn't find any hints on how to use "on AOE" or what the "On Zero"trigger is. Etc. Need more hints for noobs like me.

1) copy the damage engine category into your map

2) it's installed

The stuff you don't understand is not meant to be picked up on right away. Over the years I added a bunch of a features to satisfy requests. But the main usage is straightforward:

DamageEvent becomes equal to 1.00 - detects when DamageEventSource damages DamageEventTarget for DamageEventAmount.

If you instead use DamageModifierEvent becomes equal yo 1.00, you can change the damage before it's modified by armor or mana shield.

If you instead use DamageModifierEvent 4.00, you can change it AFTER it has been modified by armor or mana shield.

That's the core of the system. The rest is just meant for specialized stuff or exists just for demo purposes.

 

[M4gz]

If you deal damage inside the damage detection function, everything breaks and all damage is set to 0. How can I do additional damage (without increasing the current one) inside the function? I first need to deal damage to one target, and then additional damage to targets around it.

Can you show a trigger or test map? If it breaks ill fix it ASAP. I was testing for dealing damage inside the event and all works ok. You can check test triggers.

 

[Chaosy]

I am all for using a system that only does what I need to.
For example, I still recommend Weep's DDS: GUI-Friendly Damage Detection v1.2.1 to new users as it is not overwhelming with features like the more modern options.

I'd even use it myself most of the time as I very rarely need the fancy features anyway.

This seems to be somewhere in the middle, not quite as simple as Weeps, but not good enough to compete with Damage Engine (among others)

 

[Teo_omant]

M4gz, Yes, it's just that if I deal damage inside the function, the damage is set to 0. I'm checking this with debag. If you put "FaerieFire" on the enemy, which reduces the armor, the damage is also set to 0. I checked your code and saw that if the damage is not actual, then the next trigger "Event Modify" is triggered, but it does not save this damage, but sets it to 0 (why?). More precisely, it doesn't set it to 0, it only saves it if it is larger (as you have in the example of the mountain king, you increase the damage by 2 times), but I don't need it. I did everything by your example, checked it repeatedly. I like your system so much, but I just don't understand why I can't do damage inside the function. I have the ability to "reflect damage". When receiving damage-I deal part of the damage response and it does not work, the system does not "catch" "reflected damage", and the damage taked by the hero at this moment is set to 0. I believe that the error lies in the fact that applying new damage simply resets the variables "DamageEvent Target and Source". Because in this cases, debug returns null.

 

[Teo_omant]

UPD

 

[M4gz]

UPD

Remove these lines and all will works fine fine in your case

 

[Teo_omant]

M4gz, No, it doesn't help. I'm not a noob in GUI that I might have made some mistake. There is definitely a bug here.

 

[Teo_omant]

On the test map

 

[M4gz]

On the test map

The issue was with nulled damage event. I replaced it to the begining of the engine and everything works fine. Thanks ill fix it in the test map. Working example attached

 

[Teo_omant]

M4gz, thank you!

 

[MyPad]

• -------- Detect Targets Defense type --------
• Custom script: set DefenseTypeTemp = BlzGetUnitIntegerField(udg_DamageEventTarget, UNIT_IF_DEFENSE_TYPE)
• Custom script: if (DefenseTypeTemp == 0) then
• Set VariableSet DEFENSE_TYPE_LIGHT = True
• Custom script: elseif (DefenseTypeTemp == 1) then
• Set VariableSet DEFENSE_TYPE_MEDIUM = True
• Custom script: elseif (DefenseTypeTemp == 2) then
• Set VariableSet DEFENSE_TYPE_HEAVY = True
• Custom script: elseif (DefenseTypeTemp == 3) then
• Set VariableSet DEFENSE_TYPE_FORTIFIED = True
• Custom script: elseif (DefenseTypeTemp == 4) then
• Set VariableSet DEFENSE_TYPE_NORMAL = True
• Custom script: elseif (DefenseTypeTemp == 5) then
• Set VariableSet DEFENSE_TYPE_HERO = True
• Custom script: elseif (DefenseTypeTemp == 6) then
• Set VariableSet DEFENSE_TYPE_DIVINE = True
• Custom script: else
• Set VariableSet DEFENSE_TYPE_UNARMORED = True
• Custom script: endif
• -------- Detect Targets Armor type --------
• Custom script: set ArmorTypeTemp = BlzGetUnitIntegerField(udg_DamageEventTarget, UNIT_IF_ARMOR_TYPE)
• Custom script: if (ArmorTypeTemp == 1) then
• Set VariableSet ARMOR_TYPE_FLESH = True
• Custom script: elseif (ArmorTypeTemp == 2) then
• Set VariableSet ARMOR_TYPE_METAL = True
• Custom script: elseif (ArmorTypeTemp == 3) then
• Set VariableSet ARMOR_TYPE_WOOD = True
• Custom script: elseif (ArmorTypeTemp == 4) then
• Set VariableSet ARMOR_TYPE_ETHEREAL = True
• Custom script: elseif (ArmorTypeTemp == 5) then
• Set VariableSet ARMOR_TYPE_STONE = True
• Custom script: else
• Set VariableSet ARMOR_TYPE_NONE = True
• Custom script: endif
• -------- Detect Attack Type --------
• Custom script: if udg_DamageEventAttackT == ATTACK_TYPE_NORMAL then
• Set VariableSet ATTACK_TYPE_SPELLS = True
• Custom script: elseif udg_DamageEventAttackT == ATTACK_TYPE_MELEE then
• Set VariableSet ATTACK_TYPE_NORMAL = True
• Custom script: elseif udg_DamageEventAttackT == ATTACK_TYPE_PIERCE then
• Set VariableSet ATTACK_TYPE_PIERCE = True
• Custom script: elseif udg_DamageEventAttackT == ATTACK_TYPE_SIEGE then
• Set VariableSet ATTACK_TYPE_SIEGE = True
• Custom script: elseif udg_DamageEventAttackT == ATTACK_TYPE_MAGIC then
• Set VariableSet ATTACK_TYPE_MAGIC = True
• Custom script: elseif udg_DamageEventAttackT == ATTACK_TYPE_CHAOS then
• Set VariableSet ATTACK_TYPE_CHAOS = True
• Custom script: elseif udg_DamageEventAttackT == ATTACK_TYPE_HERO then
• Set VariableSet ATTACK_TYPE_HERO = True
• Custom script: endif
• -------- Detect Damage Type --------
• Custom script: if udg_DamageEventDamageT == DAMAGE_TYPE_UNKNOWN then
• Set VariableSet DAMAGE_TYPE_UNKNOWN = True
• Custom script: elseif udg_DamageEventDamageT == DAMAGE_TYPE_NORMAL then
• Set VariableSet DAMAGE_TYPE_NORMAL = True
• Custom script: elseif udg_DamageEventDamageT == DAMAGE_TYPE_ENHANCED then
• Set VariableSet DAMAGE_TYPE_ENCHANCED = True
• Custom script: elseif udg_DamageEventDamageT == DAMAGE_TYPE_FIRE then
• Set VariableSet DAMAGE_TYPE_FIRE = True
• Custom script: elseif udg_DamageEventDamageT == DAMAGE_TYPE_COLD then
• Set VariableSet DAMAGE_TYPE_COLD = True
• Custom script: elseif udg_DamageEventDamageT == DAMAGE_TYPE_LIGHTNING then
• Set VariableSet DAMAGE_TYPE_LIGHTNING = True
• Custom script: elseif udg_DamageEventDamageT == DAMAGE_TYPE_POISON then
• Set VariableSet DAMAGE_TYPE_POISON = True
• Custom script: elseif udg_DamageEventDamageT == DAMAGE_TYPE_DISEASE then
• Set VariableSet DAMAGE_TYPE_DISEASE = True
• Custom script: elseif udg_DamageEventDamageT == DAMAGE_TYPE_DIVINE then
• Set VariableSet DAMAGE_TYPE_DIVINE = True
• Custom script: elseif udg_DamageEventDamageT == DAMAGE_TYPE_MAGIC then
• Set VariableSet DAMAGE_TYPE_MAGIC = True
• Custom script: elseif udg_DamageEventDamageT == DAMAGE_TYPE_SONIC then
• Set VariableSet DAMAGE_TYPE_SONIC = True
• Custom script: elseif udg_DamageEventDamageT == DAMAGE_TYPE_ACID then
• Set VariableSet DAMAGE_TYPE_ACID = True
• Custom script: elseif udg_DamageEventDamageT == DAMAGE_TYPE_FORCE then
• Set VariableSet DAMAGE_TYPE_FORCE = True
• Custom script: elseif udg_DamageEventDamageT == DAMAGE_TYPE_DEATH then
• Set VariableSet DAMAGE_TYPE_DEATH = True
• Custom script: elseif udg_DamageEventDamageT == DAMAGE_TYPE_MIND then
• Set VariableSet DAMAGE_TYPE_MIND = True
• Custom script: elseif udg_DamageEventDamageT == DAMAGE_TYPE_PLANT then
• Set VariableSet DAMAGE_TYPE_PLANT = True
• Custom script: elseif udg_DamageEventDamageT == DAMAGE_TYPE_DEFENSIVE then
• Set VariableSet DAMAGE_TYPE_DEFENSIVE = True
• Custom script: elseif udg_DamageEventDamageT == DAMAGE_TYPE_DEMOLITION then
• Set VariableSet DAMAGE_TYPE_DEMOLITION = True
• Custom script: elseif udg_DamageEventDamageT == DAMAGE_TYPE_SLOW_POISON then
• Set VariableSet DAMAGE_TYPE_SLOW_POISON = True
• Custom script: elseif udg_DamageEventDamageT == DAMAGE_TYPE_SPIRIT_LINK then
• Set VariableSet DAMAGE_TYPE_SPIRIT_LINK = True
• Custom script: elseif udg_DamageEventDamageT == DAMAGE_TYPE_SHADOW_STRIKE then
• Set VariableSet DAMAGE_TYPE_SHADOW_STRIKE = True
• Custom script: elseif udg_DamageEventDamageT == DAMAGE_TYPE_UNIVERSAL then
• Set VariableSet DAMAGE_TYPE_UNIVERSAL = True
• Custom script: endif
• -------- Detect Weapon Type --------
• Custom script: if WeaponType == WEAPON_TYPE_METAL_LIGHT_CHOP then
• Custom script: set WeaponTypeIndex = 1
• Set VariableSet WEAPON_TYPE_ML_CHOP = True
• Custom script: elseif WeaponType == WEAPON_TYPE_METAL_MEDIUM_CHOP then
• Custom script: set WeaponTypeIndex = 2
• Set VariableSet WEAPON_TYPE_MM_CHOP = True
• Custom script: elseif WeaponType == WEAPON_TYPE_METAL_HEAVY_CHOP then
• Custom script: set WeaponTypeIndex = 3
• Set VariableSet WEAPON_TYPE_MH_CHOP = True
• Custom script: elseif WeaponType == WEAPON_TYPE_METAL_LIGHT_SLICE then
• Custom script: set WeaponTypeIndex = 4
• Set VariableSet WEAPON_TYPE_ML_SLICE = True
• Custom script: elseif WeaponType == WEAPON_TYPE_METAL_MEDIUM_SLICE then
• Custom script: set WeaponTypeIndex = 5
• Set VariableSet WEAPON_TYPE_MM_SLICE = True
• Custom script: elseif WeaponType == WEAPON_TYPE_METAL_HEAVY_SLICE then
• Custom script: set WeaponTypeIndex = 6
• Set VariableSet WEAPON_TYPE_MH_SLICE = True
• Custom script: elseif WeaponType == WEAPON_TYPE_METAL_MEDIUM_BASH then
• Custom script: set WeaponTypeIndex = 7
• Set VariableSet WEAPON_TYPE_MM_BASH = True
• Custom script: elseif WeaponType == WEAPON_TYPE_METAL_HEAVY_BASH then
• Custom script: set WeaponTypeIndex = 8
• Set VariableSet WEAPON_TYPE_MH_BASH = True
• Custom script: elseif WeaponType == WEAPON_TYPE_METAL_MEDIUM_STAB then
• Custom script: set WeaponTypeIndex = 9
• Set VariableSet WEAPON_TYPE_MM_STAB = True
• Custom script: elseif WeaponType == WEAPON_TYPE_METAL_HEAVY_STAB then
• Custom script: set WeaponTypeIndex = 10
• Set VariableSet WEAPON_TYPE_MH_STAB = True
• Custom script: elseif WeaponType == WEAPON_TYPE_WOOD_LIGHT_SLICE then
• Custom script: set WeaponTypeIndex = 11
• Set VariableSet WEAPON_TYPE_WL_SLICE = True
• Custom script: elseif WeaponType == WEAPON_TYPE_WOOD_MEDIUM_SLICE then
• Custom script: set WeaponTypeIndex = 12
• Set VariableSet WEAPON_TYPE_WM_SLICE = True
• Custom script: elseif WeaponType == WEAPON_TYPE_WOOD_HEAVY_SLICE then
• Custom script: set WeaponTypeIndex = 13
• Set VariableSet WEAPON_TYPE_WH_SLICE = True
• Custom script: elseif WeaponType == WEAPON_TYPE_WOOD_LIGHT_BASH then
• Custom script: set WeaponTypeIndex = 14
• Set VariableSet WEAPON_TYPE_WL_BASH = True
• Custom script: elseif WeaponType == WEAPON_TYPE_WOOD_MEDIUM_BASH then
• Custom script: set WeaponTypeIndex = 15
• Set VariableSet WEAPON_TYPE_WM_BASH = True
• Custom script: elseif WeaponType == WEAPON_TYPE_WOOD_HEAVY_BASH then
• Custom script: set WeaponTypeIndex = 16
• Set VariableSet WEAPON_TYPE_WH_BASH = True
• Custom script: elseif WeaponType == WEAPON_TYPE_WOOD_LIGHT_STAB then
• Custom script: set WeaponTypeIndex = 17
• Set VariableSet WEAPON_TYPE_WL_STAB = True
• Custom script: elseif WeaponType == WEAPON_TYPE_WOOD_MEDIUM_STAB then
• Custom script: set WeaponTypeIndex = 18
• Set VariableSet WEAPON_TYPE_WM_STAB = True
• Custom script: elseif WeaponType == WEAPON_TYPE_CLAW_LIGHT_SLICE then
• Custom script: set WeaponTypeIndex = 19
• Set VariableSet WEAPON_TYPE_CL_SLICE = True
• Custom script: elseif WeaponType == WEAPON_TYPE_CLAW_MEDIUM_SLICE then
• Custom script: set WeaponTypeIndex = 20
• Set VariableSet WEAPON_TYPE_CM_SLICE = True
• Custom script: elseif WeaponType == WEAPON_TYPE_CLAW_HEAVY_SLICE then
• Custom script: set WeaponTypeIndex = 21
• Set VariableSet WEAPON_TYPE_CH_SLICE = True
• Custom script: elseif WeaponType == WEAPON_TYPE_AXE_MEDIUM_CHOP then
• Custom script: set WeaponTypeIndex = 22
• Set VariableSet WEAPON_TYPE_AM_CHOP = True
• Custom script: elseif WeaponType == WEAPON_TYPE_ROCK_HEAVY_BASH then
• Custom script: set WeaponTypeIndex = 23
• Set VariableSet WEAPON_TYPE_RH_BASH = True
• Custom script: else
• Set VariableSet WEAPON_TYPE_NONE = True
• Custom script: endif
• -------- End Damage Type Detecting --------

The trigger reeks of if-then statements (There are too many of them). As far as code inspection goes, all of that set WeaponTypeIndex fiasco can be reduced to set WeaponTypeIndex = GetHandleId(WeaponType)

Given the current setup, if a new damage type, attack type, or armor type would be introduced (unlikely, though), the system will have to be updated to accommodate for that. This would be tedious to maintain or update if any bug arises, in conjunction with using the system or due to the system itself.

Considering the way weapon type is modified, it would appear that when changing the weapon type, the weapon type with the smallest index will be assigned to the damage instance, as opposed to the latest weapon type taking precedence. As shown below (this is assuming that there are at least 2 triggers modifying weapon type).

• Set VariableSet WEAPON_TYPE_ML_CHOP = true
• -------- Some other trigger running --------
• Set VariableSet WEAPON_TYPE_MM_CHOP = true

This would apply the first weapon type WEAPON_TYPE_ML_CHOP (index 1), as opposed to WEAPON_TYPE_MM_CHOP (index 2). In this case, the most recent assignment to the weapon type is not respected. Doing the same thing with Bribe's Damage Engine:

• [B] [/B]Set VariableSet DamageEventWeaponT = WEAPON_TYPE_ML_CHOP
  • -------- Some other trigger running --------
  • Set VariableSet DamageEventWeaponT = WEAPON_TYPE_MM_CHOP

The weapon type will be assigned as WEAPON_TYPE_MM_CHOP (index 2), the more recent assignment, as opposed to WEAPON_TYPE_ML_CHOP (index 1).

 

[M4gz]

Thanks ill fix it asap

 

[Bribe]

(Life of DamageEventTarget) Less than or equal to DamageEventAmount

^ That's not correct. It will fail if the damage amount is greater than 0 but less than or equal to the death threshold (which is 0.405).

You'd want to change it to Life - Damage amount <= 0.405

 

[MyPad]

This is a rather decent attempt at a damage detection system, although it is held back by a lot of factors, adding too much complexity to the system. Quoting my previous post:

• -------- Detect Targets Defense type --------
• Custom script: set DefenseTypeTemp = BlzGetUnitIntegerField(udg_DamageEventTarget, UNIT_IF_DEFENSE_TYPE)
• Custom script: if (DefenseTypeTemp == 0) then
• Set VariableSet DEFENSE_TYPE_LIGHT = True
• Custom script: elseif (DefenseTypeTemp == 1) then
• Set VariableSet DEFENSE_TYPE_MEDIUM = True
• Custom script: elseif (DefenseTypeTemp == 2) then
• Set VariableSet DEFENSE_TYPE_HEAVY = True
• Custom script: elseif (DefenseTypeTemp == 3) then
• Set VariableSet DEFENSE_TYPE_FORTIFIED = True
• Custom script: elseif (DefenseTypeTemp == 4) then
• Set VariableSet DEFENSE_TYPE_NORMAL = True
• Custom script: elseif (DefenseTypeTemp == 5) then
• Set VariableSet DEFENSE_TYPE_HERO = True
• Custom script: elseif (DefenseTypeTemp == 6) then
• Set VariableSet DEFENSE_TYPE_DIVINE = True
• Custom script: else
• Set VariableSet DEFENSE_TYPE_UNARMORED = True
• Custom script: endif
• -------- Detect Targets Armor type --------
• Custom script: set ArmorTypeTemp = BlzGetUnitIntegerField(udg_DamageEventTarget, UNIT_IF_ARMOR_TYPE)
• Custom script: if (ArmorTypeTemp == 1) then
• Set VariableSet ARMOR_TYPE_FLESH = True
• Custom script: elseif (ArmorTypeTemp == 2) then
• Set VariableSet ARMOR_TYPE_METAL = True
• Custom script: elseif (ArmorTypeTemp == 3) then
• Set VariableSet ARMOR_TYPE_WOOD = True
• Custom script: elseif (ArmorTypeTemp == 4) then
• Set VariableSet ARMOR_TYPE_ETHEREAL = True
• Custom script: elseif (ArmorTypeTemp == 5) then
• Set VariableSet ARMOR_TYPE_STONE = True
• Custom script: else
• Set VariableSet ARMOR_TYPE_NONE = True
• Custom script: endif
• -------- Detect Attack Type --------
• Custom script: if udg_DamageEventAttackT == ATTACK_TYPE_NORMAL then
• Set VariableSet ATTACK_TYPE_SPELLS = True
• Custom script: elseif udg_DamageEventAttackT == ATTACK_TYPE_MELEE then
• Set VariableSet ATTACK_TYPE_NORMAL = True
• Custom script: elseif udg_DamageEventAttackT == ATTACK_TYPE_PIERCE then
• Set VariableSet ATTACK_TYPE_PIERCE = True
• Custom script: elseif udg_DamageEventAttackT == ATTACK_TYPE_SIEGE then
• Set VariableSet ATTACK_TYPE_SIEGE = True
• Custom script: elseif udg_DamageEventAttackT == ATTACK_TYPE_MAGIC then
• Set VariableSet ATTACK_TYPE_MAGIC = True
• Custom script: elseif udg_DamageEventAttackT == ATTACK_TYPE_CHAOS then
• Set VariableSet ATTACK_TYPE_CHAOS = True
• Custom script: elseif udg_DamageEventAttackT == ATTACK_TYPE_HERO then
• Set VariableSet ATTACK_TYPE_HERO = True
• Custom script: endif
• -------- Detect Damage Type --------
• Custom script: if udg_DamageEventDamageT == DAMAGE_TYPE_UNKNOWN then
• Set VariableSet DAMAGE_TYPE_UNKNOWN = True
• Custom script: elseif udg_DamageEventDamageT == DAMAGE_TYPE_NORMAL then
• Set VariableSet DAMAGE_TYPE_NORMAL = True
• Custom script: elseif udg_DamageEventDamageT == DAMAGE_TYPE_ENHANCED then
• Set VariableSet DAMAGE_TYPE_ENCHANCED = True
• Custom script: elseif udg_DamageEventDamageT == DAMAGE_TYPE_FIRE then
• Set VariableSet DAMAGE_TYPE_FIRE = True
• Custom script: elseif udg_DamageEventDamageT == DAMAGE_TYPE_COLD then
• Set VariableSet DAMAGE_TYPE_COLD = True
• Custom script: elseif udg_DamageEventDamageT == DAMAGE_TYPE_LIGHTNING then
• Set VariableSet DAMAGE_TYPE_LIGHTNING = True
• Custom script: elseif udg_DamageEventDamageT == DAMAGE_TYPE_POISON then
• Set VariableSet DAMAGE_TYPE_POISON = True
• Custom script: elseif udg_DamageEventDamageT == DAMAGE_TYPE_DISEASE then
• Set VariableSet DAMAGE_TYPE_DISEASE = True
• Custom script: elseif udg_DamageEventDamageT == DAMAGE_TYPE_DIVINE then
• Set VariableSet DAMAGE_TYPE_DIVINE = True
• Custom script: elseif udg_DamageEventDamageT == DAMAGE_TYPE_MAGIC then
• Set VariableSet DAMAGE_TYPE_MAGIC = True
• Custom script: elseif udg_DamageEventDamageT == DAMAGE_TYPE_SONIC then
• Set VariableSet DAMAGE_TYPE_SONIC = True
• Custom script: elseif udg_DamageEventDamageT == DAMAGE_TYPE_ACID then
• Set VariableSet DAMAGE_TYPE_ACID = True
• Custom script: elseif udg_DamageEventDamageT == DAMAGE_TYPE_FORCE then
• Set VariableSet DAMAGE_TYPE_FORCE = True
• Custom script: elseif udg_DamageEventDamageT == DAMAGE_TYPE_DEATH then
• Set VariableSet DAMAGE_TYPE_DEATH = True
• Custom script: elseif udg_DamageEventDamageT == DAMAGE_TYPE_MIND then
• Set VariableSet DAMAGE_TYPE_MIND = True
• Custom script: elseif udg_DamageEventDamageT == DAMAGE_TYPE_PLANT then
• Set VariableSet DAMAGE_TYPE_PLANT = True
• Custom script: elseif udg_DamageEventDamageT == DAMAGE_TYPE_DEFENSIVE then
• Set VariableSet DAMAGE_TYPE_DEFENSIVE = True
• Custom script: elseif udg_DamageEventDamageT == DAMAGE_TYPE_DEMOLITION then
• Set VariableSet DAMAGE_TYPE_DEMOLITION = True
• Custom script: elseif udg_DamageEventDamageT == DAMAGE_TYPE_SLOW_POISON then
• Set VariableSet DAMAGE_TYPE_SLOW_POISON = True
• Custom script: elseif udg_DamageEventDamageT == DAMAGE_TYPE_SPIRIT_LINK then
• Set VariableSet DAMAGE_TYPE_SPIRIT_LINK = True
• Custom script: elseif udg_DamageEventDamageT == DAMAGE_TYPE_SHADOW_STRIKE then
• Set VariableSet DAMAGE_TYPE_SHADOW_STRIKE = True
• Custom script: elseif udg_DamageEventDamageT == DAMAGE_TYPE_UNIVERSAL then
• Set VariableSet DAMAGE_TYPE_UNIVERSAL = True
• Custom script: endif
• -------- Detect Weapon Type --------
• Custom script: if WeaponType == WEAPON_TYPE_METAL_LIGHT_CHOP then
• Custom script: set WeaponTypeIndex = 1
• Set VariableSet WEAPON_TYPE_ML_CHOP = True
• Custom script: elseif WeaponType == WEAPON_TYPE_METAL_MEDIUM_CHOP then
• Custom script: set WeaponTypeIndex = 2
• Set VariableSet WEAPON_TYPE_MM_CHOP = True
• Custom script: elseif WeaponType == WEAPON_TYPE_METAL_HEAVY_CHOP then
• Custom script: set WeaponTypeIndex = 3
• Set VariableSet WEAPON_TYPE_MH_CHOP = True
• Custom script: elseif WeaponType == WEAPON_TYPE_METAL_LIGHT_SLICE then
• Custom script: set WeaponTypeIndex = 4
• Set VariableSet WEAPON_TYPE_ML_SLICE = True
• Custom script: elseif WeaponType == WEAPON_TYPE_METAL_MEDIUM_SLICE then
• Custom script: set WeaponTypeIndex = 5
• Set VariableSet WEAPON_TYPE_MM_SLICE = True
• Custom script: elseif WeaponType == WEAPON_TYPE_METAL_HEAVY_SLICE then
• Custom script: set WeaponTypeIndex = 6
• Set VariableSet WEAPON_TYPE_MH_SLICE = True
• Custom script: elseif WeaponType == WEAPON_TYPE_METAL_MEDIUM_BASH then
• Custom script: set WeaponTypeIndex = 7
• Set VariableSet WEAPON_TYPE_MM_BASH = True
• Custom script: elseif WeaponType == WEAPON_TYPE_METAL_HEAVY_BASH then
• Custom script: set WeaponTypeIndex = 8
• Set VariableSet WEAPON_TYPE_MH_BASH = True
• Custom script: elseif WeaponType == WEAPON_TYPE_METAL_MEDIUM_STAB then
• Custom script: set WeaponTypeIndex = 9
• Set VariableSet WEAPON_TYPE_MM_STAB = True
• Custom script: elseif WeaponType == WEAPON_TYPE_METAL_HEAVY_STAB then
• Custom script: set WeaponTypeIndex = 10
• Set VariableSet WEAPON_TYPE_MH_STAB = True
• Custom script: elseif WeaponType == WEAPON_TYPE_WOOD_LIGHT_SLICE then
• Custom script: set WeaponTypeIndex = 11
• Set VariableSet WEAPON_TYPE_WL_SLICE = True
• Custom script: elseif WeaponType == WEAPON_TYPE_WOOD_MEDIUM_SLICE then
• Custom script: set WeaponTypeIndex = 12
• Set VariableSet WEAPON_TYPE_WM_SLICE = True
• Custom script: elseif WeaponType == WEAPON_TYPE_WOOD_HEAVY_SLICE then
• Custom script: set WeaponTypeIndex = 13
• Set VariableSet WEAPON_TYPE_WH_SLICE = True
• Custom script: elseif WeaponType == WEAPON_TYPE_WOOD_LIGHT_BASH then
• Custom script: set WeaponTypeIndex = 14
• Set VariableSet WEAPON_TYPE_WL_BASH = True
• Custom script: elseif WeaponType == WEAPON_TYPE_WOOD_MEDIUM_BASH then
• Custom script: set WeaponTypeIndex = 15
• Set VariableSet WEAPON_TYPE_WM_BASH = True
• Custom script: elseif WeaponType == WEAPON_TYPE_WOOD_HEAVY_BASH then
• Custom script: set WeaponTypeIndex = 16
• Set VariableSet WEAPON_TYPE_WH_BASH = True
• Custom script: elseif WeaponType == WEAPON_TYPE_WOOD_LIGHT_STAB then
• Custom script: set WeaponTypeIndex = 17
• Set VariableSet WEAPON_TYPE_WL_STAB = True
• Custom script: elseif WeaponType == WEAPON_TYPE_WOOD_MEDIUM_STAB then
• Custom script: set WeaponTypeIndex = 18
• Set VariableSet WEAPON_TYPE_WM_STAB = True
• Custom script: elseif WeaponType == WEAPON_TYPE_CLAW_LIGHT_SLICE then
• Custom script: set WeaponTypeIndex = 19
• Set VariableSet WEAPON_TYPE_CL_SLICE = True
• Custom script: elseif WeaponType == WEAPON_TYPE_CLAW_MEDIUM_SLICE then
• Custom script: set WeaponTypeIndex = 20
• Set VariableSet WEAPON_TYPE_CM_SLICE = True
• Custom script: elseif WeaponType == WEAPON_TYPE_CLAW_HEAVY_SLICE then
• Custom script: set WeaponTypeIndex = 21
• Set VariableSet WEAPON_TYPE_CH_SLICE = True
• Custom script: elseif WeaponType == WEAPON_TYPE_AXE_MEDIUM_CHOP then
• Custom script: set WeaponTypeIndex = 22
• Set VariableSet WEAPON_TYPE_AM_CHOP = True
• Custom script: elseif WeaponType == WEAPON_TYPE_ROCK_HEAVY_BASH then
• Custom script: set WeaponTypeIndex = 23
• Set VariableSet WEAPON_TYPE_RH_BASH = True
• Custom script: else
• Set VariableSet WEAPON_TYPE_NONE = True
• Custom script: endif
• -------- End Damage Type Detecting --------

The trigger reeks of if-then statements (There are too many of them). As far as code inspection goes, all of that set WeaponTypeIndex fiasco can be reduced to set WeaponTypeIndex = GetHandleId(WeaponType)

Given the current setup, if a new damage type, attack type, or armor type would be introduced (unlikely, though), the system will have to be updated to accommodate for that. This would be tedious to maintain or update if any bug arises, in conjunction with using the system or due to the system itself.

Considering the way weapon type is modified, it would appear that when changing the weapon type, the weapon type with the smallest index will be assigned to the damage instance, as opposed to the latest weapon type taking precedence. As shown below (this is assuming that there are at least 2 triggers modifying weapon type).

• Set VariableSet WEAPON_TYPE_ML_CHOP = true
• -------- Some other trigger running --------
• Set VariableSet WEAPON_TYPE_MM_CHOP = true

This would apply the first weapon type WEAPON_TYPE_ML_CHOP (index 1), as opposed to WEAPON_TYPE_MM_CHOP (index 2). In this case, the most recent assignment to the weapon type is not respected. Doing the same thing with Bribe's Damage Engine:

• [B] [/B]Set VariableSet DamageEventWeaponT = WEAPON_TYPE_ML_CHOP
  • -------- Some other trigger running --------
  • Set VariableSet DamageEventWeaponT = WEAPON_TYPE_MM_CHOP

The weapon type will be assigned as WEAPON_TYPE_MM_CHOP (index 2), the more recent assignment, as opposed to WEAPON_TYPE_ML_CHOP (index 1).

Due to most of the features primarily overlapping with Bribe's Damage Engine 5.7.1.1, and that the aforementioned system, reputable for its use in a wide range of projects, and is being frequently updated by the author, I would have to mark this as Substandard.

By moving this to Substandard, I do not wish to imply that this system is too buggy to be useful. Rather, I would recommend those who are already using this system to stick with the system.