Physical Damage Detection for GUI v1.3.0.0

[shadowvzs]

Someone asked how to remove the usual blizzard damage formula.
Firstly, you have to know the armor amount. There's simply no way over it that I know of(if you want to use the armor display for something, that is).

Secondly, set the armor damage reduction to 0.
This only works for positive armor, so for negative armor use this part in the damage handler:

if armor < 0 then//The negative armor formula by blizzard can not be entirely disabled, so we have to undo it. 
    set amount = amount / (2-Pow(0.94,I2R(-armor)))
endif

When you've triggered the armor damage reduction yourself, then you can also easily bypass it to deal true damage.

problem no native for check armor value, since want bypass in set dmg trigger and that make it more heavier than already it is (talking about create dummy unit who attack new unit type on map for check the armor)

since could have many creep type i can't use a simple formula vs all creep/neutral hero type

 

[Xonok]

I store the base armor of every relevant unit type in a variable and then change the value according to whatever buffs it gets from abilities. This can only be done when all armor gains are triggered though.

 

[Tal'Rarity]

I store the base armor of every relevant unit type in a variable and then change the value according to whatever buffs it gets from abilities. This can only be done when all armor gains are triggered though.

http://www.hiveworkshop.com/forums/...type-v8-225031/?prev=search=armor&d=list&r=20

 

[shadowvzs]

I store the base armor of every relevant unit type in a variable and then change the value according to whatever buffs it gets from abilities. This can only be done when all armor gains are triggered though.

ouch, storeing every unit armor is a bit painfull :/
or do you got something trick? or all write it manually? or did with dummy unit at map init?

 

[Tal'Rarity]

ouch, storeing every unit armor is a bit painfull :/
or do you got something trick? or all write it manually? or did with dummy unit at map init?

Sometimes its worth it.

 

[shadowvzs]

Sometimes its worth it.

but if u do map to spell section then there maybe peoples use on map where they use non regular mobs, that could be annoying :/

 

[Xonok]

I don't mind having my systems map-specific. Besides, there usually aren't THAT many relevant unit types. If there would be, I would reconsider.
Also, testing the armor amount of a unit is simply not possible if you use a custom armor system, because the damage reduction multiplier in constants is simply 0.
Yes, I write them down manually. It's not much work though.

 

[sentrywiz]

Awesome system, fairly easy to implement with the clear instructions.

I have a question though. Because I've implemented two different triggers I am interested how will they interact with each other. In one there is a chance to crit for double damage and in another there is a chance to dodge. Will there be some confusion, for example if a crit and a dodge occurs at the same time, will the crit pass the dodge or will the dodge take priority? Crit sets amount to amount * 2.00 and dodge puts amount to 0.00.

 

[shadowvzs]

Awesome system, fairly easy to implement with the clear instructions.

I have a question though. Because I've implemented two different triggers I am interested how will they interact with each other. In one there is a chance to crit for double damage and in another there is a chance to dodge. Will there be some confusion, for example if a crit and a dodge occurs at the same time, will the crit pass the dodge or will the dodge take priority? Crit sets amount to amount * 2.00 and dodge puts amount to 0.00.

i did this this way:


random=0,99

if random < dodge chance then
set dmg = 0
else
random=0,99
if random < crit_Rate then
set dmg = dmg *2
endif
endif

simple, can't crit if dodge, personally i think dodge have prior because criting then dodgeing for me no point

 

[sentrywiz]

i did this this way:


random=0,99

if random < dodge chance then
set dmg = 0
else
random=0,99
if random < crit_Rate then
set dmg = dmg *2
endif
endif

simple, can't crit if dodge, personally i think dodge have prior because criting then dodgeing for me no point

Well, maybe a unit would crit, but you would still dodge the crit. It works either way. I was just interested how does the system count priority when the trigger occurs for multiple units.

But its better to check dodge first then crit, I agree.

 

[shadowvzs]

Well, maybe a unit would crit, but you would still dodge the crit. It works either way. I was just interested how does the system count priority when the trigger occurs for multiple units.

But its better to check dodge first then crit, I agree.

reason senseless calculate anything dmg related if it will dodged anyway, so that useless math if ur formula more complex (more dmg modifier factor than crit, like custom defence, amplifier etc)

 

[shadowvzs]

here the map with little modification (added floating text and hero revive)

system stop working sometimes (randomly, sometimes need ~2-3min or more for see it)

[EDIT]

tryed with this too but same bug, so not only reviveable hero

maybe related with magic? occured after phoenix was summoned and mountain king got 1 dmg but still for a awhile everything was normal

seems if hero is neutral hostile or player 2 unit is indifferent

 

[looking_for_help]

here the map with little modification (added floating text and hero revive)

system stop working sometimes (randomly, sometimes need ~2-3min or more for see it)

The system doesn't stop working, it runs perfectly fine in the map you uploaded.

Its just that you spam text tags without recycling/cleaning them up. Wc3 has a maximum amount of text-tags, which you exceed. Therefore no more text-tags are created after some time.

Use "Display Message" to show the damage or clean up your text-tags properly and you will see that the system continous to work as expected.

 

[kamyflex]

Best DDS Ever ! Thanks man

 

[Map Designer]

so elune ability still reduces magic and pierce attacks. Only spells it doesnt reduce (just tested)
good to know

 

[kamyflex]

so elune ability still reduces magic and pierce attacks. Only spells it doesnt reduce (just tested)
good to know

Thanks for the info

 

[Almia]

Question:

What if I use UnitDamageTarget and then used the options ATTACK_TYPE_HERO and DAMAGE_TYPE_NORMAL, would it still be detected as a Physical Damage?

If so, is there a way to detect IF a physical damage comes from an attack?

 

[TwistedFirestarter]

I have sent a pm to looking_for_help but I couldn't see it in my sent box, so i am going to post my question here in case.

Whenever I create a custom item ability (without giving it to a unit, just purely creating it), it gets applied to every unit on the map. I'm 99% sure its due to the system since when i removed the PDD trigger, the ability was no longer applied to any unit. Do we have to work around this, or is it just a bug, or is it something else?

Thanks in advance

 

[Tal'Rarity]

I have sent a pm to looking_for_help but I couldn't see it in my sent box, so i am going to post my question here in case.

Whenever I create a custom item ability (without giving it to a unit, just purely creating it), it gets applied to every unit on the map. I'm 99% sure its due to the system since when i removed the PDD trigger, the ability was no longer applied to any unit. Do we have to work around this, or is it just a bug, or is it something else?

Thanks in advance

It's your lack of knowledge that is the bug. To fix this user error bug go to "DamageEvent" and find "[jass=]//////////////////////////////////////////////////////////////////////////////////
// Configurable globals
//////////////////////////////////////////////////////////////////////////////////

function InitGlobalVariables takes nothing returns nothing
// Put here the correct ability IDs
set udg_PDD_DAMAGE_TYPE_DETECTOR = 'A000'
set udg_PDD_SET_MAX_LIFE = 'A001'[/code]"

In object editor --> go to View --> Display Values As Raw Data
Then go to the Abilities tab then find the two abilities you were required to copy and paste to your map.
"DAMAGE_TYPE_DETECTOR"
"SET_MAX_LIFE"
They'll display the code you have to type into those two values above this. Match the codes with the abilities into the right spots into the trigger.
Example: A000: Alsr(DAMAGE_TYPE_DETECTOR)
You want the A000 to go into "set udg_PDD_DAMAGE_TYPE_DETECTOR = "YourCode" While the other needs the same thing with the other ability.

User bug fixed.

 

[TwistedFirestarter]

*snaps fingers* ah of course, I was too hasty when installing the system and forgot to add the spells to the code after importing them. Silly me.

Thanks alot for the solution, Dat-C3

 

[looking_for_help]

Question:

What if I use UnitDamageTarget and then used the options ATTACK_TYPE_HERO and DAMAGE_TYPE_NORMAL, would it still be detected as a Physical Damage?

Such things can be easily tested by trying, right
But yes, its of course physical damage. Whether a damage is physical or spell is determined by the attack type, and not by the damage type. And ATTACK_TYPE_HERO is physical.

If so, is there a way to detect IF a physical damage comes from an attack?

What you mean with "attack"? A melee attack? If so, then no, there is not. The purpose of this system is just to differentiate physical and spell damage, but not ranged or melee.

User bug fixed.

Thanks

 

[Almia]

@lfh

The reason is that some would attempt to create Critical strikes and evasions,cleaves,etc

 

[looking_for_help]

@lfh

The reason is that some would attempt to create Critical strikes and evasions,cleaves,etc

Well its no problem to create Critical strikes (and similar abilities like the ones you mentioned) with this system. I created a critical strike once with this system and it worked perfectly fine. Any unit by default has only one way to attack - so any physical damage is either a melee attack if the unit is a melee unit or a ranged attack if the unit is a range unit.

Exceptions are for example melee heros that carry an orb and attack a flying unit - however, you most likely want to trigger a Critical Strike on them too, just like in standard melee Wc3.

So basically I don't understand what kind of problem you mean. Could you elaborate?

 

[Almia]

What i meant is that if the damage came from a normal attack like this ideal scenario:
Unit 1 attacks Unit 2 -> executes Physical damage event
Unit 1 uses an ability that deals physical damage -> executes physical damage event
Unit 1 is used in a code to deal physical damage via UnitDamageTarget -> executes physical damage event.

From the scenario above,if someone creates a triggered Critical(damage mod) all 3 above will do a critical.

 

[looking_for_help]

What i meant is that if the damage came from a normal attack like this ideal scenario:
Unit 1 attacks Unit 2 -> executes Physical damage event
Unit 1 uses an ability that deals physical damage -> executes physical damage event
Unit 1 is used in a code to deal physical damage via UnitDamageTarget -> executes physical damage event.

From the scenario above,if someone creates a triggered Critical(damage mod) all 3 above will do a critical.

Thats what CODE damage type was invented for. Triggered damage can always be identified perfectly, so your scenario is not really a problem when creating a critical strike.

 

[Almia]

So Im gonna check first if it is physical then filter it again if it comes from a code? if so, THANKS!

I am creating a damage mod system which creates Misses, Critical Strikes, Splashes, Cleaves, etc.

 

[looking_for_help]

So Im gonna check first if it is physical then filter it again if it comes from a code? if so, THANKS!

No, CODE damage is just for reflecting damage, so it depends on what you want exactly. But the idea is the same, you just have to encode it yourself:

You would use an integer value that encodes your own damage type. So before you deal damage with triggers, you set that value. In the OnDamage event you check that value, and if it is set you reset it and know that it was caused by triggered damage. If the value is not set (for example zero), you know it was a "real" attack.

I am creating a damage mod system which creates Misses, Critical Strikes, Splashes, Cleaves, etc.

That should work without problems with this system.

 

[Wietlol]

I got 3 questions:

Why do you actually give the unit the health ability?

Why do you return when the amount of damage taken is 0?

Why are other stuff (like the spell reduction) hardcoded in the system?

EDIT: I actually downloaded this system to find out how you get the damage type.
Turns out that Phisical Damage is basic attacks and Spell Damage is abilities.

But if I would copy and paste that specific thing into my system, I got exacly the same.
Except that I never use a Hashtable, I never use timers, I have 0 code compared to this.
No offense... (I never used this system but there are many people who are very happy with it.) But I cannot find the reason why everything is added to it.

EDIT 2: Ok one more: Why do you restrict people not to use wait timers?

 

[Tal'Rarity]

I got 3 questions:

Why do you actually give the unit the health ability?

Why do you return when the amount of damage taken is 0?

Why are other stuff (like the spell reduction) hardcoded in the system?

EDIT: I actually downloaded this system to find out how you get the damage type.
Turns out that Phisical Damage is basic attacks and Spell Damage is abilities.

But if I would copy and paste that specific thing into my system, I got exacly the same.
Except that I never use a Hashtable, I never use timers, I have 0 code compared to this.
No offense... (I never used this system but there are many people who are very happy with it.) But I cannot find the reason why everything is added to it.

EDIT 2: Ok one more: Why do you restrict people not to use wait timers?

So the unit doesn't die before you interact with it as damage is dealt.

To catch any time when a unit hits another.

Because it has to be hardcoded to detect proper spell damage and to tell the difference between spell/magic and physical. Easy enough to make your own spell reduction with this, and you can even stack stuff now like add 5% of strength as spell reduction... etc.

Physical damage isn't just basic attacks, its some of the damage types from triggers.

I don't understand

But if I would copy and paste that specific thing into my system, I got exacly the same.
Except that I never use a Hashtable, I never use timers, I have 0 code compared to this.
No offense... (I never used this system but there are many people who are very happy with it.) But I cannot find the reason why everything is added to it.

Well he isn't restricting people, it just won't work when the variables are globals because they are not MUI/MPI and will be overwritten with new data when another unit hits another. You have to work around that and make your own system to counter this problem.

 

[Almia]

Why do you restrict people not to use wait timers?

We strictly want accurate results.

 

[Wietlol]

If i give a unit 99999999 basic damage and put a trigger in my system that will reduce the damage to 0 it works.

I got spells that deal 0 damage and then will be changed via triggers.
0 damage is still a hit event.

There are some ways how you could avoid it.
The thing is that (maybe) some people dont want a specific thing in it what is not required to make the DDS work.
I should put that spell reduction in a different trigger and if you turn that trigger on it works and if not then it doesnt.

I just tested it and I saw that you could see the difference between the damage from spells and the damage from basic attacks.
I dont know about trigger damage if that will also be caught as physical damage but I think that the AA / Spell is the biggest difference.

He is restricting people.
Try to put this in your system:
(Yes there is a new unit variable TempUnit but you could figure.)

• Test
  • Events
    • Game - PDD_damageEventTrigger becomes Equal to 1.00
  • Conditions
  • Actions
    • Custom script: local unit udg_TempUnit
    • Set TempUnit = PDD_target
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Unit-type of PDD_source) Equal to Archmage
      • Then - Actions
        • Wait 2.00 game-time seconds
        • Unit - Kill TempUnit
      • Else - Actions

This is completely MUI.
So???

We strictly want accurate results.

I know about timers being inaccurate, but you give this to GUI users. Otherwise change the name.
Back in the days, I was in love with the wait time.
After that I found timers.
Even now I use some wait timers now and then.
(I made them leakless and less data consuming... more like advanced wat timers.)

There are people who still use it because they dont know about timers or they dont care about the small difference.
Now people cannot use them because you want to have 0.00001 better performance from conditions?

 

[Almia]

I know about timers being inaccurate, but you give this to GUI users. Otherwise change the name.
Back in the days, I was in love with the wait time.
After that I found timers.
Even now I use some wait timers now and then.
(I made them leakless and less data consuming... more like advanced wat timers.)

There are people who still use it because they dont know about timers or they dont care about the small difference.
Now people cannot use them because you want to have 0.00001 better performance from conditions?

You should really contact Nestharus

 

[Wietlol]

Yes I could do that... but I dont know why I should.

Limiting map makers by making normal actions have errors and stop the trigger is not good system programming IMO.
No matter why you do it and why not.

 

[Almia]

Yes I could do that... but I dont know why I should.

Limiting map makers by making normal actions have errors and stop the trigger is not good system programming IMO.
No matter why you do it and why not.

Nestharus is the other one who knows a lot in Warcraft. the other is DSG.
Nestharus also the one who created most of the Timer libs we use today.

 

[Tal'Rarity]

Nestharus is the other one who knows a lot in Warcraft. the other is DSG.
Nestharus also the one who created most of the Timer libs we use today.

They're not the only ones you know. I know stuff DSG didn't as well hasn't he moved onto SC2? I do like how he still tries to help though in the WC3 section, I really respect that.

Nestharus is a VJASS'er only so he isn't much help here really. He's only a genius there, doesn't mean much really. If you want an answer and you don't mind that it'll be VJASS then Nestharus can solve any question there, that's true however he wouldn't know the other sections of WC3 just as good unless he posts here to prove me wrong.

They're knowledgeable and intelligent, but don't forget about everyone else too. We're all very smart, well most of us. Just remember it is very unlikely they will help you with GUI questions, DSG will likely provide you with a giant wall of text that redefines your question and confuses you which might or might not resolve your question while Nes provides you with the solution you want however in VJASS.

 

[Almia]

They're not the only ones you know. I know stuff DSG didn't as well hasn't he moved onto SC2? I do like how he still tries to help though in the WC3 section, I really respect that.

Nestharus is a VJASS'er only so he isn't much help here really. He's only a genius there, doesn't mean much really. If you want an answer and you don't mind that it'll be VJASS then Nestharus can solve any question there, that's true however he wouldn't know the other sections of WC3 just as good unless he posts here to prove me wrong.

They're knowledgeable and intelligent, but don't forget about everyone else too. We're all very smart, well most of us. Just remember it is very unlikely they will help you with GUI questions, DSG will likely provide you with a giant wall of text that redefines your question and confuses you which might or might not resolve your question while Nes provides you with the solution you want however in VJASS.

And you thought Nestharus only knows better in vJASS? He even know how Warcraft 3 environment works,that's why he created or can create things which we thought is impossible(such as Codeless Save Load)

 

[Wietlol]

vJASS is actually the same as GUI... in concept.

GUI is something where people can click on commands and it will be translated into JASS.
vJASS is something where people can write commands and it will be translated into JASS.

If you can use vJASS, you can also use JASS.

BTW: I do see now why 0 damage events have to be excluded.
And I see why you hardcoded the spell reduction in the system.
Didn't see that it was required before.

 

[edo494]

If i give a unit 99999999 basic damage and put a trigger in my system that will reduce the damage to 0 it works.

I got spells that deal 0 damage and then will be changed via triggers.
0 damage is still a hit event.

There are some ways how you could avoid it.
The thing is that (maybe) some people dont want a specific thing in it what is not required to make the DDS work.
I should put that spell reduction in a different trigger and if you turn that trigger on it works and if not then it doesnt.

I just tested it and I saw that you could see the difference between the damage from spells and the damage from basic attacks.
I dont know about trigger damage if that will also be caught as physical damage but I think that the AA / Spell is the biggest difference.

He is restricting people.
Try to put this in your system:
(Yes there is a new unit variable TempUnit but you could figure.)

• Test
  • Events
    • Game - PDD_damageEventTrigger becomes Equal to 1.00
  • Conditions
  • Actions
    • Custom script: local unit udg_TempUnit
    • Set TempUnit = PDD_target
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Unit-type of PDD_source) Equal to Archmage
      • Then - Actions
        • Wait 2.00 game-time seconds
        • Unit - Kill TempUnit
      • Else - Actions

This is completely MUI.
So???


I know about timers being inaccurate, but you give this to GUI users. Otherwise change the name.
Back in the days, I was in love with the wait time.
After that I found timers.
Even now I use some wait timers now and then.
(I made them leakless and less data consuming... more like advanced wat timers.)

There are people who still use it because they dont know about timers or they dont care about the small difference.
Now people cannot use them because you want to have 0.00001 better performance from conditions?

There are a lot of events that fire 0 damage events, which are not wanted(When you cast stormbolt, when the buff is applied, a 0 damage event is fired). This is why you cant have.

You dont use global variable, you use technique called variable name shadowing.

Waits are hilariously inaccurate. In multiplayer, the delay for wait is always at least the ping to host. Waits do not give two shits if your wc3 is even actively running, and they will happily keep running when your wc3 is minimalized for instance.

Waits themselves are neither leaking nor data consuming, so I dont know how you can improve that.

Nevertheless, you can not run waits or timers from native damage event either without variable name shadowing, so I dont see the problem.

Also Nestharus wrote Codeless save/load, but it is useless because anything above roughly 10 bytes takes infinity to sync.

 

[Wietlol]

Well I should have said Game-Waits (PolledWait())
They leak by creating a timer without setting it to null again.
Also they do not pause the timer... I forgot why that was necessary.

I create PolledWaits without timers... almost.
I use gametime instead of timers. When the polledwait starts I simply ask for what gametime it is and then I add the duration of the timer to it.
Whenever the gametime reaches the value that the polledwait wants, it stops looping the trigger sleeps and is therefor finished.

I know I dont use global variables but this system does not support waits.
LFH said (and I can understand) that it is not because of the performance but the problem if the DDS would re-initialize (removing events of dead units), while one of those wait timers is still running.
If so the action is destroyed anyway.

This is new for me too but I just uploaded the concept of doubled triggers.
However the system needs a different event for the re-initialization to make it work.

 

[edo494]

None of the damage detection systems support waits, because there is no way to do so.

 

[Tal'Rarity]

None of the damage detection systems support waits, because there is no way to do so.

There's actually a few ways, just they aren't meant to be part of DDS's so they're considered clutter or extra systems.

Well I should have said Game-Waits (PolledWait())
They leak by creating a timer without setting it to null again.
Also they do not pause the timer... I forgot why that was necessary.

I create PolledWaits without timers... almost.
I use gametime instead of timers. When the polledwait starts I simply ask for what gametime it is and then I add the duration of the timer to it.
Whenever the gametime reaches the value that the polledwait wants, it stops looping the trigger sleeps and is therefor finished.

I know I dont use global variables but this system does not support waits.
LFH said (and I can understand) that it is not because of the performance but the problem if the DDS would re-initialize (removing events of dead units), while one of those wait timers is still running.
If so the action is destroyed anyway.

This is new for me too but I just uploaded the concept of doubled triggers.
However the system needs a different event for the re-initialization to make it work.

Easiest way is just to shadow the names with locals If you really want to use waits. Otherwise learn to index or hashtable. http://www.hiveworkshop.com/forums/...u-should-know-when-using-triggers-gui-233242/

 

[Wietlol]

Easiest way is just to shadow the names with locals If you really want to use waits. Otherwise learn to index or hashtable. http://www.hiveworkshop.com/forums/...u-should-know-when-using-triggers-gui-233242/

Dont worry Dat-C3, I know how to write triggers... I suppose.
I only feel that people (not me) are happy enough with wait timers.
Even I use them sometimes. When I dont care about perfect accuracy or if it would be too much to use a hashtable and timer and save the stuff etc. I use wait timers.

Here is an example where I use 2 wait timers when perfect accuracy is not required.

I prefer to use JASS only but in stuff that I send to other people I make the system in JASS (mostly) and make it GUI configurable.

 

[edo494]

that means the spell/system(your submission) is broken.

If I alt-tab, the game wont run, but the wait will keep going, and when it ends it will start Jass Interpreter again, resulting in broken spells and systems

 

[Wietlol]

that means the spell/system(your submission) is broken.

If I alt-tab, the game wont run, but the wait will keep going, and when it ends it will start Jass Interpreter again, resulting in broken spells and systems

trigger sleep action = TriggerSleepAction()
wait timer = PolledWait() because it is a wait inside a timer...
timers = CreateTimer()

It is NOT running when the game is not running.

 

[Kazeon]

//  4.  Go to the locust swarm ability and invert its damage return portion
//      from (default) 0.75 to -0.75.
//  5.  Remove the spell damage reduction ability from the spell damage reduction
//      items you use (runed bracers). You can configure the resistance of this
//      item in the InitGlobalVariables function, modifying the global variable
//      udg_PDD_BRACERS_SPELL_DMG_RED.

Can you explain why should we do these steps? You said that they are required for all DDS. I don't get how they could affect how DDS works.

//
//  function GetUnitLife takes unit u returns real
//      - Use this function instead of the GetWidgetLife native. It ensures that you
//        get the correct health value, even when damage modifiers are applied. If
//        you don't use damage modifiers at all, you don't need this function.
//
//  function GetUnitMaxLife takes unit u returns real
//      - Use this function instead of the GetUnitState(u, UNIT_STATE_MAX_LIFE) native.
//        It will return the correct value, even when damage modifiers are applied. If
//        you don't use damage modifiers at all, you don't need this function.
//
//  function SetUnitLife takes unit u, real newLife returns nothing
//      - Use this function instead of the SetWidgetLife(u, newLife) native if you use
//        damage modifiers in your map. Same rules as for the GetUnitMaxLife and the
//        GetUnitMaxLife functions.

What are those functions doin' here? This is DDS not BonusMod or something.

function GetUnitLife takes unit u returns real
    local boolean duringModification
    local integer uId = GetHandleId(u)
    local real health
    local real storedHealth = LoadReal(udg_PDD_h, uId, 2)
    local real storedDamage = LoadReal(udg_PDD_h, uId, 1)
   
    // Check if the unit is being rescued from damage
    set duringModification = GetUnitAbilityLevel(u, udg_PDD_SET_MAX_LIFE) > 0
    if duringModification then
        call UnitRemoveAbility(u, udg_PDD_SET_MAX_LIFE)
    endif

    // Get the correct health value of the unit
    if storedHealth != 0.0 then
        set health = storedHealth - storedDamage
    else
        set health = GetWidgetLife(u) - storedDamage
    endif

    // Restore the rescue ability and return
    if duringModification then
        call UnitAddAbility(u, udg_PDD_SET_MAX_LIFE)
    endif
    return health
endfunction

I don't want to use your fatty function, I want to use GetWidgetLife normally.

This is worse event handling I have seen so far.

function AddDamageHandler takes code func returns nothing
    local integer id = GetHandleId(Condition(func))
    local integer index = 0
   
    // Loop to manage equal damage handlers
    loop
        exitwhen ( LoadTriggerConditionHandle(udg_PDD_h, id, index) == null )
        set index = index + 1
    endloop
    // Store the desired damage handler function
    call SaveTriggerConditionHandle(udg_PDD_h, id, index, TriggerAddCondition(udg_PDD_damageHandler, Filter(func)))
endfunction

function RemoveDamageHandler takes code func returns nothing
    local integer id = GetHandleId(Condition(func))
    local integer index = 0
   
    // Loop through all equal damage handlers
    loop
        exitwhen ( LoadTriggerConditionHandle(udg_PDD_h, id, index) == null )
        call TriggerRemoveCondition(udg_PDD_damageHandler, LoadTriggerConditionHandle(udg_PDD_h, id, index))
        set index = index + 1
    endloop
   
    // Clean things up
    call FlushChildHashtable(udg_PDD_h, id)
endfunction

You should add somekind of prefix to your function names:
function AfterDamage takes nothing returns nothing
I think it (and some others) can collide with user defined functions easily.
function MapInit takes nothing returns nothing
function UnitEntersMap takes nothing returns nothing

Further review will be made based on your answer upon this:

//  4.  Go to the locust swarm ability and invert its damage return portion
//      from (default) 0.75 to -0.75.
//  5.  Remove the spell damage reduction ability from the spell damage reduction
//      items you use (runed bracers). You can configure the resistance of this
//      item in the InitGlobalVariables function, modifying the global variable
//      udg_PDD_BRACERS_SPELL_DMG_RED.

Can you explain why should we do these steps? You said that they are required for all DDS. I don't get how they could affect how DDS works.

 

[looking_for_help]

Can you explain why should we do these steps? You said that they are required for all DDS. I don't get how they could affect how DDS works.

The fact that you have to ask this questions means you didn't even try locust swarm with your own DDS a single time.

However, before criticizing, I expect you to do some research beforehand. If you just would have tried out on your own what happens (in any DDS) if those steps are not performed you would know. And then you would not have to ask such questions or state the installation process as "complicated". Changing two values in the object editor is everything, but not complicated.

So: do the research first, then come again and ask your questions.

 

[Kazeon]

The fact that you have to ask this questions means you didn't even try locust swarm with your own DDS a single time.

However, before criticizing, I expect you to do some research beforehand. If you just would have tried out on your own what happens (in any DDS) if those steps are not performed you would know. And then you would not have to ask such questions or state the installation process as "complicated". Changing two values in the object editor is everything, but not complicated.

So: do the research first, then come again and ask your questions.

Of course I have tested locust swarm, it deals damage to caster on return instead. But still don't get the prob with bracer item.

Remember, our DDS (due to current spell damage type detection method) will not come in harmony with wc3 native abilities, tons of them have bizarre behavior that causes some strange bugs. Locust Swarm is just one example, who knows the healing amount is actually a negative spell "damage"? Blizz shouldn't have done that. Who knows why unit with high damage such as 2000 could causes bug to Spirit Link ability? Why? Can you explain? Why do bracer item convert spell damage to physical damage? Are those our fault? No. And the point is, it's not our DDS' responsibility to get rid of those bugs. If you want to remove them all one by one, I'm afraid you could encounter another tons of awaiting bugs right there.

 

[Xonok]

Of course I have tested locust swarm, it deals damage to caster on return instead. But still don't get the prob with bracer item.

Remember, our DDS (due to current spell damage type detection method) will not come in harmony with wc3 native abilities, tons of them have bizarre behavior that causes some strange bugs. Locust Swarm is just one example, who knows the healing amount is actually a negative spell "damage"? Blizz shouldn't have done that. Who knows why unit with high damage such as 2000 could causes bug to Spirit Link ability? Why? Can you explain? Why do bracer item convert spell damage to physical damage? Are those our fault? No. And the point is, it's not our DDS' responsibility to get rid of those bugs. If you want to remove them all one by one, I'm afraid you could encounter another tons of awaiting bugs right there.

I've used the one by lfh and the only bug it has it that it breaks the GUI condition for "is unit dead".
Locust swarm does not deal negative damage to yourself as far as I know, but rather it's because it considers spell resistance. Thus, since the actual damage is negative, then a factor of it is also. This is why the returned amount is negative and no, it doesn't even have to be returned as damage(if it would be, the system would actually fix it automatically).
Haven't investigated spirit link.
Bracers don't truly change spell damage into physical damage. They only reduce it and it just so happens that they can reduce it beyond 100%. Thus, this is used for detecting whether damage was magical or not, because this same ability doesn't apply to physical damage and thus, the only way to deal negative damage is by spells.
Those things are not really that hard to fix if you know about them and yes they are the responsibility of a DDS, because breaking a map just because you're lazy is unjustifiable. Undefined and/or unexpected behaviour should be avoided.

 

[Kazeon]

I've used the one by lfh and the only bug it has it that it breaks the GUI condition for "is unit dead".
Locust swarm does not deal negative damage to yourself as far as I know, but rather it's because it considers spell resistance. Thus, since the actual damage is negative, then a factor of it is also. This is why the returned amount is negative and no, it doesn't even have to be returned as damage(if it would be, the system would actually fix it automatically).

That's why I said

"damage"

It's undetectable.

Haven't investigated spirit link.
Bracers don't truly change spell damage into physical damage. They only reduce it and it just so happens that they can reduce it beyond 100%. Thus, this is used for detecting whether damage was magical or not, because this same ability doesn't apply to physical damage and thus, the only way to deal negative damage is by spells.
Those things are not really that hard to fix if you know about them and yes they are the responsibility of a DDS, because breaking a map just because you're lazy is unjustifiable. Undefined and/or unexpected behaviour should be avoided.

How about Thorn Aura and Spiked Carapace or any damage reflecting abilities bugs? If user modifies the damage amount at damage event, damage reflection's amount wont be based on that new modified damage. That would be nasty to be fixed. That's why I will just say, "my DDS is not made for wc3 native abilities"

 

[looking_for_help]

Of course I have tested locust swarm, it deals damage to caster on return instead. But still don't get the prob with bracer item.

Remember, our DDS (due to current spell damage type detection method) will not come in harmony with wc3 native abilities, tons of them have bizarre behavior that causes some strange bugs. Locust Swarm is just one example, who knows the healing amount is actually a negative spell "damage"?

There are not tons of strange bugs, but only very few which can be handled manually.

A DDS shouldn't change gameplay mechanics by default, right? So if there is the posiblity to fix a bug then why not do it? Especially if it is so extremly easy to fix? Changing one value in the object editor takes maybe 10 seconds and has to be done only once per map. So I don't get your problem with this?

If you don't use locust swarm at all in your map you can of course just omit this step. But if you use it, you might want it to work correct, right?

The problem with bracers is, that it is overwritten. All units have a bracer item with 200% spell reduction (thats required to detect damage type). If you now pic up another bracer item with, say 33% spell reduction, it overwrites the previous ability. Then spell damage detection won't work anymore.

Therefore you have to remove the ability from the item and code the reduction yourself. Then you can use it just in the standard way.

Again, if you don't need bracers, you can omit this installation step, but that should be obvious.

Why? Can you explain?

No, why should I?

That's why I will just say, "my DDS is not made for wc3 native abilities"

Then there is no point in using this system at all. Because the damage type detection technique is only useful for native abilities. If you have triggered spells only, you don't need damage type detection because you can just asign the damage type yourself. Triggered damage can always be detected perfectly without the use of the bracers trick.

If only triggered abilities are used, its better to use a DDS without damage type detection support. Because triggered damage type identification is trivial.