[MUI] Full screen inventory and shop + Custom item

[Moderator]

Full screen inventory and shop + Custom item | Reviewed by Maker | 17th Aug 2013

APPROVED

This is a cool system with nice features. It seems to work well. However it is a nightmare to import and configure. It should have been done in vjass.

[tr][td]

 

[shadowvzs]

Update: added charm, more detail in 1st post

 

[Rapid]

This is useful on rpg maps or hero arena thanks..

 

[shadowvzs]

Update:
few minor fix and added custom hp/mp potions added regen potions too, few more thing

 

[Felz_09]

Useful for Hero Defence map type .. thanks for sharing..

 

[shadowvzs]

update

added bagpack's (mui store box where u can store items, bag also a item) and treasure/surprise box (randomly give gold/potion or item)

for understanding how it work, we move bow into bag then double click to bag

 

[GaAg0]

OMG THIS IS SO EPIC! is it jass or vjass?

 

[shadowvzs]

it is simple jass, else if i know vjass (or have time/mood for learn it) then i add the saveing into file the data for save/load

 

[Rapid]

It's Jass

 

[-Kobas-]

You should add code into resource description

 

[shadowvzs]

You should add code into resource description

code is far above 80k character :/ i will add later somehow, main problem dont ahve sight where i can post huge codes and also make align and etc

 

[-Kobas-]

code is far above 80k character :/ i will add later somehow, main problem dont ahve sight where i can post huge codes and also make align and etc

Pastebin, if nothing else.

 

[shadowvzs]

Pastebin, if nothing else.

i made, 1st post updated also added in map more description/label

have fun

 

[-Kobas-]

Hmmm I would like you know your point of view about this:

//-------------------------------------------------------------------------
//                              CONSTANTS
//-------------------------------------------------------------------------

//special effect paths, example for potion
constant function EFFECT takes integer i  returns string
if i == 26 then
  return "Abilities\\Spells\\Human\\Heal\\HealTarget.mdl"
elseif i == 30 then
  return "Abilities\\Spells\\Undead\\ReplenishMana\\SpiritTouchTarget.mdl"
endif
endfunction

//max stack/charge for stackable items
constant function CHARGE_MAX takes nothing returns integer
 return 99
endfunction

//max bag zise
constant function BAG_SIZE_MAX takes nothing returns integer 
  return 24
endfunction

//etc etc...

using functions just slow down code, it's should be better to just use

constant integer CHARGE_MAX = 99
constant integer BAG_SIZE_MAX  = 24

Using functions here are good for cases like that first shown above, and bad in other 2.
Even if you work with structs, scopes and so on, using function to return variable is just inefficient.

That's why I want to hear you opinion about this.

 

[shadowvzs]

it is jass and NOT vjass thats the point

if i dont want use vjass, then what is the best way for make global constants?

onlyway is the gui global variables? or if i make function what return a simple value that dont slowdown?

i mean lets say in my map the bag size is 24 then:

function BAGSIZE takes nothing returns integer
  return 24
endfunction

is noticeable slower than udg_Bag_Size=24 at map init?

That is a perfectly fine way to do constants

 

[-Kobas-]

But why you code it within jass >.>
vJass can shrink your code by 50% for sure.

It's like comparison between C and C++.

 

[shadowvzs]

if u search then all similiar system is vjass, even this jass i got "copy of your system" comment even i wrote it from my own and not converted from vjass to jass then what if i start write in vjass?

 

[Adiktuz]

Nice improvements... I don't really like the idea of putting too much capabilities on a single system though... You can put some of them as external add-ons... but nonetheless, really nice system going...

 

[Magtheridon96]

Could you make the indentation and naming consistent throughout all the code files? :/

If you're not sure about convention, this one is favored and applied by every resource approved in the JASS section (Some old ones don't follow it)

Indentation is commonly 4 spaces per tab.

 

[shadowvzs]

Could you make the indentation and naming consistent throughout all the code files? :/

If you're not sure about convention, this one is favored and applied by every resource approved in the JASS section (Some old ones don't follow it)

Indentation is commonly 4 spaces per tab.

i used Script Aligner, so i thought most of code was done....

Nice improvements... I don't really like the idea of putting too much capabilities on a single system though... You can put some of them as external add-ons... but nonetheless, really nice system going...

when i have time and mood also idea (since i dont got too much idea from others) i update it, next update will with weapon special effect and buff

 

[Magtheridon96]

In either case,

//-----------------------------------------------------------
//      Item / Heroes registration
//-----------------------------------------------------------

function RegItemCat4Shop takes integer c, integer id returns nothing
local integer i = LoadInteger(udg_Shop_Table,c, 0)
local integer a = LoadInteger(udg_Shop_Table,0, 0)
if a < 1000 then
  set a = 1000
endif
set a = a + 1
set i = i + 1
call SaveInteger(udg_Shop_Table, c, 0, i)
call SaveInteger(udg_Shop_Table, 0, 0, a)
call SaveInteger(udg_Shop_Table, c, i, id)
call SaveInteger(udg_Shop_Table, c, -i, a)
endfunction

function RegItem4Shop takes integer c, integer sc, integer itd, integer unique returns nothing
local integer id = LoadInteger(udg_Shop_Table, c, -sc)
local integer i = LoadInteger(udg_Shop_Table, id, 0)+1
call SaveInteger(udg_Shop_Table, id, 0, i)
call SaveInteger(udg_Shop_Table, id, i, itd)
call SaveInteger(udg_Shop_Table, id, -i, unique)
endfunction

function RegisterItem takes integer id, integer dest, string path, integer price, integer lv, string descr, integer subtype returns nothing
if path != null then
  call SaveStr(udg_FSS, 601, id, path)
endif
if descr != null then
  call SaveStr(udg_FSS, 604, id, descr)
endif
  call SaveInteger(udg_FSS, 600, id, dest)
  call SaveInteger(udg_FSS, 602, id, price)
  call SaveInteger(udg_FSS, 603, id, lv)
if subtype > 0 then
  call SaveInteger(udg_FSS, 605, id, subtype)
endif
endfunction

function RegCraft takes integer id, integer d1, integer c1, integer d2, integer c2, integer d3, integer c3 returns nothing
  call SaveInteger(udg_FSS, 606, id, d1)
  call SaveInteger(udg_FSS, 607, id, c1)
  call SaveInteger(udg_FSS, 608, id, d2)
  call SaveInteger(udg_FSS, 609, id, c2)
  call SaveInteger(udg_FSS, 610, id, d3)
  call SaveInteger(udg_FSS, 611, id, c3)
endfunction

function AddDescription takes integer id, string s1, string s2, string s3 returns nothing
  call SaveStr(udg_FSS, 647, id, s1)
  call SaveStr(udg_FSS, 648, id, s2)
  call SaveStr(udg_FSS, 649, id, s3)
endfunction

function RegHeroes takes integer id1, integer id2, boolean Attachment, real size, integer class, integer damage returns nothing
  call SaveInteger(udg_FSS, 630, id1, id2)
  call SaveBoolean(udg_FSS, 631, id1, Attachment)
  call SaveReal(udg_FSS, 632, id1, size)
  call SaveInteger(udg_FSS, 633, id1, class)
  call SaveInteger(udg_FSS, 634, id1, damage)
endfunction

^That's not good alignment :v

 

[shadowvzs]

ty, i edit now and if i am done then upload the new version and change the pastebin things too, if still u notice something else too then pls tell me

i also fixed the destructible flickering in inventory and changed the design too, added buffs, weapon activation, fixed the respawn problem (trigger ran 15x coz was in loop the add action)

still i want check out better the weapon activation effects, remove the debugs from buff, add percentage hp buff, check out the trade again

 

[shadowvzs]

updated, still dont got time for trade fix but alot others things was added/solved like the new interface what dont ahve flickering or something crap

 

[shadowvzs]

updated, trade work now

few screenshot about trade and weapon activation buff

 

[Almia]

System would be better if you use Dummy.mdx.

 

[shadowvzs]

System would be better if you use Dummy.mdx.

u opened the map? coz from ur post i must guess no because it is use dummy.mdx for hero dummy and for another interface around inventory dummy hero


so dummy unti and craps are just special effect attached on dummy unit

pastebin code not updated yet because still want few thing before align every script and paste into pastebin

 

[Almia]

Oh sorry my bad
You can do the interface for the destructables,i use that in my HSS


edit
Okay,i have read the code.
The bad things i must say is the BJ events and indention.

Also,that TriggerAddAction should be replaced by TriggerAddCondition and make that action return boolean.(because TriggerAddCondition doesn't create new thread)

Some codes also lacks in description and comments.The system would be better in description if it has an API.

The User defined globals also should have prefixes, so we won't experience variable collisions.

Messages should be configurable.

Also,I found out you use TAS there.

You also use so many hashtables.

You also must not be scared with keys, the max value of a key is 2^31 and the minimum is 2^31 in negative.

You should evade using locations,you are in JASS now bro,we JASSers rarely use locations,we now use coords.

Suggestion: I would suggest a section for API and Doc,a section for constants,a section for sub-functions or utils and a section for the main triggers.You also don't need to use so many hashtables,because the max value of keys as i have mentioned before is 2^31,so don't be scared to use such thing.

Also,wanna check out this : http://www.hiveworkshop.com/forums/...nsion-176817/?prev=d=list&r=20&u=D4RK_G4ND4LF . This system is sweet and very functional. and also has short codes

 

[shadowvzs]

- u mean use dummy unit for interface? i guess better how it is now since easier to show/hide destructible than use alot dummy unit and allways recreate special effect on them (HSS=?)

- i use few bj event i know, i will work on it later just mostly i started everything from gui then converted the functions because was easier to set a event in gui then convert to custom text than search for correct event in jasscraft

- in condition in few place i cant use TSA (sometimes its block the multiple function running a TSA(0) at end and dont need another variable for it)

- few variable have prefix, maybe not best
Inv_ = inventory related variable
Buff_ buff related
Global_ - universal stat related
Stat_ - base stat for equipment units where we store all item bonus (why? because easier to make percentage boost with Stat_ and Globa_ variable arrays)

- TSA used only at end of few trigger like pick up item for avoid the duplication or somewhere where absolute not important the time and dont screw up something, everything else place i used timers

anyway like i said code not updated yet

- configurable message means a new function instead the displaytextfor player?

- idk how to make with less hashtable without calculate too much useless thing, and since 100 or how much hashtable possible on map i guess 6 is ok for nearly everything (stats/prod skills/custom windows/trackables/buffs/drop etc), i tryed avoid the overcroweded long keys like x * y + z keys etc

anyway i readed somewhere if a hashtable stored too much data then the reading and writeing into that hashtable is slower

- where i used location?

- i thought too to useing triggers for separate the sub functions but its very hard and gived up because alot function refer to another what also refer to another function so at end will be chaos if i try do it, i tryed separete in header with bigger comments with alot --------------

even maybe kinda chinese how i write but i have my own order (even to peoples that not so easy to get how its work), so header starting with constants, then elements are tagged (full screen crap, item crap, multiboard crap, attachment craps etc)
then in clickTotrackable i have ~every function what closely related with inventory (add icon/remove icon/close window/swap icon and items/clicking checks/buy/sell/equip requiment checking etc)

- at last:
i checked now that system only a bit but seems that also have long triggers
but whatever :
- dont show hide destructibles
- camera lock is bad on that system
- dont have equipments
- dont have advanced item handling like at my map with alot item properties (on that map only few regular craps like armor, life, movement bonus etc but only few of them, where is the critical strike damage, reflect, gold or exp bonus etc)
- its show with ugly white background (idk why)
- dont have trackables with mouseover functions
- cant organize ur inventory same time with old inventory
- unit can go over the inventory
- there no such things like multiple system what use same place, also dont have anything about use that place for decoration when inventory not active to u
etc etc correct me if anything not true between what i listed

anyway ty the response, coz i need fix few thing, if u got where i used location then could be cool

 

[Almia]

Prefixes should be as unique as the system's name

 

[NyQz]

Wow, this is exactly what I was looking for, thank you so much! )

 

[Almia]

- where i used location?

The only coder i know who doesn't even remember the whole code of the system

its inside the Create Hero and Stat point and gold code.

 

[shadowvzs]

The only coder i know who doesn't even remember the whole code of the system

its inside the Create Hero and Stat point and gold code.

do you readed something what i not?

coz i dont see any location thing there, everything use x,y, so what u watched there?

plsease help em out where u see location, or do u mean to start location? that created the system not me

function Trig_Hero_Stat_Point_Conditions takes nothing returns boolean
local integer pl = GetPlayerId(GetTriggerPlayer())+1
local integer cv = GetUnitUserData(GetLevelingUnit())
        set udg_Stat_Point[cv] = udg_Stat_Point[cv] + STAT_PER_LV()
        if udg_Camera_Lock[pl] == 1 and udg_Trader[pl] == 0 then
           call ShowStat(pl)
        endif
    return false
endfunction

function AddStaetEquipmentToHero takes unit u returns nothing
local integer class = LoadInteger(udg_FSS, 633, GetUnitTypeId(u))
local integer rnd
local integer w = 1
if class == 0 then
  set rnd = GetRandomInt(1,3)
elseif class == 1 or class == 2 then
  set rnd = 1
elseif class == 3 or class == 4 then
  set rnd = 2
elseif class == 5 then
  set rnd = 3
endif

  if rnd == 1 then
     if class == 1 then
      set w = 3
     else
      loop
      exitwhen w != 3
        set w = GetRandomInt(1,5)
      endloop     
     endif
     call UnitAddItem(u, LoadItemHandle(udg_CItem_Table,GenerateEQ (3, w, 2, GetHeroLevel(u), GetHeroLevel(u), GetUnitX(u), GetUnitY(u), true, 2),100))
     if w < 3 then
        call UnitAddItem(u, LoadItemHandle(udg_CItem_Table,GenerateEQ (5, 1, 2, GetHeroLevel(u), GetHeroLevel(u), GetUnitX(u), GetUnitY(u), true, 2),100))
     endif
  elseif rnd == 2 then
     if class == 3 then
        set w = 6
     else
        set w = 7
     endif
     call UnitAddItem(u, LoadItemHandle(udg_CItem_Table,GenerateEQ (3, w, 2, GetHeroLevel(u), GetHeroLevel(u), GetUnitX(u), GetUnitY(u), true, 2),100))
  elseif rnd == 3 then
     set w = GetRandomInt(7,8)
     call UnitAddItem(u, LoadItemHandle(udg_CItem_Table,GenerateEQ (3, w, 2, GetHeroLevel(u), GetHeroLevel(u), GetUnitX(u), GetUnitY(u), true, 2),100))
  endif
  call UnitAddItem(u, LoadItemHandle(udg_CItem_Table,GenerateEQ (1, rnd, 2, GetHeroLevel(u), GetHeroLevel(u), GetUnitX(u), GetUnitY(u), true, 2),100))
  call UnitAddItem(u, LoadItemHandle(udg_CItem_Table,GenerateEQ (2, rnd, 2, GetHeroLevel(u), GetHeroLevel(u), GetUnitX(u), GetUnitY(u), true, 2),100))
  call UnitAddItem(u, LoadItemHandle(udg_CItem_Table,GenerateEQ (4, rnd, 2, GetHeroLevel(u), GetHeroLevel(u), GetUnitX(u), GetUnitY(u), true, 2),100))
  //add bag
  call UnitAddItem(u, CreateItem('I00U',GetUnitX(u),GetUnitY(u)))

endfunction

function AddInv2Hero takes unit u returns nothing
local integer cv 
local integer i = GetPlayerId(GetOwningPlayer(u))+1
            call SelectUnitAddForPlayer( u, Player(i-1) )
            call SetHeroLevel( u, 5, false )
            call SuspendHeroXP( u, true )
            // make them permanent
            call SetPlayerAbilityAvailable( Player(i-1), MELEE2RANGED_ID(),  false)
            call UnitAddAbility( u, 'A00D' )
            call UnitAddAbility( u, 'A001' )
            call UnitAddAbility( u, 'A005' )
            call UnitAddAbility( u, 'A006' )
            call UnitAddAbility( u, 'A002' )
            call UnitAddAbility( u, 'A007' )
            call UnitAddAbility( u, 'A008' )
            call UnitAddAbility( u, 'A009' )
            call UnitAddAbility( u, 'A00H' )
            call UnitAddAbility( u, 'A00G' )
            call UnitMakeAbilityPermanent(u, true, 'A00D')
            call UnitMakeAbilityPermanent(u, true, 'A001')
            call UnitMakeAbilityPermanent(u, true, 'A002')
            call UnitMakeAbilityPermanent(u, true, 'A005')
            call UnitMakeAbilityPermanent(u, true, 'A006')
            call UnitMakeAbilityPermanent(u, true, 'A007')
            call UnitMakeAbilityPermanent(u, true, 'A008')
            call UnitMakeAbilityPermanent(u, true, 'A009')
            call UnitMakeAbilityPermanent(u, true, 'A00B')
            call UnitMakeAbilityPermanent(u, true, 'A00E')
            call UnitMakeAbilityPermanent(u, true, 'A00G')
            call UnitMakeAbilityPermanent(u, true, 'A00H')
            set cv = GetUnitUserData(u)
            set udg_Stat_Point[cv] = udg_Stat_Point[cv] + START_POINT()
            call StatRefresh (cv)
            call AddStaetEquipmentToHero (u)
            call SaveBoolean(udg_Stat_Table, 8890, GetHandleId(u), true)
            call TriggerRegisterUnitEvent( gg_trg_Start_Inventory, u, EVENT_UNIT_SPELL_EFFECT )
endfunction

function Trig_Create_Heroes_and_gold_for_test_Actions takes nothing returns nothing
local integer i = 1
local real x 
local real y 
local trigger t1 = CreateTrigger()
local unit u
local integer id
call TriggerAddCondition( t1, Condition( function Trig_Hero_Stat_Point_Conditions ) )

    loop
        exitwhen i > 12
        if ( GetPlayerSlotState(Player(i-1)) == PLAYER_SLOT_STATE_PLAYING and GetPlayerController(Player(i-1)) == MAP_CONTROL_USER ) then
            set x = GetPlayerStartLocationX(Player(i-1))
            set y = GetPlayerStartLocationY(Player(i-1))
            set u = CreateUnit( Player(i-1), 'H000', x, y, bj_UNIT_FACING )
            call TriggerRegisterUnitEvent( t1, u, EVENT_UNIT_HERO_LEVEL )
            set udg_Hero[i] = u
            call AddInv2Hero(u)
            set u = CreateUnit( Player(i-1), 'Hpal', x+100, y, bj_UNIT_FACING )
            call TriggerRegisterUnitEvent( t1, u, EVENT_UNIT_HERO_LEVEL )
            call AddInv2Hero(u)
            set u = CreateUnit( Player(i-1), 'Hvwd', x+100, y+100, bj_UNIT_FACING )
            call TriggerRegisterUnitEvent( t1, u, EVENT_UNIT_HERO_LEVEL )
            call AddInv2Hero(u)
            call TriggerRegisterPlayerChatEvent( gg_trg_Trade_Gold_amount, Player(i-1), GetEventPlayerChatString(), true )
            call SetPlayerState( Player(i-1), PLAYER_STATE_RESOURCE_GOLD, 100000 )
            if GetLocalPlayer() == Player(i-1) then
             call ClearSelection()
            endif
        endif
        set i = i + 1
    endloop
set t1 = null
set u = null
call CWInterface()
call ShowTradeWindow()
endfunction

//===========================================================================
function InitTrig_Create_Heroes_and_gold_for_test_and_Lv_up_func takes nothing returns nothing
    set gg_trg_Create_Heroes_and_gold_for_test_and_Lv_up_func = CreateTrigger(  )
    call TriggerRegisterTimerEventSingle( gg_trg_Create_Heroes_and_gold_for_test_and_Lv_up_func, 1.00 )
    call TriggerAddAction( gg_trg_Create_Heroes_and_gold_for_test_and_Lv_up_func, function Trig_Create_Heroes_and_gold_for_test_Actions )
endfunction

 

[Almia]

            set x = GetPlayerStartLocationX(Player(i-1))
            set y = GetPlayerStartLocationY(Player(i-1))

This?

 

[shadowvzs]

[UPDATE]
- fix few trade problem (in normal 0.95 u was unable to leave or even u quited there was still the trade partner gold floating text)
- added ally function + replace the red startlocation function to native function what dont use location - in create heroes trigger
- few indentation thing

its now i guess a stable version still if someone find bug then please tell me but i guess now its pretty ok

Pastebin codes updated too

 

[Almia]

If the code will be shorten as possible,Meg and Maker will be able to review this system.

 

[HammerFist132]

Huh will moderators rewiev this.

 

[Almia]

Huh will moderators rewiev this.

Certainly, Mag and Maker will review this when it has been modified to its simplest form, because every time they review this,they are disappointed.

 

[Maker]

I've started reviewing it two times, but always aborted the mission.

There is so much code, and it is not moderator friendly. There could be a lot less code I believe.

 

[Almia]

^ Agreed.
I think this should be reduced and modified and its simplest state,similar to CustomInvetory

 

[-Kobas-]

Something like this should be vjass coded.
Because it will be much more easier to read, edit and use code.

 

[Almia]

The question is : can shadowvs' code in vJASS?

 

[shadowvzs]

Something like this should be vjass coded.
Because it will be much more easier to read, edit and use code.

then u can do it, i dont rewrite to vjass, even it will be never reviewed, but its stay jass, if someone want it then he can rewrite....

 

[Almia]

Actually,we don't need a vJASS inventory, Anachron's CustomInventory have beaten it.

 

[Tank-Commander]

Coding efficiency aside, there's still some bugs with the system in general, for instance, it's possible to get negative resistances (which become more negative) when you reset attributes (as well as negative armour values) should not be possible really, your test map forgot to block flying units, so you can put an owl scout in there, but that's a semantics thing so not really a problem. It's a bit awkward to get out of the menu with the exit buttons right next to the hero selection boxes, and out of curiousity, what happens if two players are in their inventory at the same time?

You also have a textag bug where you can get them overlapping by spam-clicking them with a hero

The text could be a little more obvious I suppose on it (increase font size?)
, additionally, your clock timer area, should change back after selecting an item, and then click off from it

As far as other things, I'd suggest making it auto-exit when your hero takes damage, and making it inaccessible when the hero recently took damage as a configurable option for people

 

[Almia]

I think this system shall use CSS by Doomlord.

 

[shadowvzs]

Coding efficiency aside, there's still some bugs with the system in general, for instance, it's possible to get negative resistances (which become more negative) when you reset attributes (as well as negative armour values) should not be possible really, your test map forgot to block flying units, so you can put an owl scout in there, but that's a semantics thing so not really a problem. It's a bit awkward to get out of the menu with the exit buttons right next to the hero selection boxes, and out of curiousity, what happens if two players are in their inventory at the same time?

You also have a textag bug where you can get them overlapping by spam-clicking them with a hero

The text could be a little more obvious I suppose on it (increase font size?)
, additionally, your clock timer area, should change back after selecting an item, and then click off from it

As far as other things, I'd suggest making it auto-exit when your hero takes damage, and making it inaccessible when the hero recently took damage as a configurable option for people

when happen that negative ressitance? coz i still not experienced with it :/

about flying unit, i used land pathing blocker, i could change that to both

about 2 player in their inventory: both see his inventory, dont make any effect the player A inventory to other player B inventory

when occur the textbug? i found your ss[/b[ - i will fix it

about increased font size, its a bit ugly if i change the size, i could import a better font but i dont see any reason for that coz then need more space for stats and i want make the system space efficient

about auto exit when u reicive the damage is bad, could be easily abused :/

I think this system shall use CSS by Doomlord.

i dont want more ability than needed.....

 

[Tank-Commander]

Prehaps having exit-on-damage configurable then? prehaps have it as a toggle for a player?

The textbug occurs when you spam click to harvest those materials of yours

Negative armour and such occurs when you reset stat bonuses (specifically I put a tonne on agility and strength on the ranger, then pressed it and had negative values)

 

[shadowvzs]

update
- fixed the floating text thing
- fixed the air unit entering to inv. area thing
- inventory sensibility command added (i dont want sure how the best and now close inventory if any of your unit attacked but i can change to specially to only inventory unit, idk what better)

Negative armour and such occurs when you reset stat bonuses (specifically I put a tonne on agility and strength on the ranger, then pressed it and had negative values)

that not bug, in gameplay constant the default defence value before agility is -2, since you restat allways to 5 agility and 3 agility =1 defence result will be -1 armor, its normal but anyway i disable the defence bonus per agility and setted to 0 the default defence because i dont use the regular armor/damage system

 

[gorillabull]

this still isnt moderated hahaha