Lightning Cloud v2.0

[Adiktuz]

since its already jass, yeah, formulas will be better, and they are a bit easy to edit in jass than in GUI...

 

[Light]

i think this spell was used in DotA for Razor....hmmmm

 

[Bribe]

I recommend for convention using "constant function" for your configurables and, rather than using StringHash, use constant functions which return unique integers. Doing it that way would ensure better efficiency while maintaining readability.

 

[clockwork2]

cool,create a group of em and make em Deal EXTREME damage and you could use it for RA2's weather controller device.

 

[mckill2009]

===UPDATE===
- Code is greatly optimized and reduced
- Stringhashes removed
- Constant functions applied
- Merged with condition
- Global variables reduced from 4 to 2

Now, Bribe can you approve this now?

 

[baassee]

-This:

function LC_FilterThem takes nothing returns boolean
    return GetWidgetLife(GetFilterUnit()) > 0.405 and IsUnitEnemy(GetFilterUnit(), GetOwningPlayer(udg_LC_Cloud)) and IsUnitType(GetFilterUnit(), UNIT_TYPE_STRUCTURE)==false
endfunction

Should be this:

function LC_FilterThem takes nothing returns boolean
    local unit u = GetFilterUnit()
    local boolean b = GetWidgetLife(u) > 0.405 and IsUnitEnemy(u, GetOwningPlayer(udg_LC_Cloud)) and IsUnitType(u, UNIT_TYPE_STRUCTURE)==false
    set u = null
    return b
endfunction

-Why are you still destroying timers

-In the LC_Cast function, it should return false always.

-Same with DummyCast.

This is way better than before I have to say! Good work!

 

[mckill2009]

Hey tnx man, I'll do that in the next update...

Im still destroying timers coz I did not look deeper to yor recycling idea in your pounce spell...

 

[baassee]

Dig into it, it will definatly improve the spell by far.

 

[Bribe]

To add to my comment, I also highly recommend not lining up your initialization as you routinely do. It would be less silly, improve readability and some syntax highlighters take advantage of "function()" (the way that the text is right before the parenthesis) that would mess up if you type "function ()"

 

[mckill2009]

===UPDATE===
- Triggers reduced from 2 to 1
- Indenting fixed
- Codes reduced

Sorry if I still destroy timers, I think nothing wrong with it ...

 

[baassee]

Right you recycle them in another spell of yours and not in this one, doesn't make any sense at all.

Alright I don't get Bribe's suggestion, adding both conditions to the trigger? Then you can really just merge those functions into one and you will get rid of a function as well (Bribe, I think you will catch my point)

This function still need to be changed to my suggestion in a previous comment.

function LC_FilterThem takes nothing returns boolean
    return GetWidgetLife(GetFilterUnit()) > 0.405 and IsUnitEnemy(GetFilterUnit(), GetOwningPlayer(udg_LC_Cloud)) and IsUnitType(GetFilterUnit(), UNIT_TYPE_STRUCTURE)==false
endfunction

into this

function LC_FilterThem takes nothing returns boolean
    local unit u = GetFilterUnit()
    local boolean b = GetWidgetLife(u) > 0.405 and IsUnitEnemy(u, GetOwningPlayer(udg_LC_Cloud)) and IsUnitType(u, UNIT_TYPE_STRUCTURE)==false
    set u = null
    return b
endfunction

Anyway looks better and better every single time I see it but you will probably need to update this a bit further to get it approved (Bribe has some high (very needed) standards (hopefully)).

 

[mckill2009]

I think Bribe has a good point of merging the conditions, before I created 2 triggers and run 2 EVENT_PLAYER_UNIT_SPELL_EFFECT but as per Bribe's suggestion, it makes sense that it can be merged into 1...

 

[baassee]

You don't get it don't you? What I meant was that this:

    call TriggerAddCondition(t, Condition(function LC_Cast))
    call TriggerAddCondition(t, Condition(function LC_DummyCast))

Can be just this

    call TriggerAddCondition(t, Condition(function LC_Cast))

How? You merge those functions. They both contain ifs right? Then it won't be a problem to put the dummy if in the else part of the if the checks the spell id.

 

[mckill2009]

actually I already figured that out last night and made the new update, I just didnt post it yet coz I was so sleepy and update it first thing in the morning, thanks though ...

 

[x3GlikE]

Looks good.

 

[Ketsuno Anson]

Why make it so hard?
- Init : Make trigger dummy and set variables
- Loop : Make it 'jump' to the position of the caster until durationvariable is 0.

Now all you need is a dummy unit that looks like a cloud and has Phoenix Fire (Or even let it attack with Lightning Attack).
Only downside here is you either have to have a upgrade for the dummy's damage or have X different dummy units.

Also, the idea is kinda like Razor's ultimate (DotA).

3.5/5

That way,putting extra effects like knockback,etc would be harder

 

[Bribe]

This is a bit lacking. I think I know how to make it really good:

Instead of always launching the lightning from the center of the cloud, launch the lightning from a random point in the cloud. This will give it a bit more realism.

I also recommend preloading the cloud special effect via the "Preload" native.

 

[mckill2009]

This is a bit lacking. I think I know how to make it really good:

Instead of always launching the lightning from the center of the cloud, launch the lightning from a random point in the cloud. This will give it a bit more realism.

I also recommend preloading the cloud special effect via the "Preload" native.

any ideas on how to generate lightning in random area around the cloud without making dummy units?...use lightning handle???...

 

[baassee]

You have the center of the cloud coordinates, then you just do the normal polar x/y and where you usually put + something will be a random number, from -aoe/2 to aoe/2 and the angle will be also random Simple as that.

 

[mckill2009]

yes but can it be done "without making dummy units"?...or I'll just make a lightning handle and get the Z of the point like in my Ignition spell?...

EDIT:
coz what I have in mind is making dummy units with the same height as the cloud, then do the random offset+angle thing...

 

[baassee]

You dont need a dummy unit, use the coordinates instead?

 

[mckill2009]

You dont need a dummy unit, use the coordinates instead?

I dont think it can be done without creating a dummy since the cloud is the caster of the lightning, so the lightning is static...

 

[shadowvzs]

its possible for modify this for makeing just a made cloud what moveing around the map (to random place) and rarly hit a unit who have user controller (so hit only the players and dont hit the creeps)?

 

[mckill2009]

its possible for modify this for makeing just a made cloud what moveing around the map (to random place) and rarly hit a unit who have user controller (so hit only the players and dont hit the creeps)?

create a dummy unit then make the dummy unit cast the cloud ability, order
your dummy unit to wander in map, the cloud will follow the dummy unit...

as for hitting non-creeps, you can edit the "LC_FilterThem", add the line "and GetOwningPlayer(u) != Player(PLAYER_NEUTRAL_AGGRESSIVE) "

 

[shadowvzs]

create a dummy unit then make the dummy unit cast the cloud ability, order
your dummy unit to wander in map, the cloud will follow the dummy unit...

as for hitting non-creeps, you can edit the "LC_FilterThem", add the line "and GetOwningPlayer(u) != Player(PLAYER_NEUTRAL_AGGRESSIVE) "

thx, +1 noob question, where i must set the duration (coz i think to put a longer duration for cloud)

 

[mckill2009]

Pretty much everything can be found in the configurations...

constant function LC_Duration takes nothing returns real
    return 20. //This is the duration of the cloud and spell
endfunction

 

[ALTELMA]

I like it!! thanks you

 

[wolfkiller015]

Why not just use Locust for this?
U don't have brain do u?

 

[Adiktuz]

Locust does things very differently... and one of the things that triggered spells does that cannot be done using OE spells is allowing damage to be dependent on user stats for example, or other variables etc...

 

[MrFrichyBoy]

Howdy I'm trying to implement this spell into my map, I have followed each step very carefully. Yet the power still doesn't work for me, all it does is create the cloud that follows the caster, but no lightning shoots out. Could anyone help with this issue, it would be deeply appreciated!?

 

[Pyrogasm]

The author of this resource did something very stupid. Instead of creating an empty group variable to use for enumeration (finding chain lightning targets), they opted to just use bj_lastCreatedGroup. That's only usually an empty unit group, and in your case it sounds like that variable points to a group that has been destroyed. Replace the loop function with this edited version:

function LC_Loop takes nothing returns nothing
    local timer t = GetExpiredTimer()
    local integer parent = GetHandleId(t)
    local integer cloudkey
    local unit caster = LoadUnitHandle(udg_HASH, parent, 1)
    local unit cloud = LoadUnitHandle(udg_HASH, parent, 2)
    local real dur = LoadReal(udg_HASH, parent, 3)
    local real range = LoadReal(udg_HASH, parent, 4)
    local group g //added
    set cloudkey = GetHandleId(cloud)
    set udg_LC_Cloud = cloud //should be transfered to a global variable
    if dur > 0 and GetWidgetLife(caster) > 0.405 then 
        call SaveReal(udg_HASH, parent, 3 , dur - LC_TimerSpeed())
        call SetUnitX(cloud, GetUnitX(caster))
        call SetUnitY(cloud, GetUnitY(caster))
        set g = CreateGroup() //added
        call GroupEnumUnitsInRange(g, GetUnitX(cloud), GetUnitY(cloud), range, Filter(function LC_FilterThem)) //changed
        call IssueTargetOrder(cloud, "chainlightning" , FirstOfGroup(g)) //changed //852119
        call DestroyGroup(g) //added
        set g = null //added
    else
        call UnitApplyTimedLife(cloud, 'BTLF', 0.01)
        call LC_RTimer(t)
        call FlushChildHashtable(udg_HASH, parent)
        call FlushChildHashtable(udg_HASH, cloudkey)    
    endif
    set t = null
    set cloud = null
    set caster = null  
endfunction