TimedUnitScale v2.0

[Moderator]

11:23, 22th May 2015
BPower: Looks good to me. Approved.
Please remove not directly needed requirements.

22:22, 8th Jan 2015
Orcnet: Set to Need Fix, for now

 

[IcemanBo]

Actually, I'm not sure about how Hive handles Nes's resources atm. Tell me if it's a problem. :d

 

[GywGod133]

This is better for Tiny's Grow

EDIT:
Not bad...

 

[Kazeon]

• 
  First, I prefer apply and remove for the function names
  
• Thread crash could occurs on create method if growUpDuration or growDownDuration is zero (!0 devided by 0 => thread crash). The solution is to skip some/whole actions: if growUpDuration is zero, then the unit scaled up/down instantly, if growDownDuration is zero, then the unit will be reset instantly either, if both of them is zero then don't start the timer at all. I believe you can solve this by yourself actually But the point is 0 means instant
  

•             if eDuration < 0 then 
                  set growBack = false
              else
                  set growBack = true
              endif

  Usually, 0 is also included as permanent so it should be eDuration <= 0.
  

•                     if not pauseGrow then
                          set tmpScale = unitScale[id] + growRate
                          call SetUnitScale(grower, tmpScale, 1, 1)
                          set unitScale[id] = tmpScale

  I think tmpScale is unneeded (you are not using it enywhere else)
  

                      if not pauseGrow then
                          set unitScale[id] = unitScale[id] + growRate
                          call SetUnitScale(grower, unitScale[id], 1, 1)

•             set updatesUp = R2I((scaleGoal - scaleStart) /growRate)
              set updatesDown = -1   // Just a negative value. Mustn't be 0 or bigger at initialization.

  It's been quite hard to understand what those two variables do. But I have came to a conclusion that one boolean variable, named state or something, could covers both of their jobs.
  
  For example, when state is true that means unit is still growing up and vice versa. To check whether a unit has finished growing:
  

  if state then
      if (growRate < 0 and currentScale <= targetScale) or (growRate > 0 andcurrentScale >= targetScale) then
          // This means unit has finished growing
  
          set currentScale = targetScale // To makes sure the scale doesn't exceed the target
          call SetUnitScale(...)
      endif
  elseif not pause then
      // When unit is being reset-ed
  else
      // Effect duration
  endif

I will look further into it later, sudden busy

EDIT:
One more

            if growCount[id] == 1 then
                set isGrower[id] = false
                set growCount[id] = 0
            else
                set growCount[id] = growCount[id] - 1
            endif

=>

            if growCount[id] == 1 then
                set isGrower[id] = false
            endif
            set growCount[id] = growCount[id] - 1

 

[edo494]

- UnitIndexer (Nestharus)
- WorldBounds (Nestharus)
- Event (Nestharus)

these are not available, therefore they are not approved, therefore yours cant be really approved, because you cant use unapproved(even better, removed/deleted) depedencies

 

[Vinz]

This is extremely useful though. I hope that case is clarified.

 

[BPower]

these are not available, therefore they are not approved, therefore yours cant be really approved, because you cant use unapproved(even better, removed/deleted) depedencies

These resources were approved in the past and work reliable afaik. In my eyes it's not a problem using them as dependencies.

 

[edo494]

its pain in butt to get them tho, because analrus decided to migrade to github.

 

[BPower]

set growBack = (eDuration > 0.)

 

[Kazeon]

    struct DefaultScale
        private static key k
        private static Table table = k
        readonly integer unitType
        readonly real    defaultScale
        
        static method create takes integer uType, real scale returns thistype
            local thistype this = table[uType]
            if this == 0 then
                set this = allocate()
                set table[uType] = this
            endif
            set unitType = uType
            set defaultScale = scale
            return this
        endmethod
        
        static method operator [] takes integer i returns thistype
            return table[i]
        endmethod
        
    endstruct

And they are all should be privatized since I feel it's an awful way to get unit's default scale. I mean, we should have a variable DefaultScale for every unit type we register there? No way

You should add another function bloat called GetUnitDefaultScale(unit) :v

 

[IcemanBo]

its pain in butt to get them tho, because analrus decided to migrade to github.

Hm, if it helps... my test map contains them.

This is extremely useful though. I hope that case is clarified.

Thanks.

set growBack = (eDuration > 0.)

Nice one.^^

You should add another function bloat called GetUnitDefaultScale(unit) :v

Indeed, that should be added! And thanks for other suggestions, I will have a look at them.

This is better for Tiny's Grow

EDIT:
Not bad...

Thank you! Sorry, what is Tiny's Grow?

 

[Kazeon]

Thank you! Sorry, what is Tiny's Grow?

Guess you are the only human on earth who don't know dota :v

 

[IcemanBo]

Guess you are the only human on earth who don't know dota :v

Oh, haha. Then, indeed I don't know it...

 

[edo494]

http://playdota.com/heroes/stone-giant#skill402

 

[IcemanBo]

@Dalvengyr
You were right about the "zero durtion" thread crash, thanks! I do not allow now durations equal or smaller 0 anymore, because it anyway does not make sense.
People can use the SetUnitScale native for this.

            set updatesUp = R2I((scaleGoal - scaleStart) /growRate)
            set updatesDown = -1   // Just a negative value. Mustn't be 0 or bigger at initialization.

It's been quite hard to understand what those two variables do. But I have came to a conclusion that one boolean variable, named state or something, could covers both of their jobs.

For example, when state is true that means unit is still growing up and vice versa. To check whether a unit has finished growing:

if state then
    if (growRate < 0 and currentScale <= targetScale) or (growRate > 0 andcurrentScale >= targetScale) then
        // This means unit has finished growing

        set currentScale = targetScale // To makes sure the scale doesn't exceed the target
        call SetUnitScale(...)
    endif
elseif not pause then
    // When unit is being reset-ed
else
    // Effect duration
endif

I was already messing around a bit with this, but came to conclusion better to use two variables.
The reason for this was easier handling with accuracy (near targetScale) when unit is affected by multiple scale changes at same time.
(at least how I tested it... if you are sure there is a better way that won't let accuracy suffer too much under multiple instances I will try harder )

            if growCount[id] == 1 then
                set isGrower[id] = false
                set growCount[id] = 0
            else
                set growCount[id] = growCount[id] - 1
            endif

=>

            if growCount[id] == 1 then
                set isGrower[id] = false
            endif
            set growCount[id] = growCount[id] - 1

In case I use set growCount[id] = 0 it's faster than set growCount[id] = growCount[id] - 1 and same result in end.

I only quoted things I wanted to answer to. Implemented almost all other suggestions, thanks!.

Updated.

@edo
Thanks for the link.^^

 

[Maker]

In my opinion you should allow 0 duration and make it instant.

 

[IcemanBo]

In my opinion you should allow 0 duration and make it instant.

Implemented now.

 

[edo494]

** Note:
** The system does not allow take 0 as argument for durations.

erm...nope?

also, you have at least 10 candidates for generating trigger evaluations, lets play a Hide and seek shall we?

Edit: actually, only 6.

+ Indention is wrong inside function ResetScale takes unit u, real duration returns nothing

 

[IcemanBo]

** Note:
** The system does not allow take 0 as argument for durations.

erm...nope?

also, you have at least 10 candidates for generating trigger evaluations, lets play a Hide and seek shall we?

Edit: actually, only 6.

+ Indention is wrong inside function ResetScale takes unit u, real duration returns nothing

The note was outdated, thanks.

And also moved the API! Edo-update done.

 

[gorillabull]

this is good very useful Approved.

 

[Almia]

Pua?

 

[pred1980]

Why are the resources of Nest. not allowed anymore?

 

[edo494]

http://www.hiveworkshop.com/forums/graveyard-418/system-unit-indexer-172090/

 

[BPower]

Again, not a big deal in my opinion, because the script comes along with the demo map.
Btw there is a new version of UnitIndexer, but it's not so public resource friendly ( many requirements which most people won't use elsewhere)

 

[Chaosy]

Useful, easy to use, no good way to make it GUI friendly though. But still good. 4/5

 

[IcemanBo]

Thank you, Chaosy.

Pua?

?

 

[Vinz]

It might be lua since p is close to l. PUA can also mean pick-up artist. (But I don't think the latter is related in any way)

 

[Almia]

pua = perfect unit appearance

 

[IcemanBo]

Never heard of it. And your posts could be more informative, if you want to suggest something.

 

[Vinz]

Hey, if I may suggest, a Transparency system too?

 

[IcemanBo]

I don't see how to easily link a transparency system with mine. It would require new aspects, and I want to keep the system clean, so I guess not. :/ But thanks.

 

[Deleted member 219079]

Could you do same kind of library for unitmovementspeed?

 

[IcemanBo]

Could you do same kind of library for unitmovementspeed?

Could you elaborate?

 

[Deleted member 219079]

I dunno what elaborate means :/
if you mean like, explain, well like same kind of functionality, but for SetUnitMoveSpeed()

 

[IcemanBo]

So you want SetUnitSpeed(whichunit, whichspeed, whichduration) and then the unit gets the new speed over the duration, instead of an instant speed change?

But to clarify, it has nothing to do now with UnitScale system?

 

[Deleted member 219079]

Ye.

Because at the moment, SetUnitScale normally would interfere with other possible systems using the native. You could be the god of vJass and create the standard system for SetUnitSpeed.

Currently I'm afraid of adding setunitspeed to my ability, cuz it might interfere with other spells. And using it via ability is slow and unnecessary.

 

[edo494]

for instant unit speed >522 see Purge and fire's resource linked in his signature

 

[IcemanBo]

SetUnitScale won't have problems, if you use the native or the bj function to change the unit's scale. If you call the functions it gets catched, and adapted to the system.

 

[Nestharus]

I took a look at this system and I honestly think it does too much. Not only does it do scaling, but it does timed scaling and it'll even upscale and then downscale. I wouldn't mash it all together like this.

For example, upscaling and downscaling are two different scales put together. It is convenient, sure, but should one resource really do this much? It seems like it could be split up to me.

I don't particularly like the idea of hooks in the resource. This means every time that you use the native, it will throw a trigger evaluation. If you are scaling a lot of units, that's a lot of trigger evaluations.


My suggestion:

Resource 1: Simple scale tracking
Resource 2: Managed single scale
Resource 3: Managed scale sequences

Rather than grow and then shrink back to normal, you could create a scale sequence. This means that you could grow, shrink, and then grow again.


In finality, I think that it can be improved a lot. It's a decent first shot though =).

edit
Considering things like DDS, I suppose the hooks are ok. Doesn't mean that I like them ;p.

 

[IcemanBo]

I agree with you, that it should be more straight forward. I reduced structure and made it only single scale now instead of double scale. Thanks.

How ever, nothing done for sequences. Honestly I didn't even really think about it, if it's worth to code it because of usage and so on... so atm user can just use a timer or what ever.

Updated.

 

[Almia]

Make this a UnitAppearanceTracker.

I was going to create the same thing:
http://www.hiveworkshop.com/forums/pastebin.php?id=46atl2

which supports tracking ARGB and unit scaling.

[edit]
NVM. yours was vJass. and PUA does such things:

http://www.thehelper.net/threads/prioritized-unit-appearance-pua.146676/

 

[IcemanBo]

Your code seems cool.

Me personally, I'm not a big fan of RGB system, and I think that I would not implement it. But give me some time to think about it.

Thanks for the pua link, too. It seems a bit heavier, and for scaling for example he also tracks and works with all three x/y/z, which is not needed. (but it's older, though)

 

[Almia]

Btw, SetScale,AddScale etc. Function names are not too expressive. Users be like "scale what?". Name it or add a prefix to it lke UnitSetScale etc

 

[IcemanBo]

Yo, okay. Agreed and changed it.

 

[Maker]

Maybe allocate an instance only if it is needed, when you don't return 0.

 

[IcemanBo]

Thanks, fixed it. Also I got rid of GetUnitScale in main code, and made it a seperated submission. http://www.hiveworkshop.com/forums/submissions-414/snippet-getunitscale-262274/

Though it now also requires this new library. So I guess someone first has to approve it.

 

[FaLLeN]

Hey I don't understand the fuss is about can't we just put units scale in loop to increase and decrease why such big code with Jass and all

 

[IcemanBo]

Hey I don't understand the fuss is about can't we just put units scale in loop to increase and decrease

What fuss? It is a simple system indeed. It works for you.
Yes, you can create your own system of couse.
But why to create your own if you can simply import a system and use the API functions instead? o.o

why such big code with Jass and all

This is not a big code. And I don't understand the critique with using JASS.

 

[BPower]

Code looks good to me. I'll test it after the weekend.

Concerning UnitIndexer:
I checked Nestharus Demo map and the old version is still included,
So if you wish to stick to that, that's ok.

I wrote about that in GetUnitScale, but same applies there.

I'm not a big fan of the new UnitIndexer, because it requires
a bunch of resources, which I don't use anywhere else.
( Alloc modules, Trigger, TableField and dependencies. )