[JASS] Red Rift

[Moderator]

12th Dec 2015
IcemanBo: Too long time as NeedsFix. Rejected.

23:55, 18th Aug 2010
TriggerHappy:

A spell cannot be MUI & MPI, it's either or.

• What's the reason you're using ExecuteFunc?
• You don't null all your handles in every function, which makes this leak.
• Your ClearUnit function is pretty sad, use timed life or something. I know it doesn't remove the unit but it's better than what you're doing now (wait + remove)

That's all for now, I'm sure there's more.

 

[Lambdadelta]

• Map camera doesn't even start on the heroes when you test it, that's real handy isn't it?
• The lightning's look ugly as they just turn from one colour to another instantly. I would say you should fade it.
• Your code leaks alot. Don't say it doesn't. It leaks because you don't null local handles. Like orb and stuff.
• You might just want to turn StringHash(table) into a variable to save that many calls.
• It shouldn't be the user who has to scan through [messy] code to configure it. You should leave a configurable section at the top using constant functions that return a value. Even if it results in less effiency due to function calls (I think, does constant help? IDK), at least it's more user-friendly. Yes you can do this with JASS.
• The lightnings are not even attached to the orb, they are attached to the ground where the orb is. They should be connected WITH the orb.
• You can do a shitload of optimizing to your code.

 

[Prince.Zero]

Well than, messy JASS code is messy JASS code. Hard to configure, saying it's plain JASS is a stupid excuse. You have constant functions for that. Header is just a wall of text to me.

• Map camera doesn't even start on the heroes when you test it.
• The lightning's look ugly as they just turn from one colour to another instantly. I would say you should fade it.

I'm not wanting to read over the JASS code.

Your review is plain ridiculous
If you saw what was behind your vJass code there goes the real mess.
You think that if you did this into vJass it would make the code more efficient than mine?

Let me tell you, you're wrong. This is the most efficient way that a spell can work. Constant functions are like BJ's. And i heard you guys hate BJ's.

Go read the map scrip of your vJASS code and see how messy it is then come back here so i can review your smartness.

-------------
Back to the point.
I'll leave the moderators to decide whether i must use Constant functions.

• The lightning's look ugly as they just turn from one colour to another instantly. I would say you should fade it.

yea sure, big deal. just a few more reals stored...

 

[Lambdadelta]

Blah. I am not that smart. Everyone knows that but still I will persist:

If you saw what was behind your vJass code there goes the real mess.

Yes. Of course compiled vJass is messy, it's arrays and crap everywhere. But the point is we work with vJass, uncompiled, much more readable.

You think that if you did this into vJass it would make the code more efficient than mine?

In some aspects yes, you say constant functions are like BJs. But if you used JassHelper, you could declare globals freely and therefore less calls to these "BJs".

Constant functions are like BJ's. And i heard you guys hate BJ's.

Not all BJs are useless, seeing as constant functions offer easier configuration.

--

• GetWidgetLife(u)<1 - Isn't it 0.415? Or something.

 

[Prince.Zero]

No disrespect but

Yes. Of course compiled vJass is messy, it's arrays and crap everywhere. But the point is we work with vJass, uncompiled, much more readable.

Why the heck would READABLE be better than more EFFICIENT??
T_T'

I'm good with vJass but i simply stopped using it because it became very heavy on my AOS map making the map script 1.2mb in size which is unacceptable.

JASS is way more efficient if you know how to use it.
Also as you noticed all i use is one single variable called Hashtable.
And i can keep using that single variable for every single spell i can make in the future.

imagine a map with only one single global variable.
But again let's not go so far. Hashtables have a limit of instances and all pro-coders know it.

nvm... I'll just fix the "ugly" lightning that you stated above.
But still i must wait for a moderators comment if they want me to use Constant function for better "Readability"

And yea, some BJ's are useful. But still calling a function that calls many others is less efficient.

 

[Septimus]

It shouldn't be the user who has to scan through [messy] code to configure it.

it is indeed a bit messy to be read, but at least it was still readable. But you are right at this part. It is the responsibility for the coder to do it.

Let me tell you, you're wrong. This is the most efficient way that a spell can work. Constant functions are like BJ's. And i heard you guys hate BJ's.

QFT = Not all BJs are useless

Both party are right actually.

One are references to efficiency while the other are refer to user-friendly.

Prince Zero, you could eventually make 2 trigger of it with either 1 of it disable. Then post a documentation indicate 1 to be better in term of efficiency while the other as user-friendly.

Your code leaks alot. Don't say it doesn't. It leaks because you don't null local handles. Like orb and stuff.

Main reason why it won't approve.

I did't see you null it either, or the code might be too messy that i did't notice it.

 

[Lambdadelta]

Rather than having the user make their own variables, maybe you should create a disabled trigger in the map for them to copy than delete. Also tell them to have Automatically create unknown variables when pasting trigger data turned on.

Can't stress enough on making things user friendly.

Why the heck would READABLE be better than more EFFICIENT??

Hm. I kind of mean't to put READABLE combined with CONFIGURABLE.

 

[Prince.Zero]

There you go
Fancy looking lightnings that shine shiny shinelights
And a bit of code improvements.

• Your code leaks alot. Don't say it doesn't. It leaks because you don't null local handles. Like orb and stuff.

Are you sure you're a coder?
Define "Leaks a lot"

Because where i studied c++ i was tought that local handles are automatically cleaned up when the function/method exits.

Also i tested your leaking statement by opening task manager.
Not even a single kilobyte was leaked.
You don't even know what leaks are.

 

[Lambdadelta]

NO I WONT USE GLOBAL Blocks from vJASS

Uhm. Global blocks are not vJass. It's a part of JassHelper features. But I get you, "I don't want dependency on a compiler"

Are you sure you're a coder?
Define "Leaks a lot"

Because where i studied c++ i was tought that local handles are automatically cleaned up when the function/method exits.

Not in JASS. I'm not a coder, I just know JASS. I've been taught and memorized these things - and am just passing on my knowledge*.

So for all these you declare locally:
• unit
• group
• lightning

You must set to null afterwards. Although I see you are nulling in some functions, and then in none? ?

* which requires citation a lot of the time

Also i tested your leaking statement by opening task manager.
Not even a single kilobyte was leaked.
You don't even know what leaks are.

http://www.wc3c.net/showthread.php?t=81872&highlight=local+leak ;|
http://www.wc3c.net/showpost.php?p=1125190&postcount=3
http://www.wc3c.net/showpost.php?p=905121&postcount=8

Are you sure? I made an demo script that declared a local unit and didn't null it. Guess what happened when I kept running that script?

--

• You forgot to remove the Food Usage of the dummy unit. I was spamming your skill and suddenly got Low Upkeep D:

 

[Prince.Zero]

Bah you surely are a tough guy.
Too bad i can't debate this any longer because i have to go to work.
Oh well, see ya

P.S. You don't have to give credits t me if you wanna use this.
Just use it, study it, i don't care. Just helping new people to learn something.

 

[Cihparg]

Locals leak like variables.
That means, Items - Groups - Locations - Effects.
Units don't leak. But they can cause your spell/system to fail.

Besides, Jass is better than vJass.
vJass is for babies.

 

[Prince.Zero]

Locals leak like variables.
That means, Items - Groups - Locations - Effects.
Units don't leak. But they can cause your spell/system to fail.

Besides, Jass is better than vJass.
vJass is for babies.

a local unit referrance does not leak or cause anything at all.
And i didn't leak any location group, it's pretty obvious. Check the damn code!

And yea, vJass is for cry babies.
In the end, everything is Jass
GUI = JASS
vJASS = JASS
cJASS = JASS

 

[Laiev]

function RedRift_AdditionalEffects takes unit c, unit victim returns nothing
    local unit dummy
    set dummy = CreateUnit(GetOwningPlayer(c), DUMMY_ID, GetUnitX(victim), GetUnitY(victim), 0)
endfunction

can be

function RedRift_AdditionalEffects takes unit c, unit victim returns nothing
    local unit dummy = CreateUnit(GetOwningPlayer(c), DUMMY_ID, GetUnitX(victim), GetUnitY(victim), 0)
endfunction

 

[Prince.Zero]

function RedRift_AdditionalEffects takes unit c, unit victim returns nothing
    local unit dummy
    set dummy = CreateUnit(GetOwningPlayer(c), DUMMY_ID, GetUnitX(victim), GetUnitY(victim), 0)
endfunction

can be

function RedRift_AdditionalEffects takes unit c, unit victim returns nothing
    local unit dummy = CreateUnit(GetOwningPlayer(c), DUMMY_ID, GetUnitX(victim), GetUnitY(victim), 0)
endfunction

i know, that's just an example of how new users can make their own custom effects upon the ability.

 

[usfmohy]

The visual effects needs improvement but i like the idea and the purge at the end gj

 

[Nestharus]

a local unit referrance does not leak or cause anything at all.

Leaks an integer (the pointer). The pointer doesn't get recycled until it's nulled. When it goes out of scope, it isn't nulled until the var is reused. I'm not sure that these variables ever get reused if they have a pointer in them. This means that it can also leak an entire integer var ;o.

Then again, I'm also not sure how wc3 handles its memory allocation/deallocation. What I think it probably does is continues to allocate memory and then recycles the already allocate memory. If a variable has a pointer in it that isn't nulled, I don't think that variable gets recycled, meaning that it is just floating there.

This is all speculation at this point because there is no way for me to know without reading the memory addresses that wc3 uses while performing a test ; P.


Furthermore, you need to change your attitude about vjass and cjass and all of the other precompilers out there. You know what programming languages are? They are precompilers for assembly ; |, which translates to direct machine code, which in turn translates into direct bytecode ; |.

When a language is compiled, it's just parsed and translated into bytecode/assembly/machine code

Also if you use vjass correctly, it has no overhead ^.^. I don't know about you, but I prefer vJASS features and syntax over plain old JASS.

 

[Prince.Zero]

Leaks an integer (the pointer). The pointer doesn't get recycled until it's nulled. When it goes out of scope, it isn't nulled until the var is reused. I'm not sure that these variables ever get reused if they have a pointer in them. This means that it can also leak an entire integer var ;o.

Then again, I'm also not sure how wc3 handles its memory allocation/deallocation. What I think it probably does is continues to allocate memory and then recycles the already allocate memory. If a variable has a pointer in it that isn't nulled, I don't think that variable gets recycled, meaning that it is just floating there.

This is all speculation at this point because there is no way for me to know without reading the memory addresses that wc3 uses while performing a test ; P.


Furthermore, you need to change your attitude about vjass and cjass and all of the other precompilers out there. You know what programming languages are? They are precompilers for assembly ; |, which translates to direct machine code, which in turn translates into direct bytecode ; |.

When a language is compiled, it's just parsed and translated into bytecode/assembly/machine code

Also if you use vjass correctly, it has no overhead ^.^. I don't know about you, but I prefer vJASS features and syntax over plain old JASS.

don't mind an old fool like me, i'm just old school

 

[Prince.Zero]

Come on people, rate!
It's been a week

 

[Vercas]

Locals leak like variables.
That means, Items - Groups - Locations - Effects.
Units don't leak. But they can cause your spell/system to fail.

Besides, Jass is better than vJass.
vJass is for babies.

And that, ladies and gentlemen, is the reason why the best spells and systems in the cloud are written in vJass!

 

[Adiktuz]

looks good.

 

[x3GlikE]

Please note that it bugs when u cast it on the Edges of the map

 

[Prince.Zero]

Please note that it bugs when u cast it on the Edges of the map

it's itentional, if a unit goes beyond the edges, the game will propably crash

 

[x3GlikE]

Hmm I c you should make it like it destroys when reaches the edge! , Cause if someone puts it in an aos map and Is casted on the edge ? Gg their stuck there,,,

 

[Prince.Zero]

the orb destroys itself after 8 seconds actually.

 

[HD888]

i think its awesome

 

[Bribe]

All those "StringHash" calls, hashtable lookups, they all make this one very incredibly inefficient thing. Just use vJass and structs?? Rejected until updated.

 

[Kam]

Any chance on this getting updated?