09:20, 3rd Mar 2010
TriggerHappy:

Very cool and original spell. I didn't see any leaks.

 

The spell is good, alot of eye candy and it has a very good idea... but 8 triggers... thats a bit to many =\

 

I know they are too many; if you think you can make it with less triggers, go ahead

 

just put all periodic actions in the same trigger

however I'd do it like that:

cast trigger (is necessary anyway)

loop trigger
-pick all units within range with live 0 live and drag them to center
-create wisps
-if a unit has reached the center make a unitgroup full of blue balls and blast them away from the center dummy (or whenever it should happen)
-if the main dummy is dead delete this instance
-something I forgot

wisp loop trigger
-rotate wisps
(since you are using hashtables you could also load these units ids and merge this trigger to the second one)

however your effects are one of the best as always but your coding could be improved (usually I don't use hashtables except I have to since they are slower then indexing and indexing makes you able to use hashtables as 2D-arrays in combination with unitgroups)

to create unitgroups check if the current unitgroup is == null (you will probably need JASS for this but you could also add a unit and check if it is in that group if not the group is not created)
and then use
set udg_YourGroup[udg_YourIndex] = CreateGroup()

 

The mechanism you describe will not provide the same result. How could I possibly add the wisp loop trigger, that runs every 0.05 seconds into a 0.5 periodic event trigger? Each loop calculates and picks different stuff. If I combine some of them (that they probably have the same periodic event, e.g. 0.05 seconds), well, the pick on the wisps might end, while the other units, the dead ones that are dragged to the wisps' column should be still moving. I mean the trigger should stop for the wisps and keep itself on for the dead units, while I make a condition call to turn it off, once there are no units left in the wisps' group.
I really believe there are many triggers required, because of the spell's multiple sub-effects:
The casting trigger, the wisps' rotation, the one that counts the deaths to respectively add the dying unit in the trigger it should go, the drag of the dead units, their elevation and another trigger that works as a debug (the one with the timer) that kills the dragged units, in case the spell's duration is up, before they reach the column.

 

What Pharaoh says it's true, but I think you'd be able to merge two of them into one, like those two 0.05 second ones.

 

You can merge all periodic triggers, it is just a matter if you want to.

I would reduce all periodic triggers into 2 separate ones(0.5 one and a 0.03 one).

How to:

Set Interval = Interval + 0.03
If Interval >= fireOffValue then
do actions...
set Interval = 0
endif

 

I could create this spell with only one trigger . But anyway, nice spell.

cedi

 

Now that's Eye candy!

 

I tried this one. One of coolest spells I've ever seen. Looks just so damn awesome

 

Very nice, nothing else to say about the triggering, since the other people already mentioned everything +rep

 

Why is this in GUI?
Such complicated spells should be made in vJass, GUI isn't really a good choice when it comes to complicated stuff.

 

I have never made a vJass spell. I know how to code them in general, but never tried the actual script. I am fan of complicated stuff and I know that using GUI makes the submission isntantly underestimated, but it's more convenient for me..

 

That's truly funny, eye-candy and interesting! Good job

 

OmFG! Coloorzzz! Dl Dl DL DL!
Edit: Spell is owesome! Eye candy is so nice ^^
The only wierd thing is... when unit body is floating to energy portal and it closes before unit reach it, units dies again...
Also special effect ImpaleTargetDust spawn every 0.05 and cause lags.
I know what this effect is heavy and user can change it, BUT you shuld make Spam period.
It is IF when you skip effect spawn:

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • Spam[i] Greater than or equal to 5
  • Then - Actions
    • Set Spam[i] = 0
    • Special Effect - Create a special effect at Point using Objects\Spawnmodels\Undead\ImpaleTargetDust\ImpaleTargetDust.mdl
    • Special Effect - Destroy (Last created special effect)
  • Else - Actions

This will descrease spell lag dramaticaly and also you will be able to descrease loop time so spell will have cleaner and faster look

 

Wuah!!! Pharaoh!! I never tot u could do spells!!!!!!!!!!!!

Teach meeee!

 

Wow , what an awesome spell !

 

Cool spell you got there mate

Just found a bug, may not be that big but anyways: When cast after the cd is off I get an error message from your spell "allready invoked " or something. Is it supposed to only be used once? If so, please just add an infinite cd to it instead of tricking players.


+ Eyecandy is nice, but I think the dust effect doesn't quite play along with the rainbowish colours of the spell itself, + you could reduce the dust effects a bit perhaps.


Btw, since you set the flying units height not taking any Z of the terrain it's standing on it might get affected by trees, buildings but not least cliffs. But it's really not that important, just a nit pick ;P

You're a really good trigger'r and you should consider vJass, it will open enormous windows of opportunities. ^^
Nice work, 4/5!


Edit, just came up with a thing that imo would make it look wicked

If you make the swirl of whisps go crossing eachother like the dna stuff that would be awesome, but you're the creator

 

Thank you all for your feedback; I will update it soon.