Eye of the Storm v1.0

[Moderator]

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

15:45, 6th Oct 2013
Maker: Check my reply in this thread.

 

[FUJI]

Downloading....

Post the triggers of the spell like [TRIGGER][/TRIGGER] Put your code inside of the [ TRIGGER ] [/TRIGGER] just by copy as text.

EDIT:

It is MUI but it can't be manipulated and it is simple (

 

[nhocklanhox6]

=> Thing That Leak

don't care about group improper, it's look you're remove wrong location on loop

 

[FUJI]

^Hmmm

Nice !

Seems you leak a locations

EDIT:

You didn't remove this location in the loop:

• Set EYE_Point[1] = (Position of EYE_caster)

since that you don't remove it after creating it ^^.

I think the group too..

 

[kenegeneget13]

ill try to fix it

how can i know when the loc is leaking?

 

[FUJI]

Download the Leak Checker made by nhocklanhox06 ^^ in the spell section

 

[kenegeneget13]

do i need jassnewgenpack5d to make it work?

 

[deathismyfriend]

do i need jassnewgenpack5d to make it work?

Yes you do and you shouldn't need that if you look at the things that leak tutorial.

Also post triggers in spell description. You also shouldn't upload spells that are not finished ( v0.1)

 

[kenegeneget13]

i update it plz check for leaks!

 

[FUJI]

Use [TRIGGER][/TRIGGER] Tags

 

[kenegeneget13]

oh i forgot sorry

is there any leaks?

 

[Rheiko]

| Rheiko | 05/10/2013

Rheiko's Review: [Needs Fix] Documentation: [1/5] No comments or explanation at the trigger and description which could make people confused what kind of spell is this and what is this for Cons: [3/5] You don't need to use array for Set EYE_Point[1] = (Position of EYE_caster) EYE Group at cast trigger is useless Destroy the group after you are done using it, you overwrite so many group in the loop trigger Overall: [2/5] No Comment Suggestions: Replace the Set EYE_Point[1] = (Position of EYE_caster) to Set EYE_Point = .. don't store EYE Group at the cast trigger if you're not going to use it Destroy the group after you are done using it

 

[axleion]

It is MUI but it can't be manipulated and it is simple (

you sure it's MUI? I see that EYE_caster can be overwritten by another cast and it will only support 1 cast at any time.

You don't need this at EYE trigger

• Set EYE_Group = (Units within 700.00 of EYE_Point[1] matching (((Matching unit) belongs to an enemy of (Owner of EYE_caster)) Equal to True))

at EYE trigger, rather than filling the whole if-then-else block with that, you can just

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • (EYE_dummy is alive) Equal to True
  • Then - Actions
    • Unit - Kill EYE_dummy
  • Else - Actions
• Set EYE_caster = (Triggering unit)
• Set EYE_Point[1] = (Position of EYE_caster)
• Set EYE_Group = (Units within 700.00 of EYE_Point[1] matching (((Matching unit) belongs to an enemy of (Owner of EYE_caster)) Equal to True))
• Unit - Create 1 EYE DUMMY for (Owner of EYE_caster) at EYE_Point[1] facing Default building facing degrees
• Set EYE_dummy = (Last created unit)
• Unit - Add a 10.00 second Generic expiration timer to EYE_dummy
• Custom script: call RemoveLocation (udg_EYE_Point[1])
• Trigger - Turn on EYE Loop <gen>

this will do the same with yours now.

Your EYE Loop leaks a group every 0.03 seconds. Its because the call DestroyGroup is called only when the dummy died, not after each declaration of group. and you dont need the RemoveLocation in the else part as its done outside the if-then-else.

 

[kenegeneget13]

i make an update to it

is that ok?

 

[Ofel]

REVIEW|Eye of the Storm|v0.4

Resource Status: Needs Fix Rating: 2/5

GENERAL	Remove: Custom script: call RemoveLocation (udg_EYE_Point) Custom script: call DestroyGroup (udg_EYE_Group) inside the 'Else' block in loop trigger, those are useless Only get the caster position and remove it inside the 'Then' block in loop trigger Store the owner of the caster and use it both in the cast and loop triggers
PROS	Nice idea
CONS	Not MUI No import instruction No configuration
SUGGESTIONS	None

[/TD][/tr] If you have any question about this review, PM or VM me Review template by Doomlord

 

[pOke]

Well, if you fix the leaks and what not it should be decent, I made my own makeshift version a while back I'll post with hidden tags here so you can take a look if you want its by no extent perfect but I don't think it leaks and it technically reduces armor too, although its kind of a convoluted method.

• EoS Cast
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Eye of the Storm
  • Actions
    • Set EoS_MaxIndex = (EoS_MaxIndex + 1)
    • Set EoS_Caster[EoS_MaxIndex] = (Triggering unit)
    • Set TempLoc = (Position of (Triggering unit))
    • Unit - Create 1 Eye Of the Storm for (Owner of EoS_Caster[EoS_MaxIndex]) at TempLoc facing Default building facing degrees
    • Set EoS_Storm[EoS_MaxIndex] = (Last created unit)
    • Unit - Set level of Eye of the Storm (dummy) for (Last created unit) to (Level of Eye of the Storm for (Triggering unit))
    • Set EoS_Group[EoS_MaxIndex] = (Units within 500.00 of TempLoc matching ((((Matching unit) belongs to an ally of (Owner of EoS_Caster[EoS_MaxIndex])) Not equal to True) and (((Life of (Matching unit)) Greater than 0.41) and ((Unit-type of (Matching unit)) Equal to Mountain Giant))))
    • Set EoS_Counter[EoS_MaxIndex] = 333
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • EoS_MaxIndex Equal to 1
      • Then - Actions
        • Trigger - Turn on EoS Loop <gen>
      • Else - Actions
    • Custom script: call RemoveLocation(udg_TempLoc)

• EoS Loop
  • Events
    • Time - Every 0.03 seconds of game time
  • Conditions
  • Actions
    • For each (Integer EoS_CurrentIndex) from 1 to EoS_MaxIndex, do (Actions)
      • Loop - Actions
        • Set EoS_Counter[EoS_CurrentIndex] = (EoS_Counter[EoS_CurrentIndex] - 1)
        • Set TempLoc = (Position of EoS_Storm[EoS_CurrentIndex])
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • Or - Any (Conditions) are true
              • Conditions
                • EoS_Counter[EoS_CurrentIndex] Less than or equal to 0
                • (EoS_Caster[EoS_CurrentIndex] is alive) Not equal to True
                • (Life of EoS_Caster[EoS_CurrentIndex]) Less than or equal to 0.41
          • Then - Actions
            • Unit - Kill EoS_Storm[EoS_CurrentIndex]
            • Unit Group - Pick every unit in EoS_Group[EoS_CurrentIndex] and do (Actions)
              • Loop - Actions
                • Unit - Set level of EoS Armor for (Picked unit) to 1
            • Custom script: call DestroyGroup(udg_EoS_Group[udg_EoS_CurrentIndex])
            • Set EoS_Caster[EoS_CurrentIndex] = EoS_Caster[EoS_MaxIndex]
            • Set EoS_Storm[EoS_CurrentIndex] = EoS_Storm[EoS_MaxIndex]
            • Set EoS_Counter[EoS_CurrentIndex] = EoS_Counter[EoS_MaxIndex]
            • Set EoS_Group[EoS_CurrentIndex] = EoS_Group[EoS_MaxIndex]
            • Set EoS_CurrentIndex = (EoS_CurrentIndex - 1)
            • Set EoS_MaxIndex = (EoS_MaxIndex - 1)
          • Else - Actions
            • Custom script: call SetUnitX(udg_EoS_Storm[udg_EoS_CurrentIndex], GetUnitX(udg_EoS_Caster[udg_EoS_CurrentIndex]))
            • Custom script: call SetUnitY(udg_EoS_Storm[udg_EoS_CurrentIndex], GetUnitY(udg_EoS_Caster[udg_EoS_CurrentIndex]))
            • Set TempGroup = (Units within 500.00 of TempLoc matching (((Unit-type of (Matching unit)) Equal to Mountain Giant) and (((Life of (Matching unit)) Greater than 0.41) and (((Matching unit) belongs to an ally of (Owner of EoS_Caster[EoS_CurrentIndex])) Not equal to True))))
            • Unit Group - Pick every unit in TempGroup and do (Actions)
              • Loop - Actions
                • Set EoS_TempUnit = (Picked unit)
                • Set HealthAmount = 2000000.00
                • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                  • If - Conditions
                    • (Life of TempUnit) Less than HealthAmount
                  • Then - Actions
                    • Set EoS_TempUnit2 = EoS_TempUnit
                  • Else - Actions
            • Unit - Order EoS_Storm[EoS_CurrentIndex] to Orc Far Seer - Chain Lightning EoS_TempUnit2
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • (EoS_TempUnit is in EoS_Group[EoS_CurrentIndex]) Equal to True
              • Then - Actions
              • Else - Actions
                • Unit Group - Add EoS_TempUnit2 to EoS_Group[EoS_CurrentIndex]
            • Custom script: call DestroyGroup(udg_TempGroup)
        • Custom script: call RemoveLocation(udg_TempLoc)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • EoS_MaxIndex Equal to 0
      • Then - Actions
        • Trigger - Turn off (This trigger)
      • Else - Actions

• Armor Reduc
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Eye of the Storm (dummy)
  • Actions
    • Unit - Set level of EoS Armor for EoS_TempUnit2 to ((Level of EoS Armor for EoS_TempUnit2) + 1)
    • Set TempReal = ((Real((Level of Eye of the Storm (dummy) for (Triggering unit)))) x 37.50)
    • Unit - Cause (Triggering unit) to damage (Target unit of ability being cast), dealing TempReal damage of attack type Normal and damage type Normal

 

[kenegeneget13]

nc thanks..

 

[FUJI]

you sure it's MUI? I see that EYE_caster can be overwritten by another cast and it will only support 1 cast at any time.

You don't need this at EYE trigger

• Set EYE_Group = (Units within 700.00 of EYE_Point[1] matching (((Matching unit) belongs to an enemy of (Owner of EYE_caster)) Equal to True))

at EYE trigger, rather than filling the whole if-then-else block with that, you can just

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • (EYE_dummy is alive) Equal to True
  • Then - Actions
    • Unit - Kill EYE_dummy
  • Else - Actions
• Set EYE_caster = (Triggering unit)
• Set EYE_Point[1] = (Position of EYE_caster)
• Set EYE_Group = (Units within 700.00 of EYE_Point[1] matching (((Matching unit) belongs to an enemy of (Owner of EYE_caster)) Equal to True))
• Unit - Create 1 EYE DUMMY for (Owner of EYE_caster) at EYE_Point[1] facing Default building facing degrees
• Set EYE_dummy = (Last created unit)
• Unit - Add a 10.00 second Generic expiration timer to EYE_dummy
• Custom script: call RemoveLocation (udg_EYE_Point[1])
• Trigger - Turn on EYE Loop <gen>

this will do the same with yours now.

Your EYE Loop leaks a group every 0.03 seconds. Its because the call DestroyGroup is called only when the dummy died, not after each declaration of group. and you dont need the RemoveLocation in the else part as its done outside the if-then-else.

that's why It can't be manipulated

 

[kenegeneget13]

now its okaY?

 

[FUJI]

Yes because you use indexing ^^.

 

[kenegeneget13]

thx to pOke

 

[Maker]

The caster should deal the damage, not the dummy.

I think the spell is too similar to this: http://www.hiveworkshop.com/forums/spells-569/jass-mystic-storm-v1-1i-227456/

 

[Manasurge]

The caster should deal the damage, not the dummy.

I think the spell is too similar to this: http://www.hiveworkshop.com/forums/spells-569/jass-mystic-storm-v1-1i-227456/

Dat copy/pasty tooltip.

Blew my mind.

Hadn't it been JASS I'd have thought, "what else did he copy paste?".