GUI Brand[LOL] Spell Pack 1.2

[Moderator]

GUI Brand [LOL] Spell Pack 1.2 | Reviewed by Maker | 17.01.14 [COLOR="gray" [COLOR="gray" [COLOR="gray" [COLOR="gray" [COLOR="gray" Concept[/COLOR]] The spells work well as a pack and they have nice synergy Copying spells from other games leaves little room for imagination an creativity Triggers[/COLOR]] The spelss are MUI and the coding is ok CONFLAGRATIONSTART trigger has a location leak You could use variables for dummy unit types You could create less dummy units, one dummy can cast an ability on multiple units. Set movement speed, cast backswing and cast point to 0 You should share temporary variables between spells You are setting PYR_G_TEMPLOC multiple times Objects[/COLOR]] Pretty good stuff here Instead of multiple dummy unit types, consider using only one and attaching effects to it The buff icon of Blaze should be the active version Some follow through times could use a bit of adjustment The learn tooltips have extra empty lines between level data Effects[/COLOR]] Sear could use a casting sound The effects and sounds do their job Rating[/COLOR]] CONCEPT TRIGGERS OBJECTS EFFECTS RATING STATUS APPROVED

 

[Rheiko]

you should make the config triggers, so a user with low understanding with triggers can customize it
use in-game screenshot instead of brand's wallpaper, it's the rule
the rest of trigger, i haven't check it..

 

[chobibo]

Could you put in game screenies? Thanks!

 

[Chaosy]

looks pretty good. however you got the wrong keybinds on the spells. 4/5

 

[Doomguy80]

Completely epic

+rep

 

[TheWarlock3]

This is very cool!

 

[Cokemonkey11]

Hey, cool! another one. Have you included his innate?

 

[deathismyfriend]

This is in your for each loop.
This should be avoided.

0 to (B_SEAR_INDEX_LISTENER - 1)

Change it to

1 to B_SEAR_INDEX_LISTENER

And increase the above before you add everything to the array.
Alternatively set the B_SEAR_INDEX_LISTENER - 1 to a variable before the for loop and use that.

Also you shouldn't capitalize all variables. Only constants should be capitalized. It makes it very hard to read.

 

[cotd333]

Also you shouldn't capitalize all variables. Only constants should be capitalized. It makes it very hard to read.

I'm sorry about that, I have this eye problem so I can read words better when capitalized.

 

[cotd333]

Hey, cool! another one. Have you included his innate?

Yeah, but I didn't post its triggers here though XD

Could you put in game screenies? Thanks!

Uh, I don't know how to post game screenshots. Can someone teach me?

 

[chobibo]

You can use the img tag to show images:

[plain][IMG]image address[/IMG][/plain]

you can upload the images on you Pictures & Album in your UserCP

Oh and please merge your post, it's against the rules to multi-post. Thanks.

 

[deathismyfriend]

Also read the rest of my above post. Thanks

 

[BPower]

Use one permanent Dummy caster for each spell. Currently you create a huge amount of units while CreateUnit is a rather heavy operation.
Change the loop to --> 1 to B_SEAR_INDEX_LISTENER like deathismyfriend already mentioned.

Edit:

• Set B_CON_LVL_OF_ABILITY = 0
• Set B_CON_DAMAGE = 0.00
• Set B_CON_DAMAGE = 0.00

You don't have to set these to 0. They will be reset on the next spellcast

 

[jonbon29]

Wow brand spells, very hot.

 

[DMN Carry]

Nice!