[GUI/MUI] Katon 1.2

[Daffa]

Considering it's GUI, I won't use such functions (SetUnitXY) due to the fact that we can neglect speed here. But that's rather personal. In term of actual use, the header script might be missed and cause issues.

 

[Tasyen]

You put much effort into this, it looks naruto like and the sounds make it feel powerful.

Code:
dat looks wierd:

Unit Group - Remove all units of TempGroup from TempGroup​

In future better use this one.

Unit Group - Remove all units from TempGroup
(Should be called "clear" group in the editor)​

you leak some groups, has to do with this recreation & pick units

pick units will create an new group.
add unit to group, can only be used if the group exists, which does not if it was destroyed.

I would recomment using an permanent group containing currently affected units which is never destroyed and only cleared after the streamline dmg is done.
Do the rest with this below.​

One-Time use groups are in gui best handled with

• Actions
  • Set Source = (Triggering unit)
  • Set Loc = (Position of (Source))
  • Custom script: set bj_wantDestroyGroup =true
  • Unit Group - Pick every unit in (Units within 200.00 of Loc) and do (Actions)
    • Loop - Actions
      • Set Picked = (Picked unit)
      • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        • If - Conditions
          • (Picked is A structure) Equal to False
          • (Picked belongs to an enemy of (Owner of Source)) Equal to True
          • (Picked is alive) Equal to True
        • Then - Actions
          • Unit - Cause Source to damage Picked, dealing x damage of attack type Spells and damage type Magic
        • Else - Actions
  • Custom script: call RemoveLocation(udg_Loc)

Pros:

one does not need an group variable
it's easy to read/change filters.
dat would solve your recreation of tempgroup problem too.​

Cons:

You can not reuse the group.
empty filter.​

 

[Tal'Rarity]

Great spell though as with all anime spells they can get laggy and should be optimized as much as possible, looking forward to seeing more. =)
Only suggestion I have currently is learning how to use faster unit group checks.

Considering it's GUI, I won't use such functions (SetUnitXY) due to the fact that we can neglect speed here. But that's rather personal. In term of actual use, the header script might be missed and cause issues.

Actually I think it'd be a great idea to be suggesting the use of FirstOfGroup instead?

 

[Assassins-Creed]

Considering it's GUI, I won't use such functions (SetUnitXY) due to the fact that we can neglect speed here. But that's rather personal. In term of actual use, the header script might be missed and cause issues.

People can go through and replace every SetUnitXY with a move unit instantly, if they want. I only used this little function because I became used to using it. It wasn't used with the intent of making it faster in terms of processing. Assuming, that's what you meant by speed. I am not sure what you mean by "missed and cause issues".

You put much effort into this, it looks naruto like and the sounds make it feel powerful.

Thank you, I realized that sounds are more important than I thought. If possible, I look for sounds that can add the feeling of impact. But, they are hard to find, and I have not spent time learning any kind of sound design. I've only used audacity to edit sounds, whether its cutting, raising the volume, adding some fade out and reverb effects, or welding sounds to make them sound "seamless".

Code:
dat looks wierd:

Unit Group - Remove all units of TempGroup from TempGroup​

In future better use this one.

Unit Group - Remove all units from TempGroup
(Should be called "clear" group in the editor)
​

I am not sure how I missed that, must have been tunnel vision.

​

you leak some groups, has to do with this recreation & pick units

pick units will create an new group.
add unit to group, can only be used if the group exists, which does not if it was destroyed.

I would recomment using an permanent group containing currently affected units which is never destroyed and only cleared after the streamline dmg is done.
Do the rest with this below.​

I am confused. I set the TempGroup to the value, then destroy it, then recreate it, and set it to something. This causes the leak? If this causes a leak, then I am not sure how to destroy a group leak, then reuse it. If I destroyed a group without recreating, and just setting, it would cause a problem where if unit A was in TempGroup, then I destroyed it, and set it again, and unit A was still within the conditions, it wouldnt add unit A to the TempGroup.

Or are you talking about TempGroup2 where I use it to temporarily store units and then remove them. Since I do not set TempGroup2 to anything specific, this causes the leak?

Great spell though as with all anime spells they can get laggy and should be optimized as much as possible

Thanks, but I think it doesn't matter if they're anime or not, all spells can get laggy and should be optimized. I am trying to do things with optimization in mind, most of the time. Sometimes I just say "screw it, if it lags, ill fix it later" out of frustration.

Only suggestion I have currently is learning how to use faster unit group checks.

What do you mean? Where is the link to KNOWLEDGE?

Actually I think it'd be a great idea to be suggesting the use of FirstOfGroup instead?

I am confused.

P.S. Sorry for the weird text, I hit backspace on the indents, but it doesn't remove them.​

 

[Tal'Rarity]

What do you mean? Where is the link to KNOWLEDGE?

vJass Optimization: Using a First of Group Loop for Enumeration

 

[Tasyen]

This is Pick unit in range from
JASS Manual: API Browser - Blizzard.j
used by in range of loc with/out matching.

function GetUnitsInRangeOfLocMatching takes real radius, location whichLocation, boolexpr filter returns group
    local group g = CreateGroup()
    call GroupEnumUnitsInRangeOfLoc(g, whichLocation, radius, filter)
    call DestroyBoolExpr(filter)
    return g
endfunction

This is what you code does:
call GetUnitsInRangeOfLocMatching, remember the result. +1 group

do something with the group
clear the group​

destroy the group - 1 group
create the group +1 group
-> +1 group = leak

The group has to exist if you use the action addUnit/Group to group, which is tempgroup2.
Tempgroup2 is not destroyed which is correct.

Edit: First of group is a jass only thing.

 

[Rheiko]

Looks awesome. <3

 

[WINbyTEAMWORK]

Reminds me of that Naruto map: NCD 7.0+ versions. SASUKE!!!!

 

[Assassins-Creed]

This is Pick unit in range from
JASS Manual: API Browser - Blizzard.j
used by in range of loc with/out matching.

function GetUnitsInRangeOfLocMatching takes real radius, location whichLocation, boolexpr filter returns group
    local group g = CreateGroup()
    call GroupEnumUnitsInRangeOfLoc(g, whichLocation, radius, filter)
    call DestroyBoolExpr(filter)
    return g
endfunction

This is what you code does:
call GetUnitsInRangeOfLocMatching, remember the result. +1 group

do something with the group
clear the group​

destroy the group - 1 group
create the group +1 group
-> +1 group = leak

The group has to exist if you use the action addUnit/Group to group, which is tempgroup2.
Tempgroup2 is not destroyed which is correct.

Edit: First of group is a jass only thing.

Okay, I removed the CreateGroup() to show you my problem. I either need to find another work around, or just deal with the leaks.
Here is the video.

Looks awesome.

Thanks!

Reminds me of that Naruto map: NCD 7.0+ versions. SASUKE!!!!

That's surprising.