Heavy Slash[GUI/MUI]

[Moderator]

01:29, 14th Jan 2014
BPower:
Do not duplicate posts. I'll reject this one in favor of the admiral spell pack. For any questions feel free to pm me.

 

[BPower]

Hi KaelKorther,
congratulations on your first and hopefully not last submission in the spell section .

There are some things, that must be done to get your resource approved:

• You need a configuration trigger which runs on map initialization.
  This should covers settings like damage per level, the ability id, used effects, ...
  Could look like this:

  
  

  • Heavy Slash Init
    • Events
      • Map initialization
    • Conditions
    • Actions
      • -------- Configuration --------
      • -------- -------------------------------------------------------------------- --------
      • -------- The ability that used in the spell. Ability Name: --------
      • Set HS_Ability = Heavy Slash
      • -------- Attack Type and Damage Type used by the spell --------
      • Set HS_Attacktype = Normal
      • Set HS_Damagetype = Normal
      • -------- -------------------------------------------------------------------- --------
      • -------- Effect which is displayed when .... --------
      • Set HS_Effect = Abilities\Spells\Orc\WarStomp\WarStompCaster.mdl
      • -------- -------------------------------------------------------------------- --------
      • -------- Damage Configuration based on the ability level --------
      • Set HS_Damage[1] = 100.00
      • Set HS_Damage[2] = 200.00
      • Set HS_Damage[3] = 300.00
• This will of course also result in some changes in your "start" tigger, look into other approved GUI resources how it is done there.
• The boolean HS_Check is not required, if you do a proper dynamic indexing. Take a look into my signature "dynamic indexing". It is a very user-friendly tutorial about proper dynamic indexing.

In general this resource is very simple and therefore might face rejection.
Please also remove the picture from the desciption. As you can see, it is already uploaded in the screenshot window.

 

[KaelKorther]

ok..i will add my spell init like you said...
and i will update this spell to spellpack like i said....maybe take two day...

 

[nhocklanhox6]

An cool looking , i love your spell. + REP.

 

[deathismyfriend]

@BPower
the TO is not using Dynamic Indexing he is using an old form of Indexed Arrays.
Dynamic Indexing also has flaws as shown in a thread created by Maker.

@TO
You use an old indexing method which is inefficient and can cause the op-limit or the array limit to be reached breaking your spell. There is a chapter called how to index in my tutorial that shows you the new efficient way on how to index.

 

[KaelKorther]

ok...i will use dynamic indexing for my spell later...thanks for telling me...

 

[deathismyfriend]

ok...i will use dynamic indexing for my spell later...thanks for telling me...

As i said dynamic indexing is flawed you should use indexed arrays.

 

[BPower]

@KaelKorther: Dynamic indexing is only "flawed", if the instance order matters. Here it is very well explained: Why is dynamic indexing flawed

@deathismyfriend: In this spell it doesn't.
Don't argue the spell could be launched three times or more within a very short interval in the same angle and/or with a point of intersection for instance 2 and 3. That will most likely never gonna happen.

Edit (10.1.2014): I don't intend on bumping the thread with an off-topic so I just add it here.
I guess you assume I was refering to Hanky's Dynamic Indexing, which I'm not. The tutorial in my signature is exactly the same like yours is.

The term "Indexed Array" does not exist as an name for this form of data structure. It is just a normal array with an index.
Back to the original problem, if you really care about the instance order, use a different form of collection, which we call a "linked list".
In general they are neither "more efficient" nor faster than arrays.
Personally I wouldn't use a linked list here, because the chance of a spell missbehaviour is close to zero. Furthermore there other parameters which must be taken into consideration like the TimerTimeout, if we are talking about extreme fidelity.
My opinion on this case is very close to Cokemonkeys.

 

[deathismyfriend]

@deathismyfriend: In this spell it doesn't.
Don't argue the spell could be launched three times or more within a very short interval in the same angle and/or with a point of intersection for instance 2 and 3. That will most likely never gonna happen.

In every spell it matters. In the current state this spell is in it can break. Also dynamic indexing is slower than indexed arrays. You can also keep order with indexed arrays as i have done it plenty of times.
If a spell can break because of a flaw in the design then that means it should not be approved. Just because it may not happen doesn't mean anything.
Also people can edit the length of the spell which is the whole point of a config trigger. That can cause it to break a lot easier than what it is currently set at. That is why spells need to be as error proof as possible.

@TO
this leaks.

• Special Effect - Create a special effect at (Position of (Picked unit)) using HS_Effect[3]

In your unit group creation this should be stored in a player variable before it is used.

• (Owner of HS_Caster[HS_LoopIndex[3]])) Equal to True)

anything used twice or more should be stored in a variable.

 

[KaelKorther]

In every spell it matters. In the current state this spell is in it can break. Also dynamic indexing is slower than indexed arrays. You can also keep order with indexed arrays as i have done it plenty of times.
If a spell can break because of a flaw in the design then that means it should not be approved. Just because it may not happen doesn't mean anything.
Also people can edit the length of the spell which is the whole point of a config trigger. That can cause it to break a lot easier than what it is currently set at. That is why spells need to be as error proof as possible.

@TO
this leaks.

• Special Effect - Create a special effect at (Position of (Picked unit)) using HS_Effect[3]

In your unit group creation this should be stored in a player variable before it is used.

• (Owner of HS_Caster[HS_LoopIndex[3]])) Equal to True)

anything used twice or more should be stored in a variable.

Then...how to fix this...

• Special Effect - Create a special effect at (Position of (Picked unit)) using HS_Effect[3]

 

[F1ashB0nd]

Then...how to fix this...

• Special Effect - Create a special effect at (Position of (Picked unit)) using HS_Effect[3]

You mean the leak right?

• Set Temp_Point = (Position of (Picked unit))
• Special Effect - Create a special effect at Temp_Point using HS_Effect[3]
• Custom script - call RemoveLocation(udg_Temp_Point)

Basically what this does is that it stores the point onto a variable which can then be destroyed through the use of the RemoveLocation function through custom script.

Temp_Point can be any Point variable that is not used by other spells/systems. Since the point is destroyed right after it is created and used, Temp_Point can be reused again and again as long as you don't use waits.