Moderator
M
Moderator
12th Dec 2015
IcemanBo: For long time as NeedsFix. Rejected.
15:00 GMT, 1st Jun 2011
Bribe:
General_Integer[51], General_Integer[52] and General_Integer[53] should be their own variables. This will imrove performance and readability.
Same with the other General_Integers that you use. These arrays should be split up int normal variables. Here's some general advice: if it doesn't need an array, don't make it an array.
UDS Part 1 leaks a unit group.
Use (Triggering unit) not (Entering unit) / (Casting unit) / (Learning hero)
Use normal variable loops (with normal integers) instead of (Integer A) loops.
In Macropyre, you leak a lot of flamethrower special effects towards the bottom of the loop.
(Owner of (Casting unit)) -> (Triggering player)
"Custom script: call DestroyGroup (bj_lastCreatedGroup)"
What do you want to do here? Delete this line. It will screw up so many functions and systems that use it...
IcemanBo: For long time as NeedsFix. Rejected.
15:00 GMT, 1st Jun 2011
Bribe:
General_Integer[51], General_Integer[52] and General_Integer[53] should be their own variables. This will imrove performance and readability.
Same with the other General_Integers that you use. These arrays should be split up int normal variables. Here's some general advice: if it doesn't need an array, don't make it an array.
UDS Part 1 leaks a unit group.
Use (Triggering unit) not (Entering unit) / (Casting unit) / (Learning hero)
Use normal variable loops (with normal integers) instead of (Integer A) loops.
In Macropyre, you leak a lot of flamethrower special effects towards the bottom of the loop.
(Owner of (Casting unit)) -> (Triggering player)
"Custom script: call DestroyGroup (bj_lastCreatedGroup)"
What do you want to do here? Delete this line. It will screw up so many functions and systems that use it...